[Koha-bugs] [Bug 8418] Koha::Calendar is_holiday ignores all user data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8418 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added CC||oleon...@myacpl.org --- Comment #29 from Tomás Cohen Arazi tomasco...@gmail.com --- *** Bug 6398 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8418] Koha::Calendar is_holiday ignores all user data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8418 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #28 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.8.x will be in 3.8.5 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8418] Koha::Calendar is_holiday ignores all user data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8418 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master Version|master |rel_3_8 --- Comment #27 from Paul Poulain paul.poul...@biblibre.com --- Patch pushed to master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8418] Koha::Calendar is_holiday ignores all user data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8418 Mason James m...@kohaaloha.com changed: What|Removed |Added CC||m...@kohaaloha.com QA Contact||m...@kohaaloha.com --- Comment #26 from Mason James m...@kohaaloha.com --- Signed-off-by: Chris Cormack chr...@catalyst.net.nz patch looks good, passing QA... $ koha-qa.pl testing 1 commit(s) (applied to commit 60790d0) * 1230d06 Bug 8418: load repeating holidays hash correctly Koha/Calendar.pm * Koha/Calendar.pm OK -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8418] Koha::Calendar is_holiday ignores all user data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8418 Mason James m...@kohaaloha.com changed: What|Removed |Added Priority|P5 - low|P1 - high Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8418] Koha::Calendar is_holiday ignores all user data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8418 --- Comment #25 from Colin Campbell colin.campb...@ptfs-europe.com --- The non loading of exception holidays is addressed by the patch on bug 8656 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8418] Koha::Calendar is_holiday ignores all user data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8418
L. Bareño leonardobar...@gmail.com changed:
What|Removed |Added
CC||leonardobar...@gmail.com
--- Comment #24 from L. Bareño leonardobar...@gmail.com ---
1) Current code in ./Koha/Calendar.pm is ignoring single holidays (those whose
special_holidays.isexception == 0)
(line numbers and code from master at this message's date)
./Koha/Calendar.pm
line 68:
- $special-execute( $branch, 1 );
+ $special-execute( $branch, 0 );
2) exception_holidays are not holidays, and (please you people tell me if the
following interpretation I'm doing is correct) these must disable any other
repeatable or single holiday.
lines 141-165 (suggested code):
sub is_holiday {
my ( $self, $dt ) = @_;
if ( $self-{exception_holidays}-contains($dt) ) {
return 0;
}
my $dow = $dt-day_of_week;
if ( $dow == 7 ) {
$dow = 0;
}
if ( $self-{weekly_closed_days}-[$dow] == 1 ) {
return 1;
}
$dt-truncate( to = 'day' );
my $day = $dt-day;
my $month = $dt-month;
if ( exists $self-{day_month_closed_days}-{$month}-{$day} ) {
return 1;
}
if ( $self-{single_holidays}-contains($dt) ) {
return 1;
}
# damn have to go to work after all
return 0;
}
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8418] Koha::Calendar is_holiday ignores all user data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8418 Colin Campbell colin.campb...@ptfs-europe.com changed: What|Removed |Added CC||colin.campbell@ptfs-europe. ||com --- Comment #23 from Colin Campbell colin.campb...@ptfs-europe.com --- There is a further related data loading bug I've entered it as bug 8656 with a patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8418] Koha::Calendar is_holiday ignores all user data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8418 Colin Campbell colin.campb...@ptfs-europe.com changed: What|Removed |Added Attachment #11026|0 |1 is obsolete|| --- Comment #20 from Colin Campbell colin.campb...@ptfs-europe.com --- Created attachment 11611 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11611action=edit Proposed Patch The repeating holidays bug is still there. It should be corrected if the structure is setup correctly on load from the database as the TEST bersion of the object does. This fixes it in a single place unlike the previous which addressed it in the access method and meant that the test mock had to change to conform -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8418] Koha::Calendar is_holiday ignores all user data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8418 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #10811|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8418] Koha::Calendar is_holiday ignores all user data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8418 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #11025|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8418] Koha::Calendar is_holiday ignores all user data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8418 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #11611|0 |1 is obsolete|| --- Comment #21 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 11624 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11624action=edit Bug 8418: load repeating holidays hash correctly The repeating holidays structure was being loaded in a different order to how it was tested Signed-off-by: Chris Cormack chr...@catalyst.net.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8418] Koha::Calendar is_holiday ignores all user data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8418 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Patch doesn't apply |Signed Off --- Comment #22 from Chris Cormack ch...@bigballofwax.co.nz --- perl t/Calendar.t 2012-08-15 11:28:50 chrisc pts/26 1..21 ok 1 - use Koha::Calendar; ok 2 - use C4::Calendar; ok 3 - Calendar class returned isa Koha::Calendar ok 4 - Sunday is a closed day ok 5 - Monday is not a closed day ok 6 - month/day closed day test ok 7 - special closed day test ok 8 - open day test ok 9 - addDate skips closed Sunday ok 10 - Negative call to addDate ok 11 - days_between calculates correctly ok 12 - Simple Single Day Add (Calendar) ok 13 - Add 7 days Calendar mode ok 14 - Add 7 days Datedue mode ok 15 - Add 7 days Days mode ok 16 - test larger intervals ok 17 - test positive intervals ok 18 - test parameter order not relevant ok 19 - days_between calculates correctly ok 20 - holiday correctly recognized ok 21 - multiple holidays correctly recognized -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8418] Koha::Calendar is_holiday ignores all user data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8418 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added CC||paul.poul...@biblibre.com --- Comment #19 from Paul Poulain paul.poul...@biblibre.com --- isn't this patch somewhere redundant with bug 8486 ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8418] Koha::Calendar is_holiday ignores all user data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8418 Ian Walls koha.sek...@gmail.com changed: What|Removed |Added Status|Signed Off |Patch doesn't apply CC||koha.sek...@gmail.com --- Comment #18 from Ian Walls koha.sek...@gmail.com --- Patch 1: correct 'to' value of truncate function is 'day', not 'days', but the patch no longer applies. Patch 2: looks to be removing 'singleholiday' and 'exceptionholiday' references in favour of 'specialholiday'. Also, patch does not apply anymore. Patch 3: swaps around hash from 'month' = 'day' to 'day' = 'month', which seems backwards as far as granularity goes. I remember us switching this for a reason... was that reason half-baked? Or did we just not switch it in enough places? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8418] Koha::Calendar is_holiday ignores all user data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8418 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #10840|0 |1 is obsolete|| --- Comment #16 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 11025 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11025action=edit Bug 8418 - single_holidays DateTime::Set We where cargo-culting code from C4::Calendar, but in the process code executed same SQL query with isexceptional flag set each time. This basically disabled all entries on calendar without it, which is somewhat of a problem, since users currently can't add entry which does have isexception bit set. There is really no need for two separate DateTime::Set objects, since code for them is same if we remove isexception from query. Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8418] Koha::Calendar is_holiday ignores all user data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8418 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #10839|0 |1 is obsolete|| --- Comment #17 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 11026 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11026action=edit Bug 8418 - Koha::Calendar is_holiday ignores repeating holidays This is simple fix since day_month_closed_days hash has wrong arguments order and it's not used outside Koha::Calenar code. Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8418] Koha::Calendar is_holiday ignores all user data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8418 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||k...@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8418] Koha::Calendar is_holiday ignores all user data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8418 --- Comment #15 from Dobrica Pavlinusic dpav...@rot13.org --- It shouldn't. This module respect them :-) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8418] Koha::Calendar is_holiday ignores all user data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8418 --- Comment #9 from Dobrica Pavlinusic dpav...@rot13.org --- Created attachment 10838 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10838action=edit Bug 8418 - correctly mock test data -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8418] Koha::Calendar is_holiday ignores all user data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8418 Dobrica Pavlinusic dpav...@rot13.org changed: What|Removed |Added Attachment #10810|0 |1 is obsolete|| --- Comment #10 from Dobrica Pavlinusic dpav...@rot13.org --- Created attachment 10839 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10839action=edit Bug 8418 - Koha::Calendar is_holiday ignores repeating holidays This is simple fix since day_month_closed_days hash has wrong arguments order and it's not used outside Koha::Calenar code. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8418] Koha::Calendar is_holiday ignores all user data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8418 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #11 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Dobrica, I am a bit worried about Chris' question: Also are we certain everywhere is specifying holidays as day month, not month day as the test and code was before this change? So maybe he patches are breaking things in other places now? Is there a way to check/make sure? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8418] Koha::Calendar is_holiday ignores all user data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8418 Dobrica Pavlinusic dpav...@rot13.org changed: What|Removed |Added Attachment #10774|0 |1 is obsolete|| Attachment #10838|0 |1 is obsolete|| --- Comment #12 from Dobrica Pavlinusic dpav...@rot13.org --- Created attachment 10840 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10840action=edit Bug 8418 - single_holidays DateTime::Set We where cargo-culting code from C4::Calendar, but in the process code executed same SQL query with isexceptional flag set each time. This basically disabled all entries on calendar without it, which is somewhat of a problem, since users currently can't add entry which does have isexception bit set. There is really no need for two separate DateTime::Set objects, since code for them is same if we remove isexception from query. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8418] Koha::Calendar is_holiday ignores all user data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8418 --- Comment #13 from Dobrica Pavlinusic dpav...@rot13.org --- Rest of the code doesn't use (In reply to comment #11) Hi Dobrica, So maybe he patches are breaking things in other places now? Is there a way to check/make sure? I did that before I started modifing code. git grep day_month_closed_days is quite useful to get all places in code without need to write elaborate grep statements. To be honest, I switched to git grep from my own hand-crafted greps in this bug, so I'm sharing my excitement here :-) According to our coding guidelines, other code shouldn't access values directly in Koha namespace anyway, which is probably only reason why we are mocking test data within module itself (which was strange to me at first, and is probably reason why I broke it). I cleaned up two patches which to include correct mocking of test data. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8418] Koha::Calendar is_holiday ignores all user data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8418 --- Comment #14 from Katrin Fischer katrin.fisc...@bsz-bw.de --- 'coding guidelines' and 'shouldn't' make me worry again ;) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8418] Koha::Calendar is_holiday ignores all user data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8418 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #10769|0 |1 is obsolete|| --- Comment #6 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 10810 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10810action=edit Bug 8418 - Koha::Calendar is_holiday ignores repeating holidays This is simple fix since day_month_closed_days hash has wrong arguments order. Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz http://bugs.koha-community.org/show_bug.cgi?id=8414 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8418] Koha::Calendar is_holiday ignores all user data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8418 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #10773|0 |1 is obsolete|| --- Comment #7 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 10811 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10811action=edit Bug 8418 - fix dt-truncate( to = 'day' ) Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8418] Koha::Calendar is_holiday ignores all user data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8418
Chris Cormack ch...@bigballofwax.co.nz changed:
What|Removed |Added
CC||ch...@bigballofwax.co.nz
--- Comment #8 from Chris Cormack ch...@bigballofwax.co.nz ---
The tests now fail
Before the patches
perl t/Kalendar.t
1..9
ok 1 - use Koha::Calendar;
ok 2 - Calendar class returned isa Koha::Calendar
ok 3 - Sunday is a closed day
ok 4 - Monday is not a closed day
ok 5 - month/day closed day test
ok 6 - special closed day test
ok 7 - open day test
ok 8 - addDate skips closed Sunday
ok 9 - Negative call to addDate
Applying the first patch
perl t/Kalendar.t
1..9
ok 1 - use Koha::Calendar;
ok 2 - Calendar class returned isa Koha::Calendar
ok 3 - Sunday is a closed day
ok 4 - Monday is not a closed day
not ok 5 - month/day closed day test
# Failed test 'month/day closed day test'
# at t/Kalendar.t line 54.
# got: '0'
# expected: '1'
ok 6 - special closed day test
ok 7 - open day test
ok 8 - addDate skips closed Sunday
ok 9 - Negative call to addDate
# Looks like you failed 1 test of 9.
Applying the 2nd patch
Still failing 5
Applying the final one
perl t/Kalendar.t
1..9
ok 1 - use Koha::Calendar;
ok 2 - Calendar class returned isa Koha::Calendar
ok 3 - Sunday is a closed day
ok 4 - Monday is not a closed day
not ok 5 - month/day closed day test
# Failed test 'month/day closed day test'
# at t/Kalendar.t line 54.
# got: '0'
# expected: '1'
not ok 6 - special closed day test
# Failed test 'special closed day test'
# at t/Kalendar.t line 55.
# got: '0'
# expected: '1'
ok 7 - open day test
ok 8 - addDate skips closed Sunday
ok 9 - Negative call to addDate
# Looks like you failed 2 tests of 9
I can fix the test for the first fail
By changing this
-$self-{day_month_closed_days} = { 6 = { 16 = 1, } };
+$self-{day_month_closed_days} = { 16 = { 6 = 1, } };
But the test still fails for special holidays, I think this is actually broken.
Also are we certain everywhere is specifying holidays as day month, not month
day as the test and code was before this change?
Its too late in the night for me to go much further with this, I hope someone
else has a chance to look at it
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8418] Koha::Calendar is_holiday ignores all user data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8418 Dobrica Pavlinusic dpav...@rot13.org changed: What|Removed |Added Summary|Koha::Calendar is_holiday |Koha::Calendar is_holiday |ignores repeating holidays |ignores all user data -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8418] Koha::Calendar is_holiday ignores all user data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8418 Dobrica Pavlinusic dpav...@rot13.org changed: What|Removed |Added Blocks||6398 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
