[Koha-bugs] [Bug 8433] use English not needed in modules not using English
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8433 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz Version|master |3.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8433] use English not needed in modules not using English
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8433 Jared Camins-Esakov changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #9 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8433] use English not needed in modules not using English
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8433 --- Comment #8 from Colin Campbell --- (In reply to comment #6) > Is there a way to test these changes are safe? Compling the scripts with strict and warnings enables should indicated if any references remain to entities defined in English.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8433] use English not needed in modules not using English
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8433 --- Comment #7 from Jonathan Druart --- Jared, I think the script xt/find-undefined-subroutines.pl could help us here. I launched it after applying this patch and I found no error previously existing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8433] use English not needed in modules not using English
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8433 --- Comment #6 from Jared Camins-Esakov --- Is there a way to test these changes are safe? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8433] use English not needed in modules not using English
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8433 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |colin.campbell@ptfs-europe. |ity.org |com QA Contact||jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8433] use English not needed in modules not using English
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8433 Jonathan Druart changed: What|Removed |Added Attachment #14242|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Created attachment 14416 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14416&action=edit Bug 8433 Remove unused 'use English' Adding a use English to mosules which dont may waste a few CPU cycles and bytes of storage but doesnt add anything to the sum of human happiness Remove unnecessary use English's Removed already commented out but equally unnrcessary use Exporter in same modules Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8433] use English not needed in modules not using English
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8433 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m --- Comment #4 from Jonathan Druart --- QA Comments: I did not test this patch. This patch removes the English module in 5 modules (and 3 commented lines). Looks good to me. Marked as Passed QA. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8433] use English not needed in modules not using English
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8433 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||k...@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8433] use English not needed in modules not using English
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8433 Kyle M Hall changed: What|Removed |Added Attachment #10802|0 |1 is obsolete|| --- Comment #3 from Kyle M Hall --- Created attachment 14242 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14242&action=edit Bug 8433 Remove unused 'use English' Adding a use English to mosules which dont may waste a few CPU cycles and bytes of storage but doesnt add anything to the sum of human happiness Remove unnecessary use English's Removed already commented out but equally unnrcessary use Exporter in same modules Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8433] use English not needed in modules not using English
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8433 Colin Campbell changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Severity|enhancement |trivial --- Comment #2 from Colin Campbell --- Changed from enh -> trivial -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8433] use English not needed in modules not using English
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8433 --- Comment #1 from Colin Campbell --- Created attachment 10802 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10802&action=edit Proposed Patch code cleanup removing unused module reference -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
