[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2015-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #44 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Sadly, there was no reaction on the mailing list to the e-mail Marcel sent (thx
for that!) I suggest moving this back into the queue - I personally see no
cleaner way to do that, the only additions I can think of is a small warning in
Release notes.

To me this kind of fixes a bug - I can't search for other branches
subscriptions without superserials/superlibrarian, but I can claim their late
issues... that appears illogical to me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2015-04-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 QA Contact||m.de.r...@rijksmuseum.nl
Version|unspecified |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2015-04-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

--- Comment #39 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
After discussing the problem with seeing issues from other branches with
Jonathan a bit more I think we can keep it like that for now. - You will see
them, but you can't claim them. If libraries think this should be more
restrictive, please open a new bug report.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2015-04-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #37 from M. de Rooy m.de.r...@rijksmuseum.nl ---
 If we don't update the permission:
 Can suddenly no longer claim issues from other branches

 Woudl also be good to get more opinions about b).

In view of the discussion above (including older comments at the top), this
patch does not seem to be ready for inclusion yet.
I am moving it to FQA for now. Will ask for additional comments on the list.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2015-04-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

--- Comment #38 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
(In reply to Jonathan Druart from comment #36)
 Comment on attachment 35312 [details] [review]
 [SIGNED OFF] Bug 8438: Followup Set the superserials permission for all
 users with the claim_serials permission
 
 So it is preferable not to update the user permissions and maybe let a note
 in the release notes to explain that if they have issues with serial
 permissions to check the user permissions.

Sounds like the best possible solution to me.

Could you take a look if filtering out the issues from other branches would be
possible instead of just hiding the claim options?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2015-04-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #41 from M. de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to Jonathan Druart from comment #40)
 So back in the QA queue?

The permission problem has not been solved? So, I would say: No. We can wait
for some responses on the list first btw.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2015-04-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

--- Comment #43 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I'd vote for: don't mingle with permissions, put a warn that now the behaviour
is stricter and you can't claim issues from other branches without the proper
permission for doing so.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2015-04-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #40 from Jonathan Druart jonathan.dru...@biblibre.com ---
So back in the QA queue?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2015-04-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

--- Comment #42 from Jonathan Druart jonathan.dru...@biblibre.com ---
To me, there is no permission problem :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2015-03-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

Alex Arnaud alex.arn...@biblibre.com changed:

   What|Removed |Added

 CC||alex.arn...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2015-03-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2015-03-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #35312|0   |1
is obsolete||

--- Comment #36 from Jonathan Druart jonathan.dru...@biblibre.com ---
Comment on attachment 35312
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35312
[SIGNED OFF] Bug 8438: Followup Set the superserials permission for all users
with the claim_serials permission

So it is preferable not to update the user permissions and maybe let a note in
the release notes to explain that if they have issues with serial permissions
to check the user permissions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #35 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Ok, here it is: 

- We failed to get superserials and this patch set into the same version. 
- Superserials permission has been in use for quite a while now (see bug 8435) 
- This patch currently updates your permission set to add 'superserials' to it,
if you had the permission to claim serials before.
- We have a time gap here that will cause some change in behaviour, no matter
how we do it.

So this is the situation as I see it:

1) Not using IndependentBranches
= Nothing needs to be done, because nothing should change. 
No need to update the permissions in that case. 
We could add an additional check for IndependentBranches to the database
update.

2) Using IndependentBranches

a) Having superserials permission already
= Nothing changes

b) Not having superserials permission before update
= Can now suddenly manage serials from other branches after the update.
If we don't update the permission:
= Can suddenly no longer claim issues from other branches

So what can we do here?
- Introducing a 'superserialclaim permission' seems silly.
- Taking away a smaller permission seems making more sense than giving access
to even more data than before.
- I'd vote for 'don't add the superserials permission on update'.

Another thing: If I am not allowed to claim the issues from other branches,
should these issues be visible to me? A user without
superlibrarian/superserials will still see all issues that need claiming in the
serial claim view, but they will miss the checkbox for claiming them. This
doesn't seem to make sense, as I can't find the subscription using the
search... but I can access it form the link. This is not very clean.

I think the access problem could be on a separate bug (Can still access other
branches subsriptions with IndyBranches and no superserials), but I'd really
like to see a filtered view for the claims.

Jonathan, could you take a look? Woudl also be good to get more opinions about
b).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2015-01-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

Paola Rossi paola.ro...@cineca.it changed:

   What|Removed |Added

  Attachment #35306|0   |1
is obsolete||

--- Comment #33 from Paola Rossi paola.ro...@cineca.it ---
Created attachment 35312
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35312action=edit
[SIGNED OFF] Bug 8438: Followup Set the superserials permission for all users
with the claim_serials permission

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2015-01-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

Paola Rossi paola.ro...@cineca.it changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2015-01-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

Paola Rossi paola.ro...@cineca.it changed:

   What|Removed |Added

  Attachment #35305|0   |1
is obsolete||

--- Comment #32 from Paola Rossi paola.ro...@cineca.it ---
Created attachment 35311
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35311action=edit
[SIGNED OFF] Bug 8438: Users can only claim for serials related to their
branch.

I've applied the patch against master 3.19.00.006 head 12889

The upgrading of the DB was as required:
for each [PT/S] patron with the permission claim_serials ON, the permission
superserials became[/was kept to] ON.

Then, after having checked the DB upgrading, to test the currently adding
limitation:
 Users can only claim for serials related to their branch
, I reset 2 PT/S patrons-users to:
permission claim_serials: YES
permission superserials: NO
and I set the syspref IndependendeBranches to Prevent.

For:
 Only superlibrarian users can override this limitation.
the S patron-user could list AND claim:
A) subscriptions of his own branch,
B) subscriptions of other branch,
C) subscriptions without branch.

For:
 Only users with superserials permission can override this limitation.
the PT patron-user could list:
A) subscriptions of his own branch,
B) subscriptions of other branch,
C) subscriptions without branch,
and could claim only:
A) subscriptions of his own branch,
C) subscriptions without branch.

NB: a subscription is selected to be claimed.

Then I set the syspref IndependendeBranches to Don't prevent. The behaviour
was [exactly the same as in master] without the added limitation.

On [S/PT] patrons, if permission claim_serials was NO, no Claims' link was
available on Serials' page, either under Prevent or under Don't prevent.

So everything was OK just as required.

I pass the patch to Signed Off status.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2015-01-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

--- Comment #34 from Paola Rossi paola.ro...@cineca.it ---
I add to my comment 32:

I reset the PT patrons-users to:
[permission claim_serials: YES]
permission superserials: YES
under the syspref IndependentBranches set either to Prevent or to Don't
prevent.

For:
 Only users with superserials permission can override this limitation.
the PT patron-user could list AND claim:
A) subscriptions of his own branch,
B) subscriptions of other branch,
C) subscriptions without branch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2015-01-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

Paola Rossi paola.ro...@cineca.it changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #28 from Paola Rossi paola.ro...@cineca.it ---
I've applied the patches against master 3.19.00.006 head 12889

On Home › Serials , clicking on Claims' link:

Software error:

Global symbol @missingissues requires explicit package name at
[...]/serials/claims.pl line 83.
Execution of [...]/serials/claims.pl aborted due to compilation errors.

I pass the patch to Failed QA status.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2015-01-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

--- Comment #31 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Paola Rossi from comment #28)
 I've applied the patches against master 3.19.00.006 head 12889
 
 On Home › Serials , clicking on Claims' link:
 
 Software error:

Sorry about that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2015-01-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

--- Comment #30 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 35306
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35306action=edit
Bug 8438: Followup Set the superserials permission for all users with the
claim_serials permission

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2015-01-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2015-01-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #35177|0   |1
is obsolete||
  Attachment #35178|0   |1
is obsolete||

--- Comment #29 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 35305
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35305action=edit
Bug 8438: Users can only claim for serials related to their branch.

Only superlibrarian users and users with superserials permission
can override this limitation.

This patch adds a new subroutine C4::Serials::can_claim_subscription.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2015-01-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2015-01-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #29211|0   |1
is obsolete||
  Attachment #29212|0   |1
is obsolete||

--- Comment #26 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 35177
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35177action=edit
Bug 8438: Users can only claim for serials related to their branch.

Only superlibrarian users and users with superserials permission
can override this limitation.

This patch adds a new subroutine C4::Serials::can_claim_subscription.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2015-01-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

--- Comment #27 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 35178
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35178action=edit
Bug 8438: Followup Set the superserials permission for all users with the
claim_serials permission

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2015-01-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

Paola Rossi paola.ro...@cineca.it changed:

   What|Removed |Added

 CC||paola.ro...@cineca.it
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #25 from Paola Rossi paola.ro...@cineca.it ---
I've tried to apply the patch against master 3.19.00.005 head 12868

Applying: Bug 8438: Users can only claim for serials related to their branch.
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging t/db_dependent/Serials_2.t
CONFLICT (content): Merge conflict in t/db_dependent/Serials_2.t
Auto-merging serials/claims.pl
CONFLICT (content): Merge conflict in serials/claims.pl
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt
Auto-merging C4/Serials.pm
Failed to merge in the changes.
Patch failed at 0001 Bug 8438: Users can only claim for serials related to
their branch.

So I pass the patch to Patch doesn't apply status.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

--- Comment #21 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Koha Team Lyon 3 from comment #20)
 It's OK now for superlibrarians and users with superserials permissions, but
 it doesn't work any more for simple users : they are not restricted any more
 to the login branch...

Yes sorry, I changed the behavior without notifying the change.
But actually I am not sure. I decided to use the same method as on editing a
subscription, but it's wrong!
I will submit another patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #29191|0   |1
is obsolete||
  Attachment #29192|0   |1
is obsolete||

--- Comment #22 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 29211
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29211action=edit
Bug 8438: Users can only claim for serials related to their branch.

Only superlibrarian users and users with superserials permission
can override this limitation.

This patch adds a new subroutine C4::Serials::can_claim_subscription.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

--- Comment #24 from Jonathan Druart jonathan.dru...@biblibre.com ---
I didn't test all cases but the unit tests told me that should work! :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

--- Comment #23 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 29212
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29212action=edit
Bug 8438: Followup Set the superserials permission for all users with the
claim_serials permission

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2014-06-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

Koha Team Lyon 3 k...@univ-lyon3.fr changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #16 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
Sorry Jonathan, when clicking on Claims link, I got this :
SOFTWARE ERROR
Global symbol $subscription requires explicit package name at
/home/kohabac/src/serials/claims.pl line 71.

Olivier Crouzet

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2014-06-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #29098|0   |1
is obsolete||
  Attachment #29099|0   |1
is obsolete||

--- Comment #17 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 29191
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29191action=edit
Bug 8438: Users can only claim for serials related to their branch.

Only superlibrarian users and users with superserials permission
can override this limitation.
The original author of this patch is Julian Maurice.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2014-06-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

--- Comment #18 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 29192
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29192action=edit
Bug 8438: Followup Set the superserials permission for all users with the
claim_serials permission

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2014-06-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2014-06-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

--- Comment #19 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Koha Team Lyon 3 from comment #16)
 Sorry Jonathan, when clicking on Claims link, I got this :

Erk, sorry. Should be fixed now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2014-06-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

Koha Team Lyon 3 k...@univ-lyon3.fr changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #20 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
It's OK now for superlibrarians and users with superserials permissions, but it
doesn't work any more for simple users : they are not restricted any more to
the login branch...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2014-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #26399|0   |1
is obsolete||
  Attachment #26400|0   |1
is obsolete||

--- Comment #14 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 29098
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29098action=edit
Bug 8438: Users can only claim for serials related to their branch.

Only superlibrarian users and users with superserials permission
can override this limitation.
The original author of this patch is Julian Maurice.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2014-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

--- Comment #15 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 29099
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29099action=edit
Bug 8438: Followup Set the superserials permission for all users with the
claim_serials permission

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2014-06-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2014-06-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

Koha Team Lyon 3 k...@univ-lyon3.fr changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||k...@univ-lyon3.fr

--- Comment #13 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
When logged as :

superlibrarian = OK : you can select subs from all branches

user without superserials permission = OK : only checkbox corresponding to
loggin branch subscriptions are displayed. You can't select others

user with superserials permission = NOT OK : no difference from previous case.
Only loggin branch subscriptions display checkboxes.


Olivier Crouzet

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2014-03-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2014-03-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #24074|0   |1
is obsolete||

--- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 26400
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26400action=edit
Bug 8438: Followup Set the superserials permission for all users with the
claim_serials permission

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2014-03-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #11778|0   |1
is obsolete||

--- Comment #11 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 26399
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26399action=edit
Bug 8438: Users can only claim for serials related to their branch.

Only superlibrarian users and users with superserials permission
can override this limitation.
The original author of this patch is Julian Maurice.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2014-03-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

Pascale Nalon pascale.na...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||pascale.na...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2014-01-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

--- Comment #10 from Jonathan Druart jonathan.dru...@biblibre.com ---
Rebased patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2014-01-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #12842|0   |1
is obsolete||

--- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 24074
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24074action=edit
Bug 8438: Followup Set the superserials permission for all users with the
claim_serials permission

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2013-09-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

Bot Control|--- |Ignore this bug

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2013-03-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

Frederic Durand frederic.dur...@unilim.fr changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||frederic.dur...@unilim.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2013-03-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com ---
Patches apply correctly here

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2012-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

--- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 12842
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12842action=edit
Bug 8438: Followup Set the superserials permission for all users with the
claim_serials permission

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2012-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2012-10-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||k...@bywatersolutions.com

--- Comment #6 from Kyle M Hall k...@bywatersolutions.com ---
Marking as Failed QA until the concerns in comments have been addressed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2012-09-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 CC||neng...@gmail.com

--- Comment #5 from Nicole C. Engard neng...@gmail.com ---
I too am worried about this changing the current behavior. When the change was
made to the purchase suggestions by limiting to one branch it confused a lot of
our users and isn't really the desired behavior for them either.  So I say
either a preference or some way to make it less confusing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2012-08-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

--- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 11778
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11778action=edit
Bug 8438: Users can only claim for serials related to their branch.

Only superlibrarian users and users with superserials permission
can override this limitation.
The original author of this patch is Julian Maurice.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2012-08-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2012-08-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co
   |ity.org |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2012-08-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||ch...@bigballofwax.co.nz

--- Comment #2 from Chris Cormack ch...@bigballofwax.co.nz ---
Not sure about this, it is a change of existing behavour. I think you should
link it to independent branches syspref.

This new feature would indeed be a regression of a lot of my libraries. Where
they have a serials librarian who looks after serials for multiple branches.
But can't do circulation, cataloguing etc. Now they simply can't do that.
Because that user would have to be super librarian.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2012-08-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #3 from Chris Cormack ch...@bigballofwax.co.nz ---
Actually I take that back, they would need superserials. So instead my only
issue now is that this is going to change behaviour, and without warning (in
updatedatabase or anything)
So people upgrading will not have any idea what happened, we need some way to
warn people (this is a general koha issue)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2012-08-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hm, maybe we could assign the users with serials permissions now the
superserial permission on update? This way we would have no change of existing
behaviour and now surprises. But not sure how hard that is - I know the
permission flags are a bit cryptic.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/