[Koha-bugs] [Bug 8461] Block returns of withdrawn items show as 'not checked out'

2024-06-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8461

--- Comment #21 from Andrii Nugged  ---
UX issue, which became very annoying for our customers,
as raised by librarians:

They often "return again" sometimes after SIP to check, and obviously (and it's
correct behaviour) the system says for them, "Item was not checked in",

but they become confused very, thinking that the item wasn't checked in by SIP
(sic!) :). We should make a more straightforward message so as not to confuse
librarians. Saying something like, for example:

"Item was not checked in because it is already checked in".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8461] Block returns of withdrawn items show as 'not checked out'

2024-06-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8461

--- Comment #20 from Andrii Nugged  ---
Note to the above buggy behavior: it's about 23.11, 

on 24.05, because the page reload was removed, so this issue is not
reproducible.

But anyway, if to speak about the solution (maybe it CAN be somehow achieved on
24.05 too in cases when the page gives reload after modal, or so),

So there the solution:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37014

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8461] Block returns of withdrawn items show as 'not checked out'

2024-06-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8461

Andrii Nugged  changed:

   What|Removed |Added

 Blocks||37014


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37014
[Bug 37014] "Item was not checked in" printed on next POST because of missing
supplementary form
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8461] Block returns of withdrawn items show as 'not checked out'

2024-06-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8461

Andrii Nugged  changed:

   What|Removed |Added

 Attachment #167326|svreenshot and diagram of   |(screenshot and diagram of
description|potential bug   |a potential bug)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8461] Block returns of withdrawn items show as 'not checked out'

2024-06-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8461

Andrii Nugged  changed:

   What|Removed |Added

 CC||nug...@gmail.com

--- Comment #19 from Andrii Nugged  ---
Created attachment 167326
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167326=edit
svreenshot and diagram of potential bug

Post-production note:

This "not_returned" feature computation logic and:

[% IF ( riloo.not_returned ) %]
Item was not checked in
[% END %]

Our production servers started to show "Item was not checked in" for items that
had just been checked in (also for manual check-in).

I noticed that this happens on the second load. I.e., when there was a modal,
grayed-out content under modal is shown correctly: there is no "not checked in"
message, but then circ/returns.pl page reloaded, form POST'ed again, and on
next screen, it shows this "not checked in" additional message, on the next
after modal, page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8461] Block returns of withdrawn items show as 'not checked out'

2024-05-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8461

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Resolution|--- |FIXED
 Status|Pushed to stable|RESOLVED

--- Comment #18 from Lucas Gass  ---
Doesn't apply cleanly to 23.05.x, no backport.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8461] Block returns of withdrawn items show as 'not checked out'

2024-05-23 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8461

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to main  |Pushed to stable
 CC||fridolin.som...@biblibre.co
   ||m
 Version(s)|24.05.00|24.05.00,23.11.06
released in||

--- Comment #17 from Fridolin Somers  ---
Pushed to 23.11.x for 23.11.06

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8461] Block returns of withdrawn items show as 'not checked out'

2024-04-19 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8461

--- Comment #16 from Katrin Fischer  ---
Pushed for 24.05!

Well done everyone, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8461] Block returns of withdrawn items show as 'not checked out'

2024-04-19 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8461

Katrin Fischer  changed:

   What|Removed |Added

 Version(s)||24.05.00
released in||
 Status|Passed QA   |Pushed to main

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8461] Block returns of withdrawn items show as 'not checked out'

2024-04-19 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8461

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #164829|0   |1
is obsolete||

--- Comment #15 from Marcel de Rooy  ---
Created attachment 165158
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165158=edit
Bug 8461: Tidy

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8461] Block returns of withdrawn items show as 'not checked out'

2024-04-19 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8461

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #164828|0   |1
is obsolete||

--- Comment #14 from Marcel de Rooy  ---
Created attachment 165157
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165157=edit
Bug 8461: Display information on withdrawn item when checked in

This patch displays the due date and withdrawn information in the Checked-in
items table when 'ShowAllCheckins' is enabled. While the top message is clear,
if a staff member checks in two items, then refers to the table they would not
have all the information.

To test:
1 - Enable system preference 'ShowAllCheckins'
2 - Set system preference 'BlockReturnOfWithdrawnItems' to 'Block'
3 - Check out an item to a patron
4 - Mark the item as withdrawn
5 - Check the item in
6 - Note message at top says things like 'Cannot check in' 'Item has been
withdrawn'
7 - Note the Checked-in items table says 'Not checked out'
8 - Apply patch, restart all
9 - Check the item in again
10 - Note top message has not changed
11 - Note the table now say 'Item was not checked in' and displays the due date
and patron info
12 - Note the table also includes the withdrawn value for the item

Signed-off-by: Andrew Fuerste Henry 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8461] Block returns of withdrawn items show as 'not checked out'

2024-04-19 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8461

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8461] Block returns of withdrawn items show as 'not checked out'

2024-04-12 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8461

Nick Clemens  changed:

   What|Removed |Added

 Attachment #162682|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8461] Block returns of withdrawn items show as 'not checked out'

2024-04-12 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8461

--- Comment #13 from Nick Clemens  ---
(In reply to Marcel de Rooy from comment #10)
> if( $issue ){
> my $date_due_dt = dt_from_string( $issue->date_due, 'sql' );
> $duedate = $date_due_dt->strftime('%Y-%m-%d %H:%M');
> $input{borrowernumber} = $issue->borrowernumber;
> $riborrowernumber{0}   = $borrower->{'borrowernumber'};
> }
> $input{duedate}   = $duedate;
> $input{not_returned}   = 1;
> 
> 
> This raises questions. If no issue, you set not_returned? Shouldnt it depend
> on issue?

No issue is one reason for not_returned, others are withdrawn blocked, lost
blocked etc. So the issue variable may or not be present, but the elsif block
we are in means the item was not returned.

> 
> And some untidiness:
>  WARN   circ/returns.pl
>WARN   tidiness
> The file is less tidy than before (bad/messy lines before:
> 230, now: 236)

Tidied

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8461] Block returns of withdrawn items show as 'not checked out'

2024-04-12 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8461

--- Comment #12 from Nick Clemens  ---
Created attachment 164829
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164829=edit
Bug 8461: Tidy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8461] Block returns of withdrawn items show as 'not checked out'

2024-04-12 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8461

--- Comment #11 from Nick Clemens  ---
Created attachment 164828
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164828=edit
Bug 8461: Display information on withdrawn item when checked in

This patch displays the due date and withdrawn information in the Checked-in
items table when 'ShowAllCheckins' is enabled. While the top message is clear,
if a staff member checks in two items, then refers to the table they would not
have all the information.

To test:
1 - Enable system preference 'ShowAllCheckins'
2 - Set system preference 'BlockReturnOfWithdrawnItems' to 'Block'
3 - Check out an item to a patron
4 - Mark the item as withdrawn
5 - Check the item in
6 - Note message at top says things like 'Cannot check in' 'Item has been
withdrawn'
7 - Note the Checked-in items table says 'Not checked out'
8 - Apply patch, restart all
9 - Check the item in again
10 - Note top message has not changed
11 - Note the table now say 'Item was not checked in' and displays the due date
and patron info
12 - Note the table also includes the withdrawn value for the item

Signed-off-by: Andrew Fuerste Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8461] Block returns of withdrawn items show as 'not checked out'

2024-04-12 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8461

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8461] Block returns of withdrawn items show as 'not checked out'

2024-04-05 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8461

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 Status|Signed Off  |Failed QA
 QA Contact||m.de.r...@rijksmuseum.nl

--- Comment #10 from Marcel de Rooy  ---
if( $issue ){
my $date_due_dt = dt_from_string( $issue->date_due, 'sql' );
$duedate = $date_due_dt->strftime('%Y-%m-%d %H:%M');
$input{borrowernumber} = $issue->borrowernumber;
$riborrowernumber{0}   = $borrower->{'borrowernumber'};
}
$input{duedate}   = $duedate;
$input{not_returned}   = 1;


This raises questions. If no issue, you set not_returned? Shouldnt it depend on
issue?

And some untidiness:
 WARN   circ/returns.pl
   WARN   tidiness
The file is less tidy than before (bad/messy lines before: 230,
now: 236)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8461] Block returns of withdrawn items show as 'not checked out'

2024-03-01 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8461

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Attachment #161342|0   |1
is obsolete||

--- Comment #9 from Andrew Fuerste-Henry  ---
Created attachment 162682
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162682=edit
Bug 8461: Display information on whithdrawn item when checked in

This patch displays the due date and withdrawn information in the Checked-in
items table when 'ShowAllCheckins' is enabled. While the top message is clear,
if a staff member checks in two items, then refers to the table they would not
have all the information.

To test:
1 - Enable system preference 'ShowAllCheckins'
2 - Set system preference 'BlockReturnOfWithdrawnItems' to 'Block'
3 - Check out an item to a patron
4 - Mark the item as withdrawn
5 - Check the item in
6 - Note message at top says things like 'Cannot check in' 'Item has been
withdrawn'
7 - Note the Checked-in items table says 'Not checked out'
8 - Apply patch, restart all
9 - Check the item in again
10 - Note top message has not changed
11 - Note the table now say 'Item was not checked in' and displays the due date
and patron info
12 - Note the table also includes the withdrawn value for the item

Signed-off-by: Andrew Fuerste Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8461] Block returns of withdrawn items show as 'not checked out'

2024-03-01 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8461

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8461] Block returns of withdrawn items show as 'not checked out'

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8461

--- Comment #8 from Kristi  ---
I was testing in a sandbox, Nick. I think that may answer your second question.
It sounds like perhaps this is best tested in a dev environment.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8461] Block returns of withdrawn items show as 'not checked out'

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8461

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #7 from Nick Clemens  ---
(In reply to Kristi from comment #3)
> In testing, I do not see 11 - Note the table now say 'Item was not checked
> in' and displays the due date and patron info
> 12 - Note the table also includes the withdrawn value for the item.
> Screenshot attachment to come.

This works for me in my testing - did you test on a sandbox, or a local dev
environment? Can you confirm plack/memchaced were restarted after the patch was
applied?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8461] Block returns of withdrawn items show as 'not checked out'

2024-01-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8461

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #6 from Katrin Fischer  ---
Setting to Failed QA so the patch author is alerted (see last comments from
Kristi)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8461] Block returns of withdrawn items show as 'not checked out'

2024-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8461

--- Comment #5 from Kristi  ---
Created attachment 161372
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161372=edit
DueDateInfo.PNG

The checkout info does still shows the item checked out to the patron.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8461] Block returns of withdrawn items show as 'not checked out'

2024-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8461

--- Comment #4 from Kristi  ---
Created attachment 161371
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161371=edit
WithdrawnNotCheckedIn.PNG

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8461] Block returns of withdrawn items show as 'not checked out'

2024-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8461

Kristi  changed:

   What|Removed |Added

 CC||kkrue...@cuyahogalibrary.or
   ||g

--- Comment #3 from Kristi  ---
In testing, I do not see 11 - Note the table now say 'Item was not checked in'
and displays the due date and patron info
12 - Note the table also includes the withdrawn value for the item. Screenshot
attachment to come.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8461] Block returns of withdrawn items show as 'not checked out'

2024-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8461

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8461] Block returns of withdrawn items show as 'not checked out'

2024-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8461

--- Comment #2 from Nick Clemens  ---
Created attachment 161342
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161342=edit
Bug 8461: Display information on whithdrawn item when checked in

This patch displays the due date and withdrawn information in the Checked-in
items table when 'ShowAllCheckins' is enabled. While the top message is clear,
if a staff member checks in two items, then refers to the table they would not
have all the information.

To test:
1 - Enable system preference 'ShowAllCheckins'
2 - Set system preference 'BlockReturnOfWithdrawnItems' to 'Block'
3 - Check out an item to a patron
4 - Mark the item as withdrawn
5 - Check the item in
6 - Note message at top says things like 'Cannot check in' 'Item has been
withdrawn'
7 - Note the Checked-in items table says 'Not checked out'
8 - Apply patch, restart all
9 - Check the item in again
10 - Note top message has not changed
11 - Note the table now say 'Item was not checked in' and displays the due date
and patron info
12 - Note the table also includes the withdrawn value for the item

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8461] Block returns of withdrawn items show as 'not checked out'

2024-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8461

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8461] Block returns of withdrawn items show as 'not checked out'

2019-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8461

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de,
   ||oleon...@myacpl.org

--- Comment #1 from Katrin Fischer  ---
Hi Owen,
not sure you remember that one. What would you expect to display?

I just checked, when returning the item the messages on top say:

Item is withdrawn.
Item not checked out.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8461] Block returns of withdrawn items show as 'not checked out'

2015-05-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8461

Josef Moravec josef.mora...@gmail.com changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8461] Block returns of withdrawn items show as 'not checked out'

2012-07-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8461

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=3387

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/