[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Michael Adamyk changed: What|Removed |Added CC|mada...@ckls.org| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 koha-US bug tracker changed: What|Removed |Added CC||bugzi...@koha-us.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #57 from Jonathan Druart --- If you were interested in this, can you help testing bug 33948 please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Jonathan Druart changed: What|Removed |Added Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE --- Comment #56 from Jonathan Druart --- This will be fixed on bug 33948. *** This bug has been marked as a duplicate of bug 33948 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Michael Adamyk changed: What|Removed |Added CC||mada...@ckls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Amanda Campbell changed: What|Removed |Added CC||acampb...@hmcpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #55 from Marjorie Barry-Vila --- still valid in 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Chris Slone changed: What|Removed |Added CC||cslone@camdencountylibrary. ||org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Patrick Robitaille changed: What|Removed |Added CC||patrick.robitai...@ccsr.qc. ||ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Nicole C. Engard changed: What|Removed |Added CC|neng...@gmail.com | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #54 from Kyle M Hall --- (In reply to Jonathan Druart from comment #53) > (In reply to Kyle M Hall from comment #51) > > I need someone to tell me what needs changed in order to for this to pqa. > > All of these changes are internal to Koha::Object and it's children. Taking > > advantage of the underlying DBIC object should not be an issue. Can someone > > please tell me specifically what needs to be changed? > > I am sorry but I do not have any good answers. > It seems that we are stuck with our Koha::Object[s] implementation at > different places. Here you are trying to cache something when we should rely > on DBIx::Class. Can you describe how we should be relying on DBIx::Class here? Are you saying I should be getting the data via the underlying DBIC connection which I can then wrap and return? If so I can do that! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #53 from Jonathan Druart --- (In reply to Kyle M Hall from comment #51) > I need someone to tell me what needs changed in order to for this to pqa. > All of these changes are internal to Koha::Object and it's children. Taking > advantage of the underlying DBIC object should not be an issue. Can someone > please tell me specifically what needs to be changed? I am sorry but I do not have any good answers. It seems that we are stuck with our Koha::Object[s] implementation at different places. Here you are trying to cache something when we should rely on DBIx::Class. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #52 from Nicole C. Engard --- Checking in here. Can anyone on the QA team help Kyle with his question? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #51 from Kyle M Hall --- I need someone to tell me what needs changed in order to for this to pqa. All of these changes are internal to Koha::Object and it's children. Taking advantage of the underlying DBIC object should not be an issue. Can someone please tell me specifically what needs to be changed? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #50 from Katrin Fischer --- I think we can agree that the feature itself would be good to have, hope we can agree about implementation too :) Moving this to 'failed qa' (unit tests) for now - please take a look at the comments and feel free to bring it up at the next dev meeting if you think this will help moving it forward. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #49 from Katrin Fischer --- Should we move this out of the list for now? "In Discussion" or "Failed QA"? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #48 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #47) > The trick done in Koha::Checkout->item may be dangerous. > Same for Koha::Item->biblio and Koha::Item->biblioitem > You are not fetching the item on each call. That mean you could retrieve an > outdated info in some scenarios. > > The mix between the Koha::Object and DBIx::Class calls is also weird. > > I'd like to get some other QA point of views on this patch set. Does not look good to me too. We should probably not use _new_from_dbic outside Object[s] too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Jonathan Druart changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #47 from Jonathan Druart --- The trick done in Koha::Checkout->item may be dangerous. Same for Koha::Item->biblio and Koha::Item->biblioitem You are not fetching the item on each call. That mean you could retrieve an outdated info in some scenarios. The mix between the Koha::Object and DBIx::Class calls is also weird. I'd like to get some other QA point of views on this patch set. Note that tests are not provided and will be a blocker. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Kyle M Hall changed: What|Removed |Added Status|Patch doesn't apply |Signed Off --- Comment #46 from Kyle M Hall --- Test Case, Patron with 502 checkouts: Master: 2.7 seconds Original Patch: 4.8 seconds With followup: 3.6 seconds Given the improvements this patch makes, the uncommon usage of the feature, and the OO improvements, I think the minor decrease in the script speed this patch causes is worth the cost. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Kyle M Hall changed: What|Removed |Added Attachment #49144|0 |1 is obsolete|| --- Comment #45 from Kyle M Hall --- Created attachment 49145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49145&action=edit Bug 8483 - Speed improvements -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Kyle M Hall changed: What|Removed |Added Attachment #49143|0 |1 is obsolete|| --- Comment #44 from Kyle M Hall --- Created attachment 49144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49144&action=edit Bug 8483 - Speed improvements -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #43 from Kyle M Hall --- Created attachment 49143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49143&action=edit Bug 8483 - Speed improvements -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #40 from Kyle M Hall --- Created attachment 49140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49140&action=edit Bug 8483 - Add checkout classes Signed-off-by: Heather Braum -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Kyle M Hall changed: What|Removed |Added Attachment #49134|0 |1 is obsolete|| Attachment #49135|0 |1 is obsolete|| Attachment #49136|0 |1 is obsolete|| Attachment #49137|0 |1 is obsolete|| --- Comment #39 from Kyle M Hall --- Created attachment 49139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49139&action=edit Bug 8483 - Move Koha::Biblioitem(s) to Koha::BiblioItem(s) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #41 from Kyle M Hall --- Created attachment 49141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49141&action=edit Bug 8483 - Add record and item related classes Signed-off-by: Heather Braum -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #42 from Kyle M Hall --- Created attachment 49142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49142&action=edit Bug 8483 - Borrower reading history should include deleted items When showing a borrower's reading history, it'd be good to be able to include the deleted items also, as we have that information available. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Members/GetAllIssues.t 3) Check out and return an item for a patron 4) Delete that item 5) Verify the record still shows in the patron's reading history 6) Delete the record entirely 7) Verify the record still shows in the patron's reading history, but that the title is now just text instead of a hyperlink. Signed-off-by: Heather Braum -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #37 from Kyle M Hall --- Created attachment 49136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49136&action=edit Bug 8483 - Add record and item related classes Signed-off-by: Heather Braum -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Kyle M Hall changed: What|Removed |Added Attachment #49129|0 |1 is obsolete|| Attachment #49130|0 |1 is obsolete|| Attachment #49131|0 |1 is obsolete|| --- Comment #35 from Kyle M Hall --- Created attachment 49134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49134&action=edit Bug 8483 - Move Koha::Biblioitem(s) to Koha::BiblioItem(s) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #36 from Kyle M Hall --- Created attachment 49135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49135&action=edit Bug 8483 - Add checkout classes Signed-off-by: Heather Braum -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #38 from Kyle M Hall --- Created attachment 49137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49137&action=edit Bug 8483 - Borrower reading history should include deleted items When showing a borrower's reading history, it'd be good to be able to include the deleted items also, as we have that information available. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Members/GetAllIssues.t 3) Check out and return an item for a patron 4) Delete that item 5) Verify the record still shows in the patron's reading history 6) Delete the record entirely 7) Verify the record still shows in the patron's reading history, but that the title is now just text instead of a hyperlink. Signed-off-by: Heather Braum -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #34 from Kyle M Hall --- Created attachment 49131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49131&action=edit Bug 8483 - Borrower reading history should include deleted items When showing a borrower's reading history, it'd be good to be able to include the deleted items also, as we have that information available. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Members/GetAllIssues.t 3) Check out and return an item for a patron 4) Delete that item 5) Verify the record still shows in the patron's reading history 6) Delete the record entirely 7) Verify the record still shows in the patron's reading history, but that the title is now just text instead of a hyperlink. Signed-off-by: Heather Braum -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Kyle M Hall changed: What|Removed |Added Attachment #42939|0 |1 is obsolete|| Attachment #42940|0 |1 is obsolete|| Attachment #42941|0 |1 is obsolete|| --- Comment #32 from Kyle M Hall --- Created attachment 49129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49129&action=edit Bug 8483 - Add checkout classes Signed-off-by: Heather Braum -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #33 from Kyle M Hall --- Created attachment 49130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49130&action=edit Bug 8483 - Add record and item related classes Signed-off-by: Heather Braum -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Sally Healey changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 M. Tompsett changed: What|Removed |Added CC||mtomp...@hotmail.com See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=15795 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl Status|Signed Off |Patch doesn't apply --- Comment #31 from Marcel de Rooy --- The patch does not apply anymore. Additionally, reading the discussion, how can I generate some performance figures to compare with the different figures given already? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Kyle M Hall changed: What|Removed |Added Assignee|kyle.m.h...@gmail.com |k...@bywatersolutions.com CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de, ||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #30 from Jonathan Druart --- tested again, without plack, and got exactly the same difference. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #29 from Kyle M Hall --- (In reply to Jonathan Druart from comment #28) > (In reply to Kyle M Hall from comment #27) > > With 540 checkouts I get the following with your script: > > > > on master: > > real0m1.023s > > user0m0.980s > > sys 0m0.044s > > > > with bug 8483: > > real0m1.032s > > user0m0.980s > > sys 0m0.052s > > Is it 500 checkouts for 1 patron? Yes, all the checkouts are for one patron. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #28 from Jonathan Druart --- (In reply to Kyle M Hall from comment #27) > With 540 checkouts I get the following with your script: > > on master: > real 0m1.023s > user 0m0.980s > sys 0m0.044s > > with bug 8483: > real 0m1.032s > user 0m0.980s > sys 0m0.052s Is it 500 checkouts for 1 patron? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #27 from Kyle M Hall --- With 540 checkouts I get the following with your script: on master: real0m1.023s user0m0.980s sys 0m0.044s with bug 8483: real0m1.032s user0m0.980s sys 0m0.052s -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Jonathan Druart changed: What|Removed |Added Version|3.8 |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #26 from Jonathan Druart --- I was afraid of the complexity in the call stack, so did some tests: $ more bug_8483.pl use Modern::Perl; use C4::Members; my $borrowernumber=42; my $issues = GetAllIssues( $borrowernumber, 'date_due desc' ); > select count(*) from old_issues where borrowernumber=42; 43 > select count(*) from issues where borrowernumber=42; 7 $ git checkout master; git reset --hard origin/master $ git checkout -b bug_8483; git bz apply 8483 $ git checkout master; time perl bug_8483.pl perl bug_8483.pl 1.23s user 0.04s system 99% cpu 1.270 total $ git checkout bug_8483; time perl bug_8483.pl perl bug_8483.pl 1.50s user 0.05s system 99% cpu 1.560 total # => Ok we get the old_issues in addition of # Adding some issues to the patron > select count(*) from issues where borrowernumber=42; 49 # master perl bug_8483.pl 1.21s user 0.08s system 99% cpu 1.280 total # bug_8483 perl bug_8483.pl 1.82s user 0.07s system 97% cpu 1.933 total 210 # master perl bug_8483.pl 1.21s user 0.07s system 98% cpu 1.293 total # bug_8483 perl bug_8483.pl 2.73s user 0.09s system 95% cpu 2.959 total 600 # master perl bug_8483.pl 1.28s user 0.03s system 97% cpu 1.340 total # bug_8483 perl bug_8483.pl 4.78s user 0.10s system 94% cpu 5.154 total -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Kyle M Hall changed: What|Removed |Added Assignee|ro...@catalyst.net.nz |kyle.m.h...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Nicole C. Engard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #25 from Nicole C. Engard --- Created attachment 42941 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42941&action=edit Bug 8483 - Borrower reading history should include deleted items When showing a borrower's reading history, it'd be good to be able to include the deleted items also, as we have that information available. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Members/GetAllIssues.t 3) Check out and return an item for a patron 4) Delete that item 5) Verify the record still shows in the patron's reading history 6) Delete the record entirely 7) Verify the record still shows in the patron's reading history, but that the title is now just text instead of a hyperlink. Signed-off-by: Heather Braum -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #24 from Nicole C. Engard --- Created attachment 42940 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42940&action=edit Bug 8483 - Add record and item related classes Signed-off-by: Heather Braum -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Nicole C. Engard changed: What|Removed |Added Attachment #42787|0 |1 is obsolete|| Attachment #42788|0 |1 is obsolete|| Attachment #42935|0 |1 is obsolete|| --- Comment #23 from Nicole C. Engard --- Created attachment 42939 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42939&action=edit Bug 8483 - Add checkout classes Signed-off-by: Heather Braum -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Kyle M Hall changed: What|Removed |Added Attachment #42932|0 |1 is obsolete|| --- Comment #22 from Kyle M Hall --- Created attachment 42935 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42935&action=edit Bug 8483 - Borrower reading history should include deleted items When showing a borrower's reading history, it'd be good to be able to include the deleted items also, as we have that information available. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Members/GetAllIssues.t 3) Check out and return an item for a patron 4) Delete that item 5) Verify the record still shows in the patron's reading history 6) Delete the record entirely 7) Verify the record still shows in the patron's reading history, but that the title is now just text instead of a hyperlink. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Kyle M Hall changed: What|Removed |Added Attachment #42789|0 |1 is obsolete|| --- Comment #21 from Kyle M Hall --- Created attachment 42932 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42932&action=edit Bug 8483 - Borrower reading history should include deleted items When showing a borrower's reading history, it'd be good to be able to include the deleted items also, as we have that information available. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Members/GetAllIssues.t 3) Verify old checkouts for deleted items show in reading history -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Kyle M Hall changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #20 from Kyle M Hall --- Created attachment 42789 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42789&action=edit Bug 8483 - Borrower reading history should include deleted items When showing a borrower's reading history, it'd be good to be able to include the deleted items also, as we have that information available. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Members/GetAllIssues.t 3) Verify old checkouts for deleted items show in reading history -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Kyle M Hall changed: What|Removed |Added Attachment #41999|0 |1 is obsolete|| Attachment #42000|0 |1 is obsolete|| Attachment #42001|0 |1 is obsolete|| --- Comment #18 from Kyle M Hall --- Created attachment 42787 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42787&action=edit Bug 8483 - Add checkout classes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #19 from Kyle M Hall --- Created attachment 42788 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42788&action=edit Bug 8483 - Add record and item related classes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Kyle M Hall changed: What|Removed |Added Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #17 from Kyle M Hall --- I'm unable to reproduce your test failure: prove t/db_dependent/Members/GetAllIssues.t t/db_dependent/Members/GetAllIssues.t .. ok All tests successful. Files=1, Tests=16, 5 wallclock secs ( 0.02 usr 0.01 sys + 1.06 cusr 0.08 csys = 1.17 CPU) Result: PASS (In reply to Aleisha Amohia from comment #16) > DBD::mysql::db do failed: Lock wait timeout exceeded; try restarting > transaction at ../t/db_dependent/Members/GetAllIssues.t line 20. > # Looks like your test exited with 255 before it could output anything. > ../t/db_dependent/Members/GetAllIssues.t .. Dubious, test returned 255 > (wstat 65280, 0xff00) > Failed 16/16 subtests > > Test Summary Report > --- > ../t/db_dependent/Members/GetAllIssues.t (Wstat: 65280 Tests: 0 Failed: 0) > Non-zero exit status: 255 > Parse errors: Bad plan. You planned 16 tests but ran 0. > Files=1, Tests=0, 56 wallclock secs ( 0.01 usr 0.03 sys + 1.19 cusr 0.22 > csys = 1.45 CPU) > Result: FAIL > > Setting to Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||aleishaamo...@hotmail.com --- Comment #16 from Aleisha Amohia --- DBD::mysql::db do failed: Lock wait timeout exceeded; try restarting transaction at ../t/db_dependent/Members/GetAllIssues.t line 20. # Looks like your test exited with 255 before it could output anything. ../t/db_dependent/Members/GetAllIssues.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 16/16 subtests Test Summary Report --- ../t/db_dependent/Members/GetAllIssues.t (Wstat: 65280 Tests: 0 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 16 tests but ran 0. Files=1, Tests=0, 56 wallclock secs ( 0.01 usr 0.03 sys + 1.19 cusr 0.22 csys = 1.45 CPU) Result: FAIL Setting to Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #15 from Kyle M Hall --- Created attachment 42001 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42001&action=edit Bug 8483 - Borrower reading history should include deleted items When showing a borrower's reading history, it'd be good to be able to include the deleted items also, as we have that information available. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Members/GetAllIssues.t 3) Verify old checkouts for deleted items show in reading history -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #14 from Kyle M Hall --- Created attachment 42000 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42000&action=edit Bug 8483 - Add record and item related classes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Kyle M Hall changed: What|Removed |Added Attachment #41015|0 |1 is obsolete|| Attachment #41016|0 |1 is obsolete|| Attachment #41017|0 |1 is obsolete|| --- Comment #13 from Kyle M Hall --- Created attachment 41999 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41999&action=edit Bug 8483 - Add checkout classes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #12 from Kyle M Hall --- (In reply to Robin Sheat from comment #11) > Is this a bit overengineered? Could you not just extend the query? I can see why you'd think that. I'd consider this as an opportunity to add some more useful Koha objects. There's little point to having an OO model if we don't take advantage of it, and there always has to be that first step! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #11 from Robin Sheat --- Is this a bit overengineered? Could you not just extend the query? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Kyle M Hall changed: What|Removed |Added Attachment #41014|0 |1 is obsolete|| --- Comment #8 from Kyle M Hall --- Created attachment 41015 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41015&action=edit Bug 8483 - Add checkout classes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #10 from Kyle M Hall --- Created attachment 41017 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41017&action=edit Bug 8483 - Borrower reading history should include deleted items When showing a borrower's reading history, it'd be good to be able to include the deleted items also, as we have that information available. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Members/GetAllIssues.t 3) Verify old checkouts for deleted items show in reading history -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #9 from Kyle M Hall --- Created attachment 41016 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41016&action=edit Bug 8483 - Add record and item related classes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Kyle M Hall changed: What|Removed |Added Attachment #41013|0 |1 is obsolete|| --- Comment #7 from Kyle M Hall --- Created attachment 41014 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41014&action=edit Bug 8483 - Add checkout classes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #6 from Kyle M Hall --- Created attachment 41013 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41013&action=edit Bug 8483 - Borrower reading history should include deleted items TODO: Break patch into smaller parts, add unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Kyle M Hall changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #5 from Heather Braum --- Checking back in to see if the patch for this has moved forward, any further. Thanks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #4 from Heather Braum --- Has there been any further movement on this bug? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #3 from Robin Sheat --- It's very much on the backburner, but is fairly close to being done. If memory serves, it needs some minor schema changes, and that should be about it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #2 from Heather Braum --- Is this bug still being worked on by Horowhenua? We are very interested in this one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Heather Braum changed: What|Removed |Added CC||hbr...@nekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Nicole C. Engard changed: What|Removed |Added CC||neng...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Liz Rea (CatalystIT) changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=3397 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Mickey Coalwell changed: What|Removed |Added CC||mcoalw...@nekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Liz Rea (CatalystIT) changed: What|Removed |Added CC||l...@catalyst.net.nz --- Comment #1 from Liz Rea (CatalystIT) --- Work is currently in progress on this bug for Horowhenua District Council. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Robin Sheat changed: What|Removed |Added Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored Assignee|koha-b...@lists.koha-commun |ro...@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
