subject:"\[Koha\-bugs\] \[Bug 8612\] CSV export profile to have custom fields in export csv basket"

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2018-01-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Fridolin SOMERS  changed:

   What|Removed |Added

 Blocks||19200


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19200
[Bug 19200] Warns when exporting a basket
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-12-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Maura Stephens  changed:

   What|Removed |Added

 CC||maura.steph...@gmit.ie

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-07-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Fridolin SOMERS  changed:

   What|Removed |Added

 Blocks||18917


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18917
[Bug 18917] use font awesome buttons in CSV profiles
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-06-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 CC||fridolin.som...@biblibre.co
   ||m
 Resolution|--- |FIXED

--- Comment #118 from Fridolin SOMERS  ---
Enhancement not pushed to 17.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-06-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

--- Comment #117 from Jonathan Druart  
---
Comment on attachment 63910
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63910
Bug 8612: Use CSV profile for exporting basket

Review of attachment 63910:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=8612=63910)
-

::: C4/Acquisition.pm
@@ +310,5 @@
> +my $bd = GetBiblioData( $order->{'biblionumber'} );
> +my @biblioitems = GetBiblioItemByBiblioNumber( 
> $order->{'biblionumber'});
> +for my $biblioitem (@biblioitems) {
> +if ($biblioitem->{isbn} eq $order->{isbn}) {
> +$order = {%$order, %$biblioitem};

Could you explain these 3 lines?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-06-06 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

--- Comment #116 from Josef Moravec  ---
*** Bug 18717 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-06-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #115 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-06-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

--- Comment #114 from Jonathan Druart  
---
Created attachment 63966
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63966=edit
Bug 8612: Update installer files for late_issues

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-06-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

--- Comment #113 from Jonathan Druart  
---
Created attachment 63964
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63964=edit
Bug 8612: Remove warnings from tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-06-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

--- Comment #112 from Josef Moravec  ---
(In reply to Marcel de Rooy from comment #110)
> And:
> die "There is no valid csv profile given" unless $csv_profile;
> Being liberal now. But we should actually use Koha::Exceptions now according
> to a new rule in the coding guidelines.

I filled new bug 18720

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-06-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Josef Moravec  changed:

   What|Removed |Added

 Blocks||18720


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18720
[Bug 18720] Get rid of "die" in favor of exceptions in
C4::Acquisition::GetBasketAsCsv
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-06-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

--- Comment #111 from Josef Moravec  ---
(In reply to Marcel de Rooy from comment #109)
> Another report may still deal with this warn:
> Use of uninitialized value in string eq at C4/Acquisition.pm line 318.

I filled new bug 18717 for this

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-06-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Josef Moravec  changed:

   What|Removed |Added

 Blocks||18717


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18717
[Bug 18717] Use of uninitialized value in string eq at C4/Acquisition.pm line
318 after bug 8612
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-06-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

--- Comment #110 from Marcel de Rooy  ---
And:
die "There is no valid csv profile given" unless $csv_profile;
Being liberal now. But we should actually use Koha::Exceptions now according to
a new rule in the coding guidelines.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-06-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

--- Comment #109 from Marcel de Rooy  ---
Another report may still deal with this warn:
Use of uninitialized value in string eq at C4/Acquisition.pm line 318.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-06-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-06-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

--- Comment #108 from Marcel de Rooy  ---
Created attachment 63915
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63915=edit
Bug 8612: [QA Follow-up] Remove two newlines from template output

When using the Default profile from the basket form, the resulting csv
file has an additional newline after the headers and at the end.
This patch removes them.
Unit test adjusted accordingly.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-06-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

--- Comment #107 from Marcel de Rooy  ---
Created attachment 63914
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63914=edit
Bug 8612: [Follow-up] Fix unit test GetBasketAsCSV.t

Test plan:
Run t/db_dependent/Acquisition/GetBasketAsCSV.t

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-06-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

--- Comment #106 from Marcel de Rooy  ---
Created attachment 63913
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63913=edit
Bug 8612: [Follow-up] Fix regular expression

Fix regular expression to do what is described in the comment
Make header in CSV profile definition optional
Strip white chars from csv profile definition

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-06-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

--- Comment #105 from Marcel de Rooy  ---
Created attachment 63912
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63912=edit
Bug 8612: [Follow-up] Update DBIx schema

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-06-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

--- Comment #103 from Marcel de Rooy  ---
Created attachment 63910
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63910=edit
Bug 8612: Use CSV profile for exporting basket

This patch allows the user to use a CSV export profile to create the fields to
export the basket as CSV in a basket page.

Test plan:
1) Apply the patch
2) Go to Tools › CSV export profiles and create a profile of type "SQL for
basket export in acquisition"
  example:
 
biblionumber=biblio.biblionumber|auteur=biblio.author|titre=biblio.title|date=biblioitems.copyrightdate|editeur=biblioitems.publishercode|isbn=biblioitems.isbn|quantite=aqorders.quantity|prix=aqorders.rrp|panier=aqorders.basketno
3) In acquisition module, create a new basket and add an order to the basket
4) On basket detail page, there should be the split button labelled "Export to
CSV"
5) Try to use the button and export CSV with your CSV profile you defined in
step 2
6) Validate the CSV file.
7) Repeat 4-6 with a closed basket.
a) close the basket
b) View the basket
c) validate that there is an export button
d) test it with an export
8) prove t/db_dependent/Acquisition/GetBasketAsCSV.t
t/db_dependent/Koha/CsvProfiles.t

Initial work:

Sponsored by: CCSR

Signed-off-by: Josef Moravec 
Signed-off-by: mehdi 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-06-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

--- Comment #104 from Marcel de Rooy  ---
Created attachment 63911
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63911=edit
Bug 8612: [Follow-up] Make usage and type different columns in table

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-06-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

--- Comment #102 from Marcel de Rooy  ---
Rearranging extensive number of (qa) follow-ups according to this plan:

Patch 1 Original start
Patch 3 + 5 + 6 Change table design
Patch 4 DBIx Schema
Patch 7 + Patch 8 + Patch 10a Module fixes
Patch 2 + Patch 9 + Patch 10b Unit test
Patch 11 New QA follow-up

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-06-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #63279|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-06-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #63054|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-06-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #63052|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-06-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #63053|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-06-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #63049|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-06-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #63055|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-06-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #63050|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-06-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #63051|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-06-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #63104|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-06-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #63048|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-05-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

--- Comment #101 from Josef Moravec  ---
Ok, it was not good solution, now should be better ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-05-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Josef Moravec  changed:

   What|Removed |Added

  Attachment #63158|0   |1
is obsolete||

--- Comment #100 from Josef Moravec  ---
Created attachment 63279
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63279=edit
Bug 8612: QA followup - strip white chars from csv profile definition, expand
test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-05-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Josef Moravec  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #99 from Josef Moravec  ---
(In reply to Marcel de Rooy from comment #95)
> I tested with a trival csv:
> biblio.title | some_text=aqorders.quantity
> 
> The title is not shown, the quantity is. Have the impression that the regex
> might still be the cause.
> What did you test?

The reason it doesn't work for you are the spaces between fields in your
definition.

The help paragraph on csv profile page doesn't say anything about spaces, so i
decided to strip the white chars from definition before generating csv. It
doesn't hurt and could help to avoid unexpected issues.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-05-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

--- Comment #98 from Josef Moravec  ---
Created attachment 63158
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63158=edit
Bug 8612: QA followup - strip white chars from csv profile definition

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

--- Comment #97 from Philippe Audet-Fortin  
---
(In reply to Marcel de Rooy from comment #95)
> I tested with a trival csv:
> biblio.title | some_text=aqorders.quantity
> 
> The title is not shown, the quantity is. Have the impression that the regex
> might still be the cause.
> What did you test?

I copy paste your csv and I got some blank fields too. I try by removing white
spaces and it worked.
(I had not seen your comment and I signoff too early. Sorry.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Philippe Audet-Fortin  changed:

   What|Removed |Added

  Attachment #63056|0   |1
is obsolete||

--- Comment #96 from Philippe Audet-Fortin  
---
Created attachment 63104
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63104=edit
Bug 8612: QA followup - expand tests

Test plan:
prove t/db_dependent/Acquisition/GetBasketAsCSV.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #95 from Marcel de Rooy  ---
I tested with a trival csv:
biblio.title | some_text=aqorders.quantity

The title is not shown, the quantity is. Have the impression that the regex
might still be the cause.
What did you test?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Josef Moravec  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #94 from Josef Moravec  ---
(In reply to Marcel de Rooy from comment #81)
> See two things so far:
> 
> [1] Regex for field does not work:
> $field =~ s/[^\.]*\.?//; # Remove the table name if exists.
> Does not work well if there is no table in front.
> Try this:
> $field="title";
> print "$field\n";
> $field =~ s/[^\.]*\.?//; # Remove the table name if exists.
> print "$field\n";

Fixed by first today's followup

> [2] Regex for header and fieldname makes header no longer optional.
> while ( $csv_profile_content =~ /
> ([^=]+) # header
> =
> ([^\|]+) # fieldname (table.row or row)
> \|? /gxms
> ) {
> But if I understand correctly from this feature, the header should be
> optional.
> === Quote
> You have to define which fields you want to export, separated by pipes.
> You can also use your own headers (instead of the ones from Koha) by
> prefixing the field name with an header, followed by the equal sign.
> ===
> If I remove the headers now, I will have an empty csv file.

Fixed by second today's followup

Third followup is adding one more test case

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

--- Comment #91 from Josef Moravec  ---
Created attachment 63054
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63054=edit
Bug 8612: QA folowup - fix regular expression to do what is described in the
comment

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

--- Comment #93 from Josef Moravec  ---
Created attachment 63056
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63056=edit
Bug 8612: QA followup - expand tests

Test plan:
prove t/db_dependent/Acquisition/GetBasketAsCSV.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

--- Comment #92 from Josef Moravec  ---
Created attachment 63055
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63055=edit
Bug 8612: QA followup - make header in CSV profile definition optional

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Josef Moravec  changed:

   What|Removed |Added

  Attachment #61405|0   |1
is obsolete||

--- Comment #88 from Josef Moravec  ---
Created attachment 63052
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63052=edit
Bug 8612 - QA followup, fix kohastructure.sql, fix typo in template

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

--- Comment #90 from Josef Moravec  ---
Just a rebase first...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Josef Moravec  changed:

   What|Removed |Added

  Attachment #61267|0   |1
is obsolete||

--- Comment #87 from Josef Moravec  ---
Created attachment 63051
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63051=edit
Bug 8612: QA followup - update dbix schema

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Josef Moravec  changed:

   What|Removed |Added

  Attachment #61266|0   |1
is obsolete||

--- Comment #86 from Josef Moravec  ---
Created attachment 63050
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63050=edit
Bug 8612: QA followup - make usage and type different columns in db

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Josef Moravec  changed:

   What|Removed |Added

  Attachment #61264|0   |1
is obsolete||

--- Comment #84 from Josef Moravec  ---
Created attachment 63048
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63048=edit
Bug 8612: Use CSV profile for exporting basket

This patch allows the user to use a CSV export profile to create the fields to
export the basket as CSV in a basket page.

Test plan:
1) Apply the patch
2) Go to Tools › CSV export profiles and create a profile of type "SQL for
basket export in acquisition"
  example:
 
biblionumber=biblio.biblionumber|auteur=biblio.author|titre=biblio.title|date=biblioitems.copyrightdate|editeur=biblioitems.publishercode|isbn=biblioitems.isbn|quantite=aqorders.quantity|prix=aqorders.rrp|panier=aqorders.basketno
3) In acquisition module, create a new basket and add an order to the basket
4) On basket detail page, there should be the split button labelled "Export to
CSV"
5) Try to use the button and export CSV with your CSV profile you defined in
step 2
6) Validate the CSV file.
7) Repeat 4-6 with a closed basket.
a) close the basket
b) View the basket
c) validate that there is an export button
d) test it with an export
8) prove t/db_dependent/Acquisition/GetBasketAsCSV.t
t/db_dependent/Koha/CsvProfiles.t

Initial work:

Sponsored by: CCSR

Signed-off-by: Josef Moravec 
Signed-off-by: mehdi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Josef Moravec  changed:

   What|Removed |Added

  Attachment #61520|0   |1
is obsolete||

--- Comment #89 from Josef Moravec  ---
Created attachment 63053
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63053=edit
Bug 8612: [QA Follow-up] Just a cosmetic space

Could not resist to add it :)

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Josef Moravec  changed:

   What|Removed |Added

  Attachment #61265|0   |1
is obsolete||

--- Comment #85 from Josef Moravec  ---
Created attachment 63049
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63049=edit
Bug 8612: QA-followup - Fix test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

--- Comment #83 from Marcel de Rooy  ---
(In reply to Philippe Audet-Fortin from comment #82)
> Hi Marcel, I was wondering what you want to show in your first subparagraph,
> because it seems normal to me that it will not work if there is no table in
> front of the field. Koha need to know the table where the field come from.
> (Sorry for my english :))

Hmm. Maybe a misunderstanding. Comment81 refers to some lines in the code
including the comment "# Remove the table name if exists."

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-05-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Philippe Audet-Fortin  changed:

   What|Removed |Added

 CC||philippe.audet-fortin@inlib
   ||ro.com

--- Comment #82 from Philippe Audet-Fortin  
---
Hi Marcel, I was wondering what you want to show in your first subparagraph,
because it seems normal to me that it will not work if there is no table in
front of the field. Koha need to know the table where the field come from.
(Sorry for my english :))

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-03-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-03-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-03-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

--- Comment #81 from Marcel de Rooy  ---
See two things so far:

[1] Regex for field does not work:
$field =~ s/[^\.]*\.?//; # Remove the table name if exists.
Does not work well if there is no table in front.
Try this:
$field="title";
print "$field\n";
$field =~ s/[^\.]*\.?//; # Remove the table name if exists.
print "$field\n";

[2] Regex for header and fieldname makes header no longer optional.
while ( $csv_profile_content =~ /
([^=]+) # header
=
([^\|]+) # fieldname (table.row or row)
\|? /gxms
) {
But if I understand correctly from this feature, the header should be optional.
=== Quote
You have to define which fields you want to export, separated by pipes.
You can also use your own headers (instead of the ones from Koha) by prefixing
the field name with an header, followed by the equal sign.
===
If I remove the headers now, I will have an empty csv file.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-03-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

--- Comment #80 from Marcel de Rooy  ---
Created attachment 61520
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61520=edit
Bug 8612: [QA Follow-up] Just a cosmetic space

Could not resist to add it :)

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-03-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

--- Comment #79 from Marcel de Rooy  ---
QA: Looking here now

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-03-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

--- Comment #77 from Josef Moravec  ---
Created attachment 61405
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61405=edit
Bug 8612 - QA followup, fix kohastructure.sql, fix typo in template

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-03-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #76 from Marcel de Rooy  ---
used_for => 'export_records'
BUT in kohastructure: `usage` varchar(255) DEFAULT 'export_records'
You have to choose ;)

Typo:  [% ELSE %] Uknown type

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-03-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Josef Moravec  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #75 from Josef Moravec  ---
(In reply to Marcel de Rooy from comment #70)
> (In reply to Jonathan Druart from comment #69)
> > I have the feeling that there is a design issue. I'd have let the type="sql"
> > but add another DB field ('usage' or similar) to identify how the profile
> > can be used.
> 
> I agree with Jonathan.
> Although I acknowledge that this patch already has quite a history already.
> 
> Export format is the name of the table for the CSV profiles (this is already
> confusing btw). Actually, csv profiles would be a better name. 
> The column type should be either marc or sql: we refer to marc fields or
> database columns.
> But yes, we need an additional column where to use which profile. Probably
> we can start here with the simple list we have now. Could be expanded later..
> 
> About t/db_dependent/Acquisition/GetBasketAsCSV.t:
> Remove the dbh statements. You do not need them. You use schema txn..
> You pass a new CGI object in your test. You probably can; just wondering if
> you should mock C4::Languages::getlanguage and not use CGI here.
> Typo defautl

So, I rebased the patch on top of current master and added some followups.

Changes made - 
 - revert the changes in csv profile types so there are again only two - marc
and sql
 - added new db column used_for, which should say where the profile could be
used
  - fix typo and remove dbh from test GetBasketAsCSV.t

How do you think the mocked getlanguage could be used? The soubroutine
GetBasketAsCSV does need the CGI object as a param...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-03-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

--- Comment #74 from Josef Moravec  ---
Created attachment 61267
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61267=edit
Bug 8612: QA followup - update dbix schema

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-03-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

--- Comment #73 from Josef Moravec  ---
Created attachment 61266
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61266=edit
Bug 8612: QA followup - make usage and type different columns in db

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-03-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

--- Comment #72 from Josef Moravec  ---
Created attachment 61265
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61265=edit
Bug 8612: QA-followup - Fix test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-03-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Josef Moravec  changed:

   What|Removed |Added

  Attachment #60480|0   |1
is obsolete||

--- Comment #71 from Josef Moravec  ---
Created attachment 61264
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61264=edit
Bug 8612: Use CSV profile for exporting basket

This patch allows the user to use a CSV export profile to create the fields to
export the basket as CSV in a basket page.

Test plan:
1) Apply the patch
2) Go to Tools › CSV export profiles and create a profile of type "SQL for
basket export in acquisition"
  example:
 
biblionumber=biblio.biblionumber|auteur=biblio.author|titre=biblio.title|date=biblioitems.copyrightdate|editeur=biblioitems.publishercode|isbn=biblioitems.isbn|quantite=aqorders.quantity|prix=aqorders.rrp|panier=aqorders.basketno
3) In acquisition module, create a new basket and add an order to the basket
4) On basket detail page, there should be the split button labelled "Export to
CSV"
5) Try to use the button and export CSV with your CSV profile you defined in
step 2
6) Validate the CSV file.
7) Repeat 4-6 with a closed basket.
a) close the basket
b) View the basket
c) validate that there is an export button
d) test it with an export
8) prove t/db_dependent/Acquisition/GetBasketAsCSV.t
t/db_dependent/Koha/CsvProfiles.t

Initial work:

Sponsored by: CCSR

Signed-off-by: Josef Moravec 
Signed-off-by: mehdi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-02-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||m.de.r...@rijksmuseum.nl

--- Comment #70 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #69)
> I have the feeling that there is a design issue. I'd have let the type="sql"
> but add another DB field ('usage' or similar) to identify how the profile
> can be used.

I agree with Jonathan.
Although I acknowledge that this patch already has quite a history already.

Export format is the name of the table for the CSV profiles (this is already
confusing btw). Actually, csv profiles would be a better name. 
The column type should be either marc or sql: we refer to marc fields or
database columns.
But yes, we need an additional column where to use which profile. Probably we
can start here with the simple list we have now. Could be expanded later..

About t/db_dependent/Acquisition/GetBasketAsCSV.t:
Remove the dbh statements. You do not need them. You use schema txn..
You pass a new CGI object in your test. You probably can; just wondering if you
should mock C4::Languages::getlanguage and not use CGI here.
Typo defautl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-02-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

--- Comment #69 from Jonathan Druart  
---
I have the feeling that there is a design issue. I'd have let the type="sql"
but add another DB field ('usage' or similar) to identify how the profile can
be used.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-02-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Mehdi Hamidi  changed:

   What|Removed |Added

 CC||mehdi.ham...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-02-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Mehdi Hamidi  changed:

   What|Removed |Added

  Attachment #59757|0   |1
is obsolete||

--- Comment #68 from Mehdi Hamidi  ---
Created attachment 60480
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60480=edit
Bug 8612: Use CSV profile for exporting basket

This patch allows the user to use a CSV export profile to create the fields to
export the basket as CSV in a basket page.

Test plan:
1) Apply the patch
2) Go to Tools › CSV export profiles and create a profile of type "SQL for
basket export in acquisition"
  example:
 
biblionumber=biblio.biblionumber|auteur=biblio.author|titre=biblio.title|date=biblioitems.copyrightdate|editeur=biblioitems.publishercode|isbn=biblioitems.isbn|quantite=aqorders.quantity|prix=aqorders.rrp|panier=aqorders.basketno
3) In acquisition module, create a new basket and add an order to the basket
4) On basket detail page, there should be the split button labelled "Export to
CSV"
5) Try to use the button and export CSV with your CSV profile you defined in
step 2
6) Validate the CSV file.
7) Repeat 4-6 with a closed basket.
a) close the basket
b) View the basket
c) validate that there is an export button
d) test it with an export
8) prove t/db_dependent/Acquisition/GetBasketAsCSV.t
t/db_dependent/Koha/CsvProfiles.t

Initial work:

Sponsored by: CCSR

Signed-off-by: Josef Moravec 
Signed-off-by: mehdi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-02-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Mehdi Hamidi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

--- Comment #67 from Josef Moravec  ---
(In reply to Blou from comment #65)
> Josef,
> I'd be happy to have someone in our team test and sign this, but right now I
> get a 
> Applying: Bug 8612 - Followup - use Koha::CsvProfile[s] module (see bug
> 15451)
> fatal: sha1 information is lacking or useless (C4/Acquisition.pm).
> 
> Damn sha1...
> Making one big patch out of it would probably limit future rebases, btw,
> since a lot of these do-undo-redo the same code...
> 
> Reminder for the initial work:
> 
> 
> Sponsored by : CCSR
> 

I squashed the patches.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Josef Moravec  changed:

   What|Removed |Added

  Attachment #58985|0   |1
is obsolete||
  Attachment #58986|0   |1
is obsolete||
  Attachment #58987|0   |1
is obsolete||
  Attachment #58988|0   |1
is obsolete||
  Attachment #58989|0   |1
is obsolete||
  Attachment #58990|0   |1
is obsolete||
  Attachment #58991|0   |1
is obsolete||
  Attachment #58992|0   |1
is obsolete||

--- Comment #66 from Josef Moravec  ---
Created attachment 59757
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59757=edit
Bug 8612: Use CSV profile for exporting basket

This patch allows the user to use a CSV export profile to create the fields to
export the basket as CSV in a basket page.

Test plan:
1) Apply the patch
2) Go to Tools › CSV export profiles and create a profile of type "SQL for
basket export in acquisition"
  example:
 
biblionumber=biblio.biblionumber|auteur=biblio.author|titre=biblio.title|date=biblioitems.copyrightdate|editeur=biblioitems.publishercode|isbn=biblioitems.isbn|quantite=aqorders.quantity|prix=aqorders.rrp|panier=aqorders.basketno
3) In acquisition module, create a new basket and add an order to the basket
4) On basket detail page, there should be the split button labelled "Export to
CSV"
5) Try to use the button and export CSV with your CSV profile you defined in
step 2
6) Validate the CSV file.
7) Repeat 4-6 with a closed basket.
a) close the basket
b) View the basket
c) validate that there is an export button
d) test it with an export
8) prove t/db_dependent/Acquisition/GetBasketAsCSV.t
t/db_dependent/Koha/CsvProfiles.t

Initial work:

Sponsored by: CCSR

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-01-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-01-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

--- Comment #65 from Blou  ---
Josef,
I'd be happy to have someone in our team test and sign this, but right now I
get a 
Applying: Bug 8612 - Followup - use Koha::CsvProfile[s] module (see bug 15451)
fatal: sha1 information is lacking or useless (C4/Acquisition.pm).

Damn sha1...
Making one big patch out of it would probably limit future rebases, btw, since
a lot of these do-undo-redo the same code...

Reminder for the initial work:


Sponsored by : CCSR


-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-01-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Josef Moravec  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

--- Comment #64 from Josef Moravec  ---
Rebased on master, added another followup. Asking for new sign off - too many
followups and conflicts with new work pushed to master. Also note, that the
test plan should be amended. 

New test plan:

1) Apply the patches
2) Go to Tools › CSV export profiles and create a profile of type "SQL for
basket export in acquisition"
  example:
biblionumber=biblio.biblionumber|auteur=biblio.author|titre=biblio.title|date=biblioitems.copyrightdate|editeur=biblioitems.publishercode|isbn=biblioitems.isbn|quantite=aqorders.quantity|prix=aqorders.rrp|panier=aqorders.basketno
3) In acquisition module, create a new basket and add an order to the basket
4) On basket detail page, there should be the split button labelled "Export to
CSV"
5) Try to use the button and export CSV with your CSV profile you defined in
step 2
6) Validate the CSV file.
7) Repeat 4-6 with a closed basket.
 a) close the basket
 b) View the basket
 c) validate that there is an export button
 d) test it with an export
8) prove t/db_dependent/Acquisition/GetBasketAsCSV.t
t/db_dependent/Koha/CsvProfiles.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-01-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

--- Comment #63 from Josef Moravec  ---
Created attachment 58992
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58992=edit
Bug 8612: Fix test due to bug 13726

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-01-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Josef Moravec  changed:

   What|Removed |Added

  Attachment #58078|0   |1
is obsolete||

--- Comment #61 from Josef Moravec  ---
Created attachment 58990
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58990=edit
Bug 8612: Add tests for GetBasketAsCSV

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-01-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Josef Moravec  changed:

   What|Removed |Added

  Attachment #58076|0   |1
is obsolete||

--- Comment #59 from Josef Moravec  ---
Created attachment 58988
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58988=edit
Bug 8612 - Followup - use Koha::CsvProfile[s] module (see bug 15451)

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-01-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Josef Moravec  changed:

   What|Removed |Added

  Attachment #58079|0   |1
is obsolete||

--- Comment #62 from Josef Moravec  ---
Created attachment 58991
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58991=edit
Bug 8612: QA follow-up - distinguish between late issues and basket export csv
profiles

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-01-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Josef Moravec  changed:

   What|Removed |Added

  Attachment #58077|0   |1
is obsolete||

--- Comment #60 from Josef Moravec  ---
Created attachment 58989
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58989=edit
Bug 8612: QA followup - Make export button split button, unify button labels

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-01-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Josef Moravec  changed:

   What|Removed |Added

  Attachment #58075|0   |1
is obsolete||

--- Comment #58 from Josef Moravec  ---
Created attachment 58987
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58987=edit
Bug 8612 - Clean basket.pl getting rid of subroutines with sql query and use
GetBasketAsCSV instead

GetBasketAsCSV now has a new argument the profile_csv_id, when this param is
defined, it loads the profile_content, searches the value of the predefined
fields and assembles the data to create the output of the csv file.

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-01-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Josef Moravec  changed:

   What|Removed |Added

  Attachment #58073|0   |1
is obsolete||

--- Comment #56 from Josef Moravec  ---
Created attachment 58985
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58985=edit
Bug 8612 - System preference to have custom fields in export csv basket

This patch allows the user use a CSV export profile to create the fields to
export the basket as CSV in a basket page.

To test:

1) Apply the patch;
2) Create a CSV export profile - type sql -  Home › Tools › CSV export profiles
  ex:
biblionumber=biblio.biblionumber|auteur=biblio.author|titre=biblio.title|date=biblioitems.copyrightdate|editeur=biblioitems.publishercode|isbn=biblioitems.isbn|quantite=aqorders.quantity|prix=aqorders.rrp|panier=aqorders.basketno
3) Create a new basket and add an order to the basket
4) Validate: the text "Select CSV profile:" and a dropdown in the basket view
5) In the new dropdown, select the CSV export profile created
6) Validate the CSV file.
7) Do the same validation with a closed basket.
 a) close the basket
 b) View the basket
 c) validate that there is a dropdown
 d) test it with an export

Signed-off-by: Josef Moravec 

Works as expected for me

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-01-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Josef Moravec  changed:

   What|Removed |Added

  Attachment #58074|0   |1
is obsolete||

--- Comment #57 from Josef Moravec  ---
Created attachment 58986
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58986=edit
Bug 8612 - Cleans basket.tt by using TT blocks

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2016-12-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

--- Comment #55 from Josef Moravec  ---
Just rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2016-12-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Josef Moravec  changed:

   What|Removed |Added

  Attachment #57079|0   |1
is obsolete||

--- Comment #54 from Josef Moravec  ---
Created attachment 58079
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58079=edit
Bug 8612: QA follow-up - distinguish between late issues and basket export csv
profiles

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2016-12-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Josef Moravec  changed:

   What|Removed |Added

  Attachment #57028|0   |1
is obsolete||

--- Comment #52 from Josef Moravec  ---
Created attachment 58077
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58077=edit
Bug 8612: QA followup - Make export button split button, unify button labels

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2016-12-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Josef Moravec  changed:

   What|Removed |Added

  Attachment #57029|0   |1
is obsolete||

--- Comment #53 from Josef Moravec  ---
Created attachment 58078
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58078=edit
Bug 8612: Add tests for GetBasketAsCSV

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2016-12-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Josef Moravec  changed:

   What|Removed |Added

  Attachment #57026|0   |1
is obsolete||

--- Comment #50 from Josef Moravec  ---
Created attachment 58075
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58075=edit
Bug 8612 - Clean basket.pl getting rid of subroutines with sql query and use
GetBasketAsCSV instead

GetBasketAsCSV now has a new argument the profile_csv_id, when this param is
defined, it loads the profile_content, searches the value of the predefined
fields and assembles the data to create the output of the csv file.

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2016-12-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Josef Moravec  changed:

   What|Removed |Added

  Attachment #57027|0   |1
is obsolete||

--- Comment #51 from Josef Moravec  ---
Created attachment 58076
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58076=edit
Bug 8612 - Followup - use Koha::CsvProfile[s] module (see bug 15451)

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2016-12-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Josef Moravec  changed:

   What|Removed |Added

  Attachment #57025|0   |1
is obsolete||

--- Comment #49 from Josef Moravec  ---
Created attachment 58074
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58074=edit
Bug 8612 - Cleans basket.tt by using TT blocks

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2016-12-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Josef Moravec  changed:

   What|Removed |Added

  Attachment #57024|0   |1
is obsolete||

--- Comment #48 from Josef Moravec  ---
Created attachment 58073
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58073=edit
Bug 8612 - System preference to have custom fields in export csv basket

This patch allows the user use a CSV export profile to create the fields to
export the basket as CSV in a basket page.

To test:

1) Apply the patch;
2) Create a CSV export profile - type sql -  Home › Tools › CSV export profiles
  ex:
biblionumber=biblio.biblionumber|auteur=biblio.author|titre=biblio.title|date=biblioitems.copyrightdate|editeur=biblioitems.publishercode|isbn=biblioitems.isbn|quantite=aqorders.quantity|prix=aqorders.rrp|panier=aqorders.basketno
3) Create a new basket and add an order to the basket
4) Validate: the text "Select CSV profile:" and a dropdown in the basket view
5) In the new dropdown, select the CSV export profile created
6) Validate the CSV file.
7) Do the same validation with a closed basket.
 a) close the basket
 b) View the basket
 c) validate that there is a dropdown
 d) test it with an export

Signed-off-by: Josef Moravec 

Works as expected for me

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Josef Moravec  changed:

   What|Removed |Added

 Depends on|15498   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498
[Bug 15498] Replace ExportWithCsvProfile with ExportCircHistory
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Josef Moravec  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #47 from Josef Moravec  ---
(In reply to Katrin Fischer from comment #45)
> 
> I'd really like a way to indicate what the CSV profile is to be used for. I
> am hesitating to pass this as is, as I think it will be harder to do this
> later on. Once the libraries have added profiles for both, there will be no
> way to assign them automatically to the correct module. If we do it now, we
> can safely assume that all SQL profiles are used for exporting late issues.
> Hope that makes sense?

It absolutely makes sense, I agree with you. I've submitted follow-up, to you
think I'm on right way, or should I take another approach to this problem?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

--- Comment #46 from Josef Moravec  ---
Created attachment 57079
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57079=edit
Bug 8612: QA follow-up - distinguish between late issues and basket export csv
profiles

tatus: Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Josef Moravec  changed:

   What|Removed |Added

 Depends on||15498


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498
[Bug 15498] Replace ExportWithCsvProfile with ExportCircHistory
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2016-11-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #45 from Katrin Fischer  ---
I really like the new split button! Tests pass.

Sorry, but noticed this now for the first time:
When you have a CSV profile defined for your late issues export, it will also
show up as export option for the CSV export in acquisitions. I think this could
get confusing as both will require different fields from the database.

I'd really like a way to indicate what the CSV profile is to be used for. I am
hesitating to pass this as is, as I think it will be harder to do this later
on. Once the libraries have added profiles for both, there will be no way to
assign them automatically to the correct module. If we do it now, we can safely
assume that all SQL profiles are used for exporting late issues. Hope that
makes sense?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2016-11-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

--- Comment #44 from Josef Moravec  ---
Sorry, rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2016-11-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Josef Moravec  changed:

   What|Removed |Added

  Attachment #56225|0   |1
is obsolete||

--- Comment #41 from Josef Moravec  ---
Created attachment 57027
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57027=edit
Bug 8612 - Followup - use Koha::CsvProfile[s] module (see bug 15451)

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2016-11-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Josef Moravec  changed:

   What|Removed |Added

  Attachment #57013|0   |1
is obsolete||

--- Comment #43 from Josef Moravec  ---
Created attachment 57029
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57029=edit
Bug 8612: Add tests for GetBasketAsCSV

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2016-11-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Josef Moravec  changed:

   What|Removed |Added

  Attachment #57012|0   |1
is obsolete||

--- Comment #42 from Josef Moravec  ---
Created attachment 57028
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57028=edit
Bug 8612: QA followup - Make export button split button, unify button labels

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 >

1 - 100 of 150 matches

Mail list logo