[Koha-bugs] [Bug 8617] Problem with display of comments waiting for moderation in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8617 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #7 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.8.x, will be in 3.8.6 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8617] Problem with display of comments waiting for moderation in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8617 Mason James m...@kohaaloha.com changed: What|Removed |Added Attachment #11647|0 |1 is obsolete|| Attachment #11720|0 |1 is obsolete|| --- Comment #4 from Mason James m...@kohaaloha.com --- Created attachment 12223 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12223action=edit Bug 8617 - Problem with display of comments waiting for moderation in OPAC This patch addresses on aspect of Bug 8617: The behavior where live previews of edited comments are displaying on opac-detail as a duplicate comment. We must pass the review id back to the script when submitting so that the check for it will evaluate as true when it should. This patch also corrects some JavaScript for translatability. To test, submit a comment on a title and approve it. Return to the title and edit the comment. When you submit your revised comment the comment pop-up window should close and your revised comment should appear on opac-detail as pending approval. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8617] Problem with display of comments waiting for moderation in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8617 Mason James m...@kohaaloha.com changed: What|Removed |Added Attachment #11720|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8617] Problem with display of comments waiting for moderation in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8617 Mason James m...@kohaaloha.com changed: What|Removed |Added Attachment #12223|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8617] Problem with display of comments waiting for moderation in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8617 Mason James m...@kohaaloha.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||m...@kohaaloha.com QA Contact||m...@kohaaloha.com --- Comment #5 from Mason James m...@kohaaloha.com --- (In reply to comment #3) Created attachment 11720 [details] [SIGNED-OFF] Bug 8617 - Problem with display of comments waiting for moderation in OPAC Works as expected. patch looks good, passing QA… $ koha-qa.pl testing 1 commit(s) (applied to commit 0acebb8) * 1834255 Bug 8617 - Problem with display of comments waiting for moderatio koha-tmpl/opac-tmpl/prog/en/modules/opac-review.tt * koha-tmpl/opac-tmpl/prog/en/modules/opac-review.tt OK -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8617] Problem with display of comments waiting for moderation in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8617 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||paul.poul...@biblibre.com Version|master |rel_3_8 --- Comment #6 from Paul Poulain paul.poul...@biblibre.com --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8617] Problem with display of comments waiting for moderation in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8617 --- Comment #3 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 11720 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11720action=edit [SIGNED-OFF] Bug 8617 - Problem with display of comments waiting for moderation in OPAC Works as expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8617] Problem with display of comments waiting for moderation in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8617 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||julian.maur...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8617] Problem with display of comments waiting for moderation in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8617 --- Comment #1 from Owen Leonard oleon...@myacpl.org --- Created attachment 11647 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11647action=edit Bug 8617 - Problem with display of comments waiting for moderation in OPAC This patch addresses on aspect of Bug 8617: The behavior where live previews of edited comments are displaying on opac-detail as a duplicate comment. We must pass the review id back to the script when submitting so that the check for it will evaluate as true when it should. This patch also corrects some JavaScript for translatability. To test, submit a comment on a title and approve it. Return to the title and edit the comment. When you submit your revised comment the comment pop-up window should close and your revised comment should appear on opac-detail as pending approval. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8617] Problem with display of comments waiting for moderation in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8617
Owen Leonard oleon...@myacpl.org changed:
What|Removed |Added
Status|NEW |Needs Signoff
--- Comment #2 from Owen Leonard oleon...@myacpl.org ---
The reason new and edited comments disappear when you refresh the page is that
the only reason they appear on the page in the first place is because they're
added by JavaScript when you submit them.
I don't see any reason not to display unapproved comments by the logged-in
user. I suppose it means adding an optional borrowernumber parameter to
getallreviews so that we can ask for comments where approved = 1 OR
borrowernumber = {borrowernumber}
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
