[Koha-bugs] [Bug 8645] Fix background-job-progressbar.js for translations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8645

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8645] Fix background-job-progressbar.js for translations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8645

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 CC||bgkrie...@gmail.com

--- Comment #11 from Bernardo Gonzalez Kriegel  ---
(In reply to Katrin Fischer from comment #10)
> Still valid.
> 

The file and the string are no more present, I think this is now invalid

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8645] Fix background-job-progressbar.js for translations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8645

Owen Leonard  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=23753

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8645] Fix background-job-progressbar.js for translations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8645

Jonathan Druart  changed:

   What|Removed |Added

   Severity|normal  |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8645] Fix background-job-progressbar.js for translations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8645

Katrin Fischer  changed:

   What|Removed |Added

 CC||frede...@tamil.fr,
   ||katrin.fisc...@bsz-bw.de
  Component|Tools   |I18N/L10N
 Status|ASSIGNED|NEW
   Assignee|pelletiermax...@gmail.com   |koha-b...@lists.koha-commun
   ||ity.org

--- Comment #10 from Katrin Fischer  ---
(In reply to Owen Leonard from comment #9)
> (In reply to Marc Véron from comment #8)
> > Still valid?
> 
> Yes. There is still one English string in background-job-progressbar.js at
> line 72:
> 
>   alert('Failed to submit form: ' + textStatus);

Still valid.

Resetting assignee (last comment was 2016)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8645] Fix background-job-progressbar.js for translations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8645

--- Comment #9 from Owen Leonard  ---
(In reply to Marc Véron from comment #8)
> Still valid?

Yes. There is still one English string in background-job-progressbar.js at line
72:

  alert('Failed to submit form: ' + textStatus);

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8645] Fix background-job-progressbar.js for translations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8645

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #8 from Marc Véron  ---
Still valid?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8645] Fix background-job-progressbar.js for translations

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8645

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com ---
Hi Maxime,

This patch does not work for me. I think the .js files are not translatable.
Could someone confirm that ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8645] Fix background-job-progressbar.js for translations

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8645

Maxime Pelletier pelletiermax...@gmail.com changed:

   What|Removed |Added

 Status|Signed Off  |ASSIGNED

--- Comment #5 from Maxime Pelletier pelletiermax...@gmail.com ---
(In reply to comment #4)
 Hi Maxime,
 
 This patch does not work for me. I think the .js files are not translatable.
 Could someone confirm that ?

Well, damn. Forgot to add a _() in the patch to allow to be translatable. Will
upload a new patch in a few hours.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8645] Fix background-job-progressbar.js for translations

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8645

--- Comment #6 from Owen Leonard oleon...@myacpl.org ---
Is that what this patch is supposed to enable? JavaScript files are not
translatable. Translatable strings should be moved to the template:
http://wiki.koha-community.org/wiki/Coding_Guidelines#Enabling_translation_of_language_strings_in_linked_JavaScript

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8645] Fix background-job-progressbar.js for translations

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8645

--- Comment #7 from Maxime Pelletier pelletiermax...@gmail.com ---
Arg. Yeah... the code was in an .inc file in 3.6 and I just merged my code in
the .js without thinking about it.
I will try to fix it to make it translatable in a template.
Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8645] Fix background-job-progressbar.js for translations

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8645

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

  Attachment #11623|0   |1
is obsolete||

--- Comment #2 from Owen Leonard oleon...@myacpl.org ---
Created attachment 11627
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11627action=edit
[SIGNED-OFF] Bug 8645 - Fix background-job-progressbar.js for translations

Respect coding guidelines for translations in javascript by replacing ' by .
Fixes the page for the french translation (that contains a ').
Sponsored by the CCSR.

http://bugs.koha-community.org/show_bug.cgi?id=8645
Signed-off-by: Owen Leonard oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8645] Fix background-job-progressbar.js for translations

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8645

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Assignee|gmcha...@gmail.com  |pelletiermax...@gmail.com

--- Comment #3 from Owen Leonard oleon...@myacpl.org ---
This patch clearly does no harm, so I will trust that it does good. Signed off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8645] Fix background-job-progressbar.js for translations

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8645

--- Comment #1 from Maxime Pelletier pelletiermax...@gmail.com ---
Created attachment 11623
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11623action=edit
Small patch to fix

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8645] Fix background-job-progressbar.js for translations

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8645

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
 CC||ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/