[Koha-bugs] [Bug 8652] There is no default value for the late orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8652 Paul Poulain changed: What|Removed |Added Status|Passed QA |Pushed to Master Version|unspecified |rel_3_10 --- Comment #11 from Paul Poulain --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8652] There is no default value for the late orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8652 Paul Poulain changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #10 from Paul Poulain --- QA comment: * both patches passes koha-qa.pl * 1st patch has a negligible side-effect risk, 2nd patch has a larger one * investigating patch 2 more deeply: - a new possible parameter is added to output_pref signature. Depending on it, the return is as previously, or with more information - for all calls to this sub, there is no change in the returned result - checking t/DateUtils.t = still OK after the test - however, it would be worth to have a test for this new parameter. I've added a small follow-up, that add 3 tests to t/DateUtils.t passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8652] There is no default value for the late orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8652 Paul Poulain changed: What|Removed |Added Attachment #12160|0 |1 is obsolete|| --- Comment #9 from Paul Poulain --- Comment on attachment 12160 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12160 Bug 8652: Followup: add a default value for date_from obsoleted by signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8652] There is no default value for the late orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8652 --- Comment #8 from Paul Poulain --- Created attachment 12312 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12312&action=edit Bug 8652: Followup: add a default value for date_from This patchis add a third parameter to the output_pref routine. It allows to specify the output string with or without the hours and minutes (%H:%M) Signed-off-by: MathildeF -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8652] There is no default value for the late orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8652 Paul Poulain changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||paul.poul...@biblibre.com --- Comment #7 from Paul Poulain --- Patch tested with a sandbox, by MathildeF -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8652] There is no default value for the late orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8652 --- Comment #6 from Jonathan Druart --- Created attachment 12160 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12160&action=edit Bug 8652: Followup: add a default value for date_from (In reply to comment #5) > I took the liberty of amending the Koha::DateUtils calls. I'm sure the logic > could be further cleaned up. Requires testing Thanks Colin. This followup adds a parameter for the output_pref routine and reintroduces the default value for date_from if no other one is present. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8652] There is no default value for the late orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8652 Colin Campbell changed: What|Removed |Added Attachment #11640|0 |1 is obsolete|| --- Comment #5 from Colin Campbell --- Created attachment 12142 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12142&action=edit Proposed Amended Patch I took the liberty of amending the Koha::DateUtils calls. I'm sure the logic could be further cleaned up. Requires testing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8652] There is no default value for the late orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8652 Colin Campbell changed: What|Removed |Added CC||colin.campbell@ptfs-europe. ||com --- Comment #4 from Colin Campbell --- The date handling is wrong. dt_from_string returns a DateTime object. there is no need for the xxx_iso variables. if you need the date as a string in iso format you can retrieve that using DateTime's methods -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8652] There is no default value for the late orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8652 MathildeF changed: What|Removed |Added CC||mathilde.formery@ville-nime ||s.fr --- Comment #3 from MathildeF --- tested in a sandbox When I add a date in the field "Date from", I have an error message: Software error: Can not call method "strftime" without a package or object reference at / home / koha / src / Koha / DateUtils.pm line 119. " -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8652] There is no default value for the late orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8652 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #2 from Jonathan Druart --- The date manipulations is a little bit (very ?) dirty. If someone can do that with another way, he's welcome :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8652] There is no default value for the late orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8652 --- Comment #1 from Jonathan Druart --- Created attachment 11640 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11640&action=edit BUG 8652: Add a default value for the lateorders - By default, the date from value is the today's date - Replace C4::Dates with Koha::DateUtils To test: Check the page displays the late orders by default. Add values for 'date from' and/or 'date to' and/or delay. The date interval is based on the estimated delivery date and the delay param is based on the closed date. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8652] There is no default value for the late orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8652 Jonathan Druart changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
