[Koha-bugs] [Bug 8705] Software error on help of main page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8705 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #13 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.8.x, will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8705] Software error on help of main page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8705 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||paul.poul...@biblibre.com Version|master |rel_3_8 --- Comment #12 from Paul Poulain paul.poul...@biblibre.com --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8705] Software error on help of main page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8705 Mason James m...@kohaaloha.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||m...@kohaaloha.com QA Contact||m...@kohaaloha.com --- Comment #11 from Mason James m...@kohaaloha.com --- Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com patch looks good, passing QA… $ koha-qa.pl testing 1 commit(s) (applied to commit 0acebb8) * 6980862 Bug 8705: Software error on help of main page help.pl * help.pl OK -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8705] Software error on help of main page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8705 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #11924|0 |1 is obsolete|| --- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 11944 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11944action=edit Bug 8705: Software error on help of main page Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8705] Software error on help of main page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8705 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #10 from Jonathan Druart jonathan.dru...@biblibre.com --- It's ok for me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8705] Software error on help of main page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8705 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- Hum... Ok it is a simple patch and currently, it works. But if someone adds a test before, this one will not save. I can't explain that... an example will be more meaningful: my $s = aaa; $s =~ m/a(.)a/; say $1; = display a But! my $s = aaa; $s =~ m/a(.)a/; say $1; $s =~ m/b(.)b/; say $1 = display a x 2 $1 is defined in the second case. We have to test with a if when we want used $1 I don't mark it as Failed QA because this patch does not introduce this, but a followup is highly welcomed :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8705] Software error on help of main page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8705 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Attachment #11899|0 |1 is obsolete|| --- Comment #5 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 11921 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11921action=edit Proposed patch (revised) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8705] Software error on help of main page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8705 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|Signed Off |Needs Signoff --- Comment #6 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- (In reply to comment #4) I understand, $1 should only be used if pattern matches. I revised patch to wrap help template from URL behavior into a sub. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8705] Software error on help of main page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8705 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com --- Sorry but critic FAIL Subroutine prototypes used at line 28, column 1. See page 194 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8705] Software error on help of main page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8705 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Attachment #11921|0 |1 is obsolete|| --- Comment #8 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 11924 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11924action=edit Proposed patch (revised 2) Is this better ? Can you say more about it ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8705] Software error on help of main page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8705 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|gmcha...@gmail.com |fridolyn.som...@biblibre.co ||m --- Comment #1 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 11898 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11898action=edit Proposed patch Very small patch. When help page is not found from URL, display mainpage help. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8705] Software error on help of main page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8705 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added CC||neng...@gmail.com --- Comment #2 from Owen Leonard oleon...@myacpl.org --- *** Bug 7623 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8705] Software error on help of main page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8705 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #11898|0 |1 is obsolete|| --- Comment #3 from Owen Leonard oleon...@myacpl.org --- Created attachment 11899 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11899action=edit [SIGNED-OFF] Bug 8705: Software error on help of main page Signed-off-by: Owen Leonard oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8705] Software error on help of main page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8705 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
