[Koha-bugs] [Bug 8714] Poorly ordered and triggers warning in marctagstructure.pl

2012-09-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8714

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||ch...@bigballofwax.co.nz

--- Comment #5 from Chris Cormack ch...@bigballofwax.co.nz ---
Pushed to 3.8.x, will be in 3.8.5

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8714] Poorly ordered and triggers warning in marctagstructure.pl

2012-09-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8714

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||paul.poul...@biblibre.com
Version|unspecified |rel_3_8

--- Comment #4 from Paul Poulain paul.poul...@biblibre.com ---
Patch pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8714] Poorly ordered and triggers warning in marctagstructure.pl

2012-09-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8714

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||m...@kohaaloha.com
 QA Contact||m...@kohaaloha.com

--- Comment #3 from Mason James m...@kohaaloha.com ---
 Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

patch looks good, passing QA…

$ koha-qa.pl 

testing 1 commit(s) (applied to commit 0acebb8)
 * 146447b Bug 8714 - Poorly ordered and triggers warning in marctagstructur
  admin/marctagstructure.pl

* admin/marctagstructure.plOK

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8714] Poorly ordered and triggers warning in marctagstructure.pl

2012-09-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8714

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 QA Contact||mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8714] Poorly ordered and triggers warning in marctagstructure.pl

2012-09-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8714

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |mtomp...@hotmail.com
   |ity.org |
 QA Contact|mtomp...@hotmail.com|

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8714] Poorly ordered and triggers warning in marctagstructure.pl

2012-09-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8714

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #11942|0   |1
is obsolete||

--- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 11953
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11953action=edit
Bug 8714 - Poorly ordered and triggers warning in marctagstructure.pl

An array boundary check was after a comparison using the array.
By changing the logic which had  and ( $j  $cnt) to be at the
beginning ( $j  $cnt ) and , the warning is no longer shown
in the error log.

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8714] Poorly ordered and triggers warning in marctagstructure.pl

2012-09-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8714

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||jonathan.dru...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8714] Poorly ordered and triggers warning in marctagstructure.pl

2012-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8714

--- Comment #1 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 11942
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11942action=edit
Changed and statement to have boundary check first.

This is one of those strange bugs where the line number for the error number is
not where the error is. Fixing the condition in the while loop fixes the
warning generated by the test plan already posted on this bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8714] Poorly ordered and triggers warning in marctagstructure.pl

2012-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8714

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/