[Koha-bugs] [Bug 8765] Add series title to intranet search results (non XSLT)

2012-11-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8765

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED
Summary|Add series title to |Add series title to
   |intranet search results |intranet search results
   ||(non XSLT)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8765] Add series title to intranet search results

2012-09-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8765

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #7 from Chris Cormack ch...@bigballofwax.co.nz ---
Pushed to 3.8.x, will be in 3.8.5

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8765] Add series title to intranet search results

2012-09-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8765

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||paul.poul...@biblibre.com
Version|master  |rel_3_8

--- Comment #5 from Paul Poulain paul.poul...@biblibre.com ---
Patch pushed to master. Note I replaced tab by 4 spaces before pushing. Please
don't use tabs, use 4 spaces instead (see coding guidelines)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8765] Add series title to intranet search results

2012-09-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8765

--- Comment #6 from David Cook dc...@prosentient.com.au ---
(In reply to comment #5)
 Patch pushed to master. Note I replaced tab by 4 spaces before pushing.
 Please don't use tabs, use 4 spaces instead (see coding guidelines)

Thanks for the reminder, Paul. I've started using another editor and I thought
that I had it switched to spaces, but now I see the error. Future patches
should be tab free :).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8765] Add series title to intranet search results

2012-09-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8765

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

  Attachment #12180|0   |1
is obsolete||

--- Comment #2 from Owen Leonard oleon...@myacpl.org ---
Created attachment 12225
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12225action=edit
[SIGNED-OFF] Bug 8765 - Add series title to intranet search results

Patch adds series title to intranet search results, so that the
series volume is no longer displayed on its own.

It also removes the comma that comes before the series volume as
this is unnecessary punctuation that creates duplicate punctuation
in search results.

Signed-off-by: Owen Leonard oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8765] Add series title to intranet search results

2012-09-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8765

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #3 from Owen Leonard oleon...@myacpl.org ---
It's worth noting that this patch is for the normal display and enables the
display of whatever series title has been put into biblio.seriestitle, and Koha
to MARC mapping limits this to a one-to-one relationship. If you've chosen to
map 440, you won't see 490.

The XSLT results page doesn't appear to have any series handling at all.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8765] Add series title to intranet search results

2012-09-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8765

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||m...@kohaaloha.com
 QA Contact||m...@kohaaloha.com

--- Comment #4 from Mason James m...@kohaaloha.com ---
(In reply to comment #2)
 Created attachment 12225 [details]
 [SIGNED-OFF] Bug 8765 - Add series title to intranet search results
 Signed-off-by: Owen Leonard oleon...@myacpl.org

patch looks good, passing QA…

$ koha-qa.pl 

testing 1 commit(s) (applied to commit 0acebb8)
 * d2ac32b Bug 8765 - Add series title to intranet search results
  koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt

* koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt OK

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8765] Add series title to intranet search results

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8765

David Cook dc...@prosentient.com.au changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|oleon...@myacpl.org |dc...@prosentient.com.au

--- Comment #1 from David Cook dc...@prosentient.com.au ---
Created attachment 12180
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12180action=edit
Bug 8765 - Add series title to intranet search results

I suppose this could be referred to as an enhancement, but it seems more like a
bug to have the series volume but not the series title. 

If we don't want to include the series title in the intranet search results
(after all, it's not included in the opac search results), I would propose
removing the series volume from the intranet search results, as it is
essentially meaningless without the context of the series title.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/