[Koha-bugs] [Bug 8782] Close a subscription
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8782 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #12909|0 |1 is obsolete|| --- Comment #10 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 12930 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12930action=edit [SIGNED-OFF] Bug 8782: Close a subscription If a subscription is no longer enough published (or we are not waiting for a new periodical) we are allowed to close it. If a subscription is closed, we are not able to receive or generate a new serial. On the serial module, we can now - close a subscriptionn - reopen a closed subscription On serial search 2 tabs is displayed (opened and closed subscriptions). This patch adds: - a new field subscription.closed in DB - a new status for serials (8 = stopped) Test plan: - search subscriptions - close a subscription and check that you cannot receive or generate a new serial - launch another search and check that the closed serial is into the closed tab. - You are allowed to reopen a subscription on the subscription detail page and on the subscription result page. A javascript alert ask you if are certain to do this operation. - Check the serial status stopped everywhere the status is displayed (catalogue/detail.pl, serials/claims.pl, serials/serial-issues-full.pl, serials/serials-collection.pl, serials/serials-edit.pl, serials/serials-recieve.pl, serials/subscription-detail.pl and opac-full-serial-issues.pl) - The report statistics does not include the closed subscriptions if you don't check the Include expired subscriptions checkbox. Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8782] Close a subscription
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8782 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #12910|0 |1 is obsolete|| --- Comment #11 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 12931 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12931action=edit [SIGNED-OFF] Bug 8782: Followup: add some minor modifications - Show 'closed' information in biblio detail page - Add a column in serials report table - Search subscriptions on title words instead of string - Prevent serials editing when subscription is closed - Don't change status of disabled serials Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8782] Close a subscription
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8782 --- Comment #12 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 12932 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12932action=edit Bug 8782 - Close a subscription - Followup - Fix updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8782] Close a subscription
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8782 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #13 from Kyle M Hall k...@bywatersolutions.com --- Everything looks good except for updatedatabase. If get the following error: Undefined subroutine main::column_exists called at installer/data/mysql/updatedatabase.pl line 6016. I've added a patch to remove this code. Even without it, should this query be executed it should fail gracefully. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8782] Close a subscription
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8782 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #12932|0 |1 is obsolete|| --- Comment #14 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 12933 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12933action=edit Bug 8782 - Close a subscription - Followup - Fix updatedatabase.pl Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8782] Close a subscription
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8782 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #15 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to comment #13) I've added a patch to remove this code. Even without it, should this query be executed it should fail gracefully. Thank you Kyle for your test and your followup ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8782] Close a subscription
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8782 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #12305|0 |1 is obsolete|| Attachment #12879|0 |1 is obsolete|| --- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 12909 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12909action=edit Bug 8782: Close a subscription If a subscription is no longer enough published (or we are not waiting for a new periodical) we are allowed to close it. If a subscription is closed, we are not able to receive or generate a new serial. On the serial module, we can now - close a subscriptionn - reopen a closed subscription On serial search 2 tabs is displayed (opened and closed subscriptions). This patch adds: - a new field subscription.closed in DB - a new status for serials (8 = stopped) Test plan: - search subscriptions - close a subscription and check that you cannot receive or generate a new serial - launch another search and check that the closed serial is into the closed tab. - You are allowed to reopen a subscription on the subscription detail page and on the subscription result page. A javascript alert ask you if are certain to do this operation. - Check the serial status stopped everywhere the status is displayed (catalogue/detail.pl, serials/claims.pl, serials/serial-issues-full.pl, serials/serials-collection.pl, serials/serials-edit.pl, serials/serials-recieve.pl, serials/subscription-detail.pl and opac-full-serial-issues.pl) - The report statistics does not include the closed subscriptions if you don't check the Include expired subscriptions checkbox. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8782] Close a subscription
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8782 --- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 12910 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12910action=edit Bug 8782: Followup: add some minor modifications - Show 'closed' information in biblio detail page - Add a column in serials report table - Search subscriptions on title words instead of string - Prevent serials editing when subscription is closed - Don't change status of disabled serials -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8782] Close a subscription
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8782 --- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 12879 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12879action=edit Bug 8782: Followup: add some minor modifications - Show 'closed' information in biblio detail page - Add a column in serials report table - Search subscriptions on title words instead of string - Prevent serials editing when subscription is closed - Don't change status of disabled serials -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8782] Close a subscription
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8782 --- Comment #7 from David Cook dc...@prosentient.com.au --- Hi Jonathan: I just tried applying your patch against master with git bz, but it looks like it needs a rebase: Applying: Bug 8782: Close a subscription error: patch failed: installer/data/mysql/updatedatabase.pl:5795 error: installer/data/mysql/updatedatabase.pl: patch does not apply error: patch failed: koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt:189 error: koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt: patch does not apply error: patch failed: koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt:33 error: koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt: patch does not apply Patch failed at 0001 Bug 8782: Close a subscription Looking forward to testing this one out though! (In reply to comment #5) (In reply to comment #4) I'd like to start testing and signing off on larger patches, but I want to make sure that I'm doing a thorough enough job. Hi David! The patch is large but there is no complex code. There are a lot of template modifications and a new status for serials. I think if 1/ you agree with this new status 2/ you don't find any regression in the serials module pages 3/ the feature works as expected 4/ you don't have any question You can sign off this patch :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8782] Close a subscription
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8782 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Summary|Close a suscription |Close a subscription -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
