[Koha-bugs] [Bug 8782] Close a suscription
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8782 --- Comment #5 from Jonathan Druart --- (In reply to comment #4) > I'd like to start testing and signing off on larger patches, but I want to > make sure that I'm doing a thorough enough job. Hi David! The patch is large but there is no complex code. There are a lot of template modifications and a new status for serials. I think if 1/ you agree with this new status 2/ you don't find any regression in the serials module pages 3/ the feature works as expected 4/ you don't have any question You can sign off this patch :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8782] Close a suscription
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8782 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #4 from David Cook --- I'm glad to see this enhancement! This issue came up with a client back when I first started using Koha, so it's nice to see a fix for what was one of my first issues! The patch seems rather large though, so I'm not completely sure how to even start testing to see if it breaks anything. Knowing Jonathan's work, I'm sure that the patch does what it describes (yay), but what's the best way of testing if it breaks something else? Unit tests? Are the following tests enough? prove t/ prove t/db_dependent prove xt/ prove xt/author Thoughts? I'd like to start testing and signing off on larger patches, but I want to make sure that I'm doing a thorough enough job. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8782] Close a suscription
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8782 --- Comment #3 from Jonathan Druart --- (In reply to comment #2) > Hi Jonathan, > > thank you for providing the description. I was wondering about the new > status "stopped". I was thinking that closig a subscription would happen on > subscription level. In which circumstances would I mark an issue as > "stopped"? Or did I misunderstand the new status? An issue could not be marked as 'stopped'. This status is not writable/settable. The only way to have a status=8 (for serials.status) is to close the subscription and to have a serial expected. If the subscription is closed, the serial cannot be expected. I don't know if I'm clear :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8782] Close a suscription
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8782 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #2 from Katrin Fischer --- Hi Jonathan, thank you for providing the description. I was wondering about the new status "stopped". I was thinking that closig a subscription would happen on subscription level. In which circumstances would I mark an issue as "stopped"? Or did I misunderstand the new status? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8782] Close a suscription
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8782 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8782] Close a suscription
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8782 --- Comment #1 from Jonathan Druart --- Created attachment 12305 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12305&action=edit Bug 8782: Close a subscription If a subscription is no longer enough published (or we are not waiting for a new periodical) we are allowed to close it. If a subscription is closed, we are not able to receive or generate a new serial. On the serial module, we can now - close a subscriptionn - reopen a closed subscription On serial search 2 tabs is displayed (opened and closed subscriptions). This patch adds: - a new field subscription.closed in DB - a new status for serials (8 = stopped) Test plan: - search subscriptions - close a subscription and check that you cannot receive or generate a new serial - launch another search and check that the closed serial is into the "closed" tab. - You are allowed to reopen a subscription on the subscription detail page and on the subscription result page. A javascript alert ask you if are certain to do this operation. - Check the serial status "stopped" everywhere the status is displayed (catalogue/detail.pl, serials/claims.pl, serials/serial-issues-full.pl, serials/serials-collection.pl, serials/serials-edit.pl, serials/serials-recieve.pl, serials/subscription-detail.pl and opac-full-serial-issues.pl) - The report statistics does not include the closed subscriptions if you don't check the "Include expired subscriptions" checkbox. /!\ This patch is based onto Bug 5357 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8782] Close a suscription
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8782 Jonathan Druart changed: What|Removed |Added Depends on||5357 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8782] Close a suscription
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8782 Jonathan Druart changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
