[Koha-bugs] [Bug 8820] Don't show orders table if there are no orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8820 Chris Cormack changed: What|Removed |Added Status|Passed QA |Pushed to Stable --- Comment #10 from Chris Cormack --- Pushed to 3.8.x, will be in 3.8.8 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8820] Don't show orders table if there are no orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8820 Katrin Fischer changed: What|Removed |Added Attachment #13805|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 13814 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13814&action=edit [SIGNED-OFF] Bug 8820 [3.8.x] Don't show orders table if there are no orders Reworkd for 3.8.x: Patch removes the "basket empty" message in favor of hiding the orders table altogether when a basket has no orders. Other textual changes: - Correcting capitalization according to coding guidelines - Replacing the "Order Details" heading with the more succinct "Orders" Signed-off-by: Melia Meggs Signed-off-by: Katrin Fischer All tests pass, template change only. To test: 1) Create a new basket - verify 'basket empty' shows up 2) Create order line - verfiy table heading is 'Order Details' 3) Close basket, check capitalization on basket group dialog Repeat with patch applied. - 'basket empty' is gone - Heading is now 'Orders' - Capitalization on basket group dialog is correct -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8820] Don't show orders table if there are no orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8820 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8820] Don't show orders table if there are no orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8820 Melia Meggs changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||me...@bywatersolutions.com Patch complexity|--- |Small patch --- Comment #8 from Melia Meggs --- I applied this patch 3.8.7. I looked at an empty basket and see that the Order Details and Basket Empty messages are now gone. I looked at a non-empty basket and see that Order Details has been changed to just Orders. All looks good, so I'm signing off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8820] Don't show orders table if there are no orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8820 Melia Meggs changed: What|Removed |Added Attachment #13611|0 |1 is obsolete|| --- Comment #7 from Melia Meggs --- Created attachment 13805 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13805&action=edit [Signed off] Bug 8820 [3.8.x] Don't show orders table if there are no orders Reworkd for 3.8.x: Patch removes the "basket empty" message in favor of hiding the orders table altogether when a basket has no orders. Other textual changes: - Correcting capitalization according to coding guidelines - Replacing the "Order Details" heading with the more succinct "Orders" Signed-off-by: Melia Meggs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8820] Don't show orders table if there are no orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8820 Owen Leonard changed: What|Removed |Added Attachment #12535|0 |1 is obsolete|| --- Comment #6 from Owen Leonard --- Created attachment 13611 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13611&action=edit Bug 8820 [3.8.x] Don't show orders table if there are no orders Reworkd for 3.8.x: Patch removes the "basket empty" message in favor of hiding the orders table altogether when a basket has no orders. Other textual changes: - Correcting capitalization according to coding guidelines - Replacing the "Order Details" heading with the more succinct "Orders" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8820] Don't show orders table if there are no orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8820 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8820] Don't show orders table if there are no orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8820 Owen Leonard changed: What|Removed |Added Status|Pushed to Master|ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8820] Don't show orders table if there are no orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8820 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz --- Comment #5 from Chris Cormack --- Doesn't apply on 3.8.x please reformat and send for 3.8.x if it is needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8820] Don't show orders table if there are no orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8820 Paul Poulain changed: What|Removed |Added Status|Passed QA |Pushed to Master Version|master |rel_3_8 --- Comment #4 from Paul Poulain --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8820] Don't show orders table if there are no orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8820 Paul Poulain changed: What|Removed |Added Status|Signed Off |Passed QA CC||paul.poul...@biblibre.com --- Comment #3 from Paul Poulain --- QA comment * template/styling only patch, no side effect risk * passes koha-qa.pl passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8820] Don't show orders table if there are no orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8820 Nicole C. Engard changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||neng...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8820] Don't show orders table if there are no orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8820 Nicole C. Engard changed: What|Removed |Added Attachment #12505|0 |1 is obsolete|| --- Comment #2 from Nicole C. Engard --- Created attachment 12535 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12535&action=edit [SIGNED-OFF] Bug 8820 - Don't show orders table if there are no orders This page removes the "basket empty" message in favor of hiding the orders table altogether when a basket has no orders. This patch also moves the "Show all details" checkbox under the "Orders" heading to associate it more closely with the area it affects. Other textual changes: - Correcting capitalization according to coding guidelines - Correcting terminology (basket group instead of basketgroup) - Replacing the "Order Details" heading with the more succinct "Orders" Signed-off-by: Nicole C. Engard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8820] Don't show orders table if there are no orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8820 --- Comment #1 from Owen Leonard --- Created attachment 12505 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12505&action=edit Bug 8820 - Don't show orders table if there are no orders This page removes the "basket empty" message in favor of hiding the orders table altogether when a basket has no orders. This patch also moves the "Show all details" checkbox under the "Orders" heading to associate it more closely with the area it affects. Other textual changes: - Correcting capitalization according to coding guidelines - Correcting terminology (basket group instead of basketgroup) - Replacing the "Order Details" heading with the more succinct "Orders" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8820] Don't show orders table if there are no orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8820 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
