[Koha-bugs] [Bug 8919] ExtendedPatronAttributes not populated from LDAP
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8919 Chris Cormack changed: What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED --- Comment #8 from Chris Cormack --- Released in 3.10.0 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8919] ExtendedPatronAttributes not populated from LDAP
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8919 Paul Poulain changed: What|Removed |Added Version|master |3.10 --- Comment #7 from Paul Poulain --- Patch pushed to branch 3.10.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8919] ExtendedPatronAttributes not populated from LDAP
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8919 Jared Camins-Esakov changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||jcam...@cpbibliography.com --- Comment #6 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8919] ExtendedPatronAttributes not populated from LDAP
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8919 Paul Poulain changed: What|Removed |Added Status|Signed Off |Passed QA CC||paul.poul...@biblibre.com --- Comment #5 from Paul Poulain --- QA comment: * path passes QA * I haven't tested it, bug the code seems logical * the asumption Current code is overly complex and assumes that C4::Members::AttributeTypes::GetAttributeTypes returns array of attribute codes which is not true. is definetly correct (and is properly documented in C4/Members/AttributesTypes.pm passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8919] ExtendedPatronAttributes not populated from LDAP
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8919 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8919] ExtendedPatronAttributes not populated from LDAP
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8919
Chris Cormack changed:
What|Removed |Added
Attachment #12868|0 |1
is obsolete||
--- Comment #4 from Chris Cormack ---
Created attachment 13241
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13241&action=edit
Bug 8919 - ExtendedPatronAttributes not populated from LDAP
Current code is overly complex and assumes that
C4::Members::AttributeTypes::GetAttributeTypes
returns array of attribute codes which is not true.
Instead it return array of hashes so none of extended attributes
will be replicated from LDAP.
This code correctly extracts extended attributes from borrower data
provides simpler code which fills same structure.
It also skips empty values (" ") which are result of mapping without
any default value. This is needed to make unique extended patron values
work. If not handled it would insert empty value for first user and
fail for all others on uniqueness constraint.
Test scenario:
1. define Patron attribute types in administration
2. define mapping from LDAP fields to attributes in koha-conf.xml
3. login as new user with LDAP fields and verify that extended
attributes are replicated from LDAP
Signed-off-by: Chris Cormack
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8919] ExtendedPatronAttributes not populated from LDAP
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8919 Jared Camins-Esakov changed: What|Removed |Added Version|rel_3_8 |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8919] ExtendedPatronAttributes not populated from LDAP
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8919
Dobrica Pavlinusic changed:
What|Removed |Added
Attachment #12848|0 |1
is obsolete||
--- Comment #3 from Dobrica Pavlinusic ---
Created attachment 12868
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12868&action=edit
Bug 8919 - ExtendedPatronAttributes not populated from LDAP
Current code is overly complex and assumes that
C4::Members::AttributeTypes::GetAttributeTypes
returns array of attribute codes which is not true.
Instead it return array of hashes so none of extended attributes
will be replicated from LDAP.
This code correctly extracts extended attributes from borrower data
provides simpler code which fills same structure.
It also skips empty values (" ") which are result of mapping without
any default value. This is needed to make unique extended patron values
work. If not handled it would insert empty value for first user and
fail for all others on uniqueness constraint.
Test scenario:
1. define Patron attribute types in administration
2. define mapping from LDAP fields to attributes in koha-conf.xml
3. login as new user with LDAP fields and verify that extended
attributes are replicated from LDAP
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8919] ExtendedPatronAttributes not populated from LDAP
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8919
Dobrica Pavlinusic changed:
What|Removed |Added
Attachment #12814|0 |1
is obsolete||
--- Comment #2 from Dobrica Pavlinusic ---
Created attachment 12848
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12848&action=edit
Bug 8919 - ExtendedPatronAttributes not populated from LDAP
Current code is overly complex and assumes that
C4::Members::AttributeTypes::GetAttributeTypes
returns array of attribute codes which is not true.
Instead it return array of hashes so none of extended attributes
will be replicated from LDAP.
This code correctly extracts extended attributes from borrower data
provides simpler code which fills same structure.
It also skips empty values (" ") which are result of mapping without
any default value. This is needed to make unique extended patron values
work. If not handled it would insert empty value for first user and
fail for all others on uniqueness constraint.
Test scenario:
1. define Patron attribute types in administration
2. define mapping from LDAP fields to attributes in koha-conf.xml
3. login as new user with LDAP fields and verify that extended
attributes are replicated from LDAP
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8919] ExtendedPatronAttributes not populated from LDAP
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8919 Dobrica Pavlinusic changed: What|Removed |Added Priority|P5 - low|P1 - high Severity|enhancement |critical -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8919] ExtendedPatronAttributes not populated from LDAP
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8919 Dobrica Pavlinusic changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8919] ExtendedPatronAttributes not populated from LDAP
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8919 --- Comment #1 from Dobrica Pavlinusic --- Created attachment 12814 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12814&action=edit Bug 8919 - ExtendedPatronAttributes not populated from LDAP Current code is overly complex and assumes that C4::Members::AttributeTypes::GetAttributeTypes returns array of attribute codes which is not true. Instead it return array of hashes so none of extended attributes will be replicated from LDAP. This code correctly extracts extended attributes from borrower data provides simplier code which fills same structure. Test scenario: 1. define Patron attribute types in administration 2. define mapping from LDAP fields to attributes in koha-conf.xml 3. login as new user with LDAP fields and verify that extended attributes are replicated from LDAP -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8919] ExtendedPatronAttributes not populated from LDAP
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8919 Dobrica Pavlinusic changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|gmcha...@gmail.com |dpav...@rot13.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8919] ExtendedPatronAttributes not populated from LDAP
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8919 Dobrica Pavlinusic changed: What|Removed |Added Summary|ExtendedPatronAttributes|ExtendedPatronAttributes |not populated when |not populated from LDAP |replicating data from LDAP | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
