[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 --- Comment #56 from Fridolyn SOMERS --- Pushed to 3.8.12 and 3.10.5 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 Chris Cormack changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #55 from Chris Cormack --- Pushed to 3.8.x and 3.10.x I note now that we have a couple of instances of ' in the templates, will fix and push -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 --- Comment #54 from Fridolyn SOMERS --- Patches rebased for 3.10 and 3.8 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 --- Comment #53 from Fridolyn SOMERS --- Created attachment 17035 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17035&action=edit [3.8.x] Bug 8942: Translation process breaks javascript (followup 2) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 --- Comment #52 from Fridolyn SOMERS --- Created attachment 17034 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17034&action=edit [3.8.x] Bug 8942: Translation process breaks javascript (followup 1) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 --- Comment #51 from Fridolyn SOMERS --- Created attachment 17033 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17033&action=edit [3.8.x] Bug 8942: Translation process breaks javascript -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 --- Comment #50 from Fridolyn SOMERS --- Created attachment 17032 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17032&action=edit [3.10.x] Bug 8942: Translation process breaks javascript (followup 2) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 --- Comment #49 from Fridolyn SOMERS --- Created attachment 17031 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17031&action=edit [3.10.x] Bug 8942: Translation process breaks javascript (followup 1) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 --- Comment #48 from Fridolyn SOMERS --- Created attachment 17030 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17030&action=edit [3.10.x] Bug 8942: Translation process breaks javascript -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 --- Comment #47 from Chris Cormack --- The patches don't apply to 3.10.x or 3.8.x please rebase and submit if you wish them to be in those branches -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 --- Comment #46 from Fridolyn SOMERS --- Can it be pushed to stable branches ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 Jared Camins-Esakov changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #45 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 Jonathan Druart changed: What|Removed |Added Attachment #15058|0 |1 is obsolete|| --- Comment #44 from Jonathan Druart --- Created attachment 15524 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15524&action=edit Bug 8942 : Adding a test to make sure we don't use single quotes for js Signed-off-by: Owen Leonard Tested by adding single quotes to a translation-escaped string. Test correctly failed it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #43 from Jonathan Druart --- (In reply to comment #42) > (In reply to comment #40) > > ping Chris, do you agree ? > > Yep I do .. did you notice that now there is a review link next to each > patch, I added that last weekend, you can now do inline code comments :) > I hope that will be useful for doing qa. Yes, I see it. That will be useful! > Do you want me to resubmit? Im happy if you just fix that line on signing > off. I will fix it but I wanted to have your permission first. The proposed patch for Bug 9555 fixes this test. Note that a test in koha-qa has been introduced and detect simple-quote strings. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 --- Comment #42 from Chris Cormack --- (In reply to comment #40) > ping Chris, do you agree ? Yep I do .. did you notice that now there is a review link next to each patch, I added that last weekend, you can now do inline code comments :) I hope that will be useful for doing qa. Do you want me to resubmit? Im happy if you just fix that line on signing off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 Fridolyn SOMERS changed: What|Removed |Added CC||oleon...@myacpl.org --- Comment #41 from Fridolyn SOMERS --- *** Bug 9152 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 --- Comment #40 from Jonathan Druart --- ping Chris, do you agree ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 Jonathan Druart changed: What|Removed |Added Blocks||9555 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 --- Comment #39 from Jonathan Druart --- (In reply to comment #37) > Created attachment 15021 [details] > Bug 8942 : Adding a test to make sure we don't use single quotes for js Hi Chris, Don't you think is better to push the complete filepath in order to avoid ambiguity between OPAC and intranet files? -push @files, { name => "$_", lines => \@lines } if @lines; +push @files, { name => $File::Find::name, lines => \@lines } if @lines; -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 Owen Leonard changed: What|Removed |Added Attachment #15021|0 |1 is obsolete|| --- Comment #38 from Owen Leonard --- Created attachment 15058 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15058&action=edit [SIGNED-OFF] Bug 8942 : Adding a test to make sure we don't use single quotes for js Signed-off-by: Owen Leonard Tested by adding single quotes to a translation-escaped string. Test correctly failed it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 Chris Cormack changed: What|Removed |Added Patch complexity|Medium patch|Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 Chris Cormack changed: What|Removed |Added Attachment #14934|0 |1 is obsolete|| Attachment #14935|0 |1 is obsolete|| Attachment #14936|0 |1 is obsolete|| --- Comment #37 from Chris Cormack --- Created attachment 15021 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15021&action=edit Bug 8942 : Adding a test to make sure we don't use single quotes for js -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 Chris Cormack changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 Chris Cormack changed: What|Removed |Added Status|Pushed to Master|ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 Jared Camins-Esakov changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #36 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 Mason James changed: What|Removed |Added CC||m...@kohaaloha.com --- Comment #35 from Mason James --- (In reply to comment #34) > Created attachment 14936 [details] > Bug 8942: Translation process breaks javascript (followup 2) > > Signed-off-by: Owen Leonard > > Tested all changes. Functionality is unchanged. Thanks for the taking > the extra effort to move alert strings into variables. > Signed-off-by: Mason James testing 3 commit(s) (applied to f8686e9 'Bug 9116: Remove some useless tmp var') passing QA, works well... nice patch everyone :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 Mason James changed: What|Removed |Added Attachment #14338|0 |1 is obsolete|| --- Comment #34 from Mason James --- Created attachment 14936 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14936&action=edit Bug 8942: Translation process breaks javascript (followup 2) Signed-off-by: Owen Leonard Tested all changes. Functionality is unchanged. Thanks for the taking the extra effort to move alert strings into variables. Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 Mason James changed: What|Removed |Added Attachment #14337|0 |1 is obsolete|| --- Comment #33 from Mason James --- Created attachment 14935 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14935&action=edit Bug 8942: Translation process breaks javascript (followup 1) Signed-off-by: Owen Leonard Tested all effected functions. No change in functionality. Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 Mason James changed: What|Removed |Added Attachment #14336|0 |1 is obsolete|| --- Comment #32 from Mason James --- Created attachment 14934 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14934&action=edit Bug 8942: Translation process breaks javascript Signed-off-by: Owen Leonard I tested most scripts affected by this patch and visually verified all changes. Functionality is unaffected. Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 Mason James changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 --- Comment #31 from Fridolyn SOMERS --- (In reply to comment #26) > If someone signs off on Fridolyn's patches and if they work fine I'm happy > to write a test in xt/ to test no we don't let single quotes sneak back in Patches are signed-off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 Fridolyn SOMERS changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=9493 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 --- Comment #30 from Fridolyn SOMERS --- Thanks a lot for testing Owen. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 Owen Leonard changed: What|Removed |Added Attachment #13758|0 |1 is obsolete|| --- Comment #29 from Owen Leonard --- Created attachment 14338 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14338&action=edit [SIGNED-OFF] Bug 8942: Translation process breaks javascript (followup 2) Signed-off-by: Owen Leonard Tested all changes. Functionality is unchanged. Thanks for the taking the extra effort to move alert strings into variables. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 Owen Leonard changed: What|Removed |Added Attachment #13757|0 |1 is obsolete|| --- Comment #28 from Owen Leonard --- Created attachment 14337 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14337&action=edit [SIGNED-OFF] Bug 8942: Translation process breaks javascript (followup 1) Signed-off-by: Owen Leonard Tested all effected functions. No change in functionality. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 Owen Leonard changed: What|Removed |Added Attachment #13756|0 |1 is obsolete|| --- Comment #27 from Owen Leonard --- Created attachment 14336 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14336&action=edit [SIGNED-OFF] Bug 8942: Translation process breaks javascript Signed-off-by: Owen Leonard I tested most scripts affected by this patch and visually verified all changes. Functionality is unaffected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 Chris Cormack changed: What|Removed |Added Attachment #13151|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 --- Comment #26 from Chris Cormack --- If someone signs off on Fridolyn's patches and if they work fine I'm happy to write a test in xt/ to test no we don't let single quotes sneak back in -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 Fridolyn SOMERS changed: What|Removed |Added Status|In Discussion |Needs Signoff --- Comment #25 from Fridolyn SOMERS --- (In reply to comment #24) > I agree +1 for a test. Can someone help me on that? I have no idea how it works. My patches seems to be acceptable, so I change status to needs signoff. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz --- Comment #24 from Chris Cormack --- I agree +1 for a test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 --- Comment #23 from Katrin Fischer --- I think an automated test would be preferrable, or have both. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 --- Comment #22 from M. de Rooy --- (In reply to comment #21) > Hi Marcel, > If this rule is accepted, it would be possible to add a regexp in our qa > tools in order to catch all simple-quoted strings added in the js files. That would be good. But an automated test would still be safe too.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 --- Comment #21 from Jonathan Druart --- (In reply to comment #20) > Just an additional thought: If we resolve all quotes now, how do we prevent > them being added again the wrong way in the future? Unit test? Hi Marcel, If this rule is accepted, it would be possible to add a regexp in our qa tools in order to catch all simple-quoted strings added in the js files. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 --- Comment #20 from M. de Rooy --- Frederic, How do you feel about Fridolyn's counterpatches ? Just an additional thought: If we resolve all quotes now, how do we prevent them being added again the wrong way in the future? Unit test? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 --- Comment #19 from Fridolyn SOMERS --- Created attachment 13758 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13758&action=edit Always use double quotes : follow-up 2 Follow-up 2 : Move occurrences of JavaScript translated string from HTML to JavaScript block. The better way is to store translated JavaScript strings into a var : var MSG_NO_ITEM_SELECTED = _("Nothing is selected."); -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 --- Comment #18 from Fridolyn SOMERS --- Created attachment 13757 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13757&action=edit Always use double quotes : follow-up 1 Follow-up 1 : In some places, a JavaScript string concatenation exists into translated string : _('Are you sure you want to delete the ' + count + ' attached items? ') This does not work (see coding gidelines). This patch corrects by using 2 translations : _("Are you sure you want to delete the") + " " + count + " " + _("attached items?") -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 Fridolyn SOMERS changed: What|Removed |Added Attachment #13756|Proposed patch (main) |Always use double quotes : description||main patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 --- Comment #17 from Fridolyn SOMERS --- Created attachment 13756 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13756&action=edit Proposed patch (main) Main patch : replace _('xxx') by _("xxx"). Except when written into HTML : onclick="... _('') ...", see follow-up patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 Fridolyn SOMERS changed: What|Removed |Added Status|Failed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 --- Comment #16 from Fridolyn SOMERS --- After reflexion, I think it is no good idea to have an automatic quote escape. For example, if you have a single quote in a double quote string (or opposite) : _("Aujourd'hui") will become _("Aujourd\'hui"), the backslash will be displayed. Also, like Marcel example, there might be problems with HTML added in JS. For example : $("#id").html("") will generate In this case, the translation must not contain a double quotes, even escaped: $("#id").html("") will generate , bad HTML. I've looked at http://wiki.koha-community.org/wiki/Coding_Guidelines. In JavaScript section, double quotes are always used : _("xxx"). Looking at code, double quotes are used 2629 time and single quotes only 143 times. So if we always use double quotes, single quotes are not a problem anymore and it was the main problem (it is often used in French). I've looked at French PO, double quotes are actually never used in JavaScript translation ; it can be managed one by one. I've looked at old version of calendar, it used double quotes, that's why there was no problem with Today => Aujourd'hui. I will propose a patch for that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m Patch complexity|--- |Medium patch --- Comment #15 from Jonathan Druart --- (In reply to comment #14) > QA Comment: > Single quote seems to work (but see note below). Double quote does not work. > > If I translate: > msgid "Your lists:" > msgstr "Uw "lijsten:" Hi Marcel, To me, your example is not good. You cannot translate "Your lists:" into "Uw "lijsten:", the po file become wrongly formatted. Have you an example with a correctly formatted po file ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 M. de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #14 from M. de Rooy --- QA Comment: Single quote seems to work (but see note below). Double quote does not work. If I translate: msgid "Your lists:" msgstr "Uw "lijsten:" It results in: param1 += "";[% FOREACH addbarshelvesloo IN addbarshelvesloop %] (Example from opac-results.tt within document ready function section. ) OPAC displays only the word Uw. But does not show \"lijsten. NOTE: If I would use already a backslash to escape my quotes in the PO file like this: msgstr "Uw \'lijsten:" I would not like to see the backslash in the display. In other words: Could you improve the regex with lookbehind to prevent adding a backslash that is already there? Changing status to reflect need for attention. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 M. de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl Assignee|koha-b...@lists.koha-commun |frede...@tamil.fr |ity.org | QA Contact||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 Owen Leonard changed: What|Removed |Added Attachment #12939|0 |1 is obsolete|| --- Comment #13 from Owen Leonard --- Created attachment 13151 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13151&action=edit [SIGNED-OFF] Bug 8942 Fix translation of JS strings containing simple/double quote With this patch, translated strings containing simple or double quotes are escaped. This prevent breaking JavaScript strings. For example: Today, translated in French is Aujourd'hui. And so this JS line: var m = _('Today'); become in French: var m = _('Aujourd'hui'); It breaks the whole JS code. With this patch: var m = _('Ajourd\'hui'); Same issue with ", and JS strings like "foo". Signed-off-by: Owen Leonard Confirmed that the example above is handled correctly after applying the patch and generating a fresh set of French templates. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 --- Comment #12 from Katrin Fischer --- Hi Frederic, ah you are right, I made a mistake here. Your second approach limiting the change to Javascript output sounds more secure to me. Thank you! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 Frédéric Demians changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 Frédéric Demians changed: What|Removed |Added Attachment #12935|0 |1 is obsolete|| --- Comment #11 from Frédéric Demians --- Created attachment 12939 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12939&action=edit Proposed patch I leave this reworked patch here for reference. But I haven't more time to test it. It replaces ' with \' in JavaScript strings. No less no more. I can't see side effect. But someone can correct me. I solves another bug in biblio records merging, and, certainly, in other page where JavaScript code is broken due to ' presence in string between single quote like 'foo'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 --- Comment #10 from Fridolyn SOMERS --- (In reply to comment #9) > is: the code ' not the '. I don't understand how it worked for Fridolyn. I modified PO files to use ' in translated strings : msgid:"Today" msgid:"Aujourd'hui" I will correct it french POs but I encourage you to work on this bugfix. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 Frédéric Demians changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #9 from Frédéric Demians --- > as I said on the mailing list, I am a bit worried the script might > translate ' that shoudl not be replaced. Did you check the updated po > files for differences? I think maybe we could start comparing a po > file with not so many ' (not French ;) ) before and after the patch to > find strings where this might be causing problems. I am thinking about > program code that shows up in the po files by mistake. Well, indeed, you're right to be worried. Replacing simple quote (') with ' seems not to work so well. It seems to be displayed has it is: the code ' not the '. I don't understand how it worked for Fridolyn. But the issue is here. And not only in calendar, also in biblio records merging. I will propose another patch with a test plan. Katrin, the patch doesn't touch the .po file. It modifies spefically how the JavaScript translated strings is sent back for inclusion in templates. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #8 from Katrin Fischer --- Hi Kyle, as I said on the mailing list, I am a bit worried the script might translate ' that shoudl not be replaced. Did you check the updated po files for differences? I think maybe we could start comparing a po file with not so many ' (not French ;) ) before and after the patch to find strings where this might be causing problems. I am thinking about program code that shows up in the po files by mistake. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 Kyle M Hall changed: What|Removed |Added Attachment #12908|0 |1 is obsolete|| --- Comment #7 from Kyle M Hall --- Created attachment 12935 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12935&action=edit [SIGNED-OFF] Bug 8942 Fix translation of JS strings containing simple/double quote With this patch, translated strings containing simple or double quotes are transformed to their HTML entities counterpart. This prevent breaking JavaScript strings. For example: Today, translated in French is Aujourd'hui. And so this JS line: var m = _('Today'); become in French: var m = _('Aujourd'hui'); It breaks the whole JS code. With this patch: var m = _('Ajourd'hui'); Same issue with ", and JS strings like "foo". Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #6 from Kyle M Hall --- Cancel that. I'm stupid ; ) I wasn't thinking about the fact that this is a modification to the translation generator, and that I needed to regenerate my French translations before testing! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||k...@bywatersolutions.com --- Comment #5 from Kyle M Hall --- This patch isn't working for me. If I set my language to fr-FR, I still get my dates in MM/DD/ no matter what setting I have for dateformat. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 --- Comment #4 from Frédéric Demians --- > Is there not a risk to convert quotes with the fact that TT elements are > translated (they are %s) ? I don't think so. This patch transform only strings coming from JS. I've done a grep -R "&apos" and """ in fr-FR opac & staff templates directory, and I didn't find anything wrong. You can check yourself after applying this patch, and regenerating localized templates. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 --- Comment #3 from Fridolyn SOMERS --- Is there not a risk to convert quotes with the fact that TT elements are translated (they are %s) ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 claire.hernan...@biblibre.com changed: What|Removed |Added CC||claire.hernandez@biblibre.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 Frédéric Demians changed: What|Removed |Added Attachment #12907|0 |1 is obsolete|| --- Comment #2 from Frédéric Demians --- Created attachment 12908 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12908&action=edit Bug 8942 Fix translation of JS strings -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 Frédéric Demians changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 --- Comment #1 from Frédéric Demians --- Created attachment 12907 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12907&action=edit Bug 8942 Fix translation of JS strings -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/