[Koha-bugs] [Bug 8953] opac-userupdate encoding issues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8953 Liz Rea (CatalystIT) l...@catalyst.net.nz changed: What|Removed |Added Status|Pushed to Stable|RESOLVED CC||l...@catalyst.net.nz Resolution|--- |FIXED --- Comment #11 from Liz Rea (CatalystIT) l...@catalyst.net.nz --- Pushed to 3.6.x will be in 3.6.11. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8953] opac-userupdate encoding issues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8953 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m --- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com --- utf-8 support for opac-userupdate Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8953] opac-userupdate encoding issues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8953 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||paul.poul...@biblibre.com --- Comment #9 from Paul Poulain paul.poul...@biblibre.com --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8953] opac-userupdate encoding issues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8953 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #10 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.8.x will be in 3.8.7 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8953] opac-userupdate encoding issues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8953 Dobrica Pavlinusic dpav...@rot13.org changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|oleon...@myacpl.org |dpav...@rot13.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8953] opac-userupdate encoding issues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8953 --- Comment #1 from Dobrica Pavlinusic dpav...@rot13.org --- Created attachment 12995 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12995action=edit Bug 8953 - opac-userupdate encoding issues This script has various encoding problems: 1. parametars from CGI are not encoded in utf-8, so when they are compared with utf-8 strings from database every field with utf-8 characters will be reported in e-mail as changed 2. when sending e-mail, wide characters are passed to Mail::Sendmail which results in software error if edited field has utf-8 characters (because of first point, this happend if ANY fields has utf-8 chars) 3. when declaring encoding for outgoing e-mail utf-8 is more correct than just utf8 Test scenario: 1. open opac-userupdate and edit user which has utf-8 characters in at least one field (firstname and surname are common examples) 2. edit one of other fields and add utf-8 character to it 3. verify that e-mail with changes arrived with just edited field -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8953] opac-userupdate encoding issues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8953 Dobrica Pavlinusic dpav...@rot13.org changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8953] opac-userupdate encoding issues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8953 Mirko Tietgen mi...@abunchofthings.net changed: What|Removed |Added Attachment #12995|0 |1 is obsolete|| --- Comment #2 from Mirko Tietgen mi...@abunchofthings.net --- Created attachment 12996 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12996action=edit Bug 8953 - opac-userupdate encoding issues This script has various encoding problems: 1. parametars from CGI are not encoded in utf-8, so when they are compared with utf-8 strings from database every field with utf-8 characters will be reported in e-mail as changed 2. when sending e-mail, wide characters are passed to Mail::Sendmail which results in software error if edited field has utf-8 characters (because of first point, this happend if ANY fields has utf-8 chars) 3. when declaring encoding for outgoing e-mail utf-8 is more correct than just utf8 Test scenario: 1. open opac-userupdate and edit user which has utf-8 characters in at least one field (firstname and surname are common examples) 2. edit one of other fields and add utf-8 character to it 3. verify that e-mail with changes arrived with just edited field Signed-off-by: Mirko Tietgen mi...@abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8953] opac-userupdate encoding issues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8953 Mirko Tietgen mi...@abunchofthings.net changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||mi...@abunchofthings.net --- Comment #3 from Mirko Tietgen mi...@abunchofthings.net --- Followed the test plan. Sendmail error without patch, no email sent. After applying the patch the email is sent, o error page. BTW. I also have the patrons email address as changed in the email that is sent to the library (it was not really changed), no matter if I apply this patch or not. Is that normal? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8953] opac-userupdate encoding issues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8953 --- Comment #4 from Dobrica Pavlinusic dpav...@rot13.org --- Yes. In current implementation we are just sending e-mail with changes and expect librarians to enter changes through intranet manually from e-mail message (probably to have some kind of verification). I used to have quick dirty change back in Koha 3.1 or so which would also save those changes in database, but then we changed our workflow and moved to newer version, so I never submited them to upstream or ported them to newer version. It would probably make sense to revisit that code, and wrap up that in proper improvement, but I can't promise any time-frame for that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8953] opac-userupdate encoding issues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8953 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #5 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Dobrica, not related to this bug, but to your comment about getting rid of requiring manual changes - there is bug 7067 for patron self registration. I have not tested it myself, so I am not sure how it works. But the test plan looks a bit like what you might be looking for: Test Plan - Part 2 - Borrower Modifications 1) Log in to OPAC, go to my personal details tab. 2) Make some modifications to your details. 3) Repeat steps 1 and 2 for two more borrowers. 4) Log in to Koha intranet with a user that can modify borrowers. 5) At the bottom of mainpage.pl, you should see: Patrons requesting modifications: 3 6) Click the link 7) Approve one change, deny a different one, and ignore the third, then submit. 8) Check the records, you should see the changes take affect on the approved one, and no changes to the other two. You should also see Patrons requesting modifications: 1 at the bottom of mainpage.pl now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8953] opac-userupdate encoding issues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8953 --- Comment #6 from Dobrica Pavlinusic dpav...@rot13.org --- Thanks Katrin, I wouldn't found it without your pointer. I will give it a try. It seems that bug 7067 is targeting 3.12 so this bugfix might still be useful for older versions of Koha. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8953] opac-userupdate encoding issues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8953 --- Comment #7 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Yes, and I am glad you fixed it - I found the bug last week when training a library :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
