[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #36 from Kyle M Hall --- Created attachment 25867 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25867&action=edit Bug 9011 - Add the ability to store the last patron to return an item -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What|Removed |Added Attachment #22577|0 |1 is obsolete|| Attachment #22578|0 |1 is obsolete|| Attachment #22579|0 |1 is obsolete|| --- Comment #35 from Kyle M Hall --- Created attachment 25866 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25866&action=edit Bug 9011 - Re-engineer circ anonymization, move to subroutine in C4::Circulation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What|Removed |Added Depends on||9303, 11891 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What|Removed |Added Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What|Removed |Added Attachment #25866|0 |1 is obsolete|| --- Comment #37 from Kyle M Hall --- Created attachment 25868 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25868&action=edit Bug 9011 - Re-engineer circ anonymization, move to subroutine in C4::Circulation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What|Removed |Added Attachment #25868|0 |1 is obsolete|| --- Comment #39 from Kyle M Hall --- Created attachment 25870 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25870&action=edit Bug 9011 - Re-engineer circ anonymization, move to subroutine in C4::Circulation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What|Removed |Added Attachment #25869|0 |1 is obsolete|| --- Comment #40 from Kyle M Hall --- Created attachment 25871 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25871&action=edit Bug 9011 - Add the ability to store the last patron to return an item -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What|Removed |Added Attachment #25867|0 |1 is obsolete|| --- Comment #38 from Kyle M Hall --- Created attachment 25869 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25869&action=edit Bug 9011 - Add the ability to store the last patron to return an item -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #41 from Kyle M Hall --- Created attachment 25872 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25872&action=edit Bug 9011 - Add support for StoreLastBorrower to AnonymiseIssueHistory -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What|Removed |Added Attachment #25872|0 |1 is obsolete|| --- Comment #43 from Kyle M Hall --- Created attachment 25873 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25873&action=edit Bug 9011 - Add support for StoreLastBorrower to AnonymiseIssueHistory -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #42 from Kyle M Hall --- This new patch set re-engineers the entire feature. It ditches the new fields and instead simply retains the borrowernumber for the last old_issue for each patron, even if the would have been anonymized. Upon the next return of the item, that patron is then anonymized if the patron's privacy is set to 2. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Brooksml changed: What|Removed |Added CC||je...@brookslibraryvt.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Christopher Brannon changed: What|Removed |Added CC||cbran...@cdalibrary.org --- Comment #44 from Christopher Brannon --- Kyle, do you have a new test plan, or is the old one still the one to go with? Christopher -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Christopher Brannon changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #45 from Christopher Brannon --- Kyle, Ran into problems applying this patch to sandbox: The sandbox you've requested is not ready. Some problems occurred applying patches from bug 9011: Something went wrong !Applying: Bug 9011 - Re-engineer circ anonymization, move to subroutine in C4::Circulation fatal: sha1 information is lacking or useless (Koha/Schema/Result/OldIssue.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 9011 - Re-engineer circ anonymization, move to subroutine in C4::Circulation When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 9011 - Add the ability to store the last patron to return an item 25870 - Bug 9011 - Re-engineer circ anonymization, move to subroutine in C4::Circulation 25871 - Bug 9011 - Add the ability to store the last patron to return an item 25873 - Bug 9011 - Add support for StoreLastBorrower to AnonymiseIssueHistory Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-9011---Re-engineer-circ-anonymization-move-to--EetlgO.patch . Christopher -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Srdjan Jankovic changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||srd...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What|Removed |Added Attachment #16773|0 |1 is obsolete|| Attachment #18676|0 |1 is obsolete|| Attachment #20180|0 |1 is obsolete|| --- Comment #16 from Kyle M Hall --- Created attachment 20181 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20181&action=edit Bug 9011 - Add the ability to store the last patron to return an item Currently if the AnonymousPatron system preference is in use, all patron data is anonymized. Some libraries would like to be able to see the last patron who returned out an item ( in case of damage ) but still keep all other patrons anonymized. * Add the field items.last_borrower, foreign key to borrowers.borrowernumber * Add new system preference StoreLastBorrower * If StoreLastBorrower is enabled, upon checkin have Koha set this new field to the patron who last returned this item. * If this new field has a value, link to the patron from the item details page. Test plan: 1) Apply patch 2) Run updatedatabase.pl 3) Enable StoreLastBorrower 4) Issue an item to a patron and return said item 5) Issue the same item to a second patron, do not return it. 6) View moredetail.pl for the given bib, find the given item. There should be a new field in the history list 'Last returned by' with a link to the given borrowernumber. Optionally, you can also verify this works even if patron issuing history has been set to anonymize issues upon return. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What|Removed |Added Attachment #16763|0 |1 is obsolete|| --- Comment #15 from Kyle M Hall --- Created attachment 20180 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20180&action=edit Bug 9011 - Add the ability to store the last patron to return an item Currently if the AnonymousPatron system preference is in use, all patron data is anonymized. Some libraries would like to be able to see the last patron who returned out an item ( in case of damage ) but still keep all other patrons anonymized. * Add the field items.last_borrower, foreign key to borrowers.borrowernumber * Add new system preference StoreLastBorrower * If StoreLastBorrower is enabled, upon checkin have Koha set this new field to the patron who last returned this item. * If this new field has a value, link to the patron from the item details page. Test plan: 1) Apply patch 2) Run updatedatabase.pl 3) Enable StoreLastBorrower 4) Issue an item to a patron and return said item 5) Issue the same item to a second patron, do not return it. 6) View moredetail.pl for the given bib, find the given item. There should be a new field in the history list 'Last returned by' with a link to the given borrowernumber. Optionally, you can also verify this works even if patron issuing history has been set to anonymize issues upon return. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #17 from Jonathan Druart --- QA comment: 1/ The screen is not obvious: Last borrowed:14/08/2013 Last returned by: 23529001223640 Last borrower: 23529001223640 Previous borrower: 23529001223641 The "last returned by" and the "last borrower" is the same value when AnonymousPatron is not in use. 2/ Could you use the template plugin to get the syspref value (rather than to pass it from the pl script). Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #18 from Kyle M Hall --- Created attachment 20329 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20329&action=edit Bug 9011 - QA Followup * Use template plugin to get syspref values * Hide "last returned by" if AnonymousPatron is not set -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Jonathan Druart changed: What|Removed |Added QA Contact|paul.poul...@biblibre.com |jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #19 from Jonathan Druart --- Last patch fixes the issues. Thanks Kyle. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #22 from Jonathan Druart --- Created attachment 20344 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20344&action=edit Bug 9011: Update GPL license -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Jonathan Druart changed: What|Removed |Added Attachment #20329|0 |1 is obsolete|| --- Comment #21 from Jonathan Druart --- Created attachment 20343 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20343&action=edit Bug 9011 - QA Followup * Use template plugin to get syspref values * Hide "last returned by" if AnonymousPatron is not set Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Jonathan Druart changed: What|Removed |Added Attachment #20181|0 |1 is obsolete|| --- Comment #20 from Jonathan Druart --- Created attachment 20342 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20342&action=edit Bug 9011 - Add the ability to store the last patron to return an item Currently if the AnonymousPatron system preference is in use, all patron data is anonymized. Some libraries would like to be able to see the last patron who returned out an item ( in case of damage ) but still keep all other patrons anonymized. * Add the field items.last_borrower, foreign key to borrowers.borrowernumber * Add new system preference StoreLastBorrower * If StoreLastBorrower is enabled, upon checkin have Koha set this new field to the patron who last returned this item. * If this new field has a value, link to the patron from the item details page. Test plan: 1) Apply patch 2) Run updatedatabase.pl 3) Enable StoreLastBorrower 4) Issue an item to a patron and return said item 5) Issue the same item to a second patron, do not return it. 6) View moredetail.pl for the given bib, find the given item. There should be a new field in the history list 'Last returned by' with a link to the given borrowernumber. Optionally, you can also verify this works even if patron issuing history has been set to anonymize issues upon return. Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #23 from Galen Charlton --- (In reply to Kyle M Hall from comment #8) > > 3 should we keep the information limitless ? In France, I think it would be > > illegal, as all libraries must use tools/cleanborrowers.pl. Shouldn't we add > > an option in this script to remove information after a specific period, even > > if the patron is still the last borrower ? > > This I don't think will work, as the data never expiring what this is all > about! This feature is not enabled by default so I don't think that should > be a problem, right? There's a difference between keeping a link to the last borrower for a longer period of time and keeping it forever. Consequently, I agree with Paul's suggestion that cleanborrowers.pl should have an option to clear issues.last_returned_by after a specified amount of time. However, since the new feature is not on by default, I do not consider this a blocker for pushing the patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011
--- Comment #24 from Galen Charlton ---
Comment on attachment 20343
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20343
Bug 9011 - QA Followup
Review of attachment 20343:
-->
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=9011&attachment=20343)
-
::: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt
@@ +214,4 @@
>
> Last seen:[% IF (
> ITEM_DAT.datelastseen ) %][% ITEM_DAT.datelastseen | $KohaDates %] [%END
> %]
> Last borrowed:[% IF
> (ITEM_DAT.datelastborrowed ) %][% ITEM_DAT.datelastborrowed | $KohaDates %][%
> END %]
> +[% IF ( ITEM_DAT.last_returned_by &&
> Koha.Preference('StoreLastBorrower') && !Koha.Preference('AnonymousPatron') )
> %]Last returned by: href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[%
> ITEM_DAT.last_returned_by %]">[% KohaBorrowers.BorrowernumberToCardnumber(
> ITEM_DAT.last_returned_by ) %] [% END %]
Is "Koha.Preference('AnonymousPatron')" what is meant, not
"!Koha.Preference('AnonymousPatron')"?
The AnonymousPatron system preference is not a Boolean, it's the borrowernumber
of the record to which anonymized transactions should be linked.
Consequently, I think the QA follow-up has exactly the opposite of the intended
effect.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Galen Charlton changed: What|Removed |Added Status|Passed QA |In Discussion --- Comment #25 from Galen Charlton --- Setting to In Discussion and requesting a response from Jonathan to the question I asked in my previous comment. Broader question: do we really need another field in the items table? Why not just tweak AnonymiseIssueHistory() so that if StoreLastBorrower is set, old_issue rows that are the most recent return for their items are not anonymized? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011
--- Comment #26 from Jonathan Druart ---
(In reply to Galen Charlton from comment #24)
> Comment on attachment 20343 [details] [review]
> Bug 9011 - QA Followup
>
> Review of attachment 20343 [details] [review]:
> -
>
> ::: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt
> @@ +214,4 @@
> >
> > Last seen:[% IF (
> > ITEM_DAT.datelastseen ) %][% ITEM_DAT.datelastseen | $KohaDates %] [%END
> > %]
> > Last borrowed:[% IF
> > (ITEM_DAT.datelastborrowed ) %][% ITEM_DAT.datelastborrowed | $KohaDates
> > %][% END %]
> > +[% IF ( ITEM_DAT.last_returned_by &&
> > Koha.Preference('StoreLastBorrower') && !Koha.Preference('AnonymousPatron')
> > ) %]Last returned by: > href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[%
> > ITEM_DAT.last_returned_by %]">[% KohaBorrowers.BorrowernumberToCardnumber(
> > ITEM_DAT.last_returned_by ) %] [% END %]
>
> Is "Koha.Preference('AnonymousPatron')" what is meant, not
> "!Koha.Preference('AnonymousPatron')"?
>
> The AnonymousPatron system preference is not a Boolean, it's the
> borrowernumber of the record to which anonymized transactions should be
> linked.
>
> Consequently, I think the QA follow-up has exactly the opposite of the
> intended effect.
If the pref AnonymousPatron is set to 0, that means that the feature is
disabled. Else, it contains a borrowernumber and the feature is enabled.
So !Koha.Preference('AnonymousPatron') means: the feature is enabled, we want
to display the "last returned by" value.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #27 from Jonathan Druart --- (In reply to Galen Charlton from comment #25) > Setting to In Discussion and requesting a response from Jonathan to the > question I asked in my previous comment. > > Broader question: do we really need another field in the items table? Why > not just tweak AnonymiseIssueHistory() so that if StoreLastBorrower is set, > old_issue rows that are the most recent return for their items are not > anonymized? If anonymouspatron is enabled, C4::Circ::MarkIssueReturn can change the borrowernumber with the anonymouspatron value. So the information does not exist in the old_issues table. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What|Removed |Added Attachment #20344|0 |1 is obsolete|| --- Comment #30 from Kyle M Hall --- Created attachment 22579 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22579&action=edit Bug 9011: Update GPL license Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What|Removed |Added Attachment #20342|0 |1 is obsolete|| --- Comment #28 from Kyle M Hall --- Created attachment 22577 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22577&action=edit Bug 9011 - Add the ability to store the last patron to return an item Currently if the AnonymousPatron system preference is in use, all patron data is anonymized. Some libraries would like to be able to see the last patron who returned out an item ( in case of damage ) but still keep all other patrons anonymized. * Add the field items.last_borrower, foreign key to borrowers.borrowernumber * Add new system preference StoreLastBorrower * If StoreLastBorrower is enabled, upon checkin have Koha set this new field to the patron who last returned this item. * If this new field has a value, link to the patron from the item details page. Test plan: 1) Apply patch 2) Run updatedatabase.pl 3) Enable StoreLastBorrower 4) Issue an item to a patron and return said item 5) Issue the same item to a second patron, do not return it. 6) View moredetail.pl for the given bib, find the given item. There should be a new field in the history list 'Last returned by' with a link to the given borrowernumber. Optionally, you can also verify this works even if patron issuing history has been set to anonymize issues upon return. Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What|Removed |Added Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What|Removed |Added Attachment #20343|0 |1 is obsolete|| --- Comment #29 from Kyle M Hall --- Created attachment 22578 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22578&action=edit Bug 9011 - QA Followup * Use template plugin to get syspref values * Hide "last returned by" if AnonymousPatron is not set Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #31 from Paul Poulain --- (In reply to Galen Charlton from comment #25) > Broader question: do we really need another field in the items table? Why > not just tweak AnonymiseIssueHistory() so that if StoreLastBorrower is set, > old_issue rows that are the most recent return for their items are not > anonymized? The more I think of it, the less I like this patch : it introduces a duplicate information in our database: the last patron is in old_issues and in items.last_borrower I agree that the old_issues information can be removed by anonymisation. But a better option, imho, would be to improve anonymization, to have something like: * anonymize * anonymize except the last patron * don't anonymize However, I'm not the RM, so Galen final cut. But I really think that, on the long term, this patch introduces some inconsistencies, and thus, pain. (Sorry not to have written this earlier) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 jdem...@roseville.ca.us changed: What|Removed |Added CC||jdem...@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Jonathan Druart changed: What|Removed |Added QA Contact|jonathan.dru...@biblibre.co | |m | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #32 from Galen Charlton --- (In reply to Paul Poulain from comment #31) > I agree that the old_issues information can be removed by anonymisation. But > a better option, imho, would be to improve anonymization, to have something > like: > * anonymize > * anonymize except the last patron > * don't anonymize I prefer this approach as well, though I think I've heard of cases where some libraries might want the second option to be "anonymize all except the last N patrons", where N is set by the library. Kyle, Paul, Jonathan: do any of you have the wherewithal to run with that idea for 3.16? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #33 from Jonathan Druart --- (In reply to Galen Charlton from comment #32) > Kyle, Paul, Jonathan: do any of you have the wherewithal to run with that > idea for 3.16? I don't plan to work on that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Nicole C. Engard changed: What|Removed |Added CC||neng...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Katrin Fischer changed: What|Removed |Added Status|Signed Off |In Discussion CC||katrin.fisc...@bsz-bw.de --- Comment #34 from Katrin Fischer --- I have taken a longer look at this and have been trying to make up my mind. I also looked at the code and did some testing. - I agree that adding one more place that has to be taken into account when trying to anonymize the reading history seems problematic. We already have the information in statistics, action_logs and old_issues. - Choosing to build this on the existing anonymizing scripts would give us more flexibility in the future. Like Galen suggested, it would be possible to keep the "last n borrowers". - There is currently no automatic way to delete this information from items/deleteditems once you choose to deactivate the feature. This worries me a bit. Some general thoughts: When we discussed this kind of problem at work, there was a point made that the data is not useful after a certain amount of time. Can you blame a borrower for any damage you find after accepting the item at the circulation desk or reshelving it after a selfcheck return? As we are only allowed to keep data that is actually needed, it would be good if there was an option to delete after x days. About the code: 1) Database update needs to be '15' and contain the bug number. 2) Diacritics in the card number on the items tab get mangled. 3) I think the syspref description could be improved a bit. I didn't understand at first what was meant by "This setting is independent of opacreadinghistory/AnonymousPatron". I think something like "the data will be stored independent on your settings for..." might be a bit more clear and also it might be good to warn that the data will be kept for older items/issues when turning it off again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What|Removed |Added Attachment #25871|0 |1 is obsolete|| --- Comment #47 from Kyle M Hall --- Created attachment 28924 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28924&action=edit Bug 9011 - Add the ability to store the last patron to return an item -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What|Removed |Added Attachment #25870|0 |1 is obsolete|| --- Comment #46 from Kyle M Hall --- Created attachment 28923 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28923&action=edit Bug 9011 - Re-engineer circ anonymization, move to subroutine in C4::Circulation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What|Removed |Added Attachment #25873|0 |1 is obsolete|| --- Comment #48 from Kyle M Hall --- Created attachment 28925 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28925&action=edit Bug 9011 - Add support for StoreLastBorrower to AnonymiseIssueHistory -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Christopher Brannon changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #49 from Christopher Brannon --- On master when I turn on the AnonymousPatron preference, I can check items in. With patch applied and AnonymousPatron on, I get Error 500 screens on check in. Items won't check in with patch. This is true checking in from moremember.pl or circulation.pl from the list of items checked out, or from returns.pl. Christopher -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Nick Clemens changed: What|Removed |Added CC||n...@quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #50 from Kyle M Hall --- This bug depends on bug 9303, the patches for that bug must be applied prior to testing this patch set. (In reply to Christopher Brannon from comment #49) > On master when I turn on the AnonymousPatron preference, I can check items > in. With patch applied and AnonymousPatron on, I get Error 500 screens on > check in. Items won't check in with patch. This is true checking in from > moremember.pl or circulation.pl from the list of items checked out, or from > returns.pl. > > Christopher -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #51 from Nick Clemens --- After applying both patches and updating the database the feature seems to work as expected, however, when I log in to any patron account on the opac and click the 'immediate deletion' button under 'your privacy' I get the error: "The deletion of your reading history failed, because there is a problem with the configuration of this feature. Please help to fix the system by informing your library of this error." I double checked my system settings without the patches and immediate deletion works. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #52 from Kyle M Hall --- Created attachment 29301 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29301&action=edit Bug 9011 [QA Followup] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #53 from Nick Clemens --- I tested again, feature works, immediate deletion works as I think it should with this feature (i.e. Any items where last patron is being kept are not removed from history) but it does seem like when this preference is active there should be an explanation on the general privacy page and in the success message from immediate deletion to explain to the patron why everything may not be cleared even if they have privacy set to 'never' and hit immediate deletion. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #54 from Kyle M Hall --- Created attachment 29745 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29745&action=edit Bug 9011 [QA Followup 2] - Add message to OPAC * Adds warning to OPAC if StoreLastBorrower is enabled * Updates db revision -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What|Removed |Added Depends on|9303| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What|Removed |Added Attachment #29745|0 |1 is obsolete|| --- Comment #55 from Kyle M Hall --- Created attachment 29749 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29749&action=edit Bug 9011 [QA Followup 2] - Add message to OPAC * Adds warning to OPAC if StoreLastBorrower is enabled * Updates db revision * Fixes POD error -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What|Removed |Added Attachment #29749|0 |1 is obsolete|| --- Comment #56 from Kyle M Hall --- Created attachment 29750 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29750&action=edit Bug 9011 [QA Followup 2] - Add message to OPAC * Adds warning to OPAC if StoreLastBorrower is enabled * Updates db revision * Fixes POD error -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #57 from Nick Clemens --- I tested but am not seeing history stored if patron privacy preference is set to 'never' Patron also seems to be able to clear last borrower history using 'Immediate deletion' button Bug says depends on 11891, but that was pushed to master, wanted to check before clearing though. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What|Removed |Added Attachment #29750|0 |1 is obsolete|| --- Comment #58 from Kyle M Hall --- Created attachment 29930 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29930&action=edit Bug 9011 [QA Followup 2] - Add message to OPAC * Adds warning to OPAC if StoreLastBorrower is enabled * Updates db revision * Fixes POD error -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What|Removed |Added Depends on|11891 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #60 from Kyle M Hall --- (In reply to Nick Clemens from comment #57) > I tested but am not seeing history stored if patron privacy preference is > set to 'never' > Patron also seems to be able to clear last borrower history using 'Immediate > deletion' button Please retest! I believe the issue was caused by the database schema not being updated. > Bug says depends on 11891, but that was pushed to master, wanted to check > before clearing though. I've gone ahead and cleared that blocker. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #59 from Kyle M Hall --- Created attachment 29931 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29931&action=edit Bug 9011 [QA Followup 3] - Update database schema files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #61 from Nick Clemens --- Hi Kyle, I tried to test on a sandbox (3.17.00.009) and am getting Error 500 for any checkins I was going to test on my VM (3.17.00.010) but patch needs rebased for current master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #62 from Kyle M Hall --- (In reply to Nick Clemens from comment #61) > Hi Kyle, > > I tried to test on a sandbox (3.17.00.009) and am getting Error 500 for any > checkins > > I was going to test on my VM (3.17.00.010) but patch needs rebased for > current master Not sure what's going on, the patches apply to master just fine for me (3.17.00.014). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #63 from Nick Clemens --- You are correct, looks like problem was on my end. I am getting a software error at check-in: DBIx::Class::ResultSet::next(): Unknown column 'me.issue_id' in 'field list' at /home/nick/koha/C4/Circulation.pm line 3808 My steps: 1 - Applied to new VM with no errors 2 - Ran updatedatabase.pl - successful 3 - Enable StoreLastBorrower 4 - Check out an item to patron 5 - Attempt to check in item - error as above If I checkout master I can return the items Let me know if I am doing something wrong -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #64 from Kyle M Hall --- Created attachment 30979 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30979&action=edit Bug 9011 [QA Followup 4] - Add issue_id to issues tables -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #65 from Kyle M Hall --- Looks like I forgot to create the issue_id field with my db update! This latest followup should solve the problem. (In reply to Nick Clemens from comment #63) > You are correct, looks like problem was on my end. > > I am getting a software error at check-in: > DBIx::Class::ResultSet::next(): Unknown column 'me.issue_id' in 'field list' > at /home/nick/koha/C4/Circulation.pm line 3808 > > My steps: > > 1 - Applied to new VM with no errors > 2 - Ran updatedatabase.pl - successful > 3 - Enable StoreLastBorrower > 4 - Check out an item to patron > 5 - Attempt to check in item - error as above > > If I checkout master I can return the items > > Let me know if I am doing something wrong -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Nick Clemens changed: What|Removed |Added Attachment #28923|0 |1 is obsolete|| --- Comment #66 from Nick Clemens --- Created attachment 30993 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30993&action=edit [SIGNED OFF] Bug 9011 - Re-engineer circ anonymization, move to subroutine in C4::Circulation Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Nick Clemens changed: What|Removed |Added Attachment #28924|0 |1 is obsolete|| --- Comment #67 from Nick Clemens --- Created attachment 30994 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30994&action=edit [SIGNED OFF] Bug 9011 - Add the ability to store the last patron to return an item Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Nick Clemens changed: What|Removed |Added Attachment #28925|0 |1 is obsolete|| --- Comment #68 from Nick Clemens --- Created attachment 30995 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30995&action=edit [SIGNED OFF] Bug 9011 - Add support for StoreLastBorrower to AnonymiseIssueHistory Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Nick Clemens changed: What|Removed |Added Attachment #29301|0 |1 is obsolete|| --- Comment #69 from Nick Clemens --- Created attachment 30996 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30996&action=edit [SIGNED OFF] Bug 9011 [QA Followup] Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Nick Clemens changed: What|Removed |Added Attachment #29930|0 |1 is obsolete|| --- Comment #70 from Nick Clemens --- Created attachment 30997 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30997&action=edit [SIGNED OFF] Bug 9011 [QA Followup 2] - Add message to OPAC * Adds warning to OPAC if StoreLastBorrower is enabled * Updates db revision * Fixes POD error Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Nick Clemens changed: What|Removed |Added Attachment #29931|0 |1 is obsolete|| --- Comment #71 from Nick Clemens --- Created attachment 30998 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30998&action=edit [SIGNED OFF] Bug 9011 [QA Followup 3] - Update database schema files Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Nick Clemens changed: What|Removed |Added Attachment #30979|0 |1 is obsolete|| --- Comment #72 from Nick Clemens --- Created attachment 30999 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30999&action=edit [SIGNED OFF] Bug 9011 [QA Followup 4] - Add issue_id to issues tables Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #73 from Nick Clemens --- I tested with patrons using privacy settings of Forever, Never and Default. In all cases history was stored as expected before enabling StoreLastBorrower and Immediate deletion button worked with no warnings After enabling StoreLastBorrower 'immediate deletion' button offered warning that last returned items would not be deleted. For patrons with privacy set to 'Never', items were anonymised as soon as returned by the next patron. For others, items history was stored until patron clicked 'immediate deletion' The 'Last borrower' link appeared in the items histories and was only anonymised upon return by next patron (for those with privacy 'Never') or upon forced deletion by patrons with other settings. I did have one or two instances of an item getting stuck in history as I changed many settings, but could not recreate the issue purposefully. In all cases either saving patron history again or checking the item out and back in cleared the issue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #74 from Katrin Fischer --- Hi Kyle, I am having problems applying these patches - I fixed the conflicts in the second, but then can't get QA follow-up 2 to apply. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What|Removed |Added Attachment #30993|0 |1 is obsolete|| Attachment #30994|0 |1 is obsolete|| Attachment #30995|0 |1 is obsolete|| Attachment #30996|0 |1 is obsolete|| Attachment #30997|0 |1 is obsolete|| Attachment #30998|0 |1 is obsolete|| Attachment #30999|0 |1 is obsolete|| --- Comment #75 from Kyle M Hall --- Created attachment 32430 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32430&action=edit Bug 9011 - Re-engineer circ anonymization, move to subroutine in C4::Circulation Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #76 from Kyle M Hall --- Created attachment 32431 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32431&action=edit Bug 9011 - Add the ability to store the last patron to return an item Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #77 from Kyle M Hall --- Created attachment 32432 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32432&action=edit Bug 9011 - Add support for StoreLastBorrower to AnonymiseIssueHistory Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #81 from Kyle M Hall --- Created attachment 32436 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32436&action=edit Bug 9011 [QA Followup 4] - Add issue_id to issues tables Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #79 from Kyle M Hall --- Created attachment 32434 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32434&action=edit Bug 9011 [QA Followup 2] - Add message to OPAC * Adds warning to OPAC if StoreLastBorrower is enabled * Updates db revision * Fixes POD error Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #80 from Kyle M Hall --- Created attachment 32435 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32435&action=edit Bug 9011 [QA Followup 3] - Update database schema files Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #78 from Kyle M Hall --- Created attachment 32433 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32433&action=edit Bug 9011 [QA Followup] Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What|Removed |Added Attachment #32430|0 |1 is obsolete|| Attachment #32431|0 |1 is obsolete|| Attachment #32432|0 |1 is obsolete|| Attachment #32433|0 |1 is obsolete|| Attachment #32434|0 |1 is obsolete|| Attachment #32435|0 |1 is obsolete|| Attachment #32436|0 |1 is obsolete|| --- Comment #82 from Kyle M Hall --- Created attachment 32437 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32437&action=edit Bug 9011 - Re-engineer circ anonymization, move to subroutine in C4::Circulation Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #83 from Kyle M Hall --- Created attachment 32438 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32438&action=edit Bug 9011 - Add the ability to store the last patron to return an item Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #84 from Kyle M Hall --- Created attachment 32439 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32439&action=edit Bug 9011 - Add support for StoreLastBorrower to AnonymiseIssueHistory Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #85 from Kyle M Hall --- Created attachment 32440 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32440&action=edit Bug 9011 [QA Followup] Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #87 from Kyle M Hall --- Created attachment 32442 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32442&action=edit Bug 9011 [QA Followup 3] - Update database schema files Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #88 from Kyle M Hall --- Created attachment 32443 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32443&action=edit Bug 9011 [QA Followup 4] - Add issue_id to issues tables Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #86 from Kyle M Hall --- Created attachment 32441 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32441&action=edit Bug 9011 [QA Followup 2] - Add message to OPAC * Adds warning to OPAC if StoreLastBorrower is enabled * Updates db revision * Fixes POD error Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Katrin Fischer changed: What|Removed |Added QA Contact||katrin.fisc...@bsz-bw.de --- Comment #89 from Katrin Fischer --- Working on this now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #90 from Katrin Fischer --- Hi Kyle, I will continue testing for now, but the new tests are failing for me: 1..6 ok 1 - use C4::Circulation; ok 2 - use Koha::Database; Use of uninitialized value in subroutine entry at /home/katrin/kohaclone/C4/Charset.pm line 181. DBD::mysql::st execute failed: Duplicate entry '8' for key 'PRIMARY' at /home/katrin/kohaclone/C4/Circulation.pm line 2073. DBD::mysql::st execute failed: Duplicate entry '8' for key 'PRIMARY' at /home/katrin/kohaclone/C4/Circulation.pm line 2073. # Looks like you planned 6 tests but ran 2. # Looks like your test exited with 255 just after 2. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #91 from Katrin Fischer --- Hi Kyle, there is something going wrong for me: Patron: store never StoreLastPatron: Yes OpacPrivacy: Yes opacreadinghistory: Yes AnonymousPatron: set to borrowernumber I check out a book and check it back in. Expectation: The table old_issues should show a new entry with the patron's borrowernumber. But: there is no entry in old_issues... Instead I have a DB error in the logs: [Sun Oct 26 17:03:20.914868 2014] [cgi:error] [pid 28492] [client 127.0.0.1:41501] AH01215: [Sun Oct 26 21:03:20 2014] checkin: DBD::mysql::st execute failed: Duplicate entry '15' for key 'PRIMARY' at /home/katrin/kohaclone/C4/Circulation.pm line 2072., referer: http://localhost:8080/cgi-bin/koha/circ/circulation.pl I think the way the new issue_id is set does not work correctly. The new issue gets 16 - while I already have ids way above 30 in both tables. After the update it looked ok, but it's not working right for new ids. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #92 from Katrin Fischer --- I tried it again... restored my database pre-patch, ran the update again, new checkout = issue_id = 4 :( Should have been 27. I have a feeling of de ja vu... didn't we fight this problem on another patch? Looks like bug 9303 is also adding an issue_id. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #93 from Kyle M Hall --- Created attachment 32977 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32977&action=edit Bug 9011 [QA Followup 5] - Depend on bug 9303 for issue_id -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What|Removed |Added Depends on||9303 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #94 from Kyle M Hall --- You are correct! And it does a much better job of it too. I'm making bug 9303 a dependency for this bug. (In reply to Katrin Fischer from comment #92) > I tried it again... restored my database pre-patch, ran the update again, > new checkout = issue_id = 4 :( Should have been 27. > > I have a feeling of de ja vu... didn't we fight this problem on another > patch? Looks like bug 9303 is also adding an issue_id. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
