[Koha-bugs] [Bug 9032] Share a list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30953 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 Nick Clemens changed: What|Removed |Added Blocks||20687 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20687 [Bug 20687] Multiple invitations to share lists prevents some users from accepting -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 Patrick Robitaille changed: What|Removed |Added CC||patrick.robitai...@ccsr.qc. ||ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #94 from M. de Rooy --- (In reply to Galen Charlton from comment #93) > Pushed to master, along with my usual set of follow-ups. One follow-up > deserving special mention is the last one, which restores the documented > interpretation of the sharedate column. Thanks for the follow-ups. Retested the feature successfully in current master along with new parameter of cleanup-database. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #93 from Galen Charlton --- Pushed to master, along with my usual set of follow-ups. One follow-up deserving special mention is the last one, which restores the documented interpretation of the sharedate column. Thanks, Marcel! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #92 from M. de Rooy --- Thanks for QA, Jonathan. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #90 from Jonathan Druart --- Created attachment 26587 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26587&action=edit Bug 9032: QA Follow-up: Loop variable and Cancel button To satisfy QA needs: Use loop variable instead of $_ in opac-shareshelf.pl Adds Cancel button to Invite form (prog and bootstrap) in opac-shareshelf.tt. Likewise adds Return link under an error message in opac-shareshelf.tt. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #91 from Jonathan Druart --- Created attachment 26588 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26588&action=edit Bug 9032: QA Follow-up: Adding notices to foreign installer files Adds the notices SHARE_INVITE and SHARE_ACCEPT to sample_notices.sql for the foreign language installer files in installer/data/mysql. Signed-off-by: Marcel de Rooy I tested each installer file by deleting all notices from letter, running the file and counting the records. I did so with and without this patch. The results below show that in each case two notices were added as expected. Note that the English file contains 25 notices including the two new ones. BEFORE THIS PATCH: de-DE/mandatory/sample_notices.sql: 23 notices es-ES/mandatory/sample_notices.sql: 18 notices fr-FR/1-Obligatoire/sample_notices.sql: 18 notices it-IT/necessari/notices.sql: 21 notices nb-NO/1-Obligatorisk/sample_notices.sql: 23 notices pl-PL/mandatory/sample_notices.sql: 18 notices ru-RU/mandatory/sample_notices.sql: 18 notices uk-UA/mandatory/sample_notices.sql: 17 notices AFTER THIS PATCH: de-DE/mandatory/sample_notices.sql: 25 notices es-ES/mandatory/sample_notices.sql: 20 notices fr-FR/1-Obligatoire/sample_notices.sql: 20 notices it-IT/necessari/notices.sql: 23 notices nb-NO/1-Obligatorisk/sample_notices.sql: 25 notices pl-PL/mandatory/sample_notices.sql: 20 notices ru-RU/mandatory/sample_notices.sql: 20 notices uk-UA/mandatory/sample_notices.sql: 19 notices Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #85 from Jonathan Druart --- Created attachment 26582 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26582&action=edit Bug 9032: Unit tests for sharing lists This patch combines some work from report 10389 and 10441. With thanks to Srdjan and Jonathan Druart for their contributions. Adds tests for AddShare, AcceptShare, IsSharedList, RemoveShare. This patch also restores the inadvertently deleted DelShelf tests in bug 10499. Test plan: Run the test VirtualShelves.t Signed-off-by: Marcel de Rooy Rebased and squashed on March 4, 2013. Signed-off-by: Dobrica Pavlinusic Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #83 from Jonathan Druart --- Created attachment 26580 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26580&action=edit Bug 9032: [QA Follow-up] Plackify opac-shareshelf.pl Plackified opac-shareshelf by moving global my variables into hashref. Slightly changed base64ord and base64chr functions to more generic ones. Test plan: Verify if sending an share invitation still works (under prog theme). Signed-off-by: Dobrica Pavlinusic Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #82 from Jonathan Druart --- Created attachment 26579 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26579&action=edit Bug 9032 [Template follow-up] Share a list (part 1: send the invitation) This patch makes a few changes to the "share a list" template: - We don't use tables for layout of forms. This patch corrects the display of the share form to use Koha standard form markup. - Revise the confirmation message displayed after a list is shared to be more readable. - Add a link back to private lists to the confirmation message. - Add T:T markup to make this page display the left-hand navigation which is shown on other patron-related pages when a user is logged in. To test, apply this patch on top of other patches pending for Bug 9032 and confirm that the list share form looks correct and works correctly. Confirm that share confirmation page reads well. Signed-off-by: Marcel de Rooy Rebased March 5, 2014. Signed-off-by: Dobrica Pavlinusic Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #89 from Jonathan Druart --- Created attachment 26586 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26586&action=edit Bug 9032: QA Follow-up: Send cookie with redirect Small fix to resolve a problem Dobrica noted on the report. If you had to login when accepting the share, the cookie was not passed back to the server when redirecting to shelf display. Signed-off-by: Marcel de Rooy Accepted a share while logged in and while not logged in. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #86 from Jonathan Druart --- Created attachment 26583 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26583&action=edit Bug 9032: Consistent behavior when deleting lists DelShelf deletes a list regardless whether it is private, shared or public. HandleDelBorrower had another approach, trying to save shared and public lists by setting the owner to NULL. This patch makes both routines behave consistent. A new report 11889 has been opened to discuss the 'disowning' feature. NOTE: I did not add a db revision here to handle possible cases of lists without owner in the current data. Such public (or shared) lists can still be used without any problem. Bug 11889 and a new planned report for a lists management tool will address this topic further on. After that, all goals of umbrella report 7310 should be realized. Test plan: Create a list P1 with user1 that allows adding by other users. Add a patron (user2). Login as user2 and create some lists, add some items. Let user2 add some entries to P1 too. Delete patron user2. Verify that his lists are gone, but his entries in P1 are kept (nullified). Signed-off-by: Dobrica Pavlinusic Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #88 from Jonathan Druart --- Created attachment 26585 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26585&action=edit Bug 9032: Share a list (database revision for notices) Adds notice SHARE_INVITE in updatedatabase and sample_notices. [Amendation: also adds SHARE_ACCEPT notice.] Test plan: Install or upgrade and verify that you have the new notice under Tools. Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Rebased on March 3, 2014. Amended the patch to add the second notice SHARE_ACCEPT. Tested upgrade with updatestructure step of web installer. Tested install by deleting all notices and running sample_notices.sql NOTE: Will add the notices to the other sql files in the other language directories as soon as this set of patches is ready to be pushed in order to reduce the need to rebase them constantly. Signed-off-by: Dobrica Pavlinusic Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #84 from Jonathan Druart --- Created attachment 26581 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26581&action=edit Bug 9032: Share a list (accept invitation and remove a share) This patch handles: [1] The response (acceptance) by the invited person. If he accepts this share, the private list of the sender will be shown under Your lists on the shelves page. In OPAC 'Your private lists' has been renamed to Your lists (just as in Staff). The Type column shows Private or Shared for these lists; a list appears as Shared as soon as an invitation has been accepted. The owner has the options to Edit, Delete or Share; the invited person does not have these options on the shared list. [2] Removing an accepted share. If a user accepted a share, he should also be able to remove it again. The Remove Share button is visible on OPAC when viewing Your lists or a particular shared list. Note: AddShare has been extended to return a possible database error. If the share invite could not be added, a mail will not be sent. Test plan (for prog theme): Enable pref OpacAllowSharingPrivateLists User 1 creates new private list P1, perms: D-A-D, adds 2 items, sends share User 1 checks your lists display: is P1 Private with Edit button? User 2 accepts share: sees P1, but cannot add or delete items User 2 checks your lists display again: P1 shows Shared without Edit? User 1 checks your lists display again: P1 shows Shared with Edit? User 2 tries to accept share again: should fail now User 3 tries to accept share: should also fail User 3 tries again, modifies shelfnumber and/or key in url: should also fail User 2 creates new private list P2, perms: A-A-A, no items, sends share User 2 checks your lists display: P2 shows Private with Edit? User 1 accepts, adds one item User 1 checks your lists display: P2 shows Shared without Edit? User 2 checks your lists display: P2 shows Shared with Edit? User 2 deletes item of user 1 (allowed) User 2 deletes list P2 User 1 checks your lists display in opac or staff: P2 is gone? User 1 creates private list P3, sends a share. User 1 creates private list P4, adds one item, sends a share. User 2 accepts the share for P3. User 2 checks the shelves display, and removes share P3. User 2 accepts the share for P4. User 2 views shelf P4 with one item and confirms Remove share on that form. User 2 checks shelves display again. Signed-off-by: Marcel de Rooy Rebased on March 3, 2014. Combined changes for AcceptShare and RemoveShare. Signed-off-by: Dobrica Pavlinusic Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #87 from Jonathan Druart --- Created attachment 26584 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26584&action=edit Bug 9032: Follow-up for bootstrap theme Adds new template opac-shareshelf.tt. Modifies template opac-shelves.tt: Share button, Remove Share button, label "Your lists" instead of "Your private lists", list category Shared. Test plan: Verify if the Share a list-features work in bootstrap by: [1] Switch to bootstrap. Go to Lists. [2] Share one of your private lists. [3] Login as another user and accept the invitation. [4] Remove the share again. [5] Check if Share and Remove share do not popup for public lists. Signed-off-by: Dobrica Pavlinusic Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 Jonathan Druart changed: What|Removed |Added Attachment #26292|0 |1 is obsolete|| Attachment #26293|0 |1 is obsolete|| Attachment #26294|0 |1 is obsolete|| Attachment #26295|0 |1 is obsolete|| Attachment #26296|0 |1 is obsolete|| Attachment #26297|0 |1 is obsolete|| Attachment #26298|0 |1 is obsolete|| Attachment #26299|0 |1 is obsolete|| Attachment #26300|0 |1 is obsolete|| Attachment #26351|0 |1 is obsolete|| Attachment #26509|0 |1 is obsolete|| Attachment #26513|0 |1 is obsolete|| --- Comment #80 from Jonathan Druart --- Created attachment 26577 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26577&action=edit Bug 9032: Share a list (part 1: send the invitation) Adds a Share button for OPAC private lists. Allows you to send an invitation to share a list. Checks on validity of email addresses (with Email::Valid). Test plan: 1) Sharing depends on syspref and login. Toggle the pref OpacAllowSharingPrivateList. If enabled, you should see the Share button in OPAC/Private lists. Click on the Share button. You should get Share a list. Logout and try to go back to opac/opac-shareshelf.pl It should now present you the login form. 2) Try to share a public list or a list you do not own. Find a security hole in the interface. Or hack the shareshelf URL and replace the shelfnumber with a public list number. 3) Enter no email address or invalid ones (no domain, forbidden chars). If you enter no address, submit should not work. If you enter only wrong addresses (separated by: ,:; ), you get a message. 4) Test if sending the invitation works. Share one of your private lists. Enter your own email address. After your proc_message_queue cronjob ran, you should have an email. Check also if you see a new record in the virtualshelfshares table. Note that the followup patch handles the second part of accepting this share. Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Rebased. Small amendation: rewording on email notification in template. Signed-off-by: Dobrica Pavlinusic Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #81 from Jonathan Druart --- Created attachment 26578 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26578&action=edit Bug 9032: Followup for new dependency Email::Valid Just adds this dependency to PerlDependencies module. Note from Robin: libemail-valid-perl is in squeeze already. Test plan: You should see Email::Valid now under About/Perl modules. If Email::Valid is not yet installed on your system, please do so. Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Rebased on March 3, 2014. Signed-off-by: Dobrica Pavlinusic Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #79 from M. de Rooy --- Created attachment 26513 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26513&action=edit Bug 9032: QA Follow-up: Adding notices to foreign installer files Adds the notices SHARE_INVITE and SHARE_ACCEPT to sample_notices.sql for the foreign language installer files in installer/data/mysql. Signed-off-by: Marcel de Rooy I tested each installer file by deleting all notices from letter, running the file and counting the records. I did so with and without this patch. The results below show that in each case two notices were added as expected. Note that the English file contains 25 notices including the two new ones. BEFORE THIS PATCH: de-DE/mandatory/sample_notices.sql: 23 notices es-ES/mandatory/sample_notices.sql: 18 notices fr-FR/1-Obligatoire/sample_notices.sql: 18 notices it-IT/necessari/notices.sql: 21 notices nb-NO/1-Obligatorisk/sample_notices.sql: 23 notices pl-PL/mandatory/sample_notices.sql: 18 notices ru-RU/mandatory/sample_notices.sql: 18 notices uk-UA/mandatory/sample_notices.sql: 17 notices AFTER THIS PATCH: de-DE/mandatory/sample_notices.sql: 25 notices es-ES/mandatory/sample_notices.sql: 20 notices fr-FR/1-Obligatoire/sample_notices.sql: 20 notices it-IT/necessari/notices.sql: 23 notices nb-NO/1-Obligatorisk/sample_notices.sql: 25 notices pl-PL/mandatory/sample_notices.sql: 20 notices ru-RU/mandatory/sample_notices.sql: 20 notices uk-UA/mandatory/sample_notices.sql: 19 notices -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #78 from M. de Rooy --- (In reply to Katrin Fischer from comment #76) > I think there are not enough changes to the sample notices to expect a lot > of merge problems in that area. I'd prefer to have the patch ready when > Galen reviews this, so there are no additional dependencies that can get > lost or forgotten. Also the patch should be tested. OK Katrin. I'll still try to do it.. We should have changed this.. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 M. de Rooy changed: What|Removed |Added Attachment #26458|0 |1 is obsolete|| --- Comment #77 from M. de Rooy --- Created attachment 26509 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26509&action=edit Bug 9032: QA Follow-up: Loop variable and Cancel button To satisfy QA needs: Use loop variable instead of $_ in opac-shareshelf.pl Adds Cancel button to Invite form (prog and bootstrap) in opac-shareshelf.tt. Likewise adds Return link under an error message in opac-shareshelf.tt. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #76 from Katrin Fischer --- I think there are not enough changes to the sample notices to expect a lot of merge problems in that area. I'd prefer to have the patch ready when Galen reviews this, so there are no additional dependencies that can get lost or forgotten. Also the patch should be tested. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #75 from M. de Rooy --- (In reply to Jonathan Druart from comment #74) Thanks again. > (In reply to Jonathan Druart from comment #26) > > QA comment: > > - The new letter should be added to others languages. > > So what do you suggest for that? When will your provide a patch? After the > push? As soon as the RM is willing to push, I will do it right away. > > The ergonomic: > > - The page opac-shelves.pl?display=privateshelves displays a link for > > editing and deleting, but a button for sharing. Is it intentional? > > - There is no back button if I enter a bad email address. > > It seems you did not answer on that. Sorry, could have missed that. I fixed the button for bootstrap btw. I left it in prog, since that will go away soon. If you want, I can send a followup for a back button. > (In reply to M. de Rooy from comment #71) > > (In reply to Jonathan Druart from comment #70) > > > 1/ In AddShare: you remove the 10 oldest entries and add 1? What I missed? > > Just housekeeping. 10 is just an arbitrary number. (Could add this at some > > point in cleanup_database.) > > Yes, I am under the impression that the deletion should be done somewhere > else. I suggest to leave it here now, but I will open a new report and move it then to cleanup-database.pl. Agreed? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #74 from Jonathan Druart --- (In reply to Jonathan Druart from comment #26) > QA comment: > - The new letter should be added to others languages. So what do you suggest for that? When will your provide a patch? After the push? > The ergonomic: > - The page opac-shelves.pl?display=privateshelves displays a link for > editing and deleting, but a button for sharing. Is it intentional? > - There is no back button if I enter a bad email address. It seems you did not answer on that. (In reply to M. de Rooy from comment #71) > (In reply to Jonathan Druart from comment #70) > > 1/ In AddShare: you remove the 10 oldest entries and add 1? What I missed? > Just housekeeping. 10 is just an arbitrary number. (Could add this at some > point in cleanup_database.) Yes, I am under the impression that the deletion should be done somewhere else. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #71 from M. de Rooy --- (In reply to Jonathan Druart from comment #70) > QA comment: Thanks for taking a look. > 1/ In AddShare: you remove the 10 oldest entries and add 1? What I missed? Just housekeeping. 10 is just an arbitrary number. (Could add this at some point in cleanup_database.) > 2/ AddShare: > return !$dbh->err; > => useless, $dbh->do insert returns the number of inserted rows. Not sure. Could that be 0E0 ? Think that this is safer. > 3/ C4::VirtualShelves::ShelfPossibleAction > Why do you use numeric code? It should be better to use an readable code. > Moreover, these codes are used in the template. Have been using error numbers in shareshelf everywhere. Would recommend to leave it as-is for now. > 4/ return if !defined($i) || !$i || $i eq '0E0'; #not found > return 1; > Could be replaced with > return 1 if $i > 0 > I think. Not sure about that too. > 6/ (In reply to M. de Rooy from comment #31) > > (In reply to Jonathan Druart from comment #26) > > > - The new letter should be added to others languages. > > I would really get rid of that restriction. I started some development on > > that (look for i18n). But unfortunately there is not that much support for > > it. > Yes, but this one cannot be pushed as it and this one is not marked as > dependent on the other bug report. I abandoned the i18n reports. Getting that into Koha is too much for me on my own. Even reports of this size are hard to get in. In the commit message I wrote that I will add the other 10? languages as soon as this is ready for a push. (It will only trigger more merge conflicts.) > 7/ > opac/opac-shareshelf.pl > + for( 0..$#$alphabet ) > > It could be good to name the variable loop. No big deal. Will do that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #73 from M. de Rooy --- (In reply to Jonathan Druart from comment #70) > 5/ It could be great to replace quotes with simple quotes around sql queries. Can we do that for C4/VirtualShelves.pm on another report (since there are much more double quotes over there) and not put that load here? Will open one for that purpose. Like to wait with code changes of that nature until this code moves.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #72 from M. de Rooy --- Created attachment 26458 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26458&action=edit Bug 9032: QA Follow-up: Use loop variable instead of $_ in opac-shareshelf -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #70 from Jonathan Druart --- QA comment: I did not check if the current code fixes all QA issues raised on comment 26. Additional remarks: 1/ In AddShare: you remove the 10 oldest entries and add 1? What I missed? 2/ AddShare: return !$dbh->err; => useless, $dbh->do insert returns the number of inserted rows. 3/ C4::VirtualShelves::ShelfPossibleAction Why do you use numeric code? It should be better to use an readable code. Moreover, these codes are used in the template. 4/ return if !defined($i) || !$i || $i eq '0E0'; #not found return 1; Could be replaced with return 1 if $i > 0 I think. 5/ It could be great to replace quotes with simple quotes around sql queries. 6/ (In reply to M. de Rooy from comment #31) > (In reply to Jonathan Druart from comment #26) > > - The new letter should be added to others languages. > I would really get rid of that restriction. I started some development on > that (look for i18n). But unfortunately there is not that much support for > it. Yes, but this one cannot be pushed as it and this one is not marked as dependent on the other bug report. 7/ opac/opac-shareshelf.pl + for( 0..$#$alphabet ) It could be good to name the variable loop. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 M. de Rooy changed: What|Removed |Added Blocks||11943 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #69 from M. de Rooy --- (In reply to Dobrica Pavlinusic from comment #67) > Some of patches in this searies might change order because of git bz barfing > on me when changing bug status to signed off more than once, but thay do > apply on top of master as they are ordered now and don't show any diff > compared to my version on disk which I signed off. So, sorry if I re-ordered > them :-) No worries. Looks good. Sent an small fix for the login problem. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #68 from M. de Rooy --- Created attachment 26351 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26351&action=edit Bug 9032: QA Follow-up: Send cookie with redirect Small fix to resolve a problem Dobrica noted on the report. If you had to login when accepting the share, the cookie was not passed back to the server when redirecting to shelf display. Signed-off-by: Marcel de Rooy Accepted a share while logged in and while not logged in. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #67 from Dobrica Pavlinusic --- Some of patches in this searies might change order because of git bz barfing on me when changing bug status to signed off more than once, but thay do apply on top of master as they are ordered now and don't show any diff compared to my version on disk which I signed off. So, sorry if I re-ordered them :-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 Dobrica Pavlinusic changed: What|Removed |Added Attachment #26302|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 Dobrica Pavlinusic changed: What|Removed |Added Attachment #26303|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 Dobrica Pavlinusic changed: What|Removed |Added Attachment #26293|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 Dobrica Pavlinusic changed: What|Removed |Added Attachment #26292|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 Dobrica Pavlinusic changed: What|Removed |Added Attachment #26293|0 |1 is obsolete|| --- Comment #66 from Dobrica Pavlinusic --- Created attachment 26303 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26303&action=edit Bug 9032: Share a list (part 1: send the invitation) Adds a Share button for OPAC private lists. Allows you to send an invitation to share a list. Checks on validity of email addresses (with Email::Valid). Test plan: 1) Sharing depends on syspref and login. Toggle the pref OpacAllowSharingPrivateList. If enabled, you should see the Share button in OPAC/Private lists. Click on the Share button. You should get Share a list. Logout and try to go back to opac/opac-shareshelf.pl It should now present you the login form. 2) Try to share a public list or a list you do not own. Find a security hole in the interface. Or hack the shareshelf URL and replace the shelfnumber with a public list number. 3) Enter no email address or invalid ones (no domain, forbidden chars). If you enter no address, submit should not work. If you enter only wrong addresses (separated by: ,:; ), you get a message. 4) Test if sending the invitation works. Share one of your private lists. Enter your own email address. After your proc_message_queue cronjob ran, you should have an email. Check also if you see a new record in the virtualshelfshares table. Note that the followup patch handles the second part of accepting this share. Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Rebased. Small amendation: rewording on email notification in template. Signed-off-by: Dobrica Pavlinusic -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 Dobrica Pavlinusic changed: What|Removed |Added Attachment #26292|0 |1 is obsolete|| --- Comment #65 from Dobrica Pavlinusic --- Created attachment 26302 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26302&action=edit Bug 9032: Followup for new dependency Email::Valid Just adds this dependency to PerlDependencies module. Note from Robin: libemail-valid-perl is in squeeze already. Test plan: You should see Email::Valid now under About/Perl modules. If Email::Valid is not yet installed on your system, please do so. Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Rebased on March 3, 2014. Signed-off-by: Dobrica Pavlinusic -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 Dobrica Pavlinusic changed: What|Removed |Added Attachment #26291|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 Dobrica Pavlinusic changed: What|Removed |Added Attachment #26253|0 |1 is obsolete|| --- Comment #64 from Dobrica Pavlinusic --- Created attachment 26300 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26300&action=edit Bug 9032: Share a list (database revision for notices) Adds notice SHARE_INVITE in updatedatabase and sample_notices. [Amendation: also adds SHARE_ACCEPT notice.] Test plan: Install or upgrade and verify that you have the new notice under Tools. Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Rebased on March 3, 2014. Amended the patch to add the second notice SHARE_ACCEPT. Tested upgrade with updatestructure step of web installer. Tested install by deleting all notices and running sample_notices.sql NOTE: Will add the notices to the other sql files in the other language directories as soon as this set of patches is ready to be pushed in order to reduce the need to rebase them constantly. Signed-off-by: Dobrica Pavlinusic -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 Dobrica Pavlinusic changed: What|Removed |Added Attachment #25853|0 |1 is obsolete|| --- Comment #61 from Dobrica Pavlinusic --- Created attachment 26297 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26297&action=edit Bug 9032: Unit tests for sharing lists This patch combines some work from report 10389 and 10441. With thanks to Srdjan and Jonathan Druart for their contributions. Adds tests for AddShare, AcceptShare, IsSharedList, RemoveShare. This patch also restores the inadvertently deleted DelShelf tests in bug 10499. Test plan: Run the test VirtualShelves.t Signed-off-by: Marcel de Rooy Rebased and squashed on March 4, 2013. Signed-off-by: Dobrica Pavlinusic -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 Dobrica Pavlinusic changed: What|Removed |Added Attachment #25893|0 |1 is obsolete|| --- Comment #63 from Dobrica Pavlinusic --- Created attachment 26299 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26299&action=edit Bug 9032: Follow-up for bootstrap theme Adds new template opac-shareshelf.tt. Modifies template opac-shelves.tt: Share button, Remove Share button, label "Your lists" instead of "Your private lists", list category Shared. Test plan: Verify if the Share a list-features work in bootstrap by: [1] Switch to bootstrap. Go to Lists. [2] Share one of your private lists. [3] Login as another user and accept the invitation. [4] Remove the share again. [5] Check if Share and Remove share do not popup for public lists. Signed-off-by: Dobrica Pavlinusic -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 Dobrica Pavlinusic changed: What|Removed |Added Attachment #25886|0 |1 is obsolete|| --- Comment #62 from Dobrica Pavlinusic --- Created attachment 26298 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26298&action=edit Bug 9032: Consistent behavior when deleting lists DelShelf deletes a list regardless whether it is private, shared or public. HandleDelBorrower had another approach, trying to save shared and public lists by setting the owner to NULL. This patch makes both routines behave consistent. A new report 11889 has been opened to discuss the 'disowning' feature. NOTE: I did not add a db revision here to handle possible cases of lists without owner in the current data. Such public (or shared) lists can still be used without any problem. Bug 11889 and a new planned report for a lists management tool will address this topic further on. After that, all goals of umbrella report 7310 should be realized. Test plan: Create a list P1 with user1 that allows adding by other users. Add a patron (user2). Login as user2 and create some lists, add some items. Let user2 add some entries to P1 too. Delete patron user2. Verify that his lists are gone, but his entries in P1 are kept (nullified). Signed-off-by: Dobrica Pavlinusic -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 Dobrica Pavlinusic changed: What|Removed |Added Attachment #25852|0 |1 is obsolete|| --- Comment #60 from Dobrica Pavlinusic --- Created attachment 26296 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26296&action=edit Bug 9032: Share a list (accept invitation and remove a share) This patch handles: [1] The response (acceptance) by the invited person. If he accepts this share, the private list of the sender will be shown under Your lists on the shelves page. In OPAC 'Your private lists' has been renamed to Your lists (just as in Staff). The Type column shows Private or Shared for these lists; a list appears as Shared as soon as an invitation has been accepted. The owner has the options to Edit, Delete or Share; the invited person does not have these options on the shared list. [2] Removing an accepted share. If a user accepted a share, he should also be able to remove it again. The Remove Share button is visible on OPAC when viewing Your lists or a particular shared list. Note: AddShare has been extended to return a possible database error. If the share invite could not be added, a mail will not be sent. Test plan (for prog theme): Enable pref OpacAllowSharingPrivateLists User 1 creates new private list P1, perms: D-A-D, adds 2 items, sends share User 1 checks your lists display: is P1 Private with Edit button? User 2 accepts share: sees P1, but cannot add or delete items User 2 checks your lists display again: P1 shows Shared without Edit? User 1 checks your lists display again: P1 shows Shared with Edit? User 2 tries to accept share again: should fail now User 3 tries to accept share: should also fail User 3 tries again, modifies shelfnumber and/or key in url: should also fail User 2 creates new private list P2, perms: A-A-A, no items, sends share User 2 checks your lists display: P2 shows Private with Edit? User 1 accepts, adds one item User 1 checks your lists display: P2 shows Shared without Edit? User 2 checks your lists display: P2 shows Shared with Edit? User 2 deletes item of user 1 (allowed) User 2 deletes list P2 User 1 checks your lists display in opac or staff: P2 is gone? User 1 creates private list P3, sends a share. User 1 creates private list P4, adds one item, sends a share. User 2 accepts the share for P3. User 2 checks the shelves display, and removes share P3. User 2 accepts the share for P4. User 2 views shelf P4 with one item and confirms Remove share on that form. User 2 checks shelves display again. Signed-off-by: Marcel de Rooy Rebased on March 3, 2014. Combined changes for AcceptShare and RemoveShare. Signed-off-by: Dobrica Pavlinusic -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 Dobrica Pavlinusic changed: What|Removed |Added Attachment #25851|0 |1 is obsolete|| --- Comment #59 from Dobrica Pavlinusic --- Created attachment 26295 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26295&action=edit Bug 9032: [QA Follow-up] Plackify opac-shareshelf.pl Plackified opac-shareshelf by moving global my variables into hashref. Slightly changed base64ord and base64chr functions to more generic ones. Test plan: Verify if sending an share invitation still works (under prog theme). Signed-off-by: Dobrica Pavlinusic -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 Dobrica Pavlinusic changed: What|Removed |Added Attachment #25850|0 |1 is obsolete|| --- Comment #58 from Dobrica Pavlinusic --- Created attachment 26294 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26294&action=edit Bug 9032 [Template follow-up] Share a list (part 1: send the invitation) This patch makes a few changes to the "share a list" template: - We don't use tables for layout of forms. This patch corrects the display of the share form to use Koha standard form markup. - Revise the confirmation message displayed after a list is shared to be more readable. - Add a link back to private lists to the confirmation message. - Add T:T markup to make this page display the left-hand navigation which is shown on other patron-related pages when a user is logged in. To test, apply this patch on top of other patches pending for Bug 9032 and confirm that the list share form looks correct and works correctly. Confirm that share confirmation page reads well. Signed-off-by: Marcel de Rooy Rebased March 5, 2014. Signed-off-by: Dobrica Pavlinusic -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #57 from Dobrica Pavlinusic --- Created attachment 26293 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26293&action=edit Bug 9032: Share a list (part 1: send the invitation) Adds a Share button for OPAC private lists. Allows you to send an invitation to share a list. Checks on validity of email addresses (with Email::Valid). Test plan: 1) Sharing depends on syspref and login. Toggle the pref OpacAllowSharingPrivateList. If enabled, you should see the Share button in OPAC/Private lists. Click on the Share button. You should get Share a list. Logout and try to go back to opac/opac-shareshelf.pl It should now present you the login form. 2) Try to share a public list or a list you do not own. Find a security hole in the interface. Or hack the shareshelf URL and replace the shelfnumber with a public list number. 3) Enter no email address or invalid ones (no domain, forbidden chars). If you enter no address, submit should not work. If you enter only wrong addresses (separated by: ,:; ), you get a message. 4) Test if sending the invitation works. Share one of your private lists. Enter your own email address. After your proc_message_queue cronjob ran, you should have an email. Check also if you see a new record in the virtualshelfshares table. Note that the followup patch handles the second part of accepting this share. Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Rebased. Small amendation: rewording on email notification in template. Signed-off-by: Dobrica Pavlinusic -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 Dobrica Pavlinusic changed: What|Removed |Added Attachment #25849|0 |1 is obsolete|| --- Comment #56 from Dobrica Pavlinusic --- Created attachment 26292 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26292&action=edit Bug 9032: Followup for new dependency Email::Valid Just adds this dependency to PerlDependencies module. Note from Robin: libemail-valid-perl is in squeeze already. Test plan: You should see Email::Valid now under About/Perl modules. If Email::Valid is not yet installed on your system, please do so. Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Rebased on March 3, 2014. Signed-off-by: Dobrica Pavlinusic -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 Dobrica Pavlinusic changed: What|Removed |Added Attachment #25848|0 |1 is obsolete|| --- Comment #55 from Dobrica Pavlinusic --- Created attachment 26291 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26291&action=edit Bug 9032: Followup for new dependency Email::Valid Just adds this dependency to PerlDependencies module. Note from Robin: libemail-valid-perl is in squeeze already. Test plan: You should see Email::Valid now under About/Perl modules. If Email::Valid is not yet installed on your system, please do so. Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Rebased on March 3, 2014. Signed-off-by: Dobrica Pavlinusic -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 Dobrica Pavlinusic changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 Dobrica Pavlinusic changed: What|Removed |Added CC||dpav...@rot13.org --- Comment #54 from Dobrica Pavlinusic --- I was testing this patch and when I copy/paste URL without being logged in into OPAC I get following error: ERROR: You do not have adequate permission for that action on list 1330. However, after that, I'm not logged in into OPAC. If I login after that I indeed see shared list and everything works fine. This might be problem with Koha login mechanism instead of this patch, but it's just interesting to note. If I'm already logged in into OPAC it works as expected. Other than that, this patch provides very useful addition to Koha, thanks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #53 from M. de Rooy --- Trivial rebase of the dbrev for easier signoff :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 M. de Rooy changed: What|Removed |Added Attachment #25847|0 |1 is obsolete|| --- Comment #52 from M. de Rooy --- Created attachment 26253 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26253&action=edit Bug 9032: Share a list (database revision for notices) Adds notice SHARE_INVITE in updatedatabase and sample_notices. [Amendation: also adds SHARE_ACCEPT notice.] Test plan: Install or upgrade and verify that you have the new notice under Tools. Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Rebased on March 3, 2014. Amended the patch to add the second notice SHARE_ACCEPT. Tested upgrade with updatestructure step of web installer. Tested install by deleting all notices and running sample_notices.sql NOTE: Will add the notices to the other sql files in the other language directories as soon as this set of patches is ready to be pushed in order to reduce the need to rebase them constantly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 M. de Rooy changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=11889 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 M. de Rooy changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #51 from M. de Rooy --- This is ready for signoff again. Note that some of the patches already had a signoff. Some have been amended while rebasing (as noted). Some patches are new. In other words: Please help to get this further. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #50 from M. de Rooy --- Created attachment 25893 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25893&action=edit Bug 9032: Follow-up for bootstrap theme Adds new template opac-shareshelf.tt. Modifies template opac-shelves.tt: Share button, Remove Share button, label "Your lists" instead of "Your private lists", list category Shared. Test plan: Verify if the Share a list-features work in bootstrap by: [1] Switch to bootstrap. Go to Lists. [2] Share one of your private lists. [3] Login as another user and accept the invitation. [4] Remove the share again. [5] Check if Share and Remove share do not popup for public lists. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 M. de Rooy changed: What|Removed |Added Attachment #25862|0 |1 is obsolete|| --- Comment #49 from M. de Rooy --- Created attachment 25886 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25886&action=edit Bug 9032: Consistent behavior when deleting lists DelShelf deletes a list regardless whether it is private, shared or public. HandleDelBorrower had another approach, trying to save shared and public lists by setting the owner to NULL. This patch makes both routines behave consistent. A new report 11889 has been opened to discuss the 'disowning' feature. NOTE: I did not add a db revision here to handle possible cases of lists without owner in the current data. Such public (or shared) lists can still be used without any problem. Bug 11889 and a new planned report for a lists management tool will address this topic further on. After that, all goals of umbrella report 7310 should be realized. Test plan: Create a list P1 with user1 that allows adding by other users. Add a patron (user2). Login as user2 and create some lists, add some items. Let user2 add some entries to P1 too. Delete patron user2. Verify that his lists are gone, but his entries in P1 are kept (nullified). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #48 from M. de Rooy --- Created attachment 25862 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25862&action=edit Bug 9032: Consistent behavior when deleting lists DelShelf deletes a list regardless whether it is private, shared or public. HandleDelBorrower had another approach, trying to save shared and public lists by setting the owner to NULL. This patch makes both routines behave consistent. A new report 11889 has been opened to discuss the 'disowning' feature. Test plan: Create a list P1 with user1 that allows adding by other users. Add a patron (user2). Login as user2 and create some lists, add some items. Let user2 add some entries to P1 too. Delete patron user2. Verify that his lists are gone, but his entries in P1 are kept (nullified). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #46 from M. de Rooy --- Created attachment 25853 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25853&action=edit Bug 9032: Unit tests for sharing lists This patch combines some work from report 10389 and 10441. With thanks to Srdjan and Jonathan Druart for their contributions. Adds tests for AddShare, AcceptShare, IsSharedList, RemoveShare. This patch also restores the inadvertently deleted DelShelf tests in bug 10499. Test plan: Run the test VirtualShelves.t Signed-off-by: Marcel de Rooy Rebased and squashed on March 4, 2013. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #47 from M. de Rooy --- Before changing the status, I will still add at lease one patch. This is to handle the bootstrap theme. Still thinking about one additional point too.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #45 from M. de Rooy --- Created attachment 25852 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25852&action=edit Bug 9032: Share a list (accept invitation and remove a share) This patch handles: [1] The response (acceptance) by the invited person. If he accepts this share, the private list of the sender will be shown under Your lists on the shelves page. In OPAC 'Your private lists' has been renamed to Your lists (just as in Staff). The Type column shows Private or Shared for these lists; a list appears as Shared as soon as an invitation has been accepted. The owner has the options to Edit, Delete or Share; the invited person does not have these options on the shared list. [2] Removing an accepted share. If a user accepted a share, he should also be able to remove it again. The Remove Share button is visible on OPAC when viewing Your lists or a particular shared list. Note: AddShare has been extended to return a possible database error. If the share invite could not be added, a mail will not be sent. Test plan (for prog theme): Enable pref OpacAllowSharingPrivateLists User 1 creates new private list P1, perms: D-A-D, adds 2 items, sends share User 1 checks your lists display: is P1 Private with Edit button? User 2 accepts share: sees P1, but cannot add or delete items User 2 checks your lists display again: P1 shows Shared without Edit? User 1 checks your lists display again: P1 shows Shared with Edit? User 2 tries to accept share again: should fail now User 3 tries to accept share: should also fail User 3 tries again, modifies shelfnumber and/or key in url: should also fail User 2 creates new private list P2, perms: A-A-A, no items, sends share User 2 checks your lists display: P2 shows Private with Edit? User 1 accepts, adds one item User 1 checks your lists display: P2 shows Shared without Edit? User 2 checks your lists display: P2 shows Shared with Edit? User 2 deletes item of user 1 (allowed) User 2 deletes list P2 User 1 checks your lists display in opac or staff: P2 is gone? User 1 creates private list P3, sends a share. User 1 creates private list P4, adds one item, sends a share. User 2 accepts the share for P3. User 2 checks the shelves display, and removes share P3. User 2 accepts the share for P4. User 2 views shelf P4 with one item and confirms Remove share on that form. User 2 checks shelves display again. Signed-off-by: Marcel de Rooy Rebased on March 3, 2014. Combined changes for AcceptShare and RemoveShare. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #44 from M. de Rooy --- Created attachment 25851 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25851&action=edit Bug 9032: [QA Follow-up] Plackify opac-shareshelf.pl Plackified opac-shareshelf by moving global my variables into hashref. Slightly changed base64ord and base64chr functions to more generic ones. Test plan: Verify if sending an share invitation still works (under prog theme). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #43 from M. de Rooy --- Created attachment 25850 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25850&action=edit Bug 9032 [Template follow-up] Share a list (part 1: send the invitation) This patch makes a few changes to the "share a list" template: - We don't use tables for layout of forms. This patch corrects the display of the share form to use Koha standard form markup. - Revise the confirmation message displayed after a list is shared to be more readable. - Add a link back to private lists to the confirmation message. - Add T:T markup to make this page display the left-hand navigation which is shown on other patron-related pages when a user is logged in. To test, apply this patch on top of other patches pending for Bug 9032 and confirm that the list share form looks correct and works correctly. Confirm that share confirmation page reads well. Signed-off-by: Marcel de Rooy Rebased March 5, 2014. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #42 from M. de Rooy --- Created attachment 25849 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25849&action=edit Bug 9032: Share a list (part 1: send the invitation) Adds a Share button for OPAC private lists. Allows you to send an invitation to share a list. Checks on validity of email addresses (with Email::Valid). Test plan: 1) Sharing depends on syspref and login. Toggle the pref OpacAllowSharingPrivateList. If enabled, you should see the Share button in OPAC/Private lists. Click on the Share button. You should get Share a list. Logout and try to go back to opac/opac-shareshelf.pl It should now present you the login form. 2) Try to share a public list or a list you do not own. Find a security hole in the interface. Or hack the shareshelf URL and replace the shelfnumber with a public list number. 3) Enter no email address or invalid ones (no domain, forbidden chars). If you enter no address, submit should not work. If you enter only wrong addresses (separated by: ,:; ), you get a message. 4) Test if sending the invitation works. Share one of your private lists. Enter your own email address. After your proc_message_queue cronjob ran, you should have an email. Check also if you see a new record in the virtualshelfshares table. Note that the followup patch handles the second part of accepting this share. Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Rebased. Small amendation: rewording on email notification in template. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #41 from M. de Rooy --- Created attachment 25848 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25848&action=edit Bug 9032: Followup for new dependency Email::Valid Just adds this dependency to PerlDependencies module. Note from Robin: libemail-valid-perl is in squeeze already. Test plan: You should see Email::Valid now under About/Perl modules. If Email::Valid is not yet installed on your system, please do so. Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Rebased on March 3, 2014. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #40 from M. de Rooy --- Created attachment 25847 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25847&action=edit Bug 9032: Share a list (database revision for notices) Adds notice SHARE_INVITE in updatedatabase and sample_notices. [Amendation: also adds SHARE_ACCEPT notice.] Test plan: Install or upgrade and verify that you have the new notice under Tools. Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Rebased on March 3, 2014. Amended the patch to add the second notice SHARE_ACCEPT. Tested upgrade with updatestructure step of web installer. Tested install by deleting all notices and running sample_notices.sql NOTE: Will add the notices to the other sql files in the other language directories as soon as this set of patches is ready to be pushed in order to reduce the need to rebase them constantly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 M. de Rooy changed: What|Removed |Added Attachment #19935|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 M. de Rooy changed: What|Removed |Added Attachment #19934|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 M. de Rooy changed: What|Removed |Added Attachment #19378|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 M. de Rooy changed: What|Removed |Added Attachment #19377|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 M. de Rooy changed: What|Removed |Added Blocks||8262 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #39 from M. de Rooy --- Hope to revive this development next week by rebasing, making the requested QA changes and including work from the former dependency bug 10389 and bug 10441. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 M. de Rooy changed: What|Removed |Added Summary|Share a list (part 1: send |Share a list |the invitation) | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 M. de Rooy changed: What|Removed |Added Blocks|10389 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 M. de Rooy changed: What|Removed |Added Blocks|10441 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #38 from Jonathan Druart --- (In reply to M. de Rooy from comment #37) > Jonathan, > You convinced me for the Plack reason. > > But your other argument? > Note that PBP on the opposite tends to move to using lexical variables > instead of global package vars (where possible). So we should not use our if > we can solve it differently. In this case for example, i could pass lower my > variables via parameters.. Hello Marcel, It is a vocabulary issue :) What I wrongly called a global variable was a variable declared outside of the routine where it is used. Obviously, passing the variables in parameter is better than declaring them as global (our). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #37 from M. de Rooy --- Jonathan, You convinced me for the Plack reason. But your other argument? Note that PBP on the opposite tends to move to using lexical variables instead of global package vars (where possible). So we should not use our if we can solve it differently. In this case for example, i could pass lower my variables via parameters.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #36 from M. de Rooy --- (In reply to Jonathan Druart from comment #34) > That does not work with Plack. > Moreover, using global variables is not a good practice. Thanks. I was somewhat expecting to hear Plack coming :) We should add this to the coding guidelines. It is not there yet. For the record, I did not use global variables (my variables are lexical). Do you have a reference to a best practice or so about not using lexical variables on 'root level'? This is not in the coding guidelines too? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #35 from Jonathan Druart --- With Plack, on opac-shareshelf.pl?shelfnumber=1, I got an error 500 (internal server error) with the following in logs: Variable "$op" is not available at /home/koha/src/opac/opac-shareshelf.pl line 70. Variable "$errcode" is not available at /home/koha/src/opac/opac-shareshelf.pl line 71. Variable "$shelfnumber" is not available at /home/koha/src/opac/opac-shareshelf.pl line 74. Variable "@addr" is not available at /home/koha/src/opac/opac-shareshelf.pl line 91. Variable "$errcode" is not available at /home/koha/src/opac/opac-shareshelf.pl line 95. Variable "$addrlist" is not available at /home/koha/src/opac/opac-shareshelf.pl line 104. Variable "$fail_addr" is not available at /home/koha/src/opac/opac-shareshelf.pl line 105. Variable "@addr" is not available at /home/koha/src/opac/opac-shareshelf.pl line 110. Variable "$shelfnumber" is not available at /home/koha/src/opac/opac-shareshelf.pl line 121. Variable "@addr" is not available at /home/koha/src/opac/opac-shareshelf.pl line 125. Variable "@newkey" is not available at /home/koha/src/opac/opac-shareshelf.pl line 126. Variable "$loggedinuser" is not available at /home/koha/src/opac/opac-shareshelf.pl line 133. Variable "$shelfname" is not available at /home/koha/src/opac/opac-shareshelf.pl line 135. Variable "$shelfname" is not available at /home/koha/src/opac/opac-shareshelf.pl line 154. Variable "$owner" is not available at /home/koha/src/opac/opac-shareshelf.pl line 154. Variable "$shelfnumber" is not available at /home/koha/src/opac/opac-shareshelf.pl line 154. Variable "$errcode" is not available at /home/koha/src/opac/opac-shareshelf.pl line 155. Variable "$loggedinuser" is not available at /home/koha/src/opac/opac-shareshelf.pl line 155. Variable "$template" is not available at /home/koha/src/opac/opac-shareshelf.pl line 162. Variable "$loggedinuser" is not available at /home/koha/src/opac/opac-shareshelf.pl line 162. Variable "$cookie" is not available at /home/koha/src/opac/opac-shareshelf.pl line 162. Variable "$query" is not available at /home/koha/src/opac/opac-shareshelf.pl line 164. Variable "$template" is not available at /home/koha/src/opac/opac-shareshelf.pl line 171. Variable "$errcode" is not available at /home/koha/src/opac/opac-shareshelf.pl line 172. Variable "$op" is not available at /home/koha/src/opac/opac-shareshelf.pl line 173. Variable "$shelfnumber" is not available at /home/koha/src/opac/opac-shareshelf.pl line 174. Variable "$shelfname" is not available at /home/koha/src/opac/opac-shareshelf.pl line 175. Variable "@addr" is not available at /home/koha/src/opac/opac-shareshelf.pl line 176. Variable "$fail_addr" is not available at /home/koha/src/opac/opac-shareshelf.pl line 177. Variable "@base64alphabet" is not available at /home/koha/src/opac/opac-shareshelf.pl line 225. no query in gettemplate at /home/koha/src/C4/Templates.pm line 232. no query in themelanguage at /home/koha/src/C4/Templates.pm line 282. Can't call method "cookie" on an undefined value at /home/koha/src/C4/Templates.pm line 331. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #34 from Jonathan Druart --- (In reply to M. de Rooy from comment #33) > (In reply to Jonathan Druart from comment #32) > > If you use a global variable in a routine, you should declare it as 'our' > > instead of 'my'. > These variables are only used in some subroutines of this script, > eliminating the need for passing them as parameters. I do not need them to > be (global) package variables. A lexical variable declared with my is > sufficient here. That does not work with Plack. Moreover, using global variables is not a good practice. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #33 from M. de Rooy --- (In reply to Jonathan Druart from comment #32) > If you use a global variable in a routine, you should declare it as 'our' > instead of 'my'. These variables are only used in some subroutines of this script, eliminating the need for passing them as parameters. I do not need them to be (global) package variables. A lexical variable declared with my is sufficient here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #32 from Jonathan Druart --- (In reply to M. de Rooy from comment #31) > (In reply to Jonathan Druart from comment #26) > First of all, thanks for your QA, although the results were negative :) > > > - The new letter should be added to others languages. > I would really get rid of that restriction. I started some development on > that (look for i18n). But unfortunately there is not that much support for > it. So should this patch depends on them? > > - The new pl file contains a lot of routines. Some of them use global > > variables which are not defined as global. > Please explain. If you use a global variable in a routine, you should declare it as 'our' instead of 'my'. > > Marked as Failed QA. > If this should really fail for the reasons given, I will have to let this > development rest for some time. I do not have the time to keep everything in > the air now ;) Note that this impacts also unit tests and the accept a > share-followup reports. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #31 from M. de Rooy --- (In reply to Jonathan Druart from comment #26) First of all, thanks for your QA, although the results were negative :) > - The new letter should be added to others languages. I would really get rid of that restriction. I started some development on that (look for i18n). But unfortunately there is not that much support for it. > - The new pl file contains a lot of routines. Some of them use global > variables which are not defined as global. Please explain. > Marked as Failed QA. If this should really fail for the reasons given, I will have to let this development rest for some time. I do not have the time to keep everything in the air now ;) Note that this impacts also unit tests and the accept a share-followup reports. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #30 from Katrin Fischer --- I think the only messages digested like Owen describes are the checkin and checkout slips - so maybe we could turn it around and have a setting to only send those out every x minutes? I think the other mails could be sent out pretty immediately after being generated without problems. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #29 from Galen Charlton --- (In reply to Owen Leonard from comment #28) > (In reply to Galen Charlton from comment #27) > > I disagree with this. There is nothing preventing process_message_queue.pl > > from being run more frequently; > > This is the same issue that came up in discussions of Bug 7067 - allow > patron self registration via the opac. If your patrons are registering > through the OPAC and expecting a confirmation email you would want > process_message_queue.pl to run as often as once a minute. The snag is that > then your message queue "digest" options don't work because the digest never > has the time to accumulate messages. Fair point. One possibility would be to allow certain message types be marked as high-priority (which would include the interpretation that they're not meant to ever be digested), then add a switch to process_message_queue.pl to have it process just the high-priority ones. I'm willing to put a bit of time into that if folks are amenable to this approach. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #28 from Owen Leonard --- (In reply to Galen Charlton from comment #27) > I disagree with this. There is nothing preventing process_message_queue.pl > from being run more frequently; This is the same issue that came up in discussions of Bug 7067 - allow patron self registration via the opac. If your patrons are registering through the OPAC and expecting a confirmation email you would want process_message_queue.pl to run as often as once a minute. The snag is that then your message queue "digest" options don't work because the digest never has the time to accumulate messages. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 Galen Charlton changed: What|Removed |Added CC||gmcha...@gmail.com --- Comment #27 from Galen Charlton --- (In reply to Jonathan Druart from comment #26) > The invitation is sent to the message queue. The doc suggests > process_message_queue.pl runs every 1 to 4 hours. We can imagine that a user > tells to his friend: "I just share a list with you. You will receive an > email!". The friend refresh, refresh, refresh his inbox and nothing append. > The guy will resent the invitation again and again :) > I have 2 suggestions: > * directly use the sendmail command. I disagree with this. There is nothing preventing process_message_queue.pl from being run more frequently; in fact, the crontab that goes with the Debian package runs it every 15 minutes -- and it would be reasonable for a library to run it more frequently. I would be loath to give up the centralization and templating options that the message queue gives us. I see that crontab.example does need to be updated, though: it runs the message queue every hour, and it probably wouldn't hurt to bump up the frequencye. > * Add a check: if an invitation for this list and this email address has > been sent some time ago, an alert is raised and no new invitation is sent. This would be reasonable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@biblibre.co ||m --- Comment #26 from Jonathan Druart --- QA comment: The code: - Perltidies the new file please. - Use the CPLv3 license: FAILopac/opac-shareshelf.pl FAIL forbidden patterns forbidden pattern: Koha is now under the GPLv3 license (line 9) - The new letter should be added to others languages. - The new pl file contains a lot of routines. Some of them use global variables which are not defined as global. - Maybe SHARE_INVITATION_EXPIRY_DAYS should be a new syspref? Hum... or not. - Note that ADDDATE is a mysqlism, but Koha doesn't offer a better way to do. The ergonomic: - The page opac-shelves.pl?display=privateshelves displays a link for editing and deleting, but a button for sharing. Is it intentional? - There is no back button if I enter a bad email address. The feature: The invitation is sent to the message queue. The doc suggests process_message_queue.pl runs every 1 to 4 hours. We can imagine that a user tells to his friend: "I just share a list with you. You will receive an email!". The friend refresh, refresh, refresh his inbox and nothing append. The guy will resent the invitation again and again :) I have 2 suggestions: * directly use the sendmail command. * Add a check: if an invitation for this list and this email address has been sent some time ago, an alert is raised and no new invitation is sent. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #25 from M. de Rooy --- Rebased the last two patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #24 from M. de Rooy --- Created attachment 19935 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19935&action=edit Bug 9032 [Template follow-up] Share a list (part 1: send the invitation) This patch makes a few changes to the "share a list" template: - We don't use tables for layout of forms. This patch corrects the display of the share form to use Koha standard form markup. - Revise the confirmation message displayed after a list is shared to be more readable. - Add a link back to private lists to the confirmation message. - Add T:T markup to make this page display the left-hand navigation which is shown on other patron-related pages when a user is logged in. To test, apply this patch on top of other patches pending for Bug 9032 and confirm that the list share form looks correct and works correctly. Confirm that share confirmation page reads well. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 M. de Rooy changed: What|Removed |Added Attachment #19379|0 |1 is obsolete|| Attachment #19394|0 |1 is obsolete|| --- Comment #23 from M. de Rooy --- Created attachment 19934 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19934&action=edit Bug 9032: Share a list (part 1: send the invitation) Adds a Share button for OPAC private lists. Allows you to send an invitation to share a list. Checks on validity of email addresses (with Email::Valid). NOTE: This patch adds a routine to VirtualShelves.pm but does not add a test in VirtualShelves.t. This is intentional: I will still add a test, but saw report 10290 and came across a few other problems in this unit test. Will add a patch under report 10386. Test plan: 1) Sharing depends on syspref and login. Toggle the pref OpacAllowSharingPrivateList. If enabled, you should see the Share button in OPAC/Private lists. Click on the Share button. You should get Share a list. Logout and try to go back to opac/opac-shareshelf.pl It should now present you the login form. 2) Try to share a public list or a list you do not own. Find a security hole in the interface. Or hack the shareshelf URL and replace the shelfnumber with a public list number. 3) Enter no email address or invalid ones (no domain, forbidden chars). If you enter no address, submit should not work. If you enter only wrong addresses (separated by: ,:; ), you get a message. 4) Test if sending the invitation works. Share one of your private lists. Enter your own email address. After your proc_message_queue cronjob ran, you should have an email. Check also if you see a new record in the virtualshelfshares table. Note that the followup patch handles the second part of accepting this share. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #22 from M. de Rooy --- (In reply to Owen Leonard from comment #20) > Note to QA: Because of the order in which the patches were signed off the > first one, "[Template follow-up] Share a list (part 1: send the invitation)" > should be applied last. I have rearranged the order. Thanks Owen for testing. QA: These patches are ready for QA, separate from the followup reports. They can stay in the QA queue, if they pass, until at least part2 comes along (bug 10389). Will submit patches for that soon. Part 3 will handle the orphaned lists and permissions for taking ownership, moderating public/shared list names. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 M. de Rooy changed: What|Removed |Added Attachment #19394|Bug 9032 [Template |[SIGNED_OFF] Bug 9032 description|follow-up] Share a list |[Template follow-up] Share |(part 1: send the |a list (part 1: send the |invitation) |invitation) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 M. de Rooy changed: What|Removed |Added Attachment #18692|0 |1 is obsolete|| --- Comment #21 from M. de Rooy --- Created attachment 19394 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19394&action=edit Bug 9032 [Template follow-up] Share a list (part 1: send the invitation) This patch makes a few changes to the "share a list" template: - We don't use tables for layout of forms. This patch corrects the display of the share form to use Koha standard form markup. - Revise the confirmation message displayed after a list is shared to be more readable. - Add a link back to private lists to the confirmation message. - Add T:T markup to make this page display the left-hand navigation which is shown on other patron-related pages when a user is logged in. To test, apply this patch on top of other patches pending for Bug 9032 and confirm that the list share form looks correct and works correctly. Confirm that share confirmation page reads well. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 M. de Rooy changed: What|Removed |Added Attachment #19394|[SIGNED_OFF] Bug 9032 |[SIGNED-OFF] Bug 9032 description|[Template follow-up] Share |[Template follow-up] Share |a list (part 1: send the|a list (part 1: send the |invitation) |invitation) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #20 from Owen Leonard --- Note to QA: Because of the order in which the patches were signed off the first one, "[Template follow-up] Share a list (part 1: send the invitation)" should be applied last. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 Owen Leonard changed: What|Removed |Added Attachment #18619|0 |1 is obsolete|| --- Comment #19 from Owen Leonard --- Created attachment 19379 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19379&action=edit [SIGNED-OFF] Bug 9032: Share a list (part 1: send the invitation) Adds a Share button for OPAC private lists. Allows you to send an invitation to share a list. Checks on validity of email addresses (with Email::Valid). NOTE: This patch adds a routine to VirtualShelves.pm but does not add a test in VirtualShelves.t. This is intentional: I will still add a test, but saw report 10290 and came across a few other problems in this unit test. Will add a patch under report 10386. Test plan: 1) Sharing depends on syspref and login. Toggle the pref OpacAllowSharingPrivateList. If enabled, you should see the Share button in OPAC/Private lists. Click on the Share button. You should get Share a list. Logout and try to go back to opac/opac-shareshelf.pl It should now present you the login form. 2) Try to share a public list or a list you do not own. Find a security hole in the interface. Or hack the shareshelf URL and replace the shelfnumber with a public list number. 3) Enter no email address or invalid ones (no domain, forbidden chars). If you enter no address, submit should not work. If you enter only wrong addresses (separated by: ,:; ), you get a message. 4) Test if sending the invitation works. Share one of your private lists. Enter your own email address. After your proc_message_queue cronjob ran, you should have an email. Check also if you see a new record in the virtualshelfshares table. Note that the followup patch handles the second part of accepting this share. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 Owen Leonard changed: What|Removed |Added Attachment #18547|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
