[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

--- Comment #87 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 33947
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33947action=edit
Bug 9043: Add a wonderful image

This patch adds the missing multiple-select.png image.

Test plan:
- search the pref 'advsearch'
- without this patch, you get a 404 error for the image
- with this patch, you don't get the error but a wonderful image on the
  right of the multiple pref

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

--- Comment #88 from Tomás Cohen Arazi tomasco...@gmail.com ---
Minor followup pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-11-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

--- Comment #84 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 33617
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33617action=edit
Bug 9043: The comma (,) should be kept to separate multi-valuated prefs

The prefs language and opaclanguages used the comma to separate the
different values.

The new prefs OpacAdvSearchMoreOptions and OpacAdvSearchOptions should
do the same.

To reproduce the issue: update the language pref (or opaclanguages) and
refresh the page.
= The pref values are not checked anymore and the language selection
(bottom of the page) does not appear.

Test plan:
1/ Verify that the behavior described above is fixed.
2/ Verify that the original test plan of bug 9043 still passes.

Note: The 2 OpacAdvSearchMoreOptions and OpacAdvSearchOptions pref
values are overwritten but the feature have just been pushed recently.
It should not affect a production environment.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-11-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

  Attachment #33617|0   |1
is obsolete||

--- Comment #85 from Owen Leonard oleon...@myacpl.org ---
Created attachment 33620
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33620action=edit
[SIGNED-OFF] Bug 9043: The comma (,) should be kept to separate multi-valuated
prefs

The prefs language and opaclanguages used the comma to separate the
different values.

The new prefs OpacAdvSearchMoreOptions and OpacAdvSearchOptions should
do the same.

To reproduce the issue: update the language pref (or opaclanguages) and
refresh the page.
= The pref values are not checked anymore and the language selection
(bottom of the page) does not appear.

Test plan:
1/ Verify that the behavior described above is fixed.
2/ Verify that the original test plan of bug 9043 still passes.

Note: The 2 OpacAdvSearchMoreOptions and OpacAdvSearchOptions pref
values are overwritten but the feature have just been pushed recently.
It should not affect a production environment.

Signed-off-by: Owen Leonard oleon...@myacpl.org

I was able to reproduce the issue and verify that this patch corrected
the problem. Langage selection and OpacAdvSearchOptions worked
correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-11-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

--- Comment #86 from Tomás Cohen Arazi tomasco...@gmail.com ---
Followup pushed to master.

Thanks Jonathan and Owen for the fast response!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-11-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Marjorie Barry-Vila marjorie.barry-v...@ccsr.qc.ca changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-11-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #31557|0   |1
is obsolete||
  Attachment #31558|0   |1
is obsolete||
  Attachment #31559|0   |1
is obsolete||
  Attachment #31560|0   |1
is obsolete||
  Attachment #31561|0   |1
is obsolete||

--- Comment #78 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 33428
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33428action=edit
Bug 9043: Syspref improvement: add new type multiple

This patch adds a new type multiple for syspref.
This new type allows to select several values for one syspref.

Signed-off-by: Koha Team Lyon 3 k...@univ-lyon3.fr
Signed-off-by: Jacek Ablewicz a...@biblos.pk.edu.pl

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-11-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

--- Comment #79 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 33429
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33429action=edit
Bug 9043: Changes to the advanced search page

This patch adds 2 new sysprefs: OpacAdvSearchOptions and
OpacAdvSearchMoreOptions.

These sysprefs are multivalued and you can add or remove some elements on
the adv search page.

This patch allows to display/hide some entries in the advanced search
page at the OPAC.
On this way, it is possible to configure the search options to display.

Test plan:
1/
Fill OpacAdvSearchOptions with Item types and Languages.
Fill OpacAdvSearchMoreOptions with Item types, Languages and Location.
On the advanced search page, verify the Location is only displayed for
the More options view.
2/ Try different settings for these prefs
3/ Remove all entries for the OpacAdvSearchMoreOptions and verify that
the More options does not displayed additional options.
4/ Remove all entries for the OpacAdvSearchOptions and verify that the
normal view does not displayed any options.

Note that this patch only affects the bootstrap theme.

Signed-off-by: Koha Team Lyon 3 k...@univ-lyon3.fr
Signed-off-by: Jacek Ablewicz a...@biblos.pk.edu.pl

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-11-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

--- Comment #80 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 33430
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33430action=edit
Bug 9043: Add the multiple select jquery plugin

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-11-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

--- Comment #82 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 33432
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33432action=edit
Bug 9043 [QA Followup] - Don't show More options are there aren't any

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-11-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

--- Comment #81 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 33431
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33431action=edit
Bug 9043: Make strings translatable

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-11-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #83 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patches pushed to master.

Thanks Jonathan! Nice addition!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #30967|0   |1
is obsolete||
  Attachment #30968|0   |1
is obsolete||
  Attachment #30969|0   |1
is obsolete||
  Attachment #31170|0   |1
is obsolete||

--- Comment #72 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 31557
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31557action=edit
[PASSED QA] Bug 9043: Syspref improvement: add new type multiple

This patch adds a new type multiple for syspref.
This new type allows to select several values for one syspref.

Signed-off-by: Koha Team Lyon 3 k...@univ-lyon3.fr
Signed-off-by: Jacek Ablewicz a...@biblos.pk.edu.pl

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

--- Comment #74 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 31559
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31559action=edit
[PASSED QA] Bug 9043: Add the multiple select jquery plugin

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

--- Comment #76 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 31561
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31561action=edit
[PASSED QA] Bug 9043 [QA Followup] - Don't show More options are there aren't
any

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

--- Comment #73 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 31558
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31558action=edit
[PASSED QA] Bug 9043: Changes to the advanced search page

This patch adds 2 new sysprefs: OpacAdvSearchOptions and
OpacAdvSearchMoreOptions.

These sysprefs are multivalued and you can add or remove some elements on
the adv search page.

This patch allows to display/hide some entries in the advanced search
page at the OPAC.
On this way, it is possible to configure the search options to display.

Test plan:
1/
Fill OpacAdvSearchOptions with Item types and Languages.
Fill OpacAdvSearchMoreOptions with Item types, Languages and Location.
On the advanced search page, verify the Location is only displayed for
the More options view.
2/ Try different settings for these prefs
3/ Remove all entries for the OpacAdvSearchMoreOptions and verify that
the More options does not displayed additional options.
4/ Remove all entries for the OpacAdvSearchOptions and verify that the
normal view does not displayed any options.

Note that this patch only affects the bootstrap theme.

Signed-off-by: Koha Team Lyon 3 k...@univ-lyon3.fr
Signed-off-by: Jacek Ablewicz a...@biblos.pk.edu.pl

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

--- Comment #75 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 31560
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31560action=edit
[PASSED QA] Bug 9043: Make strings translatable

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

--- Comment #77 from Kyle M Hall k...@bywatersolutions.com ---
Everything looks good. Passes koha-qa, tested and functions well. Had to rebase
due to updates to the advanced search template. Added small qa followup to keep
this train rolling.

Great work Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-08-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

--- Comment #71 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 31170
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31170action=edit
Bug 9043: Make strings translatable

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-08-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-08-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

--- Comment #70 from Owen Leonard oleon...@myacpl.org ---
(In reply to Jonathan Druart from comment #69)
 The solution would be to modify the multiple-select plugin.

This worked in my test:

$(select[multiple='multiple']).multipleSelect({
placeholder: _(Please select...),
selectAllText: _(Select all),
allSelected: _(All selected),
countSelected: _(# of % selected),
noMatchesFound: _(No matches found)
});

...and the translation script seemed to pick it up.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-08-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-08-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #68 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
This works as described, but introduces a couple of untranslatable strings -
Select all, All selected, x of y selected etc. 

Marking failed for now, hoping there is a solution.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-08-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

--- Comment #69 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Katrin Fischer from comment #68)
 This works as described, but introduces a couple of untranslatable strings -
 Select all, All selected, x of y selected etc. 
 
 Marking failed for now, hoping there is a solution.

The solution would be to modify the multiple-select plugin.
Since the strings are only displayed when editing 2 sysprefs, I am not sure it
is worth forking it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-08-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Blocks||12802

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-08-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|In Discussion   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-08-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #30183|0   |1
is obsolete||
  Attachment #30184|0   |1
is obsolete||
  Attachment #30185|0   |1
is obsolete||
  Attachment #30186|0   |1
is obsolete||

--- Comment #64 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 30967
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30967action=edit
Bug 9043: Syspref improvement: add new type multiple

This patch adds a new type multiple for syspref.
This new type allows to select several values for one syspref.

Signed-off-by: Koha Team Lyon 3 k...@univ-lyon3.fr
Signed-off-by: Jacek Ablewicz a...@biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-08-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

--- Comment #66 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 30969
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30969action=edit
Bug 9043: Add the multiple select jquery plugin

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-08-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

--- Comment #65 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 30968
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30968action=edit
Bug 9043: Changes to the advanced search page

This patch adds 2 new sysprefs: OpacAdvSearchOptions and
OpacAdvSearchMoreOptions.

These sysprefs are multivalued and you can add or remove some elements on
the adv search page.

This patch allows to display/hide some entries in the advanced search
page at the OPAC.
On this way, it is possible to configure the search options to display.

Test plan:
1/
Fill OpacAdvSearchOptions with Item types and Languages.
Fill OpacAdvSearchMoreOptions with Item types, Languages and Location.
On the advanced search page, verify the Location is only displayed for
the More options view.
2/ Try different settings for these prefs
3/ Remove all entries for the OpacAdvSearchMoreOptions and verify that
the More options does not displayed additional options.
4/ Remove all entries for the OpacAdvSearchOptions and verify that the
normal view does not displayed any options.

Note that this patch only affects the bootstrap theme.

Signed-off-by: Koha Team Lyon 3 k...@univ-lyon3.fr
Signed-off-by: Jacek Ablewicz a...@biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-08-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

--- Comment #67 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Owen Leonard from comment #62)
 I haven't tested it but this looks interesting:
 
 http://wenzhixin.net.cn/p/multiple-select/docs/

The last patch set uses this multiple select plugin.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-07-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

--- Comment #56 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
There are 2 small things:

- we might want to rename Itemtypes as it could also be locations or
collections for a library. But I am not sure what would be a better name :(
- the font size and script of the new plugin created pull down seems a bit off
and some styling to make it fit better into the page would be nice.

Overall this works as it should and I think those 2 small things could be
resolved in a follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-07-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #29914|0   |1
is obsolete||
  Attachment #29915|0   |1
is obsolete||
  Attachment #29945|0   |1
is obsolete||
  Attachment #29946|0   |1
is obsolete||

--- Comment #57 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 30183
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30183action=edit
[PASSED QA] Bug 9043: [SIGNED OFF] Syspref improvement: add new type multiple

This patch adds a new type multiple for syspref.
This new type allows to select several values for one syspref.

Signed-off-by: Koha Team Lyon 3 k...@univ-lyon3.fr
Signed-off-by: Jacek Ablewicz a...@biblos.pk.edu.pl
Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-07-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-07-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

--- Comment #59 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 30185
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30185action=edit
[PASSED QA] Bug 9043: [SIGNED-OFF] Changes to the advanced search page

This patch adds 2 new sysprefs: OpacAdvSearchOptions and
OpacAdvSearchMoreOptions.

These sysprefs are multivalued and you can add or remove some elements on
the adv search page.

This patch allows to display/hide some entries in the advanced search
page at the OPAC.
On this way, it is possible to configure the search options to display.

Test plan:
1/
Fill OpacAdvSearchOptions with Item types and Languages.
Fill OpacAdvSearchMoreOptions with Item types, Languages and Location.
On the advanced search page, verify the Location is only displayed for
the More options view.
2/ Try different settings for these prefs
3/ Remove all entries for the OpacAdvSearchMoreOptions and verify that
the More options does not displayed additional options.
4/ Remove all entries for the OpacAdvSearchOptions and verify that the
normal view does not displayed any options.

Note that this patch only affects the bootstrap theme.

Signed-off-by: Koha Team Lyon 3 k...@univ-lyon3.fr
Signed-off-by: Jacek Ablewicz a...@biblos.pk.edu.pl
Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-07-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

--- Comment #58 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 30184
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30184action=edit
[PASSED QA] Bug 9043: [SIGNED-OFF] Add the dropdown check list jquery plugin

Signed-off-by: Koha Team Lyon 3 k...@univ-lyon3.fr
Signed-off-by: Jacek Ablewicz a...@biblos.pk.edu.pl
Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-07-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

--- Comment #60 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 30186
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30186action=edit
[PASSED QA] Bug 9043: Add the dropdown check list jquery plugin in the license
list.

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com
Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Passes all tests and QA scipt.

Note:
- We might want to rename Itemtypes as it could also be locations or
collections
  for a library. But I am not sure what would be a better name.
- The font size and script of the new plugin created pull down seems a bit off
and
  some styling to make it fit better into the page would be nice.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-07-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Passed QA   |In Discussion

--- Comment #61 from Owen Leonard oleon...@myacpl.org ---
I'm concerned about adding a jQuery plugin dependency that comes with this
disclaimer:

DDCL IS NO LONGER ACTIVELY SUPPORTED

It has not been rebuilt in over 2 years and is stuck on jQuery release 1.7.
However, if anybody feels they can devote time to maintaining and developing
DDCL, then feel free to get in contact.

We are still in the process of updating or replacing existing plugins which
block an upgrade of jQuery in Koha. I don't think it's a good idea to add
another one.

Are there any alternatives we could consider?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-07-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

--- Comment #62 from Owen Leonard oleon...@myacpl.org ---
I haven't tested it but this looks interesting:

http://wenzhixin.net.cn/p/multiple-select/docs/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-07-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

--- Comment #63 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Owen, thx for taking a look and finding this. I hope we find a solution that
won't block the update.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-07-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

Version|unspecified |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #29916|0   |1
is obsolete||

--- Comment #53 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 29945
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29945action=edit
Bug 9043: [SIGNED-OFF] Changes to the advanced search page

This patch adds 2 new sysprefs: OpacAdvSearchOptions and
OpacAdvSearchMoreOptions.

These sysprefs are multivalued and you can add or remove some elements on
the adv search page.

This patch allows to display/hide some entries in the advanced search
page at the OPAC.
On this way, it is possible to configure the search options to display.

Test plan:
1/
Fill OpacAdvSearchOptions with Item types and Languages.
Fill OpacAdvSearchMoreOptions with Item types, Languages and Location.
On the advanced search page, verify the Location is only displayed for
the More options view.
2/ Try different settings for these prefs
3/ Remove all entries for the OpacAdvSearchMoreOptions and verify that
the More options does not displayed additional options.
4/ Remove all entries for the OpacAdvSearchOptions and verify that the
normal view does not displayed any options.

Note that this patch only affects the bootstrap theme.

Signed-off-by: Koha Team Lyon 3 k...@univ-lyon3.fr
Signed-off-by: Jacek Ablewicz a...@biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

--- Comment #55 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Katrin Fischer from comment #51)
 Please add a follow-up to include the new jQuery plugin on the About page. 

Done.

(In reply to Katrin Fischer from comment #52)
 I think maybe rename location to 'location and availability' like on the
 advanced search form and to avoid confusion with the locations tab that you
 can add with AdvancedSearchTypes.

Done too, I amended the last patch and just changed the string in opac.pref.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

--- Comment #54 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 29946
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29946action=edit
Bug 9043: Add the dropdown check list jquery plugin in the license list.

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-07-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Jacek Ablewicz ablew...@gmail.com changed:

   What|Removed |Added

  Attachment #29005|0   |1
is obsolete||
  Attachment #29006|0   |1
is obsolete||
  Attachment #29007|0   |1
is obsolete||

--- Comment #48 from Jacek Ablewicz ablew...@gmail.com ---
Created attachment 29914
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29914action=edit
Bug 9043: [SIGNED OFF] Syspref improvement: add new type multiple

This patch adds a new type multiple for syspref.
This new type allows to select several values for one syspref.

Signed-off-by: Koha Team Lyon 3 k...@univ-lyon3.fr
Signed-off-by: Jacek Ablewicz a...@biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-07-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

--- Comment #49 from Jacek Ablewicz ablew...@gmail.com ---
Created attachment 29915
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29915action=edit
Bug 9043: [SIGNED-OFF] Add the dropdown check list jquery plugin

Signed-off-by: Koha Team Lyon 3 k...@univ-lyon3.fr
Signed-off-by: Jacek Ablewicz a...@biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-07-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

--- Comment #50 from Jacek Ablewicz ablew...@gmail.com ---
Created attachment 29916
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29916action=edit
Bug 9043: [SIGNED-OFF] Changes to the advanced search page

This patch adds 2 new sysprefs: OpacAdvSearchOptions and
OpacAdvSearchMoreOptions.

These sysprefs are multivalued and you can add or remove some elements on
the adv search page.

This patch allows to display/hide some entries in the advanced search
page at the OPAC.
On this way, it is possible to configure the search options to display.

Test plan:
1/
Fill OpacAdvSearchOptions with Item types and Languages.
Fill OpacAdvSearchMoreOptions with Item types, Languages and Location.
On the advanced search page, verify the Location is only displayed for
the More options view.
2/ Try different settings for these prefs
3/ Remove all entries for the OpacAdvSearchMoreOptions and verify that
the More options does not displayed additional options.
4/ Remove all entries for the OpacAdvSearchOptions and verify that the
normal view does not displayed any options.

Note that this patch only affects the bootstrap theme.

Signed-off-by: Koha Team Lyon 3 k...@univ-lyon3.fr
Signed-off-by: Jacek Ablewicz a...@biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-07-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 QA Contact||katrin.fisc...@bsz-bw.de

--- Comment #51 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Please add a follow-up to include the new jQuery plugin on the About page. 
Continuing testing...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-07-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

--- Comment #52 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I think maybe rename location to 'location and availability' like on the
advanced search form and to avoid confusion with the locations tab that you can
add with AdvancedSearchTypes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-07-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Jacek Ablewicz a...@biblos.pk.edu.pl changed:

   What|Removed |Added

 CC||a...@biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-07-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Jacek Ablewicz a...@biblos.pk.edu.pl changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=6567

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-07-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||aani...@gmail.com

--- Comment #47 from Jonathan Druart jonathan.dru...@biblibre.com ---
*** Bug 6567 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-06-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Koha Team Lyon 3 k...@univ-lyon3.fr changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||k...@univ-lyon3.fr

--- Comment #43 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
This patch works well :  adds 2 new sysprefs: OpacAdvSearchOptions and
OpacAdvSearchMoreOptions.

There is just one thing to remember when configuring the advance search options
: 
When you fill OpacAdvSearchOptions with Item types and Languages (for
example)you should fill also OpacAdvSearchMoreOptions with the same options :
Item types, Languages, otherwise, when you click on more options, you get
fiewer options (the options filled in OpacAdvSearchOptions are not showed)which
is quite surprising, it's a logical mistake in configuring the advance search
options : more options must be filled with at least the options filled in the
default options.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-06-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

--- Comment #46 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 29007
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29007action=edit
Bug 9043: Changes to the advanced search page

This patch adds 2 new sysprefs: OpacAdvSearchOptions and
OpacAdvSearchMoreOptions.

These sysprefs are multivalued and you can add or remove some elements on
the adv search page.

This patch allows to display/hide some entries in the advanced search
page at the OPAC.
On this way, it is possible to configure the search options to display.

Test plan:
1/
Fill OpacAdvSearchOptions with Item types and Languages.
Fill OpacAdvSearchMoreOptions with Item types, Languages and Location.
On the advanced search page, verify the Location is only displayed for
the More options view.
2/ Try different settings for these prefs
3/ Remove all entries for the OpacAdvSearchMoreOptions and verify that
the More options does not displayed additional options.
4/ Remove all entries for the OpacAdvSearchOptions and verify that the
normal view does not displayed any options.

Note that this patch only affects the bootstrap theme.

Signed-off-by: Koha Team Lyon 3 k...@univ-lyon3.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-04-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

--- Comment #39 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to David Cook from comment #38)

Thanks David to revive this bug!

 It appears that one of your patches includes the smart match operator, which
 is something we're avoiding due to its deprecated/experimental status in
 Perl 5.18, I believe.

Will be fixed.

 Do you have a test plan to accompany your patches, Jonathan?

Will be added.

 In yours, it
 appears that the options always show when viewing more options and only
 show when viewing fewer options if that option is included in the system
 preference.

 I think your patch only covers scenarios #2 and #3. Is that correct?

Yes, good catch. I will add a new pref for that.

 I'm not a huge fan of governing this behaviour using system preferences, but
 I think I prefer the 3 choices rather than 2.

I don't see another way to do that.

 I think Owen has been making an effort to move the Javascript libraries out
 of the /en/ directory and put it higher up so that it isn't needlessly
 duplicated in the translations, so it would probably make sense to move the
 JS higher up the directory tree.

At the OPAC, not at the staff interface.

 I think there might be another bug out there that seeks to add multiple
 options for system preferences...but I might be mistaken.

Not sure. If someone agree with my patches, I think the first patch should be
abandoned. Otherwise, We are going to create 6 prefs and remove them just
after.

 It looks like this patch will need to rebase due to the updatedatabase.pl
 being too old now.

Will be rebased.

 I hope that helps!

Of course!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-04-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

--- Comment #41 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 27525
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27525action=edit
[ALT 2/3] Bug 9043: Add the dropdown check list jquery plugin

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-04-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

--- Comment #42 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 27526
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27526action=edit
[ALT 3/3] Bug 9043: Changes to the advanced search page

This patch adds 2 new sysprefs: OpacAdvSearchOptions and
OpacAdvSearchMoreOptions.

These sysprefs are multivalued and you can add or remove some elements on
the adv search page.

This patch allows to display/hide some entries in the advanced search
page at the OPAC.
On this way, it is possible to configure the search options to display.

Test plan:
1/
Fill OpacAdvSearchOptions with Item types and Languages.
Fill OpacAdvSearchMoreOptions with Item types, Languages and Location.
On the advanced search page, verify the Location is only displayed for
the More options view.
2/ Try different settings for these prefs
3/ Remove all entries for the OpacAdvSearchMoreOptions and verify that
the More options does not displayed additional options.
4/ Remove all entries for the OpacAdvSearchOptions and verify that the
normal view does not displayed any options.

Note that this patch only affects the bootstrap theme.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-04-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #21643|0   |1
is obsolete||
  Attachment #21644|0   |1
is obsolete||
  Attachment #21645|0   |1
is obsolete||

--- Comment #40 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 27524
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27524action=edit
[ALT 1/3] Bug 9043: Syspref improvement: add new type multiple

This patch adds a new type multiple for syspref.
This new type allows to select several values for one syspref.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-04-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

David Cook dc...@prosentient.com.au changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #38 from David Cook dc...@prosentient.com.au ---
(In reply to Jonathan Druart from comment #35)
 Could it be possible to get some feedback on my proposed patches? The idea
 was not to block the enh but to improve it!

_One_

It appears that one of your patches includes the smart match operator, which is
something we're avoiding due to its deprecated/experimental status in Perl
5.18, I believe.

_Two_

Do you have a test plan to accompany your patches, Jonathan? It seems that the
concept behind your patch and the original are at odds in that the original
allows  finer control of when the options appear. In yours, it appears that the
options always show when viewing more options and only show when viewing
fewer options if that option is included in the system preference.

I think the idea was to choose between 3 scenarios:

1) Never show the option in advanced search
2) Show it when viewing more and fewer
3) Show it only when viewing more

I think your patch only covers scenarios #2 and #3. Is that correct?

I'm not a huge fan of governing this behaviour using system preferences, but I
think I prefer the 3 choices rather than 2.

_Three_

I think Owen has been making an effort to move the Javascript libraries out of
the /en/ directory and put it higher up so that it isn't needlessly duplicated
in the translations, so it would probably make sense to move the JS higher up
the directory tree.

_Four_

I think there might be another bug out there that seeks to add multiple options
for system preferences...but I might be mistaken.

_Five_

It looks like this patch will need to rebase due to the updatedatabase.pl being
too old now.

---

I hope that helps!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

jmbroust jean-manuel.bro...@univ-lyon2.fr changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||jean-manuel.broust@univ-lyo
   ||n2.fr

--- Comment #36 from jmbroust jean-manuel.bro...@univ-lyon2.fr ---
h1Something went wrong !/h1Applying: Bug 9043 - Changes to the advanced
search page
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging installer/data/mysql/sysprefs.sql
CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-advsearch.tt
Auto-merging opac/opac-search.pl
Failed to merge in the changes.
Patch failed at 0001 Bug 9043 - Changes to the advanced search page
When you have resolved this problem run git bz apply --continue.
If you would prefer to skip this patch, instead run git bz apply --skip.
To restore the original branch and stop patching run git bz apply --abort.
Bug 9043 - Adding system preferences to control the visibility of the content
on the Advanced Search page

15329 - [Signed off] Bug 9043 - Changes to the advanced search page
21643 - [ALT 1/3] Bug 9043: Syspref improvement: add new type multiple
21644 - [ALT 2/3] Bug 9043: Changes to the advanced search page
21645 - [ALT 3/3] Bug 9043: Add the dropdown check list jquery plugin

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2014-03-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #37 from Jonathan Druart jonathan.dru...@biblibre.com ---
You cannot test this in a sandbox, the first patch should not be applied.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2013-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

I'm just a bot git...@bugs.koha-community.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
   When did the bot|2013-09-29 00:00:00 |2013-10-28
last check this||

--- Comment #34 from I'm just a bot git...@bugs.koha-community.org ---
Applying: Bug 9043 - Changes to the advanced search page
Using index info to reconstruct a base tree...
Minstaller/data/mysql/sysprefs.sql
Minstaller/data/mysql/updatedatabase.pl
Mkoha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
Mkoha-tmpl/opac-tmpl/prog/en/modules/opac-advsearch.tt
Mopac/opac-search.pl
Falling back to patching base and 3-way merge...
Auto-merging opac/opac-search.pl
Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-advsearch.tt
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
Auto-merging installer/data/mysql/updatedatabase.pl
Auto-merging installer/data/mysql/sysprefs.sql
CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql
Patch failed at 0001 Bug 9043 - Changes to the advanced search page
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run git am --continue.
If you prefer to skip this patch, run git am --skip instead.
To restore the original branch and stop patching, run git am --abort.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2013-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #21644|Bug 9043: Changes to the|[ALT 2/3] Bug 9043: Changes
description|advanced search page|to the advanced search page

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2013-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #21645|Bug 9043: Add the dropdown  |[ALT 3/3] Bug 9043: Add the
description|check list jquery plugin|dropdown check list jquery
   ||plugin

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2013-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #21643|Bug 9043: Syspref   |[ALT 1/3] Bug 9043: Syspref
description|improvement: add new type   |improvement: add new type
   |multiple  |multiple

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2013-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff
Bot Control|--- |Ignore this bug

--- Comment #35 from Jonathan Druart jonathan.dru...@biblibre.com ---
Could it be possible to get some feedback on my proposed patches? The idea was
not to block the enh but to improve it!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #20316|0   |1
is obsolete||
  Attachment #20717|0   |1
is obsolete||
  Attachment #20718|0   |1
is obsolete||

--- Comment #31 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 21643
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21643action=edit
Bug 9043: Syspref improvement: add new type multiple

This patch adds a new type multiple for syspref.
This new type allows to select several values for one syspref.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

--- Comment #33 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 21645
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21645action=edit
Bug 9043: Add the dropdown check list jquery plugin

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

--- Comment #32 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 21644
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21644action=edit
Bug 9043: Changes to the advanced search page

New syspref: OpacAdvSearch.
This syspref is multivalued and you can add or remove some elements on
the adv search page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2013-09-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

I'm just a bot git...@bugs.koha-community.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||git...@bugs.koha-community.
   ||org
   When did the bot||2013-09-29
last check this||

--- Comment #30 from I'm just a bot git...@bugs.koha-community.org ---
Applying: Bug 9043 - Changes to the advanced search page
Using index info to reconstruct a base tree...
Minstaller/data/mysql/sysprefs.sql
Minstaller/data/mysql/updatedatabase.pl
Mkoha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
Mkoha-tmpl/opac-tmpl/prog/en/modules/opac-advsearch.tt
Mopac/opac-search.pl
Falling back to patching base and 3-way merge...
Auto-merging opac/opac-search.pl
Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-advsearch.tt
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
Auto-merging installer/data/mysql/updatedatabase.pl
Auto-merging installer/data/mysql/sysprefs.sql
CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql
Patch failed at 0001 Bug 9043 - Changes to the advanced search page
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run git am --continue.
If you prefer to skip this patch, run git am --skip instead.
To restore the original branch and stop patching, run git am --abort.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2013-09-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||julian.maur...@biblibre.com

--- Comment #28 from Julian Maurice julian.maur...@biblibre.com ---
Found a bug:

When you deselect all options from a 'multiple' syspref. The '(modified)' text
is displayed but clicking on Save button doesn't save the syspref value and
message Nothing to save appears.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2013-09-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #29 from Julian Maurice julian.maur...@biblibre.com ---
Forget that, I cleared my browser cache and it works!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2013-08-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #20317|0   |1
is obsolete||

--- Comment #26 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 20717
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20717action=edit
[ALT 2/3] Bug 9043: Changes to the advanced search page

New syspref: OpacAdvSearch.
This syspref is multivalued and you can add or remove some elements on
the adv search page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2013-08-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #20318|0   |1
is obsolete||

--- Comment #27 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 20718
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20718action=edit
[ALT 3/3] Bug 9043: Add the dropdown check list jquery plugin

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2013-08-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2013-08-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Campbell Reid-Tait campbellreidt...@gmail.com changed:

   What|Removed |Added

 CC||campbellreidt...@gmail.com

--- Comment #25 from Campbell Reid-Tait campbellreidt...@gmail.com ---
 [ALT 2/3] Bug 9043: Changes to the advanced search page (6.67 KB, patch)
2013-08-13 14:59 UTC, Jonathan Druart 

Failed to apply.

Applying: Bug 9043: Changes to the advanced search page
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-advsearch.tt
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
Auto-merging installer/data/mysql/sysprefs.sql
CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql
Failed to merge in the changes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2013-08-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Campbell Reid-Tait campbellreidt...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2013-08-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

--- Comment #23 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 20318
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20318action=edit
Bug 9043: Add the dropdown check list jquery plugin

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2013-08-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #19150|0   |1
is obsolete||
  Attachment #19151|0   |1
is obsolete||

--- Comment #21 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 20316
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20316action=edit
Bug 9043: Syspref improvement: add new type multiple

This patch adds a new type multiple for syspref.
This new type allows to select several values for one syspref.

http://bugs.koha-community.org/show_bug.cgi?id=9456

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2013-08-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

--- Comment #22 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 20317
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20317action=edit
Bug 9043: Changes to the advanced search page

New syspref: OpacAdvSearch.
This syspref is multivalued and you can add or remove some elements on
the adv search page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2013-08-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2013-08-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #20316|Bug 9043: Syspref   |[ALT 1/2] Bug 9043: Syspref
description|improvement: add new type   |improvement: add new type
   |multiple  |multiple

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2013-08-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #20317|Bug 9043: Changes to the|[ALT 2/3] Bug 9043: Changes
description|advanced search page|to the advanced search page

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2013-08-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #20318|Bug 9043: Add the dropdown  |[ALT 3/3] Bug 9043: Add the
description|check list jquery plugin|dropdown check list jquery
   ||plugin

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2013-08-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #20316|[ALT 1/2] Bug 9043: Syspref |[ALT 1/3] Bug 9043: Syspref
description|improvement: add new type   |improvement: add new type
   |multiple  |multiple

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2013-08-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

--- Comment #24 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Kyle M Hall from comment #20)
 Jonathan, your patches work quite well, but there is no way to disable all
 the options at once. When I deslect them all, and hit the save button, I get
 the Nothing to save message.
 
 Not required, but it might be nice to implement something like
 https://code.google.com/p/dropdown-check-list/ as a fair number of people
 may not know about ctrl-click to select/deselect individual items.

Thank for the idea, done!
I cannot reproduce your issue, but should be fixed by the last patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2013-08-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||k...@bywatersolutions.com

--- Comment #20 from Kyle M Hall k...@bywatersolutions.com ---
Jonathan, your patches work quite well, but there is no way to disable all the
options at once. When I deslect them all, and hit the save button, I get the
Nothing to save message.

Not required, but it might be nice to implement something like
https://code.google.com/p/dropdown-check-list/ as a fair number of people may
not know about ctrl-click to select/deselect individual items.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2013-06-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

--- Comment #16 from Jonathan Druart jonathan.dru...@biblibre.com ---
Need feedback on my last patch, switch to needs signoff.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2013-06-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #15546|0   |1
is obsolete||
  Attachment #15792|0   |1
is obsolete||

--- Comment #17 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 19150
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19150action=edit
Bug 9043: Syspref improvement: add new type multiple

This patch adds a new type multiple for syspref.
This new type allows to select several values for one syspref.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2013-06-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

--- Comment #18 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 19151
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19151action=edit
Bug 9043: Changes to the advanced search page

New syspref: OpacAdvSearch.
This syspref is multivalued and you can add or remove some elements on
the adv search page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2013-06-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #19150|Bug 9043: Syspref   |[ALT 1/2] Bug 9043: Syspref
description|improvement: add new type   |improvement: add new type
   |multiple  |multiple

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2013-06-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #19151|Bug 9043: Changes to the|[ALT 2/2] Bug 9043: Changes
description|advanced search page|to the advanced search page

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2013-06-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

--- Comment #19 from Jonathan Druart jonathan.dru...@biblibre.com ---
Note: The 3 patches are not compatible.

Either you apply:
  [Signed off] Bug 9043 - Changes to the advanced search page

Either both:
  [ALT 1/2] Bug 9043: Syspref improvement: add new type multiple
  [ALT 2/2] Bug 9043: Changes to the advanced search page

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2013-03-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

--- Comment #14 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to comment #13)
 Hi Jonathan, I like the idea. But there are couple of issues I would like to
 raise
 
 1) In the current state, the OpacAdvSearch syspref applies the same behavior
 to Advanced search page with both Fewer and More options. This needs to be
 rectified. 

Ok, I didn't understand what you want. New patch coming.

 2) I tried unselecting/disabling a previously selected/enabled option by
 clicking on it, this doesn't seem to work. How does one unselect/disable one
 of the options from the scroll-down menu?

You have to press the ctrl key and click on the entry.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2013-03-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #15547|0   |1
is obsolete||

--- Comment #15 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 15792
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15792action=edit
Bug 9043: Changes to the advanced search page

New syspref: OpacAdvSearch.
This syspref is multivalued and you can add or remove some elements on
the adv search page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2013-02-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

--- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com ---
Srikanth and Melia,
Do you think my proposal solves the problem or not?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2013-02-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

--- Comment #13 from Srikanth Dhondi srika...@catalyst.net.nz ---
Hi Jonathan, I like the idea. But there are couple of issues I would like to
raise

1) In the current state, the OpacAdvSearch syspref applies the same behavior to
Advanced search page with both Fewer and More options. This needs to be
rectified. 

2) I tried unselecting/disabling a previously selected/enabled option by
clicking on it, this doesn't seem to work. How does one unselect/disable one of
the options from the scroll-down menu?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2013-02-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |In Discussion
 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com ---
This patch works as expected but it adds a lot of sysprefs for just one thing.

I will suggest 2 alternative patchs, for discussion. The idea is to improve the
syspref's engine in order to create a new type which allow to selected several
values for one syspref.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2013-02-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

--- Comment #10 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 15546
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15546action=edit
Bug 9043: Syspref improvement: add new type multiple

This patch adds a new type multiple for syspref.
This new type allows to select several values for one syspref.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >