[Koha-bugs] [Bug 9139] Sending empty vendor or biblio when adding subscriptions gives wrong error
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9139 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #10 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9139] Sending empty vendor or biblio when adding subscriptions gives wrong error
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9139 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added CC||tomasco...@gmail.com Status|Passed QA |Pushed to Master --- Comment #9 from Tomás Cohen Arazi tomasco...@gmail.com --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9139] Sending empty vendor or biblio when adding subscriptions gives wrong error
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9139 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I really like that you have the right search now open on pressing enter, but I think the possibility to enter the vendor number or record number directly is kind of a feature, so we should not remove that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9139] Sending empty vendor or biblio when adding subscriptions gives wrong error
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9139 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9139] Sending empty vendor or biblio when adding subscriptions gives wrong error
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9139 Andreas Hedström Mace andreas.hedstrom.m...@sub.su.se changed: What|Removed |Added Attachment #38044|0 |1 is obsolete|| --- Comment #7 from Andreas Hedström Mace andreas.hedstrom.m...@sub.su.se --- Created attachment 38050 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38050action=edit Bug 9139: New subscription form - Does not check form on the first page The vendor and Record input try to sent the form if the focus is on the inputs (normal behavior). But the form is on 2 pages, and the popup message ask you to fill info on the second page when you are on the first one. This does not make sense. This patch suggests to launch search when the enter key is press on these inputs. Test plan: 1/ Create a new subscription 2/ Put the focus in the Vendor input and press enter: the vendor search popup should appear 3/ Put the focus in the Record input and press enter: the record search popup should appear Signed-off-by: Andreas Hedström Mace andreas.hedstrom.m...@sub.su.se -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9139] Sending empty vendor or biblio when adding subscriptions gives wrong error
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9139 Andreas Hedström Mace andreas.hedstrom.m...@sub.su.se changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9139] Sending empty vendor or biblio when adding subscriptions gives wrong error
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9139 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #37780|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 38044 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38044action=edit Bug 9139: New subscription form - Does not check form on the first page The vendor and Record input try to sent the form if the focus is on the inputs (normal behavior). But the form is on 2 pages, and the popup message ask you to fill info on the second page when you are on the first one. This does not make sense. This patch suggests to launch search when the enter key is press on these inputs. Test plan: 1/ Create a new subscription 2/ Put the focus in the Vendor input and press enter: the vendor search popup should appear 3/ Put the focus in the Record input and press enter: the record search popup should appear -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9139] Sending empty vendor or biblio when adding subscriptions gives wrong error
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9139 --- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com --- The preventDefault was bad placed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9139] Sending empty vendor or biblio when adding subscriptions gives wrong error
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9139 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added QA Contact||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9139] Sending empty vendor or biblio when adding subscriptions gives wrong error
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9139 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9139] Sending empty vendor or biblio when adding subscriptions gives wrong error
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9139 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #38050|0 |1 is obsolete|| --- Comment #8 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 38071 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38071action=edit [PASSED QA] Bug 9139: New subscription form - Does not check form on the first page The vendor and Record input try to sent the form if the focus is on the inputs (normal behavior). But the form is on 2 pages, and the popup message ask you to fill info on the second page when you are on the first one. This does not make sense. This patch suggests to launch search when the enter key is press on these inputs. Test plan: 1/ Create a new subscription 2/ Put the focus in the Vendor input and press enter: the vendor search popup should appear 3/ Put the focus in the Record input and press enter: the record search popup should appear Signed-off-by: Andreas Hedström Mace andreas.hedstrom.m...@sub.su.se Signed-off-by: Katrin Fischer katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9139] Sending empty vendor or biblio when adding subscriptions gives wrong error
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9139 Andreas Hedström Mace andreas.hedstrom.m...@sub.su.se changed: What|Removed |Added Attachment #37580|0 |1 is obsolete|| --- Comment #3 from Andreas Hedström Mace andreas.hedstrom.m...@sub.su.se --- Created attachment 37780 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37780action=edit Bug 9139: New subscription form - Does not check form on the first page The vendor and Record input try to sent the form if the focus is on the inputs (normal behavior). But the form is on 2 pages, and the popup message ask you to fill info on the second page when you are on the first one. This does not make sense. This patch suggests to launch search when the enter key is press on these inputs. Test plan: 1/ Create a new subscription 2/ Put the focus in the Vendor input and press enter: the vendor search popup should appear 3/ Put the focus in the Record input and press enter: the record search popup should appear Signed-off-by: Andreas Hedström Mace andreas.hedstrom.m...@sub.su.se -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9139] Sending empty vendor or biblio when adding subscriptions gives wrong error
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9139 Andreas Hedström Mace andreas.hedstrom.m...@sub.su.se changed: What|Removed |Added CC||andreas.hedstrom.mace@sub.s ||u.se Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9139] Sending empty vendor or biblio when adding subscriptions gives wrong error
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9139 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9139] Sending empty vendor or biblio when adding subscriptions gives wrong error
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9139 --- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 37580 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37580action=edit Bug 9139: New subscription form - Does not check form on the first page The vendor and Record input try to sent the form if the focus is on the inputs (normal behavior). But the form is on 2 pages, and the popup message ask you to fill info on the second page when you are on the first one. This does not make sense. This patch suggests to launch search when the enter key is press on these inputs. Test plan: 1/ Create a new subscription 2/ Put the focus in the Vendor input and press enter: the vendor search popup should appear 3/ Put the focus in the Record input and press enter: the record search popup should appear -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9139] Sending empty vendor or biblio when adding subscriptions gives wrong error
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9139 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co |ity.org |m Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9139] Sending empty vendor or biblio when adding subscriptions gives wrong error
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9139 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Summary|Sending empty vendor or |Sending empty vendor or |biblio when adding |biblio when adding |subscriptions gives error |subscriptions gives wrong ||error --- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de --- The message is now: You must choose a first publication date. This doesn't make much sense as the field is on the second page of the form and can't be accessed without filling out other mandatory fields first. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
