[Koha-bugs] [Bug 9163] Cataloguing validation workflow

2016-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163

Fridolin SOMERS  changed:

   What|Removed |Added

   Assignee|fridolin.som...@biblibre.co |alex.arn...@biblibre.com
   |m   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9163] Cataloguing validation workflow

2016-03-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163

Laurence Rault  changed:

   What|Removed |Added

 CC||laurence.ra...@biblibre.com
 Status|Needs Signoff   |Failed QA

--- Comment #32 from Laurence Rault  ---
Tested on sandbox, unimarc and marc21

"- The users with access to the validation framework are set in
CatalogingValidationUsers." : this text in CatalogingValidation description
should be removed or replaced with something like "Users with access to the
validation framework should have the cataloging_validation_framework
permission"

The cataloging_validation_framework permission does not exist at all

I feel disturbing that suppress=1 is set on 942$n in the code : that means that
this will work only for marc21 configuration. How about unimarc ?
I think it would be better to be able configure the framework field/subfield
concerned with suppress status

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9163] Cataloguing validation workflow

2015-12-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #21194|0   |1
is obsolete||

--- Comment #30 from Alex Arnaud  ---
Created attachment 45475
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45475&action=edit
BUG 9163 - Patch2 use user permissions instead of systempreferences

New user permission added to access the validation framework, under edit
catalogue section.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9163] Cataloguing validation workflow

2015-12-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #21192|0   |1
is obsolete||

--- Comment #29 from Alex Arnaud  ---
Created attachment 45474
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45474&action=edit
BUG 9163 - Cataloguing validation workflow

Added 3 systems preferences instead of one:

- 1 to use/not use the validation workflow
- 1 to set the validation framework code
- 1 to set the users with access to the validation framework

addbook.pl and addbiblio.pl show the frameworkcodes in the drop list according
to settings:

- if validation off shows all
- if validation on and framework code is different than validation framework
code, shows the framework code
- if validation on and framework code equal to validation framework code and
the user have permissions, shows the framework code
- if validation on and framework code equal to validation framework code and
the user doesn't have permissions, don't shows the framework code

addbiblio.pl also changed to:

- prevent any user to use the validation framework (if validation on) when
putting the code in the browser URL
- if validation on always set suppress = 1 in framework different than the
validating one

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9163] Cataloguing validation workflow

2015-12-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163

Alex Arnaud  changed:

   What|Removed |Added

 CC||alex.arn...@biblibre.com
 Status|Patch doesn't apply |Needs Signoff

--- Comment #31 from Alex Arnaud  ---
Patch rebased.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9163] Cataloguing validation workflow

2014-07-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #28 from Nick Clemens  ---
I'd be happy to test and get this moving again but needs rebase

Applying: BUG 9163 - Cataloguing validation workflow
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref
Auto-merging installer/data/mysql/updatedatabase.pl
Auto-merging installer/data/mysql/sysprefs.sql
Auto-merging cataloguing/addbooks.pl
Auto-merging cataloguing/addbiblio.pl
Failed to merge in the changes.
Patch failed at 0001 BUG 9163 - Cataloguing validation workflow
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/BUG-9163---Cataloguing-validation-workflow-_DFxmQ.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9163] Cataloguing validation workflow

2014-06-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@quecheelibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9163] Cataloguing validation workflow

2014-03-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163

paxed  changed:

   What|Removed |Added

 CC||pasi.kalli...@pttk.fi

--- Comment #27 from paxed  ---
(In reply to Fridolin SOMERS from comment #26)
> (In reply to Doug Kingston from comment #24)
> > When using the sandbox to try and test this, I tried searching for 'test'
> > before proceeding with the test plan and got this error message:
> > Error: Can't call method "raw" on an undefined value at
> > /home/koha/src/C4/Search.pm line 490.
> This is a known bug, it means there is no results, for a search with a sort
> order not on relevance.

Indeed: See bug 9578

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9163] Cataloguing validation workflow

2014-03-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #26 from Fridolin SOMERS  ---
(In reply to Doug Kingston from comment #24)
> When using the sandbox to try and test this, I tried searching for 'test'
> before proceeding with the test plan and got this error message:
> Error: Can't call method "raw" on an undefined value at
> /home/koha/src/C4/Search.pm line 490.
This is a known bug, it means there is no results, for a search with a sort
order not on relevance.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9163] Cataloguing validation workflow

2014-03-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163

francois.piche...@ovh.fr changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||francois.piche...@ovh.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9163] Cataloguing validation workflow

2013-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163

I'm just a bot  changed:

   What|Removed |Added

   When did the bot|2013-09-29 00:00:00 |2013-10-30
last check this||

--- Comment #25 from I'm just a bot  ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9163] Cataloguing validation workflow

2013-10-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163

Doug Kingston  changed:

   What|Removed |Added

 CC||d...@randomnotes.org

--- Comment #24 from Doug Kingston  ---
When using the sandbox to try and test this, I tried searching for 'test'
before proceeding with the test plan and got this error message:
Error: Can't call method "raw" on an undefined value at
/home/koha/src/C4/Search.pm line 490.

I do not get this if I build a sandbox from "msster" instead of "9163".

I subsequently tried to follow the test plan and got to the point of checking
to see if I can see the new record and get the error above.  Could you review
the test plan in light of the fact that you are now using user permissions.  I
think I did the right thing here but it would be good to have more explicit
instructions.  Also there are a few options for visibility in the framework and
for access under cataloging for user permissions.  Being more precise with how
those should be set would be good.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9163] Cataloguing validation workflow

2013-09-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163

I'm just a bot  changed:

   What|Removed |Added

   When did the bot||2013-09-29
last check this||

--- Comment #23 from I'm just a bot  ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9163] Cataloguing validation workflow

2013-09-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163

Fridolyn SOMERS  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9163] Cataloguing validation workflow

2013-09-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163

Fridolyn SOMERS  changed:

   What|Removed |Added

  Attachment #19271|0   |1
is obsolete||

--- Comment #22 from Fridolyn SOMERS  ---
Created attachment 21194
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21194&action=edit
BUG 9163 - Patch2 use user permissions instead of systempreferences

Rebased master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9163] Cataloguing validation workflow

2013-09-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163

Fridolyn SOMERS  changed:

   What|Removed |Added

  Attachment #19270|0   |1
is obsolete||

--- Comment #21 from Fridolyn SOMERS  ---
Created attachment 21192
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21192&action=edit
BUG 9163 - Cataloguing validation workflow

Rebased master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9163] Cataloguing validation workflow

2013-09-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163

--- Comment #20 from Fridolyn SOMERS  ---
I am rebasing the patches

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9163] Cataloguing validation workflow

2013-09-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163

I'm just a bot  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||git...@bugs.koha-community.
   ||org

--- Comment #19 from I'm just a bot  ---
Applying: BUG 9163 - Cataloguing validation workflow
Using index info to reconstruct a base tree...
Mcataloguing/addbiblio.pl
Mcataloguing/addbooks.pl
Minstaller/data/mysql/sysprefs.sql
Minstaller/data/mysql/updatedatabase.pl
Falling back to patching base and 3-way merge...
Auto-merging installer/data/mysql/updatedatabase.pl
Auto-merging installer/data/mysql/sysprefs.sql
CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql
Auto-merging cataloguing/addbooks.pl
Auto-merging cataloguing/addbiblio.pl
Patch failed at 0001 BUG 9163 - Cataloguing validation workflow
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9163] Cataloguing validation workflow

2013-06-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #18 from Jonathan Druart  ---
Fix patches order + rebase.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9163] Cataloguing validation workflow

2013-06-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163

--- Comment #17 from Jonathan Druart  ---
Created attachment 19271
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19271&action=edit
BUG 9163 - Patch2 use user permissions instead of systempreferences

New user permission added to access the validation framework, under edit
catalogue section.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9163] Cataloguing validation workflow

2013-06-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9163] Cataloguing validation workflow

2013-06-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #16619|0   |1
is obsolete||
  Attachment #16675|0   |1
is obsolete||

--- Comment #16 from Jonathan Druart  ---
Created attachment 19270
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19270&action=edit
BUG 9163 - Cataloguing validation workflow

Added 3 systems preferences instead of one:

- 1 to use/not use the validation workflow
- 1 to set the validation framework code
- 1 to set the users with access to the validation framework

addbook.pl and addbiblio.pl show the frameworkcodes in the drop list according
to settings:

- if validation off shows all
- if validation on and framework code is different than validation framework
code, shows the framework code
- if validation on and framework code equal to validation framework code and
the user have permissions, shows the framework code
- if validation on and framework code equal to validation framework code and
the user doesn't have permissions, don't shows the framework code

addbiblio.pl also changed to:

- prevent any user to use the validation framework (if validation on) when
putting the code in the browser URL
- if validation on always set suppress = 1 in framework different than the
validating one

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9163] Cataloguing validation workflow

2013-03-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163

Pierre Angot  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||tredok.pie...@gmail.com

--- Comment #15 from Pierre Angot  ---
Test on sandbox :

Something went wrong !
Applying: BUG 9163 - Patch2 use user permissions instead of systempreferences
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 BUG 9163 - Patch2 use user permissions instead of
systempreferences
When you have resolved this problem run "git am --resolved".
If you would prefer to skip this patch, instead run "git am --skip".
To restore the original branch and stop patching run "git am --abort".
Bug 9163 - Cataloguing validation workflow

second patch rebased
Apply? [yn]
Patch left in /tmp/second-patch-rebased-FeeYi6.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9163] Cataloguing validation workflow

2013-03-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163

Christophe Croullebois  changed:

   What|Removed |Added

  Attachment #16605|0   |1
is obsolete||

--- Comment #14 from Christophe Croullebois 
 ---
Created attachment 16675
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16675&action=edit
patch rebased

first patch rebased due to a lack of a bracket

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9163] Cataloguing validation workflow

2013-03-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163

Christophe Croullebois  changed:

   What|Removed |Added

  Attachment #16526|0   |1
is obsolete||

--- Comment #13 from Christophe Croullebois 
 ---
Created attachment 16619
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16619&action=edit
second patch rebased

2° patch rebased

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9163] Cataloguing validation workflow

2013-03-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163

Frederic Durand  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9163] Cataloguing validation workflow

2013-03-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163

Christophe Croullebois  changed:

   What|Removed |Added

  Attachment #16525|0   |1
is obsolete||

--- Comment #12 from Christophe Croullebois 
 ---
Created attachment 16605
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16605&action=edit
patch rebased

patch rebased ready to be tested

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9163] Cataloguing validation workflow

2013-03-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163

Frederic Durand  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9163] Cataloguing validation workflow

2013-03-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163

--- Comment #11 from Frederic Durand  ---
Testing on sandbox, did not work cause of : 
Applying: BUG 9163 - Cataloguing validation workflow
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging installer/data/mysql/sysprefs.sql
CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Failed to merge in the changes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9163] Cataloguing validation workflow

2013-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163

--- Comment #10 from Fridolyn SOMERS  ---
Resumbitted patches(In reply to comment #7)
> Testing it on sandbox, when trying to access to Cataloguing, got this error
> message : 
> Missing right curly or square bracket at
> /home/koha/src/cataloguing/addbooks.pl line 158, at end of line
> syntax error at /home/koha/src/cataloguing/addbooks.pl line 158, at EOF
> Execution of /home/koha/src/cataloguing/addbooks.pl aborted due to
> compilation errors.

Corrected

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9163] Cataloguing validation workflow

2013-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163

Fridolyn SOMERS  changed:

   What|Removed |Added

  Attachment #16384|0   |1
is obsolete||

--- Comment #9 from Fridolyn SOMERS  ---
Created attachment 16526
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16526&action=edit
BUG 9163 - Patch2 use user permissions instead of systempreferences

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9163] Cataloguing validation workflow

2013-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163

Fridolyn SOMERS  changed:

   What|Removed |Added

  Attachment #16383|0   |1
is obsolete||
 Status|Failed QA   |Needs Signoff
   Assignee|vfernan...@keep.pt  |fridolyn.som...@biblibre.co
   ||m

--- Comment #8 from Fridolyn SOMERS  ---
Created attachment 16525
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16525&action=edit
BUG 9163 - Cataloguing validation workflow

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9163] Cataloguing validation workflow

2013-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163

Frederic Durand  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9163] Cataloguing validation workflow

2013-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163

Frederic Durand  changed:

   What|Removed |Added

 CC||frederic.dur...@unilim.fr

--- Comment #7 from Frederic Durand  ---
Testing it on sandbox, when trying to access to Cataloguing, got this error
message : 
Missing right curly or square bracket at /home/koha/src/cataloguing/addbooks.pl
line 158, at end of line
syntax error at /home/koha/src/cataloguing/addbooks.pl line 158, at EOF
Execution of /home/koha/src/cataloguing/addbooks.pl aborted due to compilation
errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9163] Cataloguing validation workflow

2013-03-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163

Fridolyn SOMERS  changed:

   What|Removed |Added

  Attachment #13743|0   |1
is obsolete||

--- Comment #6 from Fridolyn SOMERS  ---
Created attachment 16384
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16384&action=edit
BUG 9163 - Patch2 use user permissions instead of systempreferences

Rebased patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9163] Cataloguing validation workflow

2013-03-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163

Fridolyn SOMERS  changed:

   What|Removed |Added

  Attachment #13737|0   |1
is obsolete||

--- Comment #5 from Fridolyn SOMERS  ---
Created attachment 16383
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16383&action=edit
BUG 9163 - Cataloguing validation workflow

Rebased patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9163] Cataloguing validation workflow

2012-12-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163

--- Comment #4 from Vitor Fernandes  ---
Hi Kyle,

Sorry for not having a test plan.
This patch was added before the adding of the guidelines for submitting
patches.

Test plan:

- OpacSuppression must be active
- set CatalogingValidation on
- change all frameworks to have 942$n hidden
- create a framework with 942$n visible (this framework will be the validation
framework)
- set CatalogingValidationFramework = code of validation framework

- you will need to users to test (or you will have to change the permissions):
set to one for them permissions to access the validation framework

- try to catalogue with one user that doesn't have permission : the validation
framework shouldn't appear (even on addbiblio.pl and addbook.pl)

- try to catalogue with one user that have permissions : the validation
framework should appear (even on addbiblio.pl and addbook.pl)

- when cataloguing with frameworks different than the validation, the records
should be added with 942$n = 1- so the cataloguing is done but needs validation

- with the validation framework access the record added, validade the
cataloguing and then set the 942$n = 0 - cataloguing validated

If you have any question, be free to ask.

NOTE: I've saw a error on CataloguingValidation system preference description,
but you can correct it:

OPACSuppresion -> OpacSuppression
The users with access to the validation framework are set in
CatalogingValidationUsers -> you can remove this line

THANKS Kyle.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9163] Cataloguing validation workflow

2012-12-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #3 from Kyle M Hall  ---
Could you please add a test plan for this patch?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9163] Cataloguing validation workflow

2012-11-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163

--- Comment #2 from Vitor Fernandes  ---
Created attachment 13743
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13743&action=edit
BUG 9163 - Patch2 use user permissions instead of systempreferences

New user permission added to access the validation framework, under edit
catalogue section.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9163] Cataloguing validation workflow

2012-11-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163

Vitor Fernandes  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9163] Cataloguing validation workflow

2012-11-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163

--- Comment #1 from Vitor Fernandes  ---
Created attachment 13737
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13737&action=edit
BUG 9163 - Cataloguing validation workflow

Added 3 systems preferences instead of one:

- 1 to use/not use the validation workflow
- 1 to set the validation framework code
- 1 to set the users with access to the validation framework

addbook.pl and addbiblio.pl show the frameworkcodes in the drop list according
to settings:

- if validation off shows all
- if validation on and framework code is different than validation framework
code, shows the framework code
- if validation on and framework code equal to validation framework code and
the user have permissions, shows the framework code
- if validation on and framework code equal to validation framework code and
the user doesn't have permissions, don't shows the framework code

addbiblio.pl also changed to:

- prevent any user to use the validation framework (if validation on) when
putting the code in the browser URL
- if validation on always set suppress = 1 in framework different than the
validating one

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9163] Cataloguing validation workflow

2012-11-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163

Vitor Fernandes  changed:

   What|Removed |Added

   Priority|P5 - low|P1 - high
  Change sponsored?|--- |Sponsored
   Assignee|gmcha...@gmail.com  |vfernan...@keep.pt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/