[Koha-bugs] [Bug 9174] Item type image does not display for biblio-level itemtypes in list display in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9174 Chris Cormack changed: What|Removed |Added Status|Passed QA |Pushed to Stable --- Comment #13 from Chris Cormack --- Pushed to 3.8.x will be in 3.8.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9174] Item type image does not display for biblio-level itemtypes in list display in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9174 Chris Cormack changed: What|Removed |Added Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9174] Item type image does not display for biblio-level itemtypes in list display in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9174 Jared Camins-Esakov changed: What|Removed |Added Status|Pushed to Stable|In Discussion --- Comment #12 from Jared Camins-Esakov --- The attached patch applies to both 3.8.x and 3.6.x, and is needed on both branches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9174] Item type image does not display for biblio-level itemtypes in list display in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9174 Jared Camins-Esakov changed: What|Removed |Added Attachment #14937|0 |1 is obsolete|| Attachment #14938|0 |1 is obsolete|| --- Comment #11 from Jared Camins-Esakov --- Created attachment 15022 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15022&action=edit Bug 9174: [3.8.x] Fix itemtype image display in OPAC lists Prior to this patch, C4::VirtualShelves::Page did not make sure that the itemtype images that it chose when displaying itemtype images for biblio-level itemtypes were for the correct interface, so even on the OPAC the Intranet icons were requested. On standard installations, intranet-tmpl is not available to the OPAC. To test: 1) Set noItemTypeImages to "Show" and item-level_items to "biblio record" 2) Create a list and add an item with the default item type (942$c in MARC21) set to something with an itemtype image associated with it. 3) View the list in the OPAC. 4) If you are an a standard install, the itemtype image will be a broken link. If on a dev install, you can confirm with Firebug or the like that the image is pulled from /intranet-tmpl. 5) Apply patch. 6) Run `prove t/db_dependent/Koha.t` to confirm that the behavior of the routine used to retrieve the image URL is correct. (Note that you must have an item type with the code 'BK') 7) Refresh the list, noting that the display is now correct/the image is pulled from opac-tmpl. Signed-off-by: Jonathan Druart It works as expected. All tests in Koha.t passed. Signed-off-by: Mason James Signed-off-by: Jared Camins-Esakov Conflicts: t/db_dependent/Koha.t Squashed with: Bug 9174 follow-up: Eliminate warning and fix POD Thanks to Marcel for spotting these issues. Signed-off-by: Chris Cormack Signed-off-by: Mason James Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9174] Item type image does not display for biblio-level itemtypes in list display in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9174 Chris Cormack changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #10 from Chris Cormack --- Pushed to 3.10.x will be in 3.10.3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9174] Item type image does not display for biblio-level itemtypes in list display in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9174 Jared Camins-Esakov changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #9 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9174] Item type image does not display for biblio-level itemtypes in list display in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9174 Mason James changed: What|Removed |Added CC||m...@kohaaloha.com --- Comment #8 from Mason James --- (In reply to comment #7) > Created attachment 14938 [details] > Bug 9174 follow-up: Eliminate warning and fix POD > > Signed-off-by: Chris Cormack > Signed-off-by: Mason James testing 2 commit(s) (applied to f8686e9 'Bug 9116: Remove some useless tmp var') passing QA, works as expected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9174] Item type image does not display for biblio-level itemtypes in list display in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9174 Mason James changed: What|Removed |Added Attachment #14351|0 |1 is obsolete|| --- Comment #7 from Mason James --- Created attachment 14938 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14938&action=edit Bug 9174 follow-up: Eliminate warning and fix POD Thanks to Marcel for spotting these issues. Signed-off-by: Chris Cormack Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9174] Item type image does not display for biblio-level itemtypes in list display in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9174 Mason James changed: What|Removed |Added Attachment #13911|0 |1 is obsolete|| --- Comment #6 from Mason James --- Created attachment 14937 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14937&action=edit Bug 9174: Fix itemtype image display in OPAC lists Prior to this patch, C4::VirtualShelves::Page did not make sure that the itemtype images that it chose when displaying itemtype images for biblio-level itemtypes were for the correct interface, so even on the OPAC the Intranet icons were requested. On standard installations, intranet-tmpl is not available to the OPAC. To test: 1) Set noItemTypeImages to "Show" and item-level_items to "biblio record" 2) Create a list and add an item with the default item type (942$c in MARC21) set to something with an itemtype image associated with it. 3) View the list in the OPAC. 4) If you are an a standard install, the itemtype image will be a broken link. If on a dev install, you can confirm with Firebug or the like that the image is pulled from /intranet-tmpl. 5) Apply patch. 6) Run `prove t/db_dependent/Koha.t` to confirm that the behavior of the routine used to retrieve the image URL is correct. (Note that you must have an item type with the code 'BK') 7) Refresh the list, noting that the display is now correct/the image is pulled from opac-tmpl. Signed-off-by: Jonathan Druart It works as expected. All tests in Koha.t passed. Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9174] Item type image does not display for biblio-level itemtypes in list display in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9174 Mason James changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9174] Item type image does not display for biblio-level itemtypes in list display in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9174 Chris Cormack changed: What|Removed |Added Attachment #14347|0 |1 is obsolete|| --- Comment #5 from Chris Cormack --- Created attachment 14351 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14351&action=edit Bug 9174 follow-up: Eliminate warning and fix POD Thanks to Marcel for spotting these issues. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9174] Item type image does not display for biblio-level itemtypes in list display in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9174 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9174] Item type image does not display for biblio-level itemtypes in list display in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9174 Jared Camins-Esakov changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9174] Item type image does not display for biblio-level itemtypes in list display in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9174 --- Comment #4 from Jared Camins-Esakov --- Created attachment 14347 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14347&action=edit Bug 9174 follow-up: Eliminate warning and fix POD Thanks to Marcel for spotting these issues. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9174] Item type image does not display for biblio-level itemtypes in list display in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9174 M. de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA CC||m.de.r...@rijksmuseum.nl Patch complexity|--- |Small patch QA Contact||m.de.r...@rijksmuseum.nl --- Comment #3 from M. de Rooy --- QA Comment: Works as expected. Code looks good to me too. Small sidenote: POD documentation of getitemtypeinfo was copied from getitemtype. Still contains wrong procedure name. You touched that line. Could you correct it when you look at the following point? Also note that the second parameter is optional. It is called more often than from lists. If you do not test if $interface is defined, you will create a lot of noise in the logs due to it being uninitialized. See the line with test $interface eq 'opac' in C4/Koha.pm routine getitemtypeinfo. For the last reason parking this report to Failed QA. Please correct or send a follow-up. Thanks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9174] Item type image does not display for biblio-level itemtypes in list display in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9174 Jonathan Druart changed: What|Removed |Added Attachment #13791|0 |1 is obsolete|| --- Comment #2 from Jonathan Druart --- Created attachment 13911 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13911&action=edit Bug 9174: Fix itemtype image display in OPAC lists Prior to this patch, C4::VirtualShelves::Page did not make sure that the itemtype images that it chose when displaying itemtype images for biblio-level itemtypes were for the correct interface, so even on the OPAC the Intranet icons were requested. On standard installations, intranet-tmpl is not available to the OPAC. To test: 1) Set noItemTypeImages to "Show" and item-level_items to "biblio record" 2) Create a list and add an item with the default item type (942$c in MARC21) set to something with an itemtype image associated with it. 3) View the list in the OPAC. 4) If you are an a standard install, the itemtype image will be a broken link. If on a dev install, you can confirm with Firebug or the like that the image is pulled from /intranet-tmpl. 5) Apply patch. 6) Run `prove t/db_dependent/Koha.t` to confirm that the behavior of the routine used to retrieve the image URL is correct. (Note that you must have an item type with the code 'BK') 7) Refresh the list, noting that the display is now correct/the image is pulled from opac-tmpl. Signed-off-by: Jonathan Druart It works as expected. All tests in Koha.t passed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9174] Item type image does not display for biblio-level itemtypes in list display in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9174 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9174] Item type image does not display for biblio-level itemtypes in list display in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9174 --- Comment #1 from Jared Camins-Esakov --- Created attachment 13791 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13791&action=edit Bug 9174: Fix itemtype image display in OPAC lists Prior to this patch, C4::VirtualShelves::Page did not make sure that the itemtype images that it chose when displaying itemtype images for biblio-level itemtypes were for the correct interface, so even on the OPAC the Intranet icons were requested. On standard installations, intranet-tmpl is not available to the OPAC. To test: 1) Set noItemTypeImages to "Show" and item-level_items to "biblio record" 2) Create a list and add an item with the default item type (942$c in MARC21) set to something with an itemtype image associated with it. 3) View the list in the OPAC. 4) If you are an a standard install, the itemtype image will be a broken link. If on a dev install, you can confirm with Firebug or the like that the image is pulled from /intranet-tmpl. 5) Apply patch. 6) Run `prove t/db_dependent/Koha.t` to confirm that the behavior of the routine used to retrieve the image URL is correct. (Note that you must have an item type with the code 'BK') 7) Refresh the list, noting that the display is now correct/the image is pulled from opac-tmpl. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9174] Item type image does not display for biblio-level itemtypes in list display in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9174 Jared Camins-Esakov changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
