[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Jonathan Druart changed: What|Removed |Added Blocks||12332 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Fridolin SOMERS changed: What|Removed |Added Blocks||11802 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #31 from Galen Charlton --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Jonathan Druart changed: What|Removed |Added Patch complexity|Small patch |Medium patch QA Contact||jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Jonathan Druart changed: What|Removed |Added Attachment #20806|0 |1 is obsolete|| --- Comment #27 from Jonathan Druart --- Created attachment 22900 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22900&action=edit Bug 9261 - Allow librarians to make purchase suggestions for patrons - QA Followup 3 Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 --- Comment #30 from Jonathan Druart --- Created attachment 22903 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22903&action=edit Bug 9261: Title is required when adding a new suggestion I don't know if it was a bug but at the OPAC, title is a required field and not on the staff interface. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 --- Comment #29 from Jonathan Druart --- Created attachment 22902 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22902&action=edit Bug 9261: QA followup: ergonomic improvement and GPL version change This patch: - changes the GPL version from 2 to 3. - uses the datatables.inc file - removes the single pixel before and after the DT (modifying the sDom value). Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Jonathan Druart changed: What|Removed |Added Attachment #22843|0 |1 is obsolete|| --- Comment #28 from Jonathan Druart --- Created attachment 22901 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22901&action=edit Bug 9261 - Allow librarians to make purchase suggestions for patrons - QA Followup 4 Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Jonathan Druart changed: What|Removed |Added Attachment #20008|0 |1 is obsolete|| --- Comment #26 from Jonathan Druart --- Created attachment 22899 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22899&action=edit Bug 9261 - Allow librarians to make purchase suggestions for patrons - QA Followup 2 Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Jonathan Druart changed: What|Removed |Added Attachment #20003|0 |1 is obsolete|| --- Comment #25 from Jonathan Druart --- Created attachment 22898 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22898&action=edit Bug 9261 - Allow librarians to make purchase suggestions for patrons - QA Followup Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Jonathan Druart changed: What|Removed |Added Attachment #20002|0 |1 is obsolete|| --- Comment #24 from Jonathan Druart --- Created attachment 22897 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22897&action=edit Bug 9261 - Allow librarians to make purchase suggestions for patrons This patch adds a new tab to the patron side menu for purchase suggestions. >From this new tab, a librarian can view the patron's existing purchase suggestios and also create new suggestions in the name of that patron. Test Plan: 1) Apply patch 2) Ensure the system preference 'suggestions' is enabled 3) View the details for a patron 4) Click the new 'Purchase suggestions' tab 5) Click the 'New purchase suggestion' button 6) Add the new purchase suggestions 7) You should now end up back at the borrowers purchase suggetions 8) Verify the new purchase suggestion was added Signed-off-by: Corey Fuimaono Step though the test plan. All OK. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #23 from Jonathan Druart --- QA comment: All works as expected, no bug found. Maybe the redirect stuff could be used when clicking on a suggestion from the patron page (with a link "back to the patron's suggestions", instead of "Back to suggestions"). But it is not blocker. 2 errors from qa tools: FAILmembers/purchase-suggestions.pl FAIL forbidden patterns forbidden pattern: Koha is now under the GPLv3 license (line 9) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/members/purchase-suggestions.tt FAIL forbidden patterns forbidden pattern: To include datatables files, please use the include file (see bug 10868) (line 11) Will be fixed in a followup. Please Kyle protests if you disagree with the GPL version change (I only write that for the sake of form, I know you will agree :)). Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Jonathan Druart changed: What|Removed |Added QA Contact|jonathan.dru...@biblibre.co | |m | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 --- Comment #22 from Kyle M Hall --- Created attachment 22843 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22843&action=edit Bug 9261 - Allow librarians to make purchase suggestions for patrons - QA Followup 4 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 --- Comment #21 from mathieu saby --- Hi Kyle, this patch would be very interesting for us. Do you think you can fix the issues raised by Katrin? For the idea of making a distinction between 2 kinds of suggestion, I don't think it is necessary. If a patron fill a printed suggestion form and if we copy it in Koha (that's the way we could use it, to manage all our suggestions in Koha), he won't be surprised to see this suggestion in OPAC. M. Saby -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA CC||katrin.fisc...@bsz-bw.de --- Comment #20 from Katrin Fischer --- Hi Kyle, starting with the tests and a first code review: Would you be ok updating to GPLv3+? FAILmembers/purchase-suggestions.pl OK pod FAIL forbidden patterns forbidden pattern: Koha is now under the GPLv3 license (line 9) Is this still relevant? +DHTMLcalendar_dateformat => C4::Dates->DHTMLcalendar(), I wonder if we need a way to allow for disabling this functionality in the patron account or a way to differentiate between suggestions created by the user in the OPAC and by a staff member. And not failing for this - but so you can take a look at the other 2 things. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 --- Comment #19 from Kyle M Hall --- Created attachment 20806 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20806&action=edit Bug 9261 - Allow librarians to make purchase suggestions for patrons - QA Followup 3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #18 from Owen Leonard --- This latest patch doesn't remove the YUI JavaScript, so even though the button looks correct there is still a JS error on the page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Kyle M Hall changed: What|Removed |Added Attachment #20007|0 |1 is obsolete|| --- Comment #17 from Kyle M Hall --- Created attachment 20008 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20008&action=edit Bug 9261 - Allow librarians to make purchase suggestions for patrons - QA Followup 2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 --- Comment #16 from Kyle M Hall --- Created attachment 20007 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20007&action=edit Bug 9261 - Allow librarians to make purchase suggestions for patrons - QA Followup 2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #15 from Owen Leonard --- A couple of issues: - The template tries to build an old YUI-style button instead of the current Bootstrap version. - The table of suggestions should link to the suggestions detail page for that entry if the user has the correct permissions. (/cgi-bin/koha/suggestion/suggestion.pl?suggestionid=X&op=show I assume, a page which should probably be made more useful somehow). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Kyle M Hall changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Kyle M Hall changed: What|Removed |Added Attachment #16603|0 |1 is obsolete|| --- Comment #14 from Kyle M Hall --- Created attachment 20003 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20003&action=edit Bug 9261 - Allow librarians to make purchase suggestions for patrons - QA Followup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Kyle M Hall changed: What|Removed |Added Attachment #16602|0 |1 is obsolete|| --- Comment #13 from Kyle M Hall --- Created attachment 20002 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20002&action=edit Bug 9261 - Allow librarians to make purchase suggestions for patrons This patch adds a new tab to the patron side menu for purchase suggestions. >From this new tab, a librarian can view the patron's existing purchase suggestios and also create new suggestions in the name of that patron. Test Plan: 1) Apply patch 2) Ensure the system preference 'suggestions' is enabled 3) View the details for a patron 4) Click the new 'Purchase suggestions' tab 5) Click the 'New purchase suggestion' button 6) Add the new purchase suggestions 7) You should now end up back at the borrowers purchase suggetions 8) Verify the new purchase suggestion was added Signed-off-by: Corey Fuimaono Step though the test plan. All OK. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Srdjan Jankovic changed: What|Removed |Added CC||srd...@catalyst.net.nz --- Comment #12 from Srdjan Jankovic --- I got Can't use an undefined value as an ARRAY reference at /usr/lib/perl5/DBI.pm line 2054. when clicking on the "New purchase suggestion" button (empty list) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Nicole C. Engard changed: What|Removed |Added CC||mathieu.saby@univ-rennes2.f ||r --- Comment #11 from Nicole C. Engard --- *** Bug 9777 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Brendan Gallagher changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff CC||bren...@bywatersolutions.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Brendan Gallagher changed: What|Removed |Added Attachment #14677|0 |1 is obsolete|| --- Comment #10 from Brendan Gallagher --- Created attachment 16603 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16603&action=edit Bug 9261 - Allow librarians to make purchase suggestions for patrons - QA Followup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Brendan Gallagher changed: What|Removed |Added Attachment #14612|0 |1 is obsolete|| --- Comment #9 from Brendan Gallagher --- Created attachment 16602 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16602&action=edit Bug 9261 - Allow librarians to make purchase suggestions for patrons This patch adds a new tab to the patron side menu for purchase suggestions. >From this new tab, a librarian can view the patron's existing purchase suggestios and also create new suggestions in the name of that patron. Test Plan: 1) Apply patch 2) Ensure the system preference 'suggestions' is enabled 3) View the details for a patron 4) Click the new 'Purchase suggestions' tab 5) Click the 'New purchase suggestion' button 6) Add the new purchase suggestions 7) You should now end up back at the borrowers purchase suggetions 8) Verify the new purchase suggestion was added Signed-off-by: Corey Fuimaono Step though the test plan. All OK. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #8 from Jonathan Druart --- Could you rebase once again please (and perhaps squash these 2 patch into 1) ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Kyle M Hall changed: What|Removed |Added CC||agent@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Kyle M Hall changed: What|Removed |Added Assignee|agent@gmail.com |k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #7 from Kyle M Hall --- > - template_name => "members/purchase-suggestions.tmpl" could be .tt Fixed! > - in suggestion.pl, %hashlists is passed twice. Fixed! > - in suggestion.pl, $redirect could be eq to "purcharse-suggestion" with a > new param borrowernumber=[%borrowernumber%] in order to open the possibility > for an other script to use this redirection. Fixed! > - in purchase-suggestion.tt, some includes are useless: calendar.inc, > tablesorter.js Fixed! > - The new tab is sometimes displayed on 2 lines and sometimes on 1 lines > depending on which tab is enabled. I don't know how to fix that... This is because the tabs are not the same width on every page. Sometimes they are wide enough to get both words on one line, sometimes they are not. I've fixed this by forcing each word to always be on a separate line. > - on the way, could you fix 4 withespaces: >* suggestion/suggestion.pl > FAIL > forbidden patterns FAIL > The patch introduces a forbidden pattern: withespace character (77) > The patch introduces a forbidden pattern: withespace character (138) >* koha-tmpl/intranet-tmpl/prog/en/modules/members/purchase-suggestions.tt > FAIL > forbidden patterns FAIL > The patch introduces a forbidden pattern: withespace character (71) > The patch introduces a forbidden pattern: withespace character (62) > Fixed! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Kyle M Hall changed: What|Removed |Added Attachment #14675|0 |1 is obsolete|| --- Comment #6 from Kyle M Hall --- Created attachment 14677 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14677&action=edit Bug 9261 - Allow librarians to make purchase suggestions for patrons - QA Followup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 --- Comment #5 from Kyle M Hall --- Created attachment 14675 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14675&action=edit Bug 9261 - Allow librarians to make purchase suggestions for patrons - QA Followup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@biblibre.co ||m QA Contact||jonathan.dru...@biblibre.co ||m --- Comment #4 from Jonathan Druart --- QA comments: The patch is clean and works well. But I have some remarks: - template_name => "members/purchase-suggestions.tmpl" could be .tt - in suggestion.pl, %hashlists is passed twice. - in suggestion.pl, $redirect could be eq to "purcharse-suggestion" with a new param borrowernumber=[%borrowernumber%] in order to open the possibility for an other script to use this redirection. - in purchase-suggestion.tt, some includes are useless: calendar.inc, tablesorter.js - The new tab is sometimes displayed on 2 lines and sometimes on 1 lines depending on which tab is enabled. I don't know how to fix that... - on the way, could you fix 4 withespaces: * suggestion/suggestion.pl FAIL forbidden patterns FAIL The patch introduces a forbidden pattern: withespace character (77) The patch introduces a forbidden pattern: withespace character (138) * koha-tmpl/intranet-tmpl/prog/en/modules/members/purchase-suggestions.tt FAIL forbidden patterns FAIL The patch introduces a forbidden pattern: withespace character (71) The patch introduces a forbidden pattern: withespace character (62) Marked as Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Corey changed: What|Removed |Added Attachment #13999|0 |1 is obsolete|| Status|Needs Signoff |Signed Off Assignee|k...@bywatersolutions.com |agent@gmail.com --- Comment #3 from Corey --- Created attachment 14612 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14612&action=edit Verification of Previous Patch. OK. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Marijana Glavica changed: What|Removed |Added CC||mglav...@ffzg.hr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Kyle M Hall changed: What|Removed |Added CC||neng...@gmail.com --- Comment #2 from Kyle M Hall --- *** Bug 8527 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 --- Comment #1 from Kyle M Hall --- Created attachment 13999 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13999&action=edit Bug 9261 - Allow librarians to make purchase suggestions for patrons This patch adds a new tab to the patron side menu for purchase suggestions. >From this new tab, a librarian can view the patron's existing purchase suggestios and also create new suggestions in the name of that patron. Test Plan: 1) Apply patch 2) Ensure the system preference 'suggestions' is enabled 3) View the details for a patron 4) Click the new 'Purchase suggestions' tab 5) Click the 'New purchase suggestion' button 6) Add the new purchase suggestions 7) You should now end up back at the borrowers purchase suggetions 8) Verify the new purchase suggestion was added -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
