[Koha-bugs] [Bug 9325] overdue notices sent same messages for all users.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9325 Volkan Sonmez changed: What|Removed |Added CC||mvson...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9325] overdue notices sent same messages for all users.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9325 --- Comment #5 from Volkan Sonmez --- Created attachment 14420 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14420&action=edit Fix generation of same overdue letter for different patrons Using C4::Letters::GetProcessedLetter instead of C4::Letters::GetPreparedLetter in parse_letter causes problem. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9325] overdue notices sent same messages for all users.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9325 Katrin Fischer changed: What|Removed |Added Status|In Discussion |RESOLVED CC||katrin.fisc...@bsz-bw.de Resolution|--- |FIXED --- Comment #4 from Katrin Fischer --- Bug 8378 that caused this bug has been reverted from master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9325] overdue notices sent same messages for all users.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9325 Liz Rea (CatalystIT) changed: What|Removed |Added CC||l...@catalyst.net.nz --- Comment #3 from Liz Rea (CatalystIT) --- Steps to reproduce the bug (copied from 8378): 1. make 2 checkouts with 2 different borrowers of the same categorycode 2. make these checkouts become overdue "update issues set date_due='-XX-XX XX:XX' where borrowernumber IN(X,Y)" 3. run misc/cronjobs/overdue_notices.pl -n You should obtain the same letter twice. 4. Now apply the patch and re-run misc/cronjobs/overdue_notices.pl -n You should obtain 2 different letters. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9325] overdue notices sent same messages for all users.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9325
Chris Cormack changed:
What|Removed |Added
Status|Needs Signoff |In Discussion
CC||ch...@bigballofwax.co.nz
--- Comment #2 from Chris Cormack ---
Commit 40f9914e60e002ae4cbf10d09cff8bbf32abd8fe for bug 8378 created this bad
behaviour.
I would be in favour of reverting that, and fixing the fines bug by just doing
@@ -671,7 +679,7 @@ sub parse_letter {
my $currency_format;
if ($params->{'letter'}->{'content'} =~ m/(.*)<\/fine>/o) { #
process any fine tags...
$currency_format = $1;
-$params->{'letter'}->{'content'} =~
s/.*<\/fine>/<>/o;
+$params->{'letter'}->{'content'} =~
s/.*<\/fine>/<>/o;
}
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9325] overdue notices sent same messages for all users.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9325 Derryn changed: What|Removed |Added CC||derr...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9325] overdue notices sent same messages for all users.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9325 Jonathan Druart changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=8378 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9325] overdue notices sent same messages for all users.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9325 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9325] overdue notices sent same messages for all users.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9325 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |julian.maur...@biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9325] overdue notices sent same messages for all users.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9325 --- Comment #1 from Jonathan Druart --- Created attachment 14297 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14297&action=edit Bug 9325: Fix overdue letter generation In overdue_notices.pl, letter template must not be passed to parse_letter because this sub modifies it, so the first overdue letter is ok but following letters have exactly the same content. This patch make a copy of the template before passing it to parse_letter -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
