[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Blocks||12410 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #26016|0 |1 is obsolete|| --- Comment #33 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 26327 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26327action=edit [PASSED QA] Bug 9366: On cataloguing each user can easily display tags or not If the syspref hide_marc is set to don't display, tags are not shown by default. This patch adds a checkbox to hide/show tags directly on the cataloguing page. The value is stored in a cookie. Test plan: Enable/disable the sysprefs hide_marc and advancedMARCeditor in order to check if the display is according with what the user want. Reload the page and verify the value is kept. The first value of the cookie is retrieved from the hide_marc pref. Bonus: This patch removes the link Show MARCtag documentation links if the syspref advancedMARCeditor is enabled. Signed-off-by: Joel Aloi alo...@live.fr Signed-off-by: Katrin Fischer katrin.fischer...@web.de This works as described, the editor will remember the choices made by the cataloguer. Passes all tests and QA script. Notes: - The error messages for mandatory fields upon saving only give the tag number and not the description, so this might require to turn back on the tag display. - The advancedMARCeditor doesn't display the documentation links before and after the patch was applied. I think it could still be useful for an advanced cataloger to be able to look up information on a field quickly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #34 from Galen Charlton gmcha...@gmail.com --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 sandbo...@biblibre.com sandbo...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||sandbo...@biblibre.com --- Comment #31 from sandbo...@biblibre.com sandbo...@biblibre.com --- Patch tested with a sandbox, by Joel Aloi alo...@live.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 sandbo...@biblibre.com sandbo...@biblibre.com changed: What|Removed |Added Attachment #25821|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #18868|0 |1 is obsolete|| Attachment #18869|0 |1 is obsolete|| --- Comment #29 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 25821 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25821action=edit Bug 9366: On cataloguing each user can easily display tags or not If the syspref hide_marc is set to don't display, tags are not shown by default. This patch adds a checkbox to hide/show tags directly on the cataloguing page. The value is stored in a cookie. Test plan: Enable/disable the sysprefs hide_marc and advancedMARCeditor in order to check if the display is according with what the user want. Reload the page and verify the value is kept. The first value of the cookie is retrieved from the hide_marc pref. Bonus: This patch removes the link Show MARCtag documentation links if the syspref advancedMARCeditor is enabled. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 --- Comment #30 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Katrin Fischer from comment #28) Some comments on this: I took all your comments into account. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #28 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Some comments on this: 1) Why not make the option sticky and saving the choice in a cookie? As it is currently it seems that you will have to recheck the checkbox for every new title that you catalog. It would be nice if it behaved the same as the Show MARC tag documentation links feature. 2) There seems to be a weird problem when switching frameworks: - Go to cataloguing - Create a new record based on the default framework - Switch the framework to Audio... - Switch back to default What I had happen was that after switching the framework, I would be redirectd to the item form and an empty record was saved. I couldn't reproduce this behaviour on master without the patch applied. 3) Why not place the Hide tags next to Show MARC tag documentation links? 4) As we have a separate option to hide documentation links, I think hiding the tags should only hide the tags, but not the documentation links. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|In Discussion |Signed Off --- Comment #27 from Jonathan Druart jonathan.dru...@biblibre.com --- I leave the in discussion status since there is no discussion. Switch back to Signed Off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added QA Contact||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 --- Comment #21 from M. de Rooy m.de.r...@rijksmuseum.nl --- QA: Looking at this one now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |In Discussion --- Comment #22 from M. de Rooy m.de.r...@rijksmuseum.nl --- QA Comment: I have two comments. The first having more weight than the second. If I am hiding descriptions, I am not sure what the purpose is of Hide tags in that case. If both tag and description is gone, a user cannot know what he is doing. Note that this is possible too in current master also but only via setting both prefs to disabled (which is less likely). IMO We should not offer to hide both labels; we are only supporting cataloging errors here ;) I suggest to only offer Hide tags if the description is visible. Furtermore, I have some doubts about keeping the pref while adding the checkbox. Maybe we actually want some staff patron cataloging preference instead, allowing some users to have the tags and others not.. Setting this report to In Discussion. Hoping for some feedback from all involved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 --- Comment #23 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to M. de Rooy from comment #22) QA Comment: I have two comments. The first having more weight than the second. If I am hiding descriptions, I am not sure what the purpose is of Hide tags in that case. If both tag and description is gone, a user cannot know what he is doing. Note that this is possible too in current master also but only via setting both prefs to disabled (which is less likely). IMO We should not offer to hide both labels; we are only supporting cataloging errors here ;) I suggest to only offer Hide tags if the description is visible. I preferred to keep existing choices instead of restricting them. But maybe you are right, it could be improved. Furtermore, I have some doubts about keeping the pref while adding the checkbox. Maybe we actually want some staff patron cataloging preference instead, allowing some users to have the tags and others not.. The pref is the default behavior, if we remove it, catalogers will have to check/uncheck the checkbox each time. Currently, Koha does not offer the possibility to have this kind of preference per patron. Waiting for others points of view. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 --- Comment #24 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to Jonathan Druart from comment #23) The pref is the default behavior, if we remove it, catalogers will have to check/uncheck the checkbox each time. Currently, Koha does not offer the possibility to have this kind of preference per patron. For completeness: I do not suggest to remove it on its own. I am thinking about having a patron preference controlling it, because it seems that we need something more than current functionality. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 --- Comment #25 from M. de Rooy m.de.r...@rijksmuseum.nl --- Note that we already have patron messaging preferences. You could easily have patron cataloging preferences too? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 --- Comment #26 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to M. de Rooy from comment #25) Note that we already have patron messaging preferences. You could easily have patron cataloging preferences too? Yes, but it is completely out of the scope of this bug :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added QA Contact|katrin.fisc...@bsz-bw.de| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Signed Off |Patch doesn't apply CC||ch...@bigballofwax.co.nz --- Comment #18 from Chris Cormack ch...@bigballofwax.co.nz --- Lots of conflicts in koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #16978|0 |1 is obsolete|| Attachment #16979|0 |1 is obsolete|| --- Comment #19 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18868 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18868action=edit Bug 9366: On cataloguing each user can easily display tags or not If the syspref hide_marc is set to don't display, tags are not shown by default. This patch adds a checkbox to hide/show tags directly on the cataloguing page. Test plan: Enable/disable the sysprefs hide_marc and advancedMARCeditor in order to check if the display is according with what the user want. Bonus: This patch removes the link Show MARCtag documentation links if the syspref advancedMARCeditor is enabled. Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com All tests pass. http://bugs.koha-community.org/show_bug.cgi?id=9803 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 --- Comment #20 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18869 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18869action=edit Bug 9366: FIX typo s/class/style It replaces the vertical-align with a margin-left Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com http://bugs.koha-community.org/show_bug.cgi?id=9803 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #16107|0 |1 is obsolete|| Attachment #16109|0 |1 is obsolete|| --- Comment #16 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 16978 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16978action=edit Bug 9366: On cataloguing each user can easily display tags or not If the syspref hide_marc is set to don't display, tags are not shown by default. This patch adds a checkbox to hide/show tags directly on the cataloguing page. Test plan: Enable/disable the sysprefs hide_marc and advancedMARCeditor in order to check if the display is according with what the user want. Bonus: This patch removes the link Show MARCtag documentation links if the syspref advancedMARCeditor is enabled. Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com All tests pass. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 --- Comment #17 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 16979 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16979action=edit Bug 9366: FIX typo s/class/style It replaces the vertical-align with a margin-left Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com http://bugs.koha-community.org/show_bug.cgi?id=9803 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Depends on||9803 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 --- Comment #11 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Jonathan - could you please fix the merge conflict with current master? I didn't want to do it wrong. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #15490|0 |1 is obsolete|| Attachment #15491|0 |1 is obsolete|| --- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 16107 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16107action=edit Bug 9366: On cataloguing each user can easily display tags or not If the syspref hide_marc is set to don't display, tags are not shown by default. This patch adds a checkbox to hide/show tags directly on the cataloguing page. Test plan: Enable/disable the sysprefs hide_marc and advancedMARCeditor in order to check if the display is according with what the user want. Bonus: This patch removes the link Show MARCtag documentation links if the syspref advancedMARCeditor is enabled. Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com All tests pass. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 --- Comment #13 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 16108 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16108action=edit Bug 9366: FIX typo s/class/style + add a margin-left for the checkbox Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #16108|0 |1 is obsolete|| --- Comment #14 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 16109 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16109action=edit Bug 9366: FIX typo s/class/style It replaces the vertical-align with a margin-left Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply |Signed Off --- Comment #15 from Jonathan Druart jonathan.dru...@biblibre.com --- Katrin, I switch back to Signed Off. Conflicts was quite easy. I modified the followup by replacing the vertical-align with a margin-left (vertical-align seems useless with the Bootstrap toolbar). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 --- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com --- Katrin, The deleted code was used to hide some inputs. Now this is done through the javascript code. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #14526|0 |1 is obsolete|| Attachment #14527|0 |1 is obsolete|| --- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 15490 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15490action=edit Bug 9366: On cataloguing each user can easily display tags or not If the syspref hide_marc is set to don't display, tags are not shown by default. This patch adds a checkbox to hide/show tags directly on the cataloguing page. Test plan: Enable/disable the sysprefs hide_marc and advancedMARCeditor in order to check if the display is according with what the user want. Bonus: This patch removes the link Show MARCtag documentation links if the syspref advancedMARCeditor is enabled. Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com All tests pass. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 --- Comment #10 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 15491 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15491action=edit Bug 9366: FIX typo s/class/style Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Patch doesn't apply CC||katrin.fisc...@bsz-bw.de QA Contact||katrin.fisc...@bsz-bw.de --- Comment #7 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Patch doesn't apply - please rebase. I noticed that you delete larger parts of the existing code, but I don't see how this is relevant for the new feature. Could you explain some? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Attachment #14469|0 |1 is obsolete|| --- Comment #5 from Nicole C. Engard neng...@gmail.com --- Created attachment 14526 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14526action=edit [SIGNED-OFF] Bug 9366: On cataloguing each user can easily display tags or not If the syspref hide_marc is set to don't display, tags are not shown by default. This patch adds a checkbox to hide/show tags directly on the cataloguing page. Test plan: Enable/disable the sysprefs hide_marc and advancedMARCeditor in order to check if the display is according with what the user want. Bonus: This patch removes the link Show MARCtag documentation links if the syspref advancedMARCeditor is enabled. Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com All tests pass. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||neng...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Attachment #14470|0 |1 is obsolete|| --- Comment #6 from Nicole C. Engard neng...@gmail.com --- Created attachment 14527 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14527action=edit [SIGNED-OFF] Bug 9366: FIX typo s/class/style Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 --- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 14469 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14469action=edit Bug 9366: On cataloguing each user can easily display tags or not If the syspref hide_marc is set to don't display, tags are not shown by default. This patch adds a checkbox to hide/show tags directly on the cataloguing page. Test plan: Enable/disable the sysprefs hide_marc and advancedMARCeditor in order to check if the display is according with what the user want. Bonus: This patch removes the link Show MARCtag documentation links if the syspref advancedMARCeditor is enabled. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |ASSIGNED Assignee|gmcha...@gmail.com |jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 --- Comment #2 from Owen Leonard oleon...@myacpl.org --- This appears to be working correctly, but I see one little markup error: labelinput id=hide_tags type=checkbox class=vertical-align:middle;/Hide tags/label class=vertical-align:middle should be style=vertical-align:middle Hide tags should probably have a space before it too, for legibility. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 14470 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14470action=edit Bug 9366: FIX typo s/class/style -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to comment #2) This appears to be working correctly, but I see one little markup error Oops yes thanks. Fixed! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
