[Koha-bugs] [Bug 9382] Bold necessary permissions for staff client access.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9382 Manos PETRIDIS changed: What|Removed |Added CC||egpetri...@yahoo.com --- Comment #17 from Manos PETRIDIS --- Could this "CheckVersion" error have crept into v3.08.11 as well? If so, please check bug #9962 for details. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9382] Bold necessary permissions for staff client access.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9382 --- Comment #16 from Chris Cormack --- Fixed and new tarball pushed, thanks for the catch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9382] Bold necessary permissions for staff client access.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9382
Derryn changed:
What|Removed |Added
CC||derr...@gmail.com
--- Comment #15 from Derryn ---
When I updated from 3.10.00 to 3.10.03 the web installer throws this:
updatedatabase.pl: Undefined subroutine &main::CheckVersion called at
/usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line
6092.
That particular line was added by this patch:
if ( CheckVersion($DBversion) ) {
Upon further investigation, there is indeed no 'CheckVersion' subroutine that I
could find.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9382] Bold necessary permissions for staff client access.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9382 --- Comment #14 from Katrin Fischer --- Bug should not be reopened because it's already been pushed, so I think another patch has to go on a new bug? Should I file one? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9382] Bold necessary permissions for staff client access.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9382 --- Comment #13 from Katrin Fischer --- To be more clear - I am talking about the updatedatabase.pl part of this patch :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9382] Bold necessary permissions for staff client access.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9382 --- Comment #12 from Katrin Fischer --- For example we could check for English strings in the permissions description - so German and other translated permissions would not be harmed by this patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9382] Bold necessary permissions for staff client access.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9382 --- Comment #11 from Chris Cormack --- (In reply to comment #9) > Um, hate to point it out - but this untranslates existing translated > permissions for non-English installations... could we add a condition here > please? Sorry Katrin, not sure what you mean here? What kind of condition? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9382] Bold necessary permissions for staff client access.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9382 --- Comment #10 from Katrin Fischer --- Apart from that I think staffaccess does not do what the description says, as that is what permissions does: INSERT INTO `userflags` VALUES(5,'permissions','Set user permissions',0); +INSERT INTO `userflags` VALUES(17,'staffaccess','Allow staff members to modify permissions for other staff members',0); >From looking at the code and from what we experienced with one of our libraries I think the permission is actually about changing other staff account details (like passwords, usernames, etc.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9382] Bold necessary permissions for staff client access.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9382 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #9 from Katrin Fischer --- Um, hate to point it out - but this untranslates existing translated permissions for non-English installations... could we add a condition here please? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9382] Bold necessary permissions for staff client access.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9382 Chris Cormack changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #8 from Chris Cormack --- Pushed to 3.10.x will be in 3.10.3 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9382] Bold necessary permissions for staff client access.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9382 Jared Camins-Esakov changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #7 from Jared Camins-Esakov --- This patch has been pushed to master. There are still capitalization issues in the permissions, but the screen is much better with this patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9382] Bold necessary permissions for staff client access.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9382 Elliott Davis changed: What|Removed |Added Status|Signed Off |Passed QA CC||elli...@bywatersolutions.co ||m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9382] Bold necessary permissions for staff client access.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9382 Elliott Davis changed: What|Removed |Added Attachment #14902|0 |1 is obsolete|| --- Comment #6 from Elliott Davis --- Created attachment 14911 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14911&action=edit Bug 9382 - updating permission labels first, replicate: go to More -> permissions on any user. Notice that it says various things "privileges, flags, permissions" they are interchangeable and inconsistent. also note that some of the permissions are nonsensical and/or not descriptive enough, or not using canonical terminology (borrowers instead of patrons, for example) To test: interface consistency changes -> means "turns into" - page title - privileges -> permissions - breadcrumbs - privileges -> permissions - headings - privileges -> permissions - "set flags" button -> save Permissions that have changed description: - Catalogue changes to "Required for staff login" in bold (this was the original impetus for this boatload of changes) - reports - editauthorities - management - serials - updatecharges - circulate - parameters - borrowers - tools - staffaccess - edit_patrons (only on updatedb, not on new db) - Read through and make sure there are no typos, and that the descriptions seem to jive with what privileges the permission gives the user. Suggestions are, in fact, welcome. - If you are feeling ambitious, go ahead and create a new, clean database and check the wording there as well - it should match what has been done in the db update. Signed-off-by: Owen Leonard Tested both with existing database and new database Signed-off-by: Elliott Davis Tested with existing database. Introduces no new mysql-isms. Kudos for adding that syspref in bold, that got me when I first started with Koha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9382] Bold necessary permissions for staff client access.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9382 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9382] Bold necessary permissions for staff client access.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9382 Owen Leonard changed: What|Removed |Added Attachment #14762|0 |1 is obsolete|| --- Comment #5 from Owen Leonard --- Created attachment 14902 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14902&action=edit [SIGNED-OFF] Bug 9382 - updating permission labels first, replicate: go to More -> permissions on any user. Notice that it says various things "privileges, flags, permissions" they are interchangeable and inconsistent. also note that some of the permissions are nonsensical and/or not descriptive enough, or not using canonical terminology (borrowers instead of patrons, for example) To test: interface consistency changes -> means "turns into" - page title - privileges -> permissions - breadcrumbs - privileges -> permissions - headings - privileges -> permissions - "set flags" button -> save Permissions that have changed description: - Catalogue changes to "Required for staff login" in bold (this was the original impetus for this boatload of changes) - reports - editauthorities - management - serials - updatecharges - circulate - parameters - borrowers - tools - staffaccess - edit_patrons (only on updatedb, not on new db) - Read through and make sure there are no typos, and that the descriptions seem to jive with what privileges the permission gives the user. Suggestions are, in fact, welcome. - If you are feeling ambitious, go ahead and create a new, clean database and check the wording there as well - it should match what has been done in the db update. Signed-off-by: Owen Leonard Tested both with existing database and new database -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9382] Bold necessary permissions for staff client access.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9382 Liz Rea (CatalystIT) changed: What|Removed |Added Attachment #14760|0 |1 is obsolete|| --- Comment #4 from Liz Rea (CatalystIT) --- Created attachment 14762 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14762&action=edit Bug 9382 - updating permission labels first, replicate: go to More -> permissions on any user. Notice that it says various things "privileges, flags, permissions" they are interchangeable and inconsistent. also note that some of the permissions are nonsensical and/or not descriptive enough, or not using canonical terminology (borrowers instead of patrons, for example) To test: interface consistency changes -> means "turns into" - page title - privileges -> permissions - breadcrumbs - privileges -> permissions - headings - privileges -> permissions - "set flags" button -> save Permissions that have changed description: - Catalogue changes to "Required for staff login" in bold (this was the original impetus for this boatload of changes) - reports - editauthorities - management - serials - updatecharges - circulate - parameters - borrowers - tools - staffaccess - edit_patrons (only on updatedb, not on new db) - Read through and make sure there are no typos, and that the descriptions seem to jive with what privileges the permission gives the user. Suggestions are, in fact, welcome. - If you are feeling ambitious, go ahead and create a new, clean database and check the wording there as well - it should match what has been done in the db update. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9382] Bold necessary permissions for staff client access.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9382 Liz Rea (CatalystIT) changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9382] Bold necessary permissions for staff client access.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9382 --- Comment #3 from Liz Rea (CatalystIT) --- Ah thanks - will fix those things. :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9382] Bold necessary permissions for staff client access.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9382 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard --- I see a few differences between the start-from-scratch database and the updated-existing database versions: Flag 2, "catalogue": New db: "Staff access, allows viewing of catalogue in staff client.)" Updated db: Staff access, allows viewing of catalogue in staff client." (^^ extra ')' in new db) Flag 3, "parameters": New db: "Set Koha system parameters." Updated db: "Manage Koha system settings (Administration panel)" Flag 12, "management": New db: "Manage Koha system settings (Administration panel)" Updated db: "Set library management parameters (deprecated)" And by the way, unrelated to this patch: tools:edit_patrons New db: "Perform batch modification of patrons" Updated db: "Perform batch modifivation of patrons" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9382] Bold necessary permissions for staff client access.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9382 Liz Rea (CatalystIT) changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9382] Bold necessary permissions for staff client access.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9382 --- Comment #1 from Liz Rea (CatalystIT) --- Created attachment 14760 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14760&action=edit Bug 9382 - updating permission labels first, replicate: go to More -> permissions on any user. Notice that it says various things "privileges, flags, permissions" they are interchangeable and inconsistent. also note that some of the permissions are nonsensical and/or not descriptive enough, or not using canonical terminology (borrowers instead of patrons, for example) To test: interface consistency changes -> means "turns into" - page title - privileges -> permissions - breadcrumbs - privileges -> permissions - headings - privileges -> permissions - "set flags" button -> save Permissions that have changed description: - Catalogue changes to "Required for staff login" in bold (this was the original impetus for this boatload of changes) - reports - editauthorities - management - serials - updatecharges - circulate - parameters - borrowers - tools - staffaccess - Read through and make sure there are no typos, and that the descriptions seem to jive with what privileges the permission gives the user. Suggestions are, in fact, welcome. - If you are feeling ambitious, go ahead and create a new, clean database and check the wording there as well - it should match what has been done in the db update. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9382] Bold necessary permissions for staff client access.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9382 Nicole C. Engard changed: What|Removed |Added CC||neng...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
