[Koha-bugs] [Bug 9438] Biblio notes displayed when ordering
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9438 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added CC||fridolyn.som...@biblibre.co ||m Version|master |3.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9438] Biblio notes displayed when ordering
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9438 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added CC||paul.poul...@biblibre.com QA Contact||paul.poul...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9438] Biblio notes displayed when ordering
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9438 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #17 from Paul Poulain paul.poul...@biblibre.com --- QA comment: * passes koha-qa.pl * small patch, does the job nothing to add, pass QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9438] Biblio notes displayed when ordering
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9438 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #15064|0 |1 is obsolete|| Attachment #15187|0 |1 is obsolete|| --- Comment #18 from Paul Poulain paul.poul...@biblibre.com --- Created attachment 16576 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16576action=edit [PASSED QA] Bug 9438: biblio notes displayed when adding order The biblio notes should not appear in the Notes textarea of the New order page, in Acquisitions. TEST PLAN 1) Find a biblio with a note (for example 300$a in UNIMARC, 500$a in USMARC), or add a note to a biblio. 2) In a basket, create a new order for that title. Before the patch, the Notes textarea contains the note from the biblio. After the patch the textarea is empty. Signed-off-by: Owen Leonard oleon...@myacpl.org Signed-off-by: Paul Poulain paul.poul...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9438] Biblio notes displayed when ordering
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9438 --- Comment #19 from Paul Poulain paul.poul...@biblibre.com --- Created attachment 16577 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16577action=edit [PASSED QA] Follow-up Bug 9438 - Biblio notes displayed when ordering This patch re-enables displying Notes when select Modify order from basket view. To Test: 1) After applying first patch, Notes are empty when select Modify order 2) Apply patch 3) Now Notes are visible again, unless the order is new. Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Paul Poulain paul.poul...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9438] Biblio notes displayed when ordering
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9438 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #20 from Jared Camins-Esakov jcam...@cpbibliography.com --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9438] Biblio notes displayed when ordering
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9438 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #15070|0 |1 is obsolete|| --- Comment #15 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 15186 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15186action=edit [SIGNED-OFF] Follow-up Bug 9438 - Biblio notes displayed when ordering This patch re-enables displying Notes when select Modify order from basket view. To Test: 1) After applying first patch, Notes are empty when select Modify order 2) Apply patch 3) Now Notes are visible again, unless the order is new. Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9438] Biblio notes displayed when ordering
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9438 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9438] Biblio notes displayed when ordering
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9438 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #15186|0 |1 is obsolete|| --- Comment #16 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 15187 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15187action=edit Follow-up Bug 9438 - Biblio notes displayed when ordering This patch re-enables displying Notes when select Modify order from basket view. To Test: 1) After applying first patch, Notes are empty when select Modify order 2) Apply patch 3) Now Notes are visible again, unless the order is new. Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9438] Biblio notes displayed when ordering
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9438 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #15187|Follow-up Bug 9438 - Biblio |[SIGNED-OFF] Follow-up Bug description|notes displayed when|9438 - Biblio notes |ordering|displayed when ordering -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9438] Biblio notes displayed when ordering
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9438 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9438] Biblio notes displayed when ordering
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9438 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9438] Biblio notes displayed when ordering
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9438 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #14732|0 |1 is obsolete|| --- Comment #11 from Owen Leonard oleon...@myacpl.org --- Created attachment 15064 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15064action=edit [SIGNED-OFF] Bug 9438: biblio notes displayed when adding order The biblio notes should not appear in the Notes textarea of the New order page, in Acquisitions. TEST PLAN 1) Find a biblio with a note (for example 300$a in UNIMARC, 500$a in USMARC), or add a note to a biblio. 2) In a basket, create a new order for that title. Before the patch, the Notes textarea contains the note from the biblio. After the patch the textarea is empty. Signed-off-by: Owen Leonard oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9438] Biblio notes displayed when ordering
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9438
--- Comment #12 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Perhaps I'm wrong, but I found the following behavior:
1) Follow test plan after patch applied
2) In a new basket the Notes field in Accounting Details is empty
(was the place filled with 300a/500a), patch is working!
3) Add a note and save
4) When viewing the basket, press Modify order... and the Notes is empty!!
(the data is saved, in doubt do select notes from aqorders)
That was the meaning of my previous comment.
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt
is used to add AND modify a order in a basket. If you remove [% notes %] from
it then will never see your Accounting Details Notes again.
I got the expected behavior using:
in .../neworderempty.tt
[% IF ( notes ) %][% notes %][% END %]
and in .../neworderempty.pl
$template-param ( notes = $data-{'notes'} ) unless ( $ordernumber eq '' );
Regards
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9438] Biblio notes displayed when ordering
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9438 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #13 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Bernardo, I think your test sounds logical - I woudl like to see this resolved. Adrien - could you take a look please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9438] Biblio notes displayed when ordering
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9438 --- Comment #14 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 15070 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15070action=edit Follow-up Bug 9438 - Biblio notes displayed when ordering This patch re-enables displying Notes when select Modify order from basket view. To Test: 1) After applying first patch, Notes are empty when select Modify order 2) Apply patch 3) Now Notes are visible again, unless the order is new. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9438] Biblio notes displayed when ordering
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9438 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9438] Biblio notes displayed when ordering
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9438 --- Comment #7 from mathieu saby mathieu.s...@univ-rennes2.fr --- Galen Charlton and Zeno Tajoli agreed with the patch. So, Katrin, if it works, you can sign it off ;-) M. Saby -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9438] Biblio notes displayed when ordering
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9438 --- Comment #8 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Mathieu - I saw the mails on the mailing list, thank you for asking. I will try to sign off, but maybe better if I do QA on it instead? :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9438] Biblio notes displayed when ordering
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9438 --- Comment #9 from mathieu saby mathieu.s...@univ-rennes2.fr --- Ok, I will sign it off this afternoon, so you will be able to QA if you want. M. Saby -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9438] Biblio notes displayed when ordering
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9438
Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:
What|Removed |Added
CC||bgkrie...@gmail.com
--- Comment #10 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
This patch will never show order notes.
I think that the change needs to be in
acqui/neworderempty.pl.
Something like
392:notes = $data-{'notes'} unless ( $ordernumber eq '' ),
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9438] Biblio notes displayed when ordering
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9438 --- Comment #6 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Mathieu, I agree with you :) I am only worried because the confusing behaviour has been there for a long while. So maybe libraries do like the information to show up at least somewhere. So I think if we could just get some people to give an opinion here that would be a good thing. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9438] Biblio notes displayed when ordering
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9438 --- Comment #1 from Adrien SAURAT adrien.sau...@biblibre.com --- Created attachment 14732 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14732action=edit proposed patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9438] Biblio notes displayed when ordering
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9438 Adrien SAURAT adrien.sau...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9438] Biblio notes displayed when ordering
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9438 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Adrien, it has always (or for a very long time) been like this. I am not a fan, but I think we maybe need to ask if people find it useful or have to keep it as an option. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9438] Biblio notes displayed when ordering
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9438 --- Comment #3 from Adrien SAURAT adrien.sau...@biblibre.com --- I'm not a librarian and I really don't know how it should be =) Two librairies working with us saw this and considered this behaviour as a bug, that's all I know! This can wait until we have other opinions on the matter, of course. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9438] Biblio notes displayed when ordering
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9438 --- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I am not sure myself - maybe we should have a field for footnotes in the bibliographic area? So no information would be lost, but we would still free up the note in the acquisition area of the form for information about the order itself. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
