[Koha-bugs] [Bug 9525] group floating rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Emmi Takkinen changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Depends on|13906, 13995| --- Comment #45 from Emmi Takkinen --- Attached new patches, removed dependencies on bug 13906 and bug 13995. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906 [Bug 13906] TestObjectFactory(ies) for Koha objects. Enable easy Test object creation from HASHes or from preconfigured test groups. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995 [Bug 13995] Proper Exception handling -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #44 from Emmi Takkinen --- Created attachment 124827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124827&action=edit Bug 9525: Add option to define float groups and rules for float Bug 22284 introduced ability to create hold groups. We should have ability to create float groups in same manner. This patch adds checkbox "Is local float group" to group creation feature and new return policy "Item floats by librarygroup". To test: 1. Add new float group and some libraries to it. 2. From circulation and fine rules, set default return policy as "Item floats by library group". 3. Check out an item for a patron. 4. Set library as one that belongs in the same float group. 5. Check in the item. => Observe that notice for transfer doesn't pop up. 6. Check out again. 7. This time set library as one that doen's belong in the same float group. 8. Check in. => Observe that notice for transfer pops up. Experiment this feature by changing return policy per library, item type etc. Also prove t/db_dependent/Koha/Libraries.t Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #43 from Emmi Takkinen --- Created attachment 124826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124826&action=edit Bug 9525: DO NOT PUSH! Schema update Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Emmi Takkinen changed: What|Removed |Added Attachment #40102|0 |1 is obsolete|| Attachment #40103|0 |1 is obsolete|| Attachment #112550|0 |1 is obsolete|| Attachment #112551|0 |1 is obsolete|| Attachment #112552|0 |1 is obsolete|| Attachment #112553|0 |1 is obsolete|| --- Comment #42 from Emmi Takkinen --- Created attachment 124825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124825&action=edit Bug 9525: Add ft_local_float_group column This patch adds new ft_local_float_group column to library_groups table. To test: 1. Apply patch and update database 2. Confirm new column is added correctly to the library_groups table Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Emmi Takkinen changed: What|Removed |Added Assignee|olli-antti.kivila...@jns.fi |emmi.takki...@koha-suomi.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Emmi Takkinen changed: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #41 from Emmi Takkinen --- We are currently working on upcoming version update and have decided to ditch this floating matrix feature. Instead we've decided use float groups which work like hold groups introduced in bug 22284. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Emmi Takkinen changed: What|Removed |Added Attachment #103831|0 |1 is obsolete|| --- Comment #39 from Emmi Takkinen --- Created attachment 112553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112553&action=edit Bug 9525: Add support for regexps in conditional floating clauses itype =~ ^(KI|DV) or location eq 'SHELF' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Emmi Takkinen changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #40 from Emmi Takkinen --- Rebased patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Emmi Takkinen changed: What|Removed |Added Attachment #103830|0 |1 is obsolete|| --- Comment #38 from Emmi Takkinen --- Created attachment 112552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112552&action=edit Bug 9525: Fixing floating on return -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Emmi Takkinen changed: What|Removed |Added Attachment #103828|0 |1 is obsolete|| --- Comment #36 from Emmi Takkinen --- Created attachment 112550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112550&action=edit Bug 9525: Group floating rules +-+ | USAGE TIPS (sorry didn't document these in the GUI | +-+ When modifying a floating route rule, pressing "%" accepts the modification and pressing "V" cancels the modifications and reverts the old rule. The empty text box in the center of the route rule (under the floating type dropdown list) is the box for conditional rules, where you put the logical expression. +-+ | SETTING UP THE TEST CONTEXT | +-+ -1. Find an Item, which can be circulated freely, and has homebranch B and any holdingbranch. 0. Read the instructions at admin/floating-matrix.pl. +---+ | TEST PLAN: Disabled floating: +---+ 0. Make sure that the floating rules from branch A to branch B (A -> B) are "Disabled" and vice versa (B -> A). 1. Set your current library to A. 2. Check-in the Item. 3. Observe the started transport to branch B. 4. Set your current library to B. 5. Check-in to receive the transfer. +---+ | TEST PLAN: Always floating: +---+ 0. Make sure that the floating rules from branch A to branch B (A -> B) are "Allowed". 1. Set your current library to A. 2. Check-in the Item. 3. Observe that there is not transport prompt to branch B and the Item is not "in-transit" -state. +---+ | TEST PLAN: Possibly floating: +---+ 0. Make sure that the floating rules from branch A to branch B (A -> B) are "Possible". 1. Set your current library to A. 2. Check-in the Item. 3. Observe that there is a transport prompt to branch B. You can decide if you want to transfer or no. +---+ | TEST PLAN: Conditional floating: +---+ 0. Same as Always floating if the given condition matches. See the feature description at admin/floating-matrix.pl explaining Conditional floating. +---+ | TEST PLAN: Floating rule tester: +---+ 0. Add some floating rules between libraries 1. Choose origin library, destination library and give barcode for the item you want to test 2. Hit "Test" 3. Make sure box next to the "Test" button changes color according rules you made 4. Also for conditional floating use barcode for item that doesn't match given condition -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Emmi Takkinen changed: What|Removed |Added Attachment #103829|0 |1 is obsolete|| --- Comment #37 from Emmi Takkinen --- Created attachment 112551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112551&action=edit Bug 9525: Schema changes - DO NOT PUSH -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #35 from Lisette Scheer --- 103828 - Bug 9525: Group floating rules 103829 - Bug 9525: Schema changes - DO NOT PUSH 103830 - Bug 9525: Fixing floating on return 103831 - Bug 9525: Add support for regexps in conditional floating clauses Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 9525: Group floating rules Using index info to reconstruct a base tree... M C4/Circulation.pm M installer/data/mysql/kohastructure.sql M koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt Auto-merging installer/data/mysql/kohastructure.sql Auto-merging C4/Circulation.pm CONFLICT (content): Merge conflict in C4/Circulation.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 9525: Group floating rules -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Emmi Takkinen changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Emmi Takkinen changed: What|Removed |Added Attachment #100743|0 |1 is obsolete|| --- Comment #34 from Emmi Takkinen --- Created attachment 103831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103831&action=edit Bug 9525: Add support for regexps in conditional floating clauses -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Emmi Takkinen changed: What|Removed |Added Attachment #100742|0 |1 is obsolete|| --- Comment #33 from Emmi Takkinen --- Created attachment 103830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103830&action=edit Bug 9525: Fixing floating on return -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #32 from Emmi Takkinen --- Created attachment 103829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103829&action=edit Bug 9525: Schema changes - DO NOT PUSH -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Emmi Takkinen changed: What|Removed |Added Attachment #100741|0 |1 is obsolete|| --- Comment #31 from Emmi Takkinen --- Created attachment 103828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103828&action=edit Bug 9525: Group floating rules Rebased patch and moved schema changes into a separate patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Laurence Rault changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||laurence.ra...@biblibre.com --- Comment #30 from Laurence Rault --- On biblibre sandbox, impossible to apply the patch : Auto-merging Koha/Schema/Result/Branch.pm CONFLICT (content): Merge conflict in Koha/Schema/Result/Branch.pm Auto-merging C4/Circulation.pm CONFLICT (content): Merge conflict in C4/Circulation.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 9525: Group floating rules -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Emmi Takkinen changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Emmi Takkinen changed: What|Removed |Added Attachment #100422|0 |1 is obsolete|| --- Comment #29 from Emmi Takkinen --- Created attachment 100743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100743&action=edit Bug 9525: Add support for regexps in conditional floating -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Emmi Takkinen changed: What|Removed |Added Attachment #100421|0 |1 is obsolete|| --- Comment #28 from Emmi Takkinen --- Created attachment 100742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100742&action=edit Bug 9525: Fixing floating on return -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Emmi Takkinen changed: What|Removed |Added Attachment #100420|0 |1 is obsolete|| --- Comment #27 from Emmi Takkinen --- Created attachment 100741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100741&action=edit Bug 9525: Group floating rules +-+ | USAGE TIPS (sorry didn't document these in the GUI | +-+ When modifying a floating route rule, pressing "%" accepts the modification and pressing "V" cancels the modifications and reverts the old rule. The empty text box in the center of the route rule (under the floating type dropdown list) is the box for conditional rules, where you put the logical expression. +-+ | SETTING UP THE TEST CONTEXT | +-+ -1. Find an Item, which can be circulated freely, and has homebranch B and any holdingbranch. 0. Read the instructions at admin/floating-matrix.pl. +---+ | TEST PLAN: Disabled floating: +---+ 0. Make sure that the floating rules from branch A to branch B (A -> B) are "Disabled" and vice versa (B -> A). 1. Set your current library to A. 2. Check-in the Item. 3. Observe the started transport to branch B. 4. Set your current library to B. 5. Check-in to receive the transfer. +---+ | TEST PLAN: Always floating: +---+ 0. Make sure that the floating rules from branch A to branch B (A -> B) are "Allowed". 1. Set your current library to A. 2. Check-in the Item. 3. Observe that there is not transport prompt to branch B and the Item is not "in-transit" -state. +---+ | TEST PLAN: Possibly floating: +---+ 0. Make sure that the floating rules from branch A to branch B (A -> B) are "Possible". 1. Set your current library to A. 2. Check-in the Item. 3. Observe that there is a transport prompt to branch B. You can decide if you want to transfer or no. +---+ | TEST PLAN: Conditional floating: +---+ 0. Same as Always floating if the given condition matches. See the feature description at admin/floating-matrix.pl explaining Conditional floating. +---+ | TEST PLAN: Floating rule tester: +---+ 0. Add some floating rules between libraries 1. Choose origin library, destination library and give barcode for the item you want to test 2. Hit "Test" 3. Make sure box next to the "Test" button changes color according rules you made 4. Also for conditional floating use barcode for item that doesn't match given condition -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #26 from Emmi Takkinen --- (In reply to Owen Leonard from comment #25) > (In reply to Owen Leonard from comment #24) > > ERROR 1005 (HY000): Can't create table 'koha_kohadev.floating_matrix' > > (errno: 150) Hm, it seems I missed that in kohastructure.pl there was: ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci instead of: ENGINE = InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci That's likely the issue here. I'll recheck patches for any other possible problems and reattach them later. > Is this because I was supposed to apply the last three patches on top of the > remote github branch? > > Look for commits starting with the tag "Bug 9525 - " > > Sorry I don't know what this means. I'm accustomed to seeing a separate > testing branch. No need to use remote branch or look commits related to this, all latest code is included here and should work after I fix this issue with database. >I got a couple of conflicts when applying these patches but was able to >resolve them. Anything I could look into? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #25 from Owen Leonard --- (In reply to Owen Leonard from comment #24) > ERROR 1005 (HY000): Can't create table 'koha_kohadev.floating_matrix' > (errno: 150) Is this because I was supposed to apply the last three patches on top of the remote github branch? > Look for commits starting with the tag "Bug 9525 - " Sorry I don't know what this means. I'm accustomed to seeing a separate testing branch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #24 from Owen Leonard --- I got a couple of conflicts when applying these patches but was able to resolve them. However, I get an error when running the database update: ERROR 1005 (HY000): Can't create table 'koha_kohadev.floating_matrix' (errno: 150) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Emmi Takkinen changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #23 from Emmi Takkinen --- Created attachment 100422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100422&action=edit Bug 9525: Add support for regexps in conditional floating clauses -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #22 from Emmi Takkinen --- Created attachment 100421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100421&action=edit Bug 9525: Fixing floating on return -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Emmi Takkinen changed: What|Removed |Added Attachment #40077|0 |1 is obsolete|| Attachment #44756|0 |1 is obsolete|| Attachment #44760|0 |1 is obsolete|| Attachment #48310|0 |1 is obsolete|| CC||emmi.takki...@outlook.com --- Comment #21 from Emmi Takkinen --- Created attachment 100420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100420&action=edit Bug 9525: Group floating rules Rebased with latest version from https://github.com/KohaSuomi/kohasuomi. Patch combines all previously made patches for this feature. To test follow test plan in comment 13. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Bug 9525 depends on bug 14188, which changed state. Bug 14188 Summary: branchtransfers GetAllTransfers and GetAllPendingTransfers functions to ease testing. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14188 What|Removed |Added Status|BLOCKED |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 BASE Library Consortium changed: What|Removed |Added CC||baselibrary.consortium@nhs. ||net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #20 from Olli-Antti Kivilahti --- Latest code for this feature can be found from our GitHub: https://github.com/KohaSuomi/kohasuomi Look for commits starting with the tag "Bug 9525 - " We are porting all our code to master presently and hopefully by Q1 2017 we have updated patches here in Bugzilla. Looks like this needs to be rebased to the REST API as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Bug 9525 depends on bug 14187, which changed state. Bug 14187 Summary: branchtransfer needs a primary key (id) for DBIx and common sense. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #19 from Olli-Antti Kivilahti --- Created attachment 48310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48310&action=edit Bug 9525 - group floating rules - added logging ALWAYS and CODITIONAL floats. SELECT * FROM action_logs WHERE module = "FLOATING"; -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #18 from Olli-Antti Kivilahti --- Hi! This feature work really well :) :) :) We are going to rebase it this summer (hopefully) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Nicole C. Engard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #17 from Nicole C. Engard --- 40077 - Bug 9525 - group floating rules 44756 - Bug 9525 - group floating rules, floating rule tester :) 44760 - Bug 9525 - group floating rules, CGI doesn't understand DELETE at all. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 9525 - group floating rules fatal: sha1 information is lacking or useless (C4/Circulation.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 9525 - group floating rules When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-9525---group-floating-rules-MxbdS8.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #16 from Olli-Antti Kivilahti --- Created attachment 44760 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44760&action=edit Bug 9525 - group floating rules, CGI doesn't understand DELETE at all. instead of DELETE we GET the delete request so CGI works with it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Olli-Antti Kivilahti changed: What|Removed |Added Attachment #44754|0 |1 is obsolete|| --- Comment #15 from Olli-Antti Kivilahti --- Created attachment 44756 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44756&action=edit Bug 9525 - group floating rules, floating rule tester :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #14 from Olli-Antti Kivilahti --- Created attachment 44754 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44754&action=edit Bug 9525 - group floating rules, floating rule tester :) Implemented a tester to floating-matrix.pl to more easily test the changes in the floating rules matrix "FloMax". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Zeno Tajoli changed: What|Removed |Added Patch complexity|--- |Large patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #13 from Olli-Antti Kivilahti --- +-+ | USAGE TIPS (sorry didn't document these in the GUI | +-+ When modifying a floating route rule, pressing "%" accepts the modification and pressing "V" cancels the modifications and reverts the old rule. The empty text box in the center of the route rule (under the floating type dropdown list) is the box for conditional rules, where you put the logical expression. +-+ | SETTING UP THE TEST CONTEXT | +-+ -2. Set syspref "HomeOrHoldingBranchReturn" to homebranch. -1. Find an Item, which can be circulated freely, and has homebranch B and any holdingbranch. 0. Read the instructions at admin/floating-matrix.pl. +---+ | TEST PLAN: Disabled floating: +---+ 0. Make sure that the floating rules from branch A to branch B (A -> B) are "Disabled" and vice versa (B -> A). 1. Set your current library to A. 2. Check-in the Item. 3. Observe the started transport to branch B. 4. Set your current library to B. 5. Check-in to receive the transfer. +---+ | TEST PLAN: Always floating: +---+ 0. Make sure that the floating rules from branch A to branch B (A -> B) are "Allowed". 1. Set your current library to A. 2. Check-in the Item. 3. Observe that there is not transport prompt to branch B and the Item is not "in-transit" -state. +---+ | TEST PLAN: Possibly floating: +---+ 0. Make sure that the floating rules from branch A to branch B (A -> B) are "Possible". 1. Set your current library to A. 2. Check-in the Item. 3. Observe that there is a transport prompt to branch B. You can decide if you want to transfer or no. +---+ | TEST PLAN: Conditional floating: +---+ 0. Same as Always floating if the given condition matches. See the feature description at admin/floating-matrix.pl explaining Conditional floating. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Mirko Tietgen changed: What|Removed |Added CC||mi...@abunchofthings.net --- Comment #12 from Mirko Tietgen --- Would test if it had a test plan. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #11 from Olli-Antti Kivilahti --- In production for ~3 weeks. Working fine and helping a lot! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #10 from Olli-Antti Kivilahti --- Thanks for pushing Bernardo. I hope images are worth more than 100 words ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #9 from Olli-Antti Kivilahti --- This screenshot: The floating matrix control panel where you configure the 4 types of floating between routes. Explains how to use this feature. Then just check-in Items and they float based on the rules. If you don't want to use this feature, don't set any floating routes and it is completely unintrusive. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #7 from Olli-Antti Kivilahti --- Created attachment 40102 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40102&action=edit Admin menu screenshot, how to navigate to the control panel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #8 from Olli-Antti Kivilahti --- Created attachment 40103 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40103&action=edit The floating matrix control panel where you configure the 4 types of floating between routes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #6 from Bernardo Gonzalez Kriegel --- (In reply to Olli-Antti Kivilahti from comment #5) > But it is a nice feature and works remarkably well for us. Great :) Is it possible a short description of the use case scenario? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #5 from Olli-Antti Kivilahti --- But it is a nice feature and works remarkably well for us. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #4 from Olli-Antti Kivilahti --- Hi Bernardo. Sorry I must focus on other things. I am happy I even managed to rebase and push all things to bugzilla. If you like it, you can write a test plan. Tho I am 100% sure the dependencies will go stale in 1 week and then nobody but a programmer can test this :) And that kind of testing implies a code review. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Bernardo Gonzalez Kriegel changed: What|Removed |Added CC||bgkrie...@gmail.com --- Comment #3 from Bernardo Gonzalez Kriegel --- Hi, nice feature! Can you please add a test plan? Also some files need a Licence and others need an updated one (from 2 -> 3) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Olli-Antti Kivilahti changed: What|Removed |Added Depends on|13096 |13906 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Olli-Antti Kivilahti changed: What|Removed |Added Depends on||14188, 14187, 13995, 13096 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Olli-Antti Kivilahti changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #2 from Olli-Antti Kivilahti --- Created attachment 40077 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40077&action=edit Bug 9525 - group floating rules Cucumber integration tests included. run t/Cucumber/runCucumberTests.pl --tags @floatingMatrix -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Olli-Antti Kivilahti changed: What|Removed |Added CC||olli-antti.kivila...@jns.fi --- Comment #1 from Olli-Antti Kivilahti --- We need the same thing ASAP. We just added a few bookmobiles which need floating between their parent libraries and are shifting priorities to try to solve this issue ASAP. This is an awkward pending issue for us and hopefully I can deliver an acceptable solution soon. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Olli-Antti Kivilahti changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |olli-antti.kivila...@jns.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
