[Koha-bugs] [Bug 9576] Enable or disable issue limit confirmation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9576 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #13 from Galen Charlton --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9576] Enable or disable issue limit confirmation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9576 --- Comment #11 from Katrin Fischer --- Created attachment 19612 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19612&action=edit [PASSED QA] Bug 9576 - Enable or disable issue limit confirmation Adds a new system preference AllowTooManyOverride to control whether a librarian can override the 'Too many checked out' message which is currently always overridable. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Attempt to check out 1 more item to a patron than the max issues 4) You should be allowed to override by default ( current behavior ) 5) Set AllowTooManyOverride to "Don't allow" 6) Repeat step 3 7) You should be blocked from being able to issue the item Signed-off-by: Srdjan Signed-off-by: Katrin Fischer The new system preference is activated by default, which mean there will be know change in behaviour on update. The system preference is correctly added to the database and .pref files. Test plan and QA script passes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9576] Enable or disable issue limit confirmation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9576 Katrin Fischer changed: What|Removed |Added Attachment #18722|0 |1 is obsolete|| Attachment #19612|0 |1 is obsolete|| --- Comment #12 from Katrin Fischer --- Created attachment 19613 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19613&action=edit [PASSED QA] Bug 9576 - Enable or disable issue limit confirmation Adds a new system preference AllowTooManyOverride to control whether a librarian can override the 'Too many checked out' message which is currently always overridable. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Attempt to check out 1 more item to a patron than the max issues 4) You should be allowed to override by default ( current behavior ) 5) Set AllowTooManyOverride to "Don't allow" 6) Repeat step 3 7) You should be blocked from being able to issue the item Signed-off-by: Srdjan Signed-off-by: Katrin Fischer The new system preference is activated by default, which mean there will be know change in behaviour on update. The system preference is correctly added to the database and .pref files. Test plan and QA script passes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9576] Enable or disable issue limit confirmation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9576 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9576] Enable or disable issue limit confirmation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9576 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #10 from Katrin Fischer --- I will test this as it's a consistent change and I think Galen is ok with it? But I agree that we should start to think about how to handle these on permission level. I think AllowRenewalLimitOverride works in combination with a permission, but I am not sure what takes precedence. - Should it be possible to overwrite the global setting with the permission? Should the permission only be offered, when the system preference allows the action in general? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9576] Enable or disable issue limit confirmation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9576 --- Comment #9 from Galen Charlton --- (In reply to comment #1) > This should be controlled via a syspref ala the Allow*Override system > preferences. This comment isn't about the proposed patch per se, just inspired by it. Doing it via syspref, while consistent with precedent (OverduesBlockCirc, AllFinesNeedOverride, AllowNotForLoanOverride, AgeRestrictionOverride, etc.), bothers me. The ability to override isn't necessarily just a matter of library policy; it also ought to be a matter of staff permission. The problem with using sysprefs is that they're too broad. As the original bug reporter implies, you don't necessarily want ordinary circ clerks to be able to override the limit, but you probably do want circ supervisors to be able to do so; consider the usual "library board member is standing in front of you wanting to check out just one more book" scenario. If we pursue creating staff user permissions for overrides, how do folks think they should work? Replace the system preference? Work in conjunction with the syspref? As I said, this comment isn't about the proposed patch, which is consistent with how things have been handled in the past. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9576] Enable or disable issue limit confirmation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9576 Srdjan Jankovic changed: What|Removed |Added CC||srd...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9576] Enable or disable issue limit confirmation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9576 Srdjan Jankovic changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9576] Enable or disable issue limit confirmation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9576 Srdjan Jankovic changed: What|Removed |Added Attachment #18658|0 |1 is obsolete|| --- Comment #8 from Srdjan Jankovic --- Created attachment 18722 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18722&action=edit [SIGNED-OFF] Bug 9576 - Enable or disable issue limit confirmation Adds a new system preference AllowTooManyOverride to control whether a librarian can override the 'Too many checked out' message which is currently always overridable. Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9576] Enable or disable issue limit confirmation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9576 Fridolyn SOMERS changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9576] Enable or disable issue limit confirmation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9576 Fridolyn SOMERS changed: What|Removed |Added Attachment #16272|0 |1 is obsolete|| --- Comment #7 from Fridolyn SOMERS --- Created attachment 18658 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18658&action=edit Bug 9576 - Enable or disable issue limit confirmation Rebased master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9576] Enable or disable issue limit confirmation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9576 Koha Team Lyon 3 changed: What|Removed |Added Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9576] Enable or disable issue limit confirmation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9576 --- Comment #6 from Koha Team Lyon 3 --- Yes, I completely forgot, sorry. And now the patch doesn't apply any more... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9576] Enable or disable issue limit confirmation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9576 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz --- Comment #5 from Chris Cormack --- Did you miss adding your sign off to this patch? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9576] Enable or disable issue limit confirmation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9576 Koha Team Lyon 3 changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #4 from Koha Team Lyon 3 --- OK : if syspref "AllowTooManyOverride" is don't allow : there's an alert and you can't borrow more than the limit. if if syspref "AllowTooManyOverride" is allow : there's a question and you can choose to borrow -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9576] Enable or disable issue limit confirmation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9576 Fridolyn SOMERS changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9576] Enable or disable issue limit confirmation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9576 Fridolyn SOMERS changed: What|Removed |Added Attachment #15236|0 |1 is obsolete|| Status|Patch doesn't apply |Needs Signoff Assignee|k...@bywatersolutions.com |fridolyn.som...@biblibre.co ||m --- Comment #3 from Fridolyn SOMERS --- Created attachment 16272 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16272&action=edit Bug 9576 - Enable or disable issue limit confirmation Patch rebased master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9576] Enable or disable issue limit confirmation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9576 Koha Team Lyon 3 changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||k...@univ-lyon3.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9576] Enable or disable issue limit confirmation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9576 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9576] Enable or disable issue limit confirmation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9576 --- Comment #2 from Kyle M Hall --- Created attachment 15236 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15236&action=edit Bug 9576 - Enable or disable issue limit confirmation Adds a new system preference AllowTooManyOverride to control whether a librarian can override the 'Too many checked out' message which is currently always overridable. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Attempt to check out 1 more item to a patron than the max issues 4) You should be allowed to override by default ( current behavior ) 5) Set AllowTooManyOverride to "Don't allow" 6) Repeat step 3 7) You should be blocked from being able to issue the item -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9576] Enable or disable issue limit confirmation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9576 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #1 from Kyle M Hall --- This should be controlled via a syspref ala the Allow*Override system preferences. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
