[Koha-bugs] [Bug 9739] more options for serialsUpdate.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9739 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #17 from Galen Charlton gmcha...@gmail.com --- Pushed to master. Thanks, Fridolyn! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9739] more options for serialsUpdate.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9739 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #12 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I have found some smaller problems with this script that I wanted to note: 1) When I start the script without giving any parameters nothing happens. Maybe it would be helpful to print out the help in this case? 2) The script updates serial issues that are already late and claimed with the note. I think it shouldn't touch issues that are already marked late in the interface. 3) The script overwrites and deletes existing notes on the issues. I think all this problems predate your patch, but I am quite worried about 2) and 3). The existing notes can now be preserved using the --no-note option, but I think ideally the new notes should be amended to the existing one in general. Still, this patch is an improvement, so it will pass. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9739] more options for serialsUpdate.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9739 --- Comment #15 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 21590 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21590action=edit [PASSED QA] Bug 9739 - followup - adds missing comma Adds a missing comma in select statement. Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9739] more options for serialsUpdate.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9739 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9739] more options for serialsUpdate.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9739 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #20871|0 |1 is obsolete|| Attachment #20872|0 |1 is obsolete|| Attachment #20873|0 |1 is obsolete|| --- Comment #13 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 21588 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21588action=edit [PASSED QA] Bug 9739: more options for serialsUpdate.pl Script serialsUpdate.pl must be set in crontab to run daily. It checks serials that are late, modifies status and adds a note. This patch adds some options : --note : defined note, a defaut one is used if not defined --no-note : disable automatic note --verbose : used to control output This patch also implements confirmation option -c who whas present but not used. Test plan : Run script on a database with late serials : - serialsUpdate.pl -h = you get help text in output - serialsUpdate.pl --man = you get full help - serialsUpdate.pl -v = you get output of changed serials but database has not changed - serialsUpdate.pl -c -v = you get output of changed serials and database has changed, with note Automatically set to late - serialsUpdate.pl -c = database has changed without anything in output - serialsUpdate.pl -c --note LATE = database has changed, with note LATE - serialsUpdate.pl -c --no-note = database has changed with no note Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Works as described. No koha-qa errors. Signed-off-by: Katrin Fischer katrin.fischer...@web.de Passes all tests and QA script. New options behave as described. There are some existing problems with this script that I have noted directly on the bug report. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9739] more options for serialsUpdate.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9739
--- Comment #14 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 21589
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21589action=edit
[PASSED QA] Bug 9739: more options for serialsUpdate.pl (followup)
cosmetic changes :
perltidy
q{} for query
list of columns is query instead of SELECT *
Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com
Your cosmetic changes missed a comma, fixed in a followup
Signed-off-by: Katrin Fischer katrin.fischer...@web.de
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9739] more options for serialsUpdate.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9739 --- Comment #16 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 21592 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21592action=edit Bug 9739: Follow-up - Improve help text a bit Changes only strings in the script: the help text and the success message for updated serial issues. Thx to Jared for proof reading! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9739] more options for serialsUpdate.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9739 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #18058|0 |1 is obsolete|| --- Comment #9 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 20871 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20871action=edit [SIGNED-OFF] Bug 9739: more options for serialsUpdate.pl Script serialsUpdate.pl must be set in crontab to run daily. It checks serials that are late, modifies status and adds a note. This patch adds some options : --note : defined note, a defaut one is used if not defined --no-note : disable automatic note --verbose : used to control output This patch also implements confirmation option -c who whas present but not used. Test plan : Run script on a database with late serials : - serialsUpdate.pl -h = you get help text in output - serialsUpdate.pl --man = you get full help - serialsUpdate.pl -v = you get output of changed serials but database has not changed - serialsUpdate.pl -c -v = you get output of changed serials and database has changed, with note Automatically set to late - serialsUpdate.pl -c = database has changed without anything in output - serialsUpdate.pl -c --note LATE = database has changed, with note LATE - serialsUpdate.pl -c --no-note = database has changed with no note Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Works as described. No koha-qa errors. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9739] more options for serialsUpdate.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9739
Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:
What|Removed |Added
Attachment #18059|0 |1
is obsolete||
--- Comment #10 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 20872
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20872action=edit
[SIGNED-OFF] Bug 9739: more options for serialsUpdate.pl (followup)
cosmetic changes :
perltidy
q{} for query
list of columns is query instead of SELECT *
Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com
Your cosmetic changes missed a comma, fixed in a followup
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9739] more options for serialsUpdate.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9739 --- Comment #11 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 20873 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20873action=edit Bug 9739 - followup - adds missing comma Adds a missing comma in select statement. Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9739] more options for serialsUpdate.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9739 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||bgkrie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9739] more options for serialsUpdate.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9739 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Attachment #15800|0 |1 is obsolete|| --- Comment #6 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 18058 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18058action=edit Proposed patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9739] more options for serialsUpdate.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9739 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Attachment #15801|0 |1 is obsolete|| --- Comment #7 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 18059 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18059action=edit Proposed patch (followup) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9739] more options for serialsUpdate.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9739 --- Comment #8 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- (In reply to comment #5) Your followup looks strange : it contains the same strings as the main patch. Mathieu Indeed. I recreated patches form my branch and reattached them. Thanks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9739] more options for serialsUpdate.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9739 --- Comment #5 from mathieu saby mathieu.s...@univ-rennes2.fr --- Your followup looks strange : it contains the same strings as the main patch. Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9739] more options for serialsUpdate.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9739 --- Comment #4 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- (In reply to comment #3) Fridolyn, I suppose the 1st attachment is obsolete? No, 1st attachement is the main patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9739] more options for serialsUpdate.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9739 mathieu saby mathieu.s...@univ-rennes2.fr changed: What|Removed |Added CC||mathieu.saby@univ-rennes2.f ||r --- Comment #3 from mathieu saby mathieu.s...@univ-rennes2.fr --- Fridolyn, I suppose the 1st attachment is obsolete? M. Saby -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9739] more options for serialsUpdate.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9739 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|gmcha...@gmail.com |fridolyn.som...@biblibre.co ||m --- Comment #1 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 15800 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15800action=edit Proposed patch See commit message. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9739] more options for serialsUpdate.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9739 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9739] more options for serialsUpdate.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9739 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Patch complexity|Medium patch|Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9739] more options for serialsUpdate.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9739
--- Comment #2 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
Created attachment 15801
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15801action=edit
Proposed patch (followup)
Follow up patch for cosmetic changes :
- perltidy
- q{} for SQL query instead of
- list of columns is SQL query instead of SELECT *
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
