[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 --- Comment #30 from Anneli Österman --- Patron's borrowernumber was in info column but not in object column which is usually used when action concerns certain borrower. For example, if someone asks, how is it possible that this borrower has issues even when borrower is restricted. I would start to investigate the problem by searching with patron's borrowernumber from object column and would get nothing. I would have to know that in restriction overrides patron's borrowernumber is in info column and I would have to search using that one. What I'm trying to say is that if there were a problem, I would start from patron's action log view. Now you kind of have start from staff memeber's action log view but the problem is, that you do not know which staff member to look for. Or you have to make large search by info column when you get lots of unnecessary hits with itemnumbers or other numbers that happens to be same as the borrowernumber. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 --- Comment #29 from Matthias Le Gac --- I think the info is already there, either in the "Object column", there's a link to the person who checkout. If that's what you mean. The logs are in Tools > Log viewer. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Anneli Österman changed: What|Removed |Added CC||anneli.osterman@koha-suomi. ||fi --- Comment #28 from Anneli Österman --- I tested in Bywater's sandbox points 1, 2, 3, 10 and 16 and was about to comment that these doesn't work because there were no logs for those borrowers whose restriction was overridden. Then I checked the action_logs table with SQL report and noticed that there actually were logs for overrides. But there were no object recorded which is why I did not find anything at first with the log viewer. Should the borrowernumber of the borrower whose resctriction is overridden be recorded as well to the object column in action_logs? It would help to find those overrides more easily. I intuitively looked for them from borrowers logs. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Katie Bliss changed: What|Removed |Added CC||kebl...@dmpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Matthias Le Gac changed: What|Removed |Added Attachment #164510|0 |1 is obsolete|| --- Comment #27 from Matthias Le Gac --- Created attachment 164519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164519=edit Bug 9762: Test CanBookBeIssued.pm Current status: Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 --- Comment #26 from Matthias Le Gac --- Rebase to master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Matthias Le Gac changed: What|Removed |Added Attachment #164426|0 |1 is obsolete|| --- Comment #25 from Matthias Le Gac --- Created attachment 164510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164510=edit Bug 9762: Test CanBookBeIssued.pm To test: 1) Apply the patch 2) run prove t/db_dependent/Circulation/CanBookBeIssued.t --After each step, a message will be displayed in the action_logs table and in Tools > Log viewer -- Circulation -- Checking out 1) Check out an item that is age-restricted (AgeRestrictionOverride syspref) 2) Check out an item that has a “not for loan” status (AllowNotForLoanOverride syspref) 3) Check out an item that has a “lost” status (IssueLostItem syspref) 4) Check out an item to a patron who has reached the checkout limit (AllowTooManyOverride syspref) 5) Check out an item to a patron who is not allowed to borrow this item type 6) Check out an item to a patron who has unpaid fines (AllFinesNeedOverride and/or AllowFineOverride + noissuescharge sysprefs) 7) Check out an item on hold for someone else 8) Check out an item on hold ready for pickup by someone else 9) Check out an item already checked out to someone else (AutoReturnCheckedOutItems syspref) 10) Check out to a patron who has restrictions Circulation -- Checking in 11) Ignore a hold upon check in 12) Ignore a hold and transfer upon check in Circulation – Renewing 13) Renew an item on hold for someone else (AllowRenewalOnHoldOverride syspref) 14) Renew an item that has reached the maximum number of renewals (AllowRenewalLimitOverride syspref) Holds 15) Place a hold for a patron who is not allowed to place this item type on hold (AllowHoldPolicyOverride syspref) 16) Place a hold for a patron who has reached the maximum number of holds 17) Place an item-level hold when rules dictate that this is not allowed (In circulation rules put "On shelf holds allowed" to "If any unavailable") -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Matthias Le Gac changed: What|Removed |Added Attachment #164387|0 |1 is obsolete|| --- Comment #24 from Matthias Le Gac --- Created attachment 164509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164509=edit Bug 9762: Change how to pass the param -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Matthias Le Gac changed: What|Removed |Added Attachment #164068|0 |1 is obsolete|| --- Comment #23 from Matthias Le Gac --- Created attachment 164508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164508=edit Bug 9762: Log circulation overrides This patch allows you to save commands that have been overridden by someone. The patch has been updated but is not yet completed. Tests 10, 13, 14, and 17 are still not functional. Tests 15 and 16 need to be fixed as they do not display the barcode. All other tests should be functional. To test: --After each step, a message will be displayed in the action_logs table and in Tools > Log viewer -- Circulation -- Checking out 1) Check out an item that is age-restricted (AgeRestrictionOverride syspref) 2) Check out an item that has a “not for loan” status (AllowNotForLoanOverride syspref) 3) Check out an item that has a “lost” status (IssueLostItem syspref) 4) Check out an item to a patron who has reached the checkout limit (AllowTooManyOverride syspref) 5) Check out an item to a patron who is not allowed to borrow this item type 6) Check out an item to a patron who has unpaid fines (AllFinesNeedOverride and/or AllowFineOverride + noissuescharge sysprefs) 7) Check out an item on hold for someone else 8) Check out an item on hold ready for pickup by someone else 9) Check out an item already checked out to someone else (AutoReturnCheckedOutItems syspref) 10) Check out to a patron who has restrictions Circulation -- Checking in 11) Ignore a hold upon check in 12) Ignore a hold and transfer upon check in Circulation – Renewing 13) Renew an item on hold for someone else (AllowRenewalOnHoldOverride syspref) 14) Renew an item that has reached the maximum number of renewals (AllowRenewalLimitOverride syspref) Holds 15) Place a hold for a patron who is not allowed to place this item type on hold (AllowHoldPolicyOverride syspref) 16) Place a hold for a patron who has reached the maximum number of holds 17) Place an item-level hold when rules dictate that this is not allowed (In circulation rules put "On shelf holds allowed" to "If any unavailable") Current status: Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 --- Comment #22 from Matthias Le Gac --- Sorry not the good bz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Matthias Le Gac changed: What|Removed |Added Attachment #164479|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 --- Comment #21 from Matthias Le Gac --- Created attachment 164479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164479=edit Bug 9762: change test Current status: Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 --- Comment #20 from Matthias Le Gac --- I created a separate test file from circulation.t because I think it's simpler as it tests the message sending for the method CanBookBeIssued in Circulation.pm method and also on master and without having applied the patch the Circulation.t test didn't work so I couldn't test my tests. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 --- Comment #19 from Matthias Le Gac --- Created attachment 164426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164426=edit Bug 9762: Test CanBookBeIssued.pm To test: 1) Apply the patch 2) run prove t/db_dependent/Circulation/CanBookBeIssued.t --After each step, a message will be displayed in the action_logs table and in Tools > Log viewer -- Circulation -- Checking out 1) Check out an item that is age-restricted (AgeRestrictionOverride syspref) 2) Check out an item that has a “not for loan” status (AllowNotForLoanOverride syspref) 3) Check out an item that has a “lost” status (IssueLostItem syspref) 4) Check out an item to a patron who has reached the checkout limit (AllowTooManyOverride syspref) 5) Check out an item to a patron who is not allowed to borrow this item type 6) Check out an item to a patron who has unpaid fines (AllFinesNeedOverride and/or AllowFineOverride + noissuescharge sysprefs) 7) Check out an item on hold for someone else 8) Check out an item on hold ready for pickup by someone else 9) Check out an item already checked out to someone else (AutoReturnCheckedOutItems syspref) 10) Check out to a patron who has restrictions Circulation -- Checking in 11) Ignore a hold upon check in 12) Ignore a hold and transfer upon check in Circulation – Renewing 13) Renew an item on hold for someone else (AllowRenewalOnHoldOverride syspref) 14) Renew an item that has reached the maximum number of renewals (AllowRenewalLimitOverride syspref) Holds 15) Place a hold for a patron who is not allowed to place this item type on hold (AllowHoldPolicyOverride syspref) 16) Place a hold for a patron who has reached the maximum number of holds 17) Place an item-level hold when rules dictate that this is not allowed (In circulation rules put "On shelf holds allowed" to "If any unavailable") -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Matthias Le Gac changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Matthias Le Gac changed: What|Removed |Added Attachment #164302|0 |1 is obsolete|| --- Comment #18 from Matthias Le Gac --- Created attachment 164387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164387=edit Bug 9762: Change how to pass the param Current status: Failed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 --- Comment #17 from Matthias Le Gac --- Created attachment 164302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164302=edit Bug 9762: Change how to pass the param issueconfirmed To test: --After each step, a message will be displayed in the action_logs table and in Tools > Log viewer -- Circulation -- Checking out 1) Check out an item that is age-restricted (AgeRestrictionOverride syspref) 2) Check out an item that has a “not for loan” status (AllowNotForLoanOverride syspref) 3) Check out an item that has a “lost” status (IssueLostItem syspref) 4) Check out an item to a patron who has reached the checkout limit (AllowTooManyOverride syspref) 5) Check out an item to a patron who is not allowed to borrow this item type 6) Check out an item to a patron who has unpaid fines (AllFinesNeedOverride and/or AllowFineOverride + noissuescharge sysprefs) 7) Check out an item on hold for someone else 8) Check out an item on hold ready for pickup by someone else 9) Check out an item already checked out to someone else (AutoReturnCheckedOutItems syspref) 10) Check out to a patron who has restrictions Circulation -- Checking in 11) Ignore a hold upon check in 12) Ignore a hold and transfer upon check in Circulation – Renewing 13) Renew an item on hold for someone else (AllowRenewalOnHoldOverride syspref) 14) Renew an item that has reached the maximum number of renewals (AllowRenewalLimitOverride syspref) Holds 15) Place a hold for a patron who is not allowed to place this item type on hold (AllowHoldPolicyOverride syspref) 16) Place a hold for a patron who has reached the maximum number of holds 17) Place an item-level hold when rules dictate that this is not allowed (In circulation rules put "On shelf holds allowed" to "If any unavailable") Current status: Failed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Matthias Le Gac changed: What|Removed |Added Attachment #164067|0 |1 is obsolete|| --- Comment #16 from Matthias Le Gac --- Created attachment 164068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164068=edit Bug 9762: Log circulation overrides This patch allows you to save commands that have been overridden by someone. The patch has been updated but is not yet completed. Tests 10, 13, 14, and 17 are still not functional. Tests 15 and 16 need to be fixed as they do not display the barcode. All other tests should be functional. To test: --After each step, a message will be displayed in the action_logs table and in Tools > Log viewer -- Circulation -- Checking out 1) Check out an item that is age-restricted (AgeRestrictionOverride syspref) 2) Check out an item that has a “not for loan” status (AllowNotForLoanOverride syspref) 3) Check out an item that has a “lost” status (IssueLostItem syspref) 4) Check out an item to a patron who has reached the checkout limit (AllowTooManyOverride syspref) 5) Check out an item to a patron who is not allowed to borrow this item type 6) Check out an item to a patron who has unpaid fines (AllFinesNeedOverride and/or AllowFineOverride + noissuescharge sysprefs) 7) Check out an item on hold for someone else 8) Check out an item on hold ready for pickup by someone else 9) Check out an item already checked out to someone else (AutoReturnCheckedOutItems syspref) 10) Check out to a patron who has restrictions Circulation -- Checking in 11) Ignore a hold upon check in 12) Ignore a hold and transfer upon check in Circulation – Renewing 13) Renew an item on hold for someone else (AllowRenewalOnHoldOverride syspref) 14) Renew an item that has reached the maximum number of renewals (AllowRenewalLimitOverride syspref) Holds 15) Place a hold for a patron who is not allowed to place this item type on hold (AllowHoldPolicyOverride syspref) 16) Place a hold for a patron who has reached the maximum number of holds 17) Place an item-level hold when rules dictate that this is not allowed (In circulation rules put "On shelf holds allowed" to "If any unavailable") Fix POD problem for Circulation.pm Current status: Failed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 --- Comment #15 from Matthias Le Gac --- And I will make a new patch for test Circulation.pm -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 --- Comment #14 from Matthias Le Gac --- For the "skip_record_index" I don't now why Emily deleted this code but I thing we need this code so I put it back. Tell me if it's good?? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Matthias Le Gac changed: What|Removed |Added Attachment #163847|0 |1 is obsolete|| Attachment #164022|0 |1 is obsolete|| --- Comment #13 from Matthias Le Gac --- Created attachment 164067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164067=edit Bug 9762: Log circulation overrides This patch allows you to save commands that have been overridden by someone. The patch has been updated but is not yet completed. Tests 10, 13, 14, and 17 are still not functional. Tests 15 and 16 need to be fixed as they do not display the barcode. All other tests should be functional. To test: --After each step, a message will be displayed in the action_logs table and in Tools > Log viewer -- Circulation -- Checking out 1) Check out an item that is age-restricted (AgeRestrictionOverride syspref) 2) Check out an item that has a “not for loan” status (AllowNotForLoanOverride syspref) 3) Check out an item that has a “lost” status (IssueLostItem syspref) 4) Check out an item to a patron who has reached the checkout limit (AllowTooManyOverride syspref) 5) Check out an item to a patron who is not allowed to borrow this item type 6) Check out an item to a patron who has unpaid fines (AllFinesNeedOverride and/or AllowFineOverride + noissuescharge sysprefs) 7) Check out an item on hold for someone else 8) Check out an item on hold ready for pickup by someone else 9) Check out an item already checked out to someone else (AutoReturnCheckedOutItems syspref) 10) Check out to a patron who has restrictions Circulation -- Checking in 11) Ignore a hold upon check in 12) Ignore a hold and transfer upon check in Circulation – Renewing 13) Renew an item on hold for someone else (AllowRenewalOnHoldOverride syspref) 14) Renew an item that has reached the maximum number of renewals (AllowRenewalLimitOverride syspref) Holds 15) Place a hold for a patron who is not allowed to place this item type on hold (AllowHoldPolicyOverride syspref) 16) Place a hold for a patron who has reached the maximum number of holds 17) Place an item-level hold when rules dictate that this is not allowed (In circulation rules put "On shelf holds allowed" to "If any unavailable") In this patch I smatch my log fix and tideness fix. I will make another patch for the new test. Current status: Failed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Matthias Le Gac changed: What|Removed |Added CC||matthias.le-...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762
Lucas Gass changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #12 from Lucas Gass ---
Lots of issues here.
1. renew.pl now fails with this error:
Could not compile /kohadevbox/koha/circ/renew.pl: Global symbol "$borrower"
requires explicit package name (did you forget to declare "my $borrower"?) at
/kohadevbox/koha/circ/renew.pl line 67.
2. Looks like some debugging code is leftover
3. request.pl has a whole block of code commented out starting with:
# elsif ( C4::Context->preference('AllowHoldPolicyOverride') ){
4. Why remove the check for "unless( $skip_record_index )" in AddRenewal? I
think there are times when we want to skip indexing.
5. FAILC4/Circulation.pm
FAIL pod coverage
POD is missing for CanBookBeReturned
6. FAILcirc/renew.pl
WARN tidiness
The file is less tidy than before (bad/messy lines before: 28,
now: 44)
FAIL valid
Global symbol "$borrower" requires explicit package name (did
you forget to declare "my $borrower"?)
Global symbol "$issue" requires explicit package name (did you
forget to declare "my $issue"?)
Global symbol "$borrower" requires explicit package name (did
you forget to declare "my $borrower"?)
Global symbol "$borrower" requires explicit package name (did
you forget to declare "my $borrower"?)
Global symbol "$borrower" requires explicit package name (did
you forget to declare "my $borrower"?)
Global symbol "$borrower" requires explicit package name (did
you forget to declare "my $borrower"?)
circ/renew.pl had compilation errors.
7. Changes to CanBookBeIssued and AddRenewal probably need test coverage.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 --- Comment #11 from Matthias Le Gac --- Created attachment 164022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164022=edit Bug 9762: fix log for test 10 13 14 15 16 17 To test: --After each step, a message will be displayed in the action_logs table and in Tools > Log viewer -- Circulation -- Checking out 1) Check out an item that is age-restricted (AgeRestrictionOverride syspref) 2) Check out an item that has a “not for loan” status (AllowNotForLoanOverride syspref) 3) Check out an item that has a “lost” status (IssueLostItem syspref) 4) Check out an item to a patron who has reached the checkout limit (AllowTooManyOverride syspref) 5) Check out an item to a patron who is not allowed to borrow this item type 6) Check out an item to a patron who has unpaid fines (AllFinesNeedOverride and/or AllowFineOverride + noissuescharge sysprefs) 7) Check out an item on hold for someone else 8) Check out an item on hold ready for pickup by someone else 9) Check out an item already checked out to someone else (AutoReturnCheckedOutItems syspref) 10) Check out to a patron who has restrictions Circulation -- Checking in 11) Ignore a hold upon check in 12) Ignore a hold and transfer upon check in Circulation – Renewing 13) Renew an item on hold for someone else (AllowRenewalOnHoldOverride syspref) 14) Renew an item that has reached the maximum number of renewals (AllowRenewalLimitOverride syspref) Holds 15) Place a hold for a patron who is not allowed to place this item type on hold (AllowHoldPolicyOverride syspref) 16) Place a hold for a patron who has reached the maximum number of holds 17) Place an item-level hold when rules dictate that this is not allowed (In circulation rules put "On shelf holds allowed" to "If any unavailable") -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Matthias Le Gac changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Matthias Le Gac changed: What|Removed |Added Attachment #156222|0 |1 is obsolete|| --- Comment #10 from Matthias Le Gac --- Created attachment 163847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163847=edit Bug 9762: Log circulation overrides Rebase to master This patch allows you to save commands that have been overridden by someone. The patch has been updated but is not yet completed. Tests 10, 13, 14, and 17 are still not functional. Tests 15 and 16 need to be fixed as they do not display the barcode. All other tests should be functional. To test: --After each step, a message will be displayed in the action_logs table and in Tools > Log viewer -- Circulation -- Checking out 1) Check out an item that is age-restricted (AgeRestrictionOverride syspref) 2) Check out an item that has a “not for loan” status (AllowNotForLoanOverride syspref) 3) Check out an item that has a “lost” status (IssueLostItem syspref) 4) Check out an item to a patron who has reached the checkout limit (AllowTooManyOverride syspref) 5) Check out an item to a patron who is not allowed to borrow this item type 6) Check out an item to a patron who has unpaid fines (AllFinesNeedOverride and/or AllowFineOverride + noissuescharge sysprefs) 7) Check out an item on hold for someone else 8) Check out an item on hold ready for pickup by someone else 9) Check out an item already checked out to someone else (AutoReturnCheckedOutItems syspref) 10) Check out to a patron who has restrictions Circulation -- Checking in 11) Ignore a hold upon check in 12) Ignore a hold and transfer upon check in Circulation – Renewing 13) Renew an item on hold for someone else (AllowRenewalOnHoldOverride syspref) 14) Renew an item that has reached the maximum number of renewals (AllowRenewalLimitOverride syspref) Holds 15) Place a hold for a patron who is not allowed to place this item type on hold (AllowHoldPolicyOverride syspref) 16) Place a hold for a patron who has reached the maximum number of holds 17) Place an item-level hold when rules dictate that this is not allowed Current status: Failed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Émily-Rose Francoeur changed: What|Removed |Added Attachment #149554|0 |1 is obsolete|| --- Comment #9 from Émily-Rose Francoeur --- Created attachment 156222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156222=edit Bug 9762: Log circulation overrides This patch allows you to save commands that have been overridden by someone. The patch has been updated but is not yet completed. Tests 10, 13, 14, and 17 are still not functional. Tests 15 and 16 need to be fixed as they do not display the barcode. All other tests should be functional. To test: --After each step, a message will be displayed in the action_logs table and in Tools > Log viewer -- Circulation -- Checking out 1) Check out an item that is age-restricted (AgeRestrictionOverride syspref) 2) Check out an item that has a “not for loan” status (AllowNotForLoanOverride syspref) 3) Check out an item that has a “lost” status (IssueLostItem syspref) 4) Check out an item to a patron who has reached the checkout limit (AllowTooManyOverride syspref) 5) Check out an item to a patron who is not allowed to borrow this item type 6) Check out an item to a patron who has unpaid fines (AllFinesNeedOverride and/or AllowFineOverride + noissuescharge sysprefs) 7) Check out an item on hold for someone else 8) Check out an item on hold ready for pickup by someone else 9) Check out an item already checked out to someone else (AutoReturnCheckedOutItems syspref) 10) Check out to a patron who has restrictions Circulation -- Checking in 11) Ignore a hold upon check in 12) Ignore a hold and transfer upon check in Circulation – Renewing 13) Renew an item on hold for someone else (AllowRenewalOnHoldOverride syspref) 14) Renew an item that has reached the maximum number of renewals (AllowRenewalLimitOverride syspref) Holds 15) Place a hold for a patron who is not allowed to place this item type on hold (AllowHoldPolicyOverride syspref) 16) Place a hold for a patron who has reached the maximum number of holds 17) Place an item-level hold when rules dictate that this is not allowed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Emily Lamancusa changed: What|Removed |Added CC||emily.lamancusa@montgomeryc ||ountymd.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 --- Comment #8 from Katrin Fischer --- (In reply to Lucas Gass from comment #7) > Solene, > > Most of this is working and this will be a great addition! A few things > though: > > -Do these strings need to translatable? > -This is going to need unit tests. The messages in action_logs are usually not translated, but they are also usually not sentences/text, but data changes in JSON and other machine friendly syntax. Could we use codes instead of plain text and then translate them on the action log viewer? This would make them translatable and we could also adjust the texts easier. I expected to find override in the descriptions or it being a new type of action. Maybe we could be a little bit clearer that these were all override actions. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||lu...@bywatersolutions.com --- Comment #7 from Lucas Gass --- Solene, Most of this is working and this will be a great addition! A few things though: -Do these strings need to translatable? -This is going to need unit tests. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 solene.nga...@inlibro.com changed: What|Removed |Added CC||solene.nga...@inlibro.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 --- Comment #6 from solene.nga...@inlibro.com --- Created attachment 149554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149554=edit Bug 9762: Log circulation overrides This patch allows you to save commands that have been overridden by someone. To test: --After each step, a message will be display on the actionlog-- Circulation -- Checking out - Check out an item that is age restricted (AgeRestrictionOverride syspref) - Check out an item that has a not for loan status (AllowNotForLoanOverride syspref) - Check out an item that has a lost status (IssueLostItem syspref) - Check out an item to a patron who has reached the checkout limit (AllowTooManyOverride syspref) - Check out an item to a patron who is not allowed to borrow this item type - Check out an item to a patron who has unpaid fines (AllFinesNeedOverride and/or AllowFineOverride + noissuescharge sysprefs) - Check out an item on hold for someone else - Check out an item on hold ready for pickup by someone else - Check out an item already checked out to someone else (AutoReturnCheckedOutItems syspref) - Check out to a patron who has restrictions Circulation -- Checking in - Ignore a hold upon check in - Ignore a hold & transfer upon check in Circulation -- Renewing - Renew an item on hold for someone else - Renew an item that has reached the maximum amount of renewals Holds - Place a hold for a patron who is not allowed to put this item type on hold - Place a hold for a patron who has reached the maximum amount of holds - Place an item-level hold when rules say this is not allowed Signed-off-by: Solene Ngamga -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 --- Comment #5 from Michael Adamyk --- As a consortia library, this would also be helpful for us. If we have librarians overriding restrictions (such as circulation rules), it can cause problems if the rules are for another library. Knowing which login is doing this would help track down what's going on. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Michael Adamyk changed: What|Removed |Added CC||mada...@ckls.org --- Comment #4 from Michael Adamyk --- As a consortia library, this would also be helpful for us. If we have librarians overriding restrictions (such as circulation rules), it can cause problems if the rules are for another library. Knowing which login is doing this would help track down what's going on. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Martha Fuerst changed: What|Removed |Added CC||mfue...@hmcpl.org --- Comment #3 from Martha Fuerst --- We are also very interested in this logging. Other things to consider in addition to Caroline's list, depending on how sysprefs are set: - Check out an item to a patron who has guarantee's who have unpaid fines (NoIssuesChargeGuarantees) - Check out an item to a patron who has overdues (OverduesBlockCirc) - Renew an item for a patron who has overdues (OverduesBlockRenewing) - Override circulation fine rules via "specify dute dute" Thanks for the attention on this enhancement! -Marti Fuerst, Huntsville-Madison County Public Library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Margaret Hade changed: What|Removed |Added CC||margaret@bywatersolutions.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com --- Comment #2 from Caroline Cyr La Rose --- I'm trying to make a list of all possibilities where someone can override a restriction. I don't know if it's useful for a developer... Circulation -- Checking out - Check out an item that is age restricted (AgeRestrictionOverride syspref) - Check out an item that has a not for loan status (AllowNotForLoanOverride syspref) - Check out an item that has a lost status (IssueLostItem syspref) - Check out an item to a patron who has reached the checkout limit (AllowTooManyOverride syspref) - Check out an item to a patron who is not allowed to borrow this item type - Check out an item to a patron who has unpaid fines (AllFinesNeedOverride and/or AllowFineOverride + noissuescharge sysprefs) - Check out an item on hold for someone else - Check out an item on hold ready for pickup by someone else - Check out an item already checked out to someone else (AutoReturnCheckedOutItems syspref) - Check out to a patron who has restrictions Circulation -- Checking in - Ignore a hold upon check in - Ignore a hold & transfer upon check in Circulation -- Renewing - Renew an item on hold for someone else - Renew an item that has reached the maximum amount of renewals Holds - Place a hold for a patron who is not allowed to put this item type on hold - Place a hold for a patron who has reached the maximum amount of holds - Place an item-level hold when rules say this is not allowed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Katrin Fischer changed: What|Removed |Added Blocks||22794 Depends on|22794 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 [Bug 22794] Omnibus: Improve and extend logging in Koha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Katrin Fischer changed: What|Removed |Added CC||bar...@bywatersolutions.com --- Comment #1 from Katrin Fischer --- *** Bug 21422 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Katrin Fischer changed: What|Removed |Added Depends on||22794 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 [Bug 22794] Omnibus: Improve and extend logging in Koha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Katrin Fischer changed: What|Removed |Added Summary|way to track overrides |Log circulation overrides CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
