[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #86 from Pierre Angot tredok.pie...@gmail.com --- (En réponse au commentaire 84) Pushed to 3.10.x, will be in 3.10.7 Thanks ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Chris Hall chr...@catalyst.net.nz changed: What|Removed |Added CC||chr...@catalyst.net.nz --- Comment #85 from Chris Hall chr...@catalyst.net.nz --- Pushed to 3.8.x, will be in 3.8.14 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||bgkrie...@gmail.com --- Comment #84 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Pushed to 3.10.x, will be in 3.10.7 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #83 from Pierre Angot tredok.pie...@gmail.com --- Is it possible to push this patch to 3.10.x ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #81 from Jonathan Druart jonathan.dru...@biblibre.com --- Sorry Marcel, I should have add a comment in addition to the see also field. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #82 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to comment #81) Sorry Marcel, I should have add a comment in addition to the see also field. No problem. Just looking a little bit better could have helped me :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #73 from Paul Poulain paul.poul...@biblibre.com --- Patch tested with a sandbox, by Pierre Angot tredok.pie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #18348|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #74 from Paul Poulain paul.poul...@biblibre.com --- Created attachment 18506 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18506action=edit Bug 9824: Followup adding some text around Apply/cancel filter. The texts Apply/cancel filter did not need translation and were used to get this change into 3.12. For 3.12.X or 3.14 we can add some words to clarify its meaning. With thanks to Owen for some rewording. Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl Signed-off-by: Pierre Angot tredok.pie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #18506|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #18332|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #18219|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #18184|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #75 from Jonathan Druart jonathan.dru...@biblibre.com --- All 3 patches of this bug have been pushed to master and 3.12 branches -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #18221|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Pushed to Stable|ASSIGNED --- Comment #76 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to comment #75) All 3 patches of this bug have been pushed to master and 3.12 branches No, this is not true. Somehow you obsoleted the two followups. I will try to recover them now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #18184|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #18219|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #18221|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #18332|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #18506|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #18506|Bug 9824: Followup adding |[SIGNED_OFF] Bug 9824: description|some text around|Followup adding some text |Apply/cancel filter.|around Apply/cancel filter. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #77 from M. de Rooy m.de.r...@rijksmuseum.nl --- The two followups 18332 and 18506 are now signed off. They apply fine to current master. Although I wrote them, they are actually QA followups on the three patches pushed before. Since they only pertain to a small textual change and some POD lines, I am setting the status to Passed QA myself, herewith ending the confusion about the status of this report. Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #78 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to comment #76) (In reply to comment #75) All 3 patches of this bug have been pushed to master and 3.12 branches No, this is not true. Somehow you obsoleted the two followups. I will try to recover them now. And now I see the move of these patches to another report, rhhh. OK. Please add a comment if you do so. Will obsolete everything again.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #18506|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #18332|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #18221|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #18219|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #18184|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #79 from M. de Rooy m.de.r...@rijksmuseum.nl --- Restored the situation now where Jonathan left it. Learned something more about Bugzilla :) The two followups on these three reports are on bug 10381. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #80 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to comment #79) The two followups on these three reports are on bug 10381. reports - patches No confusion anymore now? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #18332|Bug-9824-Followup-for-POD-l |[SIGNED_OFF] filename|ines-of-GetBasketsInfos.pat |Bug-9824-Followup-for-POD-l |ch |ines-of-GetBasketsInfos.pat ||ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #18332|[SIGNED_OFF]|Bug-9824-Followup-for-POD-l filename|Bug-9824-Followup-for-POD-l |ines-of-GetBasketsInfos.pat |ines-of-GetBasketsInfos.pat |ch |ch | Attachment #18332|Bug 9824: Followup for POD |[SIGNED_OFF] Bug 9824: description|lines of|Followup for POD lines of |GetBasketsInfosByBookseller |GetBasketsInfosByBookseller -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #18348|Bug 9824: Followup adding |[NEEDS_SIGNOFF] Bug 9824: description|some text around|Followup adding some text |Apply/cancel filter.|around Apply/cancel filter. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #68 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to comment #66) but there is only 2 followups. Where is the main patch? The second followup only needs a signoff, preferably from a native English speaker. (Note that I already followed the suggestion of Owen here.) Thanks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #69 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to comment #67) Remember people, once something is marked pushed to master, please to go back to needs signoff, (unless it is the patch rebased for a stable branch or something). Not completely clear what you mean here, Chris. But these followups imo do not need a separate report.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #70 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hm, I was tempted to suggest a separate bug too when I took a look at this. It seems like a good practice to me to use a new bug once the original feature has been pushed. And in this case the original feature has even been released :) - I am also thinking about the automatically created release notes here. Maybe something like Reword basket filter in vendor search result list would be more clear? For testers and QA it's also harder to deal with a lng discussion like this :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #71 from mathieu saby mathieu.s...@univ-rennes2.fr --- (En réponse au commentaire 70) Hm, I was tempted to suggest a separate bug too when I took a look at this. It seems like a good practice to me to use a new bug once the original feature has been pushed. And in this case the original feature has even been released :) - I am also thinking about the automatically created release notes here. Maybe something like Reword basket filter in vendor search result list would be more clear? For testers and QA it's also harder to deal with a lng discussion like this :) I don't know if it is already an enforced rule, but 1 or 2 times I tried to add followup to bugs pushed to master, and I was said to create new bugs (for ex., a followup for UNIMARC of a MARC21 enh). After having thougth at this, I believe it was a good advice ;-) M. Saby -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #72 from M. de Rooy m.de.r...@rijksmuseum.nl --- Sorry, will try to remember your suggestion next time :) Katrin: As you suggested, I asked Owen on irc and adjusted the text. Would you mind passing these two patches on this report now or still require a new one? Thanks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added CC||ch...@bigballofwax.co.nz --- Comment #67 from Chris Cormack ch...@bigballofwax.co.nz --- (In reply to comment #66) ok, i'll test it. but there is only 2 followups. Where is the main patch? Mathieu It was pushed to master and 3.12 way back on comment 49, at that point a new bug should have been created for any followups, because as you demonstrate, it is just confusing otherwise. Remember people, once something is marked pushed to master, please to go back to needs signoff, (unless it is the patch rebased for a stable branch or something). Thanks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #64 from mathieu saby mathieu.s...@univ-rennes2.fr --- The status was not changed. Could be marked as Signed off I suppose? M. Saby -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #65 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I think probably the reworded patch waits for sign-off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #66 from mathieu saby mathieu.s...@univ-rennes2.fr --- ok, i'll test it. but there is only 2 followups. Where is the main patch? Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Needs Signoff --- Comment #54 from M. de Rooy m.de.r...@rijksmuseum.nl --- As requested, back to Needs signoff. Could a native speaker look at the proposed textual change? Thanks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 cedric.v...@dracenie.com changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||cedric.v...@dracenie.com --- Comment #55 from cedric.v...@dracenie.com --- Sandbox setup by unknown with database 2 and bug 9824 on Thu May 23 09:59:56 2013 Something went wrong ! Applying: Bug 9824: Followup for POD lines of GetBasketsInfosByBookseller Applying: Bug 9824: Followup adding some text around Apply/cancel filter. Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt Failed to merge in the changes. Patch failed at 0001 Bug 9824: Followup adding some text around Apply/cancel filter. When you have resolved this problem run git am --resolved. If you would prefer to skip this patch, instead run git am --skip. To restore the original branch and stop patching run git am --abort. Bug 9824 - Hide basket with no expected items in basket list by bookseller Bug 9824: Followup for POD lines of GetBasketsInfosByBookseller Apply? [yn] Bug 9824: Followup adding some text around Apply/cancel filter. Apply? [yn] Patch left in /tmp/Bug-9824-Followup-adding-some-text-around-Applycan-myQQFX.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #56 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to comment #55) Sandbox setup by unknown with database 2 and bug 9824 on Thu May 23 09:59:56 2013 Patch failed at 0001 Bug 9824: Followup adding some text around Apply/cancel filter. Thanks for testing! Strange. These two patches do apply fine for me on current master. Are you sure that the sandbox setup is on current master? Back to Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #57 from Paul Poulain paul.poul...@biblibre.com --- Patch tested with a sandbox, by Cedric Vita cedric.v...@dracenie.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #58 from Paul Poulain paul.poul...@biblibre.com --- Created attachment 18332 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18332action=edit Bug 9824: Followup for POD lines of GetBasketsInfosByBookseller Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl Signed-off-by: Cedric Vita cedric.v...@dracenie.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #59 from cedric.v...@dracenie.com --- Error sandbox for sinagture. I will revalidate the good Pelardon -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #60 from Paul Poulain paul.poul...@biblibre.com --- Patch tested with a sandbox, by Cedric Vita cedric.v...@dracenie.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #61 from Paul Poulain paul.poul...@biblibre.com --- Created attachment 18336 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18336action=edit Bug 9824: Followup adding some text around Apply/cancel filter. The texts Apply/cancel filter did not need translation and were used to get this change into 3.12. For 3.12.X or 3.14 we can add some words to clarify its meaning. Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl Signed-off-by: Cedric Vita cedric.v...@dracenie.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #18311|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #18313|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #18336|0 |1 is obsolete|| --- Comment #62 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 18348 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18348action=edit Bug 9824: Followup adding some text around Apply/cancel filter. The texts Apply/cancel filter did not need translation and were used to get this change into 3.12. For 3.12.X or 3.14 we can add some words to clarify its meaning. With thanks to Owen for some rewording. Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #63 from M. de Rooy m.de.r...@rijksmuseum.nl --- Thank you for your quick signoff, cedric vita. I reworded the text of the links on the second patch, with thanks to Owen. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #50 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 18311 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18311action=edit Bug 9824: Followup for POD lines of GetBasketsInfosByBookseller Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #51 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 18312 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18312action=edit Bug 9824: Followup adding some text around Apply/cancel filter. The texts Apply/cancel filter did not need translation and were used to get this change into 3.12. For 3.12.X or 3.14 we can add some words to clarify its meaning. Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #18312|0 |1 is obsolete|| --- Comment #52 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 18313 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18313action=edit Bug 9824: Followup adding some text around Apply/cancel filter. The texts Apply/cancel filter did not need translation and were used to get this change into 3.12. For 3.12.X or 3.14 we can add some words to clarify its meaning. Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #18219|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #18221|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Pushed to Master|ASSIGNED --- Comment #53 from M. de Rooy m.de.r...@rijksmuseum.nl --- Katrin: Do you still have a suggestion on the second followup for textual changes? Perhaps from translation point of view. I submitted an amendment to make translation somewhat easier. Status back to Signed off for two trivial QA followups. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #48 from Jared Camins-Esakov jcam...@cpbibliography.com --- Exercising my powers as RM and passing QA since the patches work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #49 from Jared Camins-Esakov jcam...@cpbibliography.com --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Summary|Hide basket with no |Hide basket with no |expected items in basqket |expected items in basket |list by bookseller |list by bookseller --- Comment #43 from M. de Rooy m.de.r...@rijksmuseum.nl --- My last action for today on Bugzilla will be: eliminate this typo basqket in the title of this great report :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #44 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Good news - you really tricked the translation scripts! Now it would be perfect if we could make a link 'Apply filter' show up after clicking the link for the first time... looking into it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #18184|0 |1 is obsolete|| Attachment #18215|0 |1 is obsolete|| --- Comment #45 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 18219 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18219action=edit [SIGNED OFF] Bug 9824: Followup for removing filter Adds allbaskets parameter to GetBasketsInfosByBookseller. (Only used in booksellers.pl now) Normally, all 'active' baskets are shown. With allbaskets=1 all baskets :) In the template I had to rename a loop var supplier to supplier1 to resolve name conflict between template vars. In the template I added the string: Cancel filter. Note that this string is already translated: msgid Cancel filter msgstr Hope this helps. Signed-off-by: Katrin Fischer katrin.fischer...@web.de Undoing the filter works and I checked that the string gets translated with the po files in current master. So this is almost perfect, only we can't apply the filters again and the link remains 'cancel' when we already did. Sending a follow-up trying to fix this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #46 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 18220 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18220action=edit Bug 9824: Make it possible to apply/cancel switch Using another existing string 'Apply filter' we are now able to cancel the filter... and apply it... and cancel it again... and so on. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #18220|0 |1 is obsolete|| --- Comment #47 from Owen Leonard oleon...@myacpl.org --- Created attachment 18221 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18221action=edit [SIGNED-OFF] Bug 9824: Make it possible to apply/cancel switch Using another existing string 'Apply filter' we are now able to cancel the filter... and apply it... and cancel it again... and so on. Signed-off-by: Owen Leonard oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/