[Koha-bugs] [Bug 9833] New virtual shelves/lists permissions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9833

--- Comment #13 from Katrin Fischer  ---
(In reply to Fridolin Somers from comment #12)
> Merge from shelves is more a cataloguing action non ?
> Should be a permission under "editcatalogue".
> It is actually depending on "edit_catalogue" permission.

I think maybe merging could be a general permission applying to merging in the
cataloguing module or in lists and be listed under cataloguing. 

And I would recommend splitting this bug into 2.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9833] New virtual shelves/lists permissions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9833

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #12 from Fridolin SOMERS  ---
Merge from shelves is more a cataloguing action non ?
Should be a permission under "editcatalogue".
It is actually depending on "edit_catalogue" permission.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9833] New virtual shelves/lists permissions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9833

Nicole C. Engard  changed:

   What|Removed |Added

 CC|neng...@gmail.com   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9833] New virtual shelves/lists permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9833

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=13417

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9833] New virtual shelves/lists permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9833

Marjorie Barry-Vila marjorie.barry-v...@ccsr.qc.ca changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9833] New virtual shelves/lists permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9833

--- Comment #11 from Liz Rea l...@catalyst.net.nz ---
The lists owned by NULL happens when the borrower that created the list is
deleted. That's probably a different bug than this. 

Matthias, any chance of getting this fixed up?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9833] New virtual shelves/lists permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9833

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #10 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Picked some discussion from irc log:
==
wizzyrea: and even better, apparently there was a bug at some point that set
the owners to NULL, so there are lists existent that cannot be edited by
anyone?!

dcook: That is a bit confusing...I can't tell if Marcel passed or failed it
based on the comments.. Although it does look like he's asking for some
changes? then he attached a patch...
= [End of quote]

Do no know exactly any more but I must have attached this patch just for a
trivial rebase. Yes, I failed this patch for reasons mentioned in comment 6.

Note also that there are privacy issues on viewing/editing all lists by
superlibs. Furthermore, I am still working on development for sharing lists
that should also cover the topic of lists without owner (i call them orphaned
lists). It should be the third patch of the Sharing a lists- series..

Hope that helps.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9833] New virtual shelves/lists permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9833

--- Comment #9 from M. de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to Liz Rea from comment #8)
 Marcel,
 
 I'm confused by the status of this patch - there's a signed off patch but
 it's failed QA?
 
 I came up against this today, it would be super cool to get this little
 nagger fixed.
 
 Liz

I hope that Matthias as author of the patch (or someone else from Biblibre?)
adjusts this patch to make it pass qa.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9833] New virtual shelves/lists permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9833

Liz Rea l...@catalyst.net.nz changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz

--- Comment #8 from Liz Rea l...@catalyst.net.nz ---
Marcel,

I'm confused by the status of this patch - there's a signed off patch but it's
failed QA?

I came up against this today, it would be super cool to get this little nagger
fixed.

Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9833] New virtual shelves/lists permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9833

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
Summary|New shelves permissions |New virtual shelves/lists
   ||permissions
 QA Contact||m.de.r...@rijksmuseum.nl

--- Comment #6 from M. de Rooy m.de.r...@rijksmuseum.nl ---
I like this patch since we really need some permissions for shelves!!

But I think that we must not add manage shelves under editcatalogue.
Managing shelves should have its own permission (if we allow it in the first
place). If this patch adds an entry for shelves/lists, I would also have the
idea of adding/allowing Change ownership for instance. Note also the privacy
issue here as noted in related reports (should a staff user be able to view
these lists at all?).
So, you could remove manage_shelves from this patch or add a root entry like
lists and start a discussion on how we should view the underlying manage. What
we do need e.g. is a permission to manage shelves that do no longer have an
owner (after deleting user).

Merge from shelves is another story: this indeed fits better under
edit_catalogue.

A technical detail: To know member-userid you use GetMemberDetails: Isn't that
quite overkill?
Also please watch operator priority in $user  $shelf-{owner}==$user) ||
C4::Auth::haspermission... Place parentheses? 

A test plan should be added too.

Thanks for your attention.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9833] New virtual shelves/lists permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9833

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=5763

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9833] New virtual shelves/lists permissions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9833

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #16360|0   |1
is obsolete||

--- Comment #7 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 18247
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18247action=edit
Bug 9833: Refine shelves permissions.

- This patch adds two new permissions for shelves:
   -  manage_shelves: allows to manage shelves
   - merge_from_shelves: allows to merge records from shelves

Signed-off-by: Pierre Angot tredok.pie...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/