[Koha-bugs] [Bug 9946] opac-topissues with no time limit

2013-04-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9946

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #5 from Jared Camins-Esakov jcam...@cpbibliography.com ---
This patch has been pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9946] opac-topissues with no time limit

2013-03-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9946

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9946] opac-topissues with no time limit

2013-03-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9946

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9946] opac-topissues with no time limit

2013-03-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9946

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

  Attachment #16967|0   |1
is obsolete||

--- Comment #2 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 17075
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17075action=edit
Bug 9946 - opac-topissues with no time limit

When in opac-topissues using filter of the last: with value No limit, the
result shows the caption : The 10 most checked-out in the past 999 months.

This patch corrects a typo error : $timeLimit was used instead of
$timeLimitFinite

Test plan :
- Go to OPAC most popular
- Select No limit in last filter and submit
= Check that result displays caption : The 10 most checked-out of all time
- Come back
- Select 6 months in last filter and submit
= Check that result displays caption : The 10 most checked-out in the past 6
months

Signed-off-by: Chris Cormack chr...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9946] opac-topissues with no time limit

2013-03-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9946

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I am not very happy about the behaviour of this page and I think it needs more
fixes (see bug 9959)

1) Why do I have to double submit my search sometimes? 
   - go to top issues from opac start page
   - change filter from last 3 months to no limit
   - submit
2) Why are the search options of this second form different to the first form?
   - library changes from Union to Demo for me
3) Why does hitting the submit button on the filter left sometimes change the
   filters too?
   - library changes from all libraries to Union (last in list)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9946] opac-topissues with no time limit

2013-03-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9946

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9946] opac-topissues with no time limit

2013-03-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9946

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #17075|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 17089
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17089action=edit
[PASSED QA] Bug 9946 - opac-topissues with no time limit

When in opac-topissues using filter of the last: with value No limit, the
result shows the caption : The 10 most checked-out in the past 999 months.

This patch corrects a typo error : $timeLimit was used instead of
$timeLimitFinite

Test plan :
- Go to OPAC most popular
- Select No limit in last filter and submit
= Check that result displays caption : The 10 most checked-out of all time
- Come back
- Select 6 months in last filter and submit
= Check that result displays caption : The 10 most checked-out in the past 6
months

Signed-off-by: Chris Cormack chr...@catalyst.net.nz
Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Passes all tests and QA script.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9946] opac-topissues with no time limit

2013-03-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9946

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9946] opac-topissues with no time limit

2013-03-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9946

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|oleon...@myacpl.org |fridolyn.som...@biblibre.co
   ||m

--- Comment #1 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
Created attachment 16967
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16967action=edit
Proposed patch

See commit comment.
Very small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/