[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Marcel de Rooy  changed:

   What|Removed |Added

  Text to go in the||This enhancement replaces
  release notes||dontmerge by a limit. The
   ||Zebra code in merge is
   ||removed. The cron job has
   ||been refactored, and is no
   ||longer optional; it also
   ||supports merges from one
   ||authority type to another
   ||(with a table revision).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Marcel de Rooy  changed:

   What|Removed |Added

   Severity|normal  |enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

--- Comment #27 from Marcel de Rooy  ---
If you apply all patches, you may want to use this COMBINED test script:

Run the three db revs.
Run tests:
t/db_dependent/Koha/Authorities.t
t/db_dependent/Authorities/Merge.t
t/db_dependent/Authorities/MergeRequests.t
t/db_dependent/Koha/SearchEngine/Search.t
t/db_dependent/UsageStats.t
Follow test plan: Check the merge limit in sub merge
Follow test plan: Refactor the cron script

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

--- Comment #25 from Marcel de Rooy  ---
Created attachment 60606
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60606=edit
Bug 9988: Add the cronjob and print an upgrade message

The Debian cron file and the misc crontab example are updated.
A message is printed when upgrading.

Note: At this moment the merge cron job is run once a day. This is imo a
good starting point. The load for this job greatly depends on the value of
pref AuthorityMergeLimit. Of course you can schedule the job more often,
and if this need is felt more globally, we can adjust it later.

Test plan:
[1] Run the dbrev and see the message.
[2] Read the changes to the cron files.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

--- Comment #18 from Marcel de Rooy  ---
Created attachment 60599
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60599=edit
Bug 9988: Add get_usage_count and linked_biblionumbers to Koha::Authority

When replacing the Zebra code in sub merge, we actually need CountUsage
as well as the results it gets from SearchEngine.

In order to get count and/or results, we now create:

[1] instance methods get_usage_count and linked_biblionumbers in
Koha::Authority,
[2] class methods of the same name in Koha::Authorities.

The instance method calls the class method. The class method can be used
for deleted authority records, and in 'legacy calls' before refactoring.

Note: On BZ 18149 we will replace all CountUsage calls.

Test plan:
Run t/db_dependent/Koha/Authorities.t

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

--- Comment #23 from Marcel de Rooy  ---
Created attachment 60604
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60604=edit
Bug 9988: Refactor the cron script

The cron job is moved from migration tools to cronjobs. And renamed to
a plural form. The script is now based on Koha objects. It does no longer
include the code to merge one record. This can be done via the interface,
and will be added to a maintenance script on bug 18071. Should not be part
of this cron job.

Adding a cron_cleanup method to MergeRequests; this method is called from
the cron script to reset older entries still marked in progress and to
also remove old processed entries. Tested in a separate unit test.

Test plan:
[1] Run t/db_dependent/Authorities/MergeRequests.t
[2] Set AuthorityMergeLimit to 0. (All merges are postponed.)
[3] Modify an authority linked to a few records.
[4] Delete an authority linked to a few records with batch delete tool.
[5] And select two auth records with linked records.
Merge these two records with authority/merge.pl.
Note: Do not select Default. See also bug 17380.
[6] Check the need_merge_authorities table for inserted records.
[7] Run misc/cronjobs/merge_authorities.pl -b and inspect the linked
records and the record status in need_merge_authorities.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

--- Comment #26 from Marcel de Rooy  ---
Created attachment 60607
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60607=edit
Bug 9988: Final polishing

[1] DelAuthority: There is actually no need to call GetAuthority in
this routine. The subfields of the old record are not relevant
when removing all references in the linked biblio records.
[2] Added a few POD lines to merge.
[3] Removed a trailing space in a comment line in merge.

Test plan:
[1] Run Merge.t

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

--- Comment #24 from Marcel de Rooy  ---
Created attachment 60605
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60605=edit
Bug 9988: Fix a small last minute bug in merge

When you postpone an 'authtype crossing' authority merge from A to B,
the record for A will be deleted. In that case the condition for tags_new
in sub merge does not work well. We should allow an empty authtypefrom
here in order to get a new field belonging to authority B.
Simply put, if we go from PERSO to CORPO, all linked records should go
from X00 to X10 etc.

Test plan:
[1] Run Merge.t
[2] Select two authorities of different type with linked records.
[3] Set AuthorityMergeLimit to zero. And merge both auth records.
Note: Do not select Default. See also bug 17380.
[4] Run the cron job and check the linked records (especially the ones
that were linked to the deleted record).

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

--- Comment #20 from Marcel de Rooy  ---
Created attachment 60601
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60601=edit
Bug 9988: Remove the Zebra code from sub merge

Since we can now call linked_biblionumbers, we can now remove all Zebra
related code from merge. We also add a parameter biblionumbers; we use it
in the test now, but it may be handy too later in the maintenance script
when we want to trigger a merge for specific biblionumber(s). See bug
report 18071.

All mocks for ZOOM, Context::Zconn, Search::new_record_for_zebra in the
merge test can now be replaced by one mock for linked_biblionumbers. Note
that we test the biblionumbers parameter in the last subtest without that
mock.

Remove unused vars $countunmodifiedbiblio, $counterrors from merge.
Renamed zebrarecords to linkedrecords in the Merge test.

Test plan:
[1] Run t/db_dependent/Authorities/Merge.t
[2] Modify an authority record. Check the linked biblio records.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

--- Comment #21 from Marcel de Rooy  ---
Created attachment 60602
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60602=edit
Bug 9988: Check the merge limit in sub merge

At this point, we are replacing dontmerge functionality by the new
AuthorityMergeLimit logic. Instead of doing this check before calling
merge, we just call merge and check it there. In order to let the cron
job do the larger (postponed) merges, we add a parameter override_limit.

A subtest is added in Merge.t to test the 'postponed merge' feature. Since
merge now also calls get_usage_count, an additional mock is added. All
references to dontmerge are removed.

In merge two lines, initializing $dbh and $counteditbiblios, are moved.
The dontmerge test in DelAuthority and ModAuthority is removed. Since this
did not leave much in ModAuthority, I fixed the whitespace on the remaining
lines rightaway (yes, I know).
A minimal set of changes is applied to the cron script; it will get further
attention on a next patch.

Test plan:
[1] Run Merge.t
[2] Set AuthorityMergeLimit to 2. Modify an authority with two linked
biblios. Check that the merge was done immediately.
[3] Now modify an authority with more than 2 linked records.
Verify that the merge was postponed; a record must be inserted in
the need_merge_authorities table.
[4] Testing of the merge cron job is *postponed* to a next patch.
Note: I tested a modification, but the script just needs more
attention.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

--- Comment #19 from Marcel de Rooy  ---
Created attachment 60600
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60600=edit
Bug 9988: Merge should have a parameter hash

We will need a few additional parameters for merge later on. This patch
puts the original parameters in a parameter hash.

Test plan:
[1] Run Merge.t
[2] Merge two authorities in the Authorities module

Note: I also tested script merge_authority.pl with -b parameter. This
script will still need further attention. I manually deleted an authority
record, inserted a record in need_merge_authorities, and ran the script
with -b while adding -f and -t with an existing authority number. This
record number is ignored in batch mode. The biblio record with the deleted
authority was correctly cleaned up.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

--- Comment #22 from Marcel de Rooy  ---
Created attachment 60603
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60603=edit
Bug 9988: Remove further references to dontmerge

[1] The preference was sent to HEA. We can now send both AuthorityMergeMode
as well as AuthorityMergeLimit.
[2] A comment in authorities/merge.pl is removed. Note that a subsequent
patch will modify and test the cron job.
[3] Script misc/batchRebuildItemsTables.pl temporarily enabled dontmerge.
This is equivalent to setting the mergelimit to zero.
The function defnonull is no longer needed. (If the pref was NULL,
we restore that value. Sub merge won't mind.)

Test plan:
[1] Run t/db_dependent/UsageStats.t
[2] Run misc/batchRebuildItemsTables.pl -t
This just ensures you it still compiles; the changes speak for itself.
[3] Now git grep on dontmerge.
You should only find hits in atomicupdate and misc/translator/po.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

--- Comment #16 from Marcel de Rooy  ---
Created attachment 60597
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60597=edit
Bug 9988: Add Koha objects for table need_merge_authorities

This patch adds two Koha objects: MergeRequest(s).
MergeRequest has a new method and an oldmarc method.
A class method reporting_tag_xml is added to MergeRequests.pm.
All new routines are tested in Authorities.t.

Removes a few unneeded modules from Koha::Authority.

Test plan:
Run t/db_dependent/Koha/Authorities.t

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

--- Comment #14 from Marcel de Rooy  ---
Created attachment 60595
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60595=edit
Bug 9988: Table revision for need_merge_authorities

In order to let merge do exactly the same when called from the merge
cron job, we need three additional fields in the table. The use of these
fields will be explained in a follow-up.

Test plan:
Run the dbrev (updatestructure step in webinstaller).

Signed-off-by: Marcel de Rooy 
Also tested running kohastructure.sql for this table.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

--- Comment #15 from Marcel de Rooy  ---
Created attachment 60596
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60596=edit
Bug 9988: DBIx schema changes for need_merge_authorities

As generated by misc/devel/update_dbix_class_files.pl.
No test plan.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

--- Comment #17 from Marcel de Rooy  ---
Created attachment 60598
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60598=edit
Bug 9988: Add extract_biblionumber to Koha/SearchEngine

When we will replace the Zebra code in sub merge, we will call SearchEngine
to pass records and we need a routine to extract a biblionumber from
a search result record. A record from Zebra still must be converted to
MARC::Record. This is no longer needed for a ElasticSearch record.

Test plan:
Run t/db_dependent/Koha/SearchEngine/Search.t

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

--- Comment #13 from Marcel de Rooy  ---
Created attachment 60594
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60594=edit
Bug 9988: Database revision for AuthorityMergeLimit

Introduce the new preference and remove dontmerge.
If dontmerge was enabled, the new pref will be set to zero and we will
print a message about raising this value now.

Test plan:
Run the database revision or a new install.
In case of an upgrade, check the new pref value. Should be 0 when
dontmerge was enabled, otherwise 50.

Signed-off-by: Marcel de Rooy 
Also tested sysprefs.sql on a new database.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #60259|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #60256|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #60257|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #60258|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Marcel de Rooy  changed:

   What|Removed |Added

 Blocks||18149


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18149
[Bug 18149] Move CountUsage calls to Koha namespace
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

--- Comment #10 from Marcel de Rooy  ---
Created attachment 60257
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60257=edit
Bug 9988: Table revision for need_merge_authorities

In order to let merge do exactly the same when called from the merge
cron job, we need two additional fields in the table. One existing field
is renamed.

Test plan:
Run the dbrev (updatestructure step in webinstaller).

Signed-off-by: Marcel de Rooy 
Also tested running kohastructure.sql for this table.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #59159|0   |1
is obsolete||

--- Comment #12 from Marcel de Rooy  ---
Created attachment 60259
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60259=edit
Bug 9988: Add Koha objects for table need_merge_authorities

This patch adds two Koha objects: MergeRequest(s).
A method add_merge_request is added to Koha::Authority.
A class method reporting_tag_xml is added to MergeRequests.pm.
Both routines are tested in Authorities.t.

Test plan:
Run t/db_dependent/Koha/Authorities.t

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

--- Comment #11 from Marcel de Rooy  ---
Created attachment 60258
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60258=edit
Bug 9988: DBIx schema changes for need_merge_authorities

As generated by misc/devel/update_dbix_class_files.pl.
No test plan.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #59158|0   |1
is obsolete||

--- Comment #9 from Marcel de Rooy  ---
Created attachment 60256
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60256=edit
Bug 9988: Database revision for AuthorityMergeLimit

Introduce the new preference and remove dontmerge.
If dontmerge was enabled, the new pref will be set to a lower number.

Test plan:
Run the database revision or a new install.
In case of an upgrade, check the new pref value. Should be 10 when
dontmerge was enabled, otherwise 50.

Signed-off-by: Marcel de Rooy 
Also tested sysprefs.sql on a new database.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Marcel de Rooy  changed:

   What|Removed |Added

 Depends on||18070


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18070
[Bug 18070] Support clean removal of authority records
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

--- Comment #8 from Marcel de Rooy  ---
Just a run-up. More patches coming, but needing rebase on other work coming
from the omnibus bug 17908.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

--- Comment #7 from Marcel de Rooy  ---
Created attachment 59159
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59159=edit
Bug 9988: Add Koha objects for table need_merge_authorities

Test plan:
Run t/db_dependent/Koha/Authorities.t

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

--- Comment #6 from Marcel de Rooy  ---
Created attachment 59158
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59158=edit
Bug 9988: Database revision for AuthorityMergeLimit

Introduce the new preference and remove dontmerge.
If dontmerge was enabled, the new pref will be set to a lower number.

Test plan:
Run the database revision or a new install.
In case of an upgrade, check the new pref value. Should be 10 when
dontmerge was enabled, otherwise 50.

Signed-off-by: Marcel de Rooy 
Also tested sysprefs.sql on a new database.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Marcel de Rooy  changed:

   What|Removed |Added

 Blocks||17908


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908
[Bug 17908] Authority merge omnibus
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

--- Comment #5 from Marcel de Rooy  ---
*** Bug 12791 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Marcel de Rooy  changed:

   What|Removed |Added

 CC||hans...@gmail.com

--- Comment #4 from Marcel de Rooy  ---
*** Bug 5821 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

--- Comment #3 from Marcel de Rooy  ---
(In reply to Marcel de Rooy from comment #0)
> But in case I just update e.g. a 551 tag for the auth record, there is no
> need at all to update all those bib records.

Will leave this case out. Sometimes we may expect to trigger an authority merge
by saving an authority, and perhaps do not want a 'smart' merge to do nothing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Marcel de Rooy  changed:

   What|Removed |Added

Summary|Unneeded timeouts when  |Leave larger authority
   |saving authorities (Can we  |merges to merge_authority
   |merge smarter?) |cronjob (pref
   ||AuthorityMergeLimit)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Marcel de Rooy  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |m.de.r...@rijksmuseum.nl
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/