[Koha-bugs] [Bug 24819] Allow the librarian to choose a patron when entering a purchase suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24819 --- Comment #8 from Matthias Meusburger --- Created attachment 101583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101583=edit Bug 24819: (follow-up) Rename suggestion_search to suggestor_search -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754 Marcel de Rooy changed: What|Removed |Added Attachment #100305|0 |1 is obsolete|| --- Comment #30 from Marcel de Rooy --- Created attachment 101584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101584=edit Bug 24754: Set userenv for ilsdi requests Currently ILSDI scripts do not have a userenv set. This affects both action_logs and statistics. For action_logs we either get no user or, if there is an active session, we use that one. This can have unintended consequences and we should explicitly set the env so that system user (0) is recorded For statistics we need to specify a branch to record for actions like renewals. With bug 24759 we add an items method for this. We should take advantage of this method and use the 'opac' interface as the ilsdi scripts live there. To test: 1 - Enable ILSDI in systempreferences 2 - Checkout an item to a patron 3 - Enable Renewal logs 4 - Ensure you will be able to renew the item several times 5 - Open an incognito/private browser 6 - Renew item via ilsdi: http://localhost:8080/cgi-bin/koha/ilsdi.pl?service=RenewLoan_id=5_id=1128 7 - Check action logs, interface may be random, user should be 0, if not make sure the user in step 9 is a different one 8 - In private browser open a new tab 9 - Sign in to staff client 10 - Return to other tab 11 - Refresh page to repeat renewal 12 - Check action_logs 13 - The second renewal indicates it was renewed via intranet by logged in staff member 14 - Apply patch 15 - restart_all 16 - Ensure staff client still signed in 17 - Repeate renewal again 18 - Check logs, renewal now indicates opac again (as it should), user is 0 even if logged in on other tab Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | --- Comment #32 from Marcel de Rooy --- @RM: There is a dependency ! But note that it is imo not strictly needed to wait for it.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22771] Elasticsearch - Sort by title do not considerate second indicator of field 245 (marc21)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22771 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22771] Elasticsearch - Sort by title do not considerate second indicator of field 245 (marc21)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22771 --- Comment #12 from Nick Clemens --- Created attachment 101552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101552=edit Bug 22771: Fix mistakes in list of nonfiling character fields Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22771] Elasticsearch - Sort by title do not considerate second indicator of field 245 (marc21)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22771 --- Comment #13 from Nick Clemens --- Created attachment 101553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101553=edit Bug 22771: (QA follow-up) Fix POD Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22771] Elasticsearch - Sort by title do not considerate second indicator of field 245 (marc21)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22771 Nick Clemens changed: What|Removed |Added Attachment #100297|0 |1 is obsolete|| Attachment #100298|0 |1 is obsolete|| --- Comment #11 from Nick Clemens --- Created attachment 101551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101551=edit Bug 22771: Respect nonfiling indicators for search fields Strip initial characters from search fields in accordance with nonfiling character indicators. To test: 1) Apply patch 2) Run tests in t/Koha/SearchEngine/Elasticsearch.t 3) All tests should pass Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16457] Remove the use of "onclick" from the patron entry form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16457 Owen Leonard changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16457] Remove the use of "onclick" from the patron entry form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16457
--- Comment #4 from Owen Leonard ---
Created attachment 101554
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101554=edit
Bug 16457: (follow-up) Enable click event on dynamically-created elements
This patch moves the click handler for patron attribute actions ("new",
"clear") from the links themselves to the container. This allows jQuery
to correctly target dynamically-created copies of the links.
To test you should have extended patron attributes enabled and you
should have some repeatable attributes defined.
- Create or edit a patron record
- In the "Additional attributes and identifiers" section, test the
"Clear" and "New" links. Confirm that the controls work with both the
original instance of the field and those created by clicking "New."
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24023] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24023 Julian Maurice changed: What|Removed |Added Attachment #95331|0 |1 is obsolete|| --- Comment #4 from Julian Maurice --- Created attachment 101555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101555=edit Bug 24023: Add ability to create bundles of items This patch adds the ability to link items to a biblio to create bundles of items that can be reserved and checked out like a regular item. A withdrawn status will be set to linked items so that they can't be checked out while they are part of a bundle. When returning a bundle, the list of items that are part of this bundle will be displayed, allowing the librarian to verify that all items are there. Bundles can also be used in the inventory tool as a filter. Test plan: 0. Apply the patch, run updatedatabase + update_dbix_class_files 1. Create a biblio record with at least a title. Create an item for this biblio record 2. In the biblio 'Edit' menu you have a new option: 'Link elements'. Click on it 3. Enter a list of valid and invalid barcodes in the textarea, select a withdrawn status and click on 'Continue' 4. Verify that new fields have been added to the MARC record (462 for UNIMARC, 774 otherwise) 5. Verify that the withdrawn status has been correctly set for the items you have linked 6. Verify that, for item created at step 1, items.materials has been updated with the number of items contained in the bundle 7. Edit the biblio record and remove one of the 462/774 fields 8. Verify that the corresponding item's withdrawn status has been reset 9. Checkout and checkin the item created at step 1 10. You should see the list of items contained in the bundle. Click on 'Confirm checkin without verifying'. Verify that the item has been returned 11. Checkout and checkin the item created at step 1 again 12. Now click on 'Verify items bundle contents'. A textarea lets you enter barcodes. Enter some (but not all) barcodes that are in the bundle. Select a 'lost' status and click on 'Confirm checkin and mark missing items as lost' 13. Verify that the items corresponding to barcodes you did not type in the textarea are now marked as lost with the lost status you chose 14. Go to the inventory tool, use the bundle filter and verify that it works Sponsored-by: Bibliothèque Départementale de l'Yonne -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24159] Short loan collection issues on a day marked as closed (move useDaysMode to circ rules)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 --- Comment #19 from Simon Perry --- Created attachment 101556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101556=edit Test 24/3/20 Attached is testing completed today. I tested all 4 options available in the useDaysMode syspref. Only for the Ignore and Use calendar to push due date to next pen matching weekday syspref settings did the checkout due date/hour remain on the days of checkout. This wouldn't work for our live system settings as noted. Regards, Simon -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24966] New: Fix calls to maybe_add where method call does not return a value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24966
Bug ID: 24966
Summary: Fix calls to maybe_add where method call does not
return a value
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: critical
Priority: P5 - low
Component: SIP2
Assignee: koha-bugs@lists.koha-community.org
Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com
For reasons unknown to me, a call like:
--
$resp .= maybe_add( FID_CALL_NUMBER, $item->call_number, $server );
--
will not work as expected if the item has no callnumber.
One would expect the parameters to the subroutine to be: 'CY', under, and a
SIPServer object.
What is actually received is: 'CY', and a SIPServer object.
We ingest the parameters like so:
--
sub maybe_add {
my ($fid, $value, $server) = @_;
--
So, what happens is $value is populated with the server object!
This can cause bad output like this:
--
OUTPUT MSG: '101YNN20200324063701AOBPL|AB32503201584185|AQBPL|AJCat
/|CK001|CRn|CSJ 636.8
CLU|CYC4::SIP::SIPServer=HASH(0x1ea0e58)|DAC4::SIP::SIPServer=HASH(0x1ea0e58)|'---
I do not know why this is happening, but there are a couple solutions:
1) Move the $server parameter to be the first parameter of the subroutine call
2) Check the value of $value and swap $value and $server if it is the server
object.
I will write a patch implementing the latter solution, as it is a two line
change, versus a many line change for the former.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory defaults to records from external sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276 --- Comment #23 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #18) > I have another issue tho: We apply the default from the ACQ framework, while > we can specifically choose a framework to import the record in on the > Z39.50/SRU form - this is not caused by this bug, but doesn't make sense to > me. Especially for 942$c it would make a lot of sense to me to set different > default for different frameworks and use them. What do you think, Marcel? Sounds valid, have to check. Getting back to it.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22534] Add ability to choose which fields are copied from guarantor to guarantee
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 Sally changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk --- Comment #9 from Sally --- I've tested 1-15 on a sandbox and it works well. If someone else could test 16, then I'm happy to add my sign off line to the patch: 16. Run tests: sudo koha-shell prove xt prove t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Nicolas Legrand changed: What|Removed |Added Attachment #101452|0 |1 is obsolete|| --- Comment #6 from Nicolas Legrand --- Created attachment 101564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101564=edit Bug 24201: Attach desk to intranet session When Desks are defined, a librarian can attach a desk to its session. Test plan: 1. apply 13881 and create some desks 2. you should see “NO DESK SET” in the intranet header 3. go to circulation > Set desk 4. you should see your desk name in the header, whatever the page 5. you can also set desk with the header menu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15326] Add CMS feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #135 from Nick Clemens --- Rebased, found issues: Parent child links are a confusing: List display parent name needlessly Cannot see children from parent in breadcrumbs Can access unpublished pages Library specific pages are listed for all branches Staff side link should use link title not page title Can view staff pages on opac -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24829] ClaimReturnedWarningThreshold is always triggered if patron has one or more claims
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24829 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #100375|0 |1 is obsolete|| --- Comment #2 from PTFS Europe Sandboxes --- Created attachment 101582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101582=edit Bug 24829: ClaimReturnedWarningThreshold is always triggered if patron has one or more claims ClaimReturnedWarningThreshold is supposed to display a warning if a patron has more than the number of claims specified in the system preference. Currently the warning is displayed for any number of claims over zero. Test Plan: 1) Make 3 return claims for a patron 2) Set ClaimReturnedWarningThreshold to 4 3) Note the claims warning displays for the patron on circulation.pl 4) Apply this patch 5) Reload circulation.pl, the warning should go away 6) Set ClaimReturnedWarningThreshold to 2 7) Reload the page, the warning should reappear Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24829] ClaimReturnedWarningThreshold is always triggered if patron has one or more claims
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24829 Sally changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24745] OPAC news block plugin should evaluate as false if there are no items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24745 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24965] New: Koha::Object->to_api should handle undef counts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24965
Bug ID: 24965
Summary: Koha::Object->to_api should handle undef counts
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: koha-bugs@lists.koha-community.org
Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org
If to_api is requested to embed the count on a relation that might be undef
(for example, if the relation is not just a FK on another table but linking
table:
sub current_item_level_holds {
my ($self) = @_;
my $items_rs = $self->_result->aqorders_items;
my @item_numbers = $items_rs->get_column('itemnumber')->all;
return unless @item_numbers;
my $biblio = $self->biblio;
return unless $biblio;
return $biblio->current_holds->search(
{
itemnumber => {
-in => \@item_numbers
}
}
);
}
it is possible to get exceptions for calling ->count on an undefined object. We
should catch this situation and return zero.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24965] Koha::Object->to_api should handle undef counts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24965 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | Blocks||20212 Depends on||24528 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 [Bug 20212] Slowness in Receiving in Acquisitions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528 [Bug 24528] Add a syntax for specifying counts on x-koha-embed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi changed: What|Removed |Added Depends on||24965 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24965 [Bug 24965] Koha::Object->to_api should handle undef counts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24745] OPAC news block plugin should evaluate as false if there are no items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24745 Owen Leonard changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24966] Fix calls to maybe_add where method call does not return a value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24966 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20399] Remove "did you mean" for the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20399 Fridolin SOMERS changed: What|Removed |Added Attachment #101336|0 |1 is obsolete|| --- Comment #8 from Fridolin SOMERS --- Created attachment 101562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101562=edit Bug 20399: Remove "did you mean" for the staff interface The amdin page for the "did you mean" feature has two block for setting it up in the staff interface, and a note saying this isn't implemented on the staff interface yet. We remove the part about the staff interface until it actually is implemented. Test plan : 1) Apply patch 2) Go to Administration > Did you mean? 3) See there is only the OPAC block 4) Change some checkboxes 5) Save configuration 6) Check that configuration is saved -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20399] Remove "did you mean" for the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20399 Fridolin SOMERS changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24756] Occasional failures for Koha/XSLT/Security.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24756 --- Comment #19 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #18) > It seems that we need it for 19.11 as well > > 19.11_D9 (79) > > koha_1 | # Failed test 'Remote import does not fail on read_net' > koha_1 | # at t/db_dependent/Koha/XSLT/Security.t line 124. > koha_1 | # found warning: XSLT_Handler: I/O warning : failed to load > HTTP resource > koha_1 | # expected to find warning: (?^u:I/O warning : failed to load > external entity) > koha_1 | # Looks like you failed 1 test of 7. This should be backported, yes. The RMaints look in this queue, right? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15326] Add CMS feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Nick Clemens changed: What|Removed |Added Attachment #97237|0 |1 is obsolete|| --- Comment #133 from Nick Clemens --- Created attachment 101579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101579=edit Bug 15326: (follow-up) Template tweaks This patch makes some tweaks to the staff-side template: - Fix some indentation - Add some markup comments - Fix some HTML validation errors: Eliminate duplicate id attributes - Expand the descriptiveness of , breadcrumbs, and form legend - Increase size of link and title fields; Add maxlength attribute to title field. - Move title and link fields to the second column of the table -- more consistent with other tables where the main link is in the first column. - Link parent page information to corresponding edit page - Correct incorrectly filtered action links - Correct default table sort - Fix TinyMCE configuration - I copied some configuration code from another page which was updated more recently. To test, apply the patch and test the process of adding, editing, and deleting pages. Test all the options in the "Actions" menu. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15326] Add CMS feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #134 from Nick Clemens --- Created attachment 101580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101580=edit Bug 15326: DO NOT PUSH - Schema changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24745] OPAC news block plugin should evaluate as false if there are no items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24745 Marcel de Rooy changed: What|Removed |Added Attachment #100152|0 |1 is obsolete|| Attachment #101558|0 |1 is obsolete|| --- Comment #11 from Marcel de Rooy --- Created attachment 101586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101586=edit Bug 24745: OPAC news block plugin should evaluate as false if there are no items This patch changes the way news is returned from GetNewsToDisplay in KohaNews.pm so that the template variable will evaluate as false instead of simply being an empty data structure. To verify the bug, remove your opacheader news entry and view source on any page in the OPAC. You should find some empty markup right after ' ' To test the fix, apply the patch and reload the OPAC page. The empty divs should be gone. Add content to the opacheader news item and confirm that it displays correctly. Signed-off-by: Bernardo Gonzalez Kriegel Divs gone, no errors. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24745] OPAC news block plugin should evaluate as false if there are no items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24745 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 --- Comment #17 from Frank Hansen --- When we migrated from your previous ILS (Virtua), I kept some vendor contact information in booksellerfax, bookselleremail and currency. This means that we are will lose this information when you drop them from DB. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Assignee|koha-b...@lists.koha-commun |nicolas.legr...@bulac.fr |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting reserve to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Assignee|koha-b...@lists.koha-commun |nicolas.legr...@bulac.fr |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24710] patron-title.inc should have seperate span classes for firstname, othername, surname
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24710
PTFS Europe Sandboxes changed:
What|Removed |Added
Attachment #100078|0 |1
is obsolete||
--- Comment #10 from PTFS Europe Sandboxes ---
Created attachment 101557
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101557=edit
Bug 24710: patron-title.inc should have seperate span classes for names
This patch adds some elements with classes to patron-title.inc for both
the staff client and OPAC
TEST PLAN:
1. Have a patron with a firstname, surname, and othername and title
2. Apply patch
3. There should be no visible changes but if you inscept each element you
should see seperate elements with clases.
4. Add each of these to IntranetUserCSS to make sure it hides that element
(this effects patroninfo section AND breadcrumbs)
.patron-firstname {display: none;}
.patron-othernames {display:none};
.patron-surname{display:none}
.patron-title{display:none}
5. On the OPAC navigate to /cgi-bin/koha/opac-user.pl and check the names by
adding the same CSS to OPACUserCSS
6. Sign-off
Signed-off-by: Sally
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24710] patron-title.inc should have seperate span classes for firstname, othername, surname
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24710 Sally changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20399] Remove "did you mean" for the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20399 --- Comment #7 from Fridolin SOMERS --- (In reply to Katrin Fischer from comment #6) > (In reply to Fridolin SOMERS from comment #5) > > > > Do we remove INTRAdidyoumean syspref and related code ? > > I guess we could - it's not been implemented in years and I suppose you can > still easily add it back if you intend to develop it? Indeed, by looking at code for OPAC I'd say -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15326] Add CMS feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Nick Clemens changed: What|Removed |Added Attachment #96095|0 |1 is obsolete|| --- Comment #130 from Nick Clemens --- Created attachment 101576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101576=edit Bug 15326: (follow-up) Remove obsolete LESS file, add TT filters Previous versions of this patch set adds a LESS file to the OPAC, which is now obsolete. It should be removed. In addition, the change made to opac.less contained CSS which didn't apply to any existing markup, so it need not be added to opac.scss. The patch also adds missing Template Toolkit filters to template files. None of these changes should be visible in testing. OPAC CMS pages should function as usual. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15326] Add CMS feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Nick Clemens changed: What|Removed |Added Attachment #96097|0 |1 is obsolete|| --- Comment #131 from Nick Clemens --- Created attachment 101577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101577=edit Bug 15326: Fix QA errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15326] Add CMS feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #132 from Nick Clemens --- Created attachment 101578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101578=edit Bug 15326: Fix filters and adjust tiny_mce assets -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15326] Add CMS feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Nick Clemens changed: What|Removed |Added Attachment #96089|0 |1 is obsolete|| --- Comment #124 from Nick Clemens --- Created attachment 101570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101570=edit Bug 15326: (follow-up) Fix tools menu highlighting Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar Rebased-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15326] Add CMS feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Nick Clemens changed: What|Removed |Added Attachment #96091|0 |1 is obsolete|| --- Comment #126 from Nick Clemens --- Created attachment 101572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101572=edit Bug 15326: (follow-up) Interface fixes This patch addresses the following: a) I feel we don't need the "Pages" heading. It only takes up space and states the obvious. (non-blocker... but navigation needs work, see below) b) OpacMainUserBlock should not show on the pages in my opinion. Libraries use it to place text on the start page instead of using the news feature, which means it repeats on all pages. I'd really like to see this changed. c) Personally I'd change "Location" to "Interface" to avoid confusion with the item value in translations. But I see it's the same on news. So out of scope here. d) Parent pages can be deleted without warning. Childs will be moved to top level. This is acceptable behaviour as they are not left orphaned. But it might be something to improve on in the future. e) In the test plan and in the code I see there should be a confirmation message on deleting a single or multiple entries, but this doesn't work. (blocker) Signed-off-by: Michal Denar Signed-off-by: Michal Denar Rebased-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15326] Add CMS feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326
Nick Clemens changed:
What|Removed |Added
Attachment #96090|0 |1
is obsolete||
--- Comment #125 from Nick Clemens ---
Created attachment 101571
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101571=edit
Bug 15326: (follow-up) Code review fixes
Addresses the following issues:
b) In opac-cmspages there is:
+flagsrequired => { borrow => 1 },
The borrow permission has been removed since. (blocker)
c) Comment was removed unnecessarily, just needs to be moved into
its right spot below again:
-# If GoogleIndicTransliteration system preference is On Set
parameter to load Google's javascript in OPAC search screens
d) One file uses qw( -utf-8) but another does not:
+use CGI;
+use CGI qw( -utf8 ); (blocker)
Signed-off-by: Michal Denar
Signed-off-by: Michal Denar
Rebased-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15326] Add CMS feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Nick Clemens changed: What|Removed |Added Attachment #96088|0 |1 is obsolete|| --- Comment #123 from Nick Clemens --- Created attachment 101569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101569=edit Bug 15326: (follow-up) Don't make links to unpublished pages in opac Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar Rebased-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15326] Add CMS feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Nick Clemens changed: What|Removed |Added Attachment #96094|0 |1 is obsolete|| --- Comment #129 from Nick Clemens --- Created attachment 101575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101575=edit Bug 15326: (follow-up) Corrections to staff client templates This patch makes some corrections to the staff client's CMS-related templates: - Add missing Template Toolkit filters. - Remove JavaScript from tools-menu.inc. This must have crept in during a rebase. - Add navigation link highlighting to tools-menu.js instead. - Convert tools/cmspages.tt to Bootstrap grid. - Correct toolbar button class. - Move some column sorting configuration out of JS and into table markup. - Move "Select all" / "Clear all" links to the top of the table to match similar interfaces. - Change the Action menu's "Intranet" and "OPAC" links to be "View" and "View in OPAC." The OPAC view now opens a new window. To test, apply the patches and test the Pages feature in the staff client: Adding, editing, deleting, viewing. For each view, test that the page layout adjusts to various browser widths. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15326] Add CMS feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Nick Clemens changed: What|Removed |Added Attachment #96093|0 |1 is obsolete|| --- Comment #128 from Nick Clemens --- Created attachment 101574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101574=edit Bug 15326: (follow-up) Redindent new CMS page templates This patch is an opinionated reindent of new and changed templates related to the CMS feature. I think it would be nice for these templates to start out with good indentation. To test, apply the patch and test the CMS feature. There should be no visible change to the way it looks or the way it works. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15326] Add CMS feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Nick Clemens changed: What|Removed |Added Attachment #96092|0 |1 is obsolete|| --- Comment #127 from Nick Clemens --- Created attachment 101573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101573=edit Bug 15326: (follow-up) Pages navigation fixes This is the best I've managed to do with the navigation. Would be happy for someone else to give it a go because I'm aware that some parent links repeat. Signed-off-by: Michal Denar Signed-off-by: Michal Denar Rebased-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24819] Allow the librarian to choose a patron when entering a purchase suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24819 Matthias Meusburger changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24745] OPAC news block plugin should evaluate as false if there are no items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24745 --- Comment #12 from Marcel de Rooy --- Created attachment 101587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101587=edit Bug 24745: (follow-up) Correct return statement in news plugin Subroutine should "return;" instead of "return 0;" We also prevent ProhibitExplicitReturnUndef by not returning "undef" explicitly. Signed-off-by: Marcel de Rooy Commit message edited. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21047] Wrong koha to marc mapping on bibliosubtitle in SQL files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21047 --- Comment #6 from Fridolin SOMERS --- Now that there is Bug 11529 do we replace instead of removing ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24886] Reindent reports template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24886 Lucas Gass changed: What|Removed |Added Attachment #101493|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24886] Reindent reports template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24886 Lucas Gass changed: What|Removed |Added Attachment #101498|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24455] Date formatting from JS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455 --- Comment #45 from Martin Renvoize --- I'm looking to add a followup of my own here to clarify the situation.. struggled to put it into words when talking to Agustin so I'm going to let code speak ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer changed: What|Removed |Added Attachment #100789|0 |1 is obsolete|| --- Comment #114 from Katrin Fischer --- Created attachment 101589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101589=edit Bug 23590: Clean TT variables for patrons Just a bit of cleaning Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer changed: What|Removed |Added Attachment #100788|0 |1 is obsolete|| --- Comment #113 from Katrin Fischer --- Created attachment 101588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101588=edit Bug 23590: Add ability to edit the manager of a suggestion Prior to this patch there was an hidden behavior that set the manager to the logged in user when a suggestion was edited. This patch proposes to let the librarian pick another manager. Other small adjustements will be added to polish this new behavior: * Create 2 new DB columns: suggestions.lastmodificationby and suggestion.lastmodificationdate * Choose a manager when editing a suggestion * Batch modify suggestions and set a manager for them * Let notify the new manager using the TO_PROCESS letter * Display the manageddate, lastmodificationby and lastmodificationdate info where appropriate This first patch adds a new "Select manager" link when editing a suggestion. Test plan for the whole patchset: 0/ a. Execute the update DB entry, generate the new DBIC file and restart all b. Create at least 2 patrons with the suggestions_manage permission 1/ Submit a new suggestion (OPAC or staff, not important) 2/ Accept it 3/ Edit it => "Last modification by" is empty => You see that you are the manager of this suggestion 4/ Click "Select manager" and search for a new manager => The patron search will only display patrons with the suggestions_manage permission 5/ Save 6/ Edit again => The manager is set to you, but there is a note saying that previously it was the patron you picked => The "Last modification by" is set to you 7/ Click "Keep existing manager" => The manager is now set to the previous manager 8/ Select another manager (which has a valid email address defined) 9/ Click the "notify" checkbox 10/ Save 11/ Confirm that a TO_PROCESS notice has been generated into the message_queue table 12/ Create at least one other suggestion 13/ List the suggestions => There is a 4th action column to assign a manager to several suggestions in one go. 14/ Use this new button and confirm that it works as expected 15/ Go to your purchase suggestion list (OPAC and staff) => You see the "managed date" displayed in a new column Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer changed: What|Removed |Added Attachment #100795|0 |1 is obsolete|| --- Comment #120 from Katrin Fischer --- Created attachment 101595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101595=edit Bug 23590: Add atomic update file Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer changed: What|Removed |Added Attachment #100790|0 |1 is obsolete|| --- Comment #115 from Katrin Fischer --- Created attachment 101590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101590=edit Bug 23590: Cleaning - Remove op_* vars Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer changed: What|Removed |Added Attachment #100791|0 |1 is obsolete|| --- Comment #116 from Katrin Fischer --- Created attachment 101591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101591=edit Bug 23590: Batch update manager for suggestions Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer changed: What|Removed |Added Attachment #100792|0 |1 is obsolete|| --- Comment #117 from Katrin Fischer --- Created attachment 101592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101592=edit Bug 23590: Only return patrons that have the suggestions_manage permission Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer changed: What|Removed |Added Attachment #101539|0 |1 is obsolete|| --- Comment #129 from Katrin Fischer --- Created attachment 101604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101604=edit Bug 23590: Fix 'select manager' when creation a suggestion On creating the TT var managedby_patron does not exist yet Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer changed: What|Removed |Added Attachment #100853|0 |1 is obsolete|| --- Comment #128 from Katrin Fischer --- Created attachment 101603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101603=edit Bug 23590: Create a separate template notice NOTIFY_MANAGER To separate the two feature we want to create a distinct template notice. A new NOTIFY_MANAGER notice is added. A follow-up patch will be added for other languages, when this one will be approved by QA. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer changed: What|Removed |Added Attachment #101548|0 |1 is obsolete|| --- Comment #130 from Katrin Fischer --- Created attachment 101605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101605=edit Bug 23590: DBIC Changes Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer changed: What|Removed |Added Attachment #100852|0 |1 is obsolete|| --- Comment #127 from Katrin Fischer --- Created attachment 101602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101602=edit Bug 23590: Fix ergonomic issue if last modification by is empty Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer changed: What|Removed |Added Attachment #100851|0 |1 is obsolete|| --- Comment #126 from Katrin Fischer --- Created attachment 101601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101601=edit Bug 23590: Update new fields with relevant values We are filling lastmodificationdate and lastmodificationby depending on the max dates between manageddate, accepteddate and rejecteddate Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24968] Add Syspref controls for cronjobs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24968 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- +1 With mulitple instances on one server I'd really love that. Turning things off for just one instance is painful otherwise if you are using for-each. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #26 from Fridolin SOMERS --- Rebased on current master with an obvious conflict because of Bug 24468. Performance is really better, tested on my laptop : 100 items => 54 seconds without patch, 8 seconds with patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23798] Convert OpacMaintenanceNotice system preference to news block
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23798 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24676] opac-auth.tt contains trivial HTML error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24676 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable CC||lu...@bywatersolutions.com Version(s)|20.05.00, 19.11.04 |20.05.00, 19.11.04, released in||19.05.09 --- Comment #7 from Lucas Gass --- backported to 19.05.x for 19.05.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 --- Comment #20 from Jonathan Druart --- (In reply to Frank Hansen from comment #17) > When we migrated from your previous ILS (Virtua), I kept some vendor contact > information in booksellerfax, bookselleremail and currency. This means that > we are will lose this information when you drop them from DB. Thanks Frank for this feedback! What about this last patch? We are going to remove the column only if there is no data, otherwise a warning will be displayed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18177] Many unused columns in aqbooksellers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 --- Comment #19 from Jonathan Druart --- (In reply to Frank Hansen from comment #17) > When we migrated from your previous ILS (Virtua), I kept some vendor contact > information in booksellerfax, bookselleremail and currency. This means that > we are will lose this information when you drop them from DB. Thanks Frank for this feedback? What about this last patch? We are going to remove the column only if there is no data, otherwise a warning will be displayed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6271] GetItemIssue(s) : renewals in both items and issues tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6271 Fridolin SOMERS changed: What|Removed |Added Status|Failed QA |RESOLVED Resolution|--- |INVALID --- Comment #12 from Fridolin SOMERS --- Obsolete since Bug 17679 and Bug 17680 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22534] Add ability to choose which fields are copied from guarantor to guarantee
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #10 from Katrin Fischer --- (In reply to Sally from comment #9) > I've tested 1-15 on a sandbox and it works well. > > If someone else could test 16, then I'm happy to add my sign off line to the > patch: > > 16. Run tests: > sudo koha-shell > prove xt > prove t Hi Sally, don't worry about those, we will cover tests during QA :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19261] never hide biblionumber field in view policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19261 Fridolin SOMERS changed: What|Removed |Added Status|Failed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Medium patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185 Fridolin SOMERS changed: What|Removed |Added Attachment #101355|0 |1 is obsolete|| --- Comment #23 from Fridolin SOMERS --- Created attachment 101607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101607=edit Bug 24185: Make holds page faster - improved "if" `$can_item_be_reserved eq 'OK'` moved in `&&` before `IsAvailableForItemLevelRequest` to cut away with static known values before calling to more resource consuming subroutine. Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185 Fridolin SOMERS changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185 --- Comment #27 from Andrew Nugged --- oh, thanks for REBASE! In a case, if another assistance needed – I am monitoring this actively. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24968] Add Syspref controls for cronjobs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24968 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com ||, bwsdo...@gmail.com, ||ke...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13976] Sorting search results by popularity is alphabetical
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13976 --- Comment #6 from Fridolin SOMERS --- I bet its solved with Elasticsearch. Can someone confirm ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23755] Inventory.pl should have a texbox for direct barcode scanning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23755 Matthias Meusburger changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE CC||matthias.meusburger@biblibr ||e.com --- Comment #1 from Matthias Meusburger --- *** This bug has been marked as a duplicate of bug 23114 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185
Fridolin SOMERS changed:
What|Removed |Added
Attachment #101358|0 |1
is obsolete||
--- Comment #28 from Fridolin SOMERS ---
Created attachment 101611
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101611=edit
Bug 24185: Make holds page fast when 'on shelf holds' set to 'If all
unavailable'
When "reserve/request.pl -> C4/Reserves.pm::IsAvailableForItemLevelRequest"
called many times with hundred of items and "on shelf holds" parameter set to
"If all unavailable" for these items + patron, it goes slow.
It happens because in subloop it is checking if all items available so it is
O(n^2) and it re-checks each time the same info for each item with repeating
DB/data requests.
Fix:
The inner loop 1:1 picked out into separate subroutine and called outside of
the loop, saving data in 'items_any_available' variable once, this variable
passed to IsAvailableForItemLevelRequest to be used inside as the precalculated
result.
This made algorithm O(n) instead of O(n^2) so there is noticeable speed
increase.
How to reproduce:
1) on freshly installed kohadevbox create/import one book,
remember that biblionumber for later use it in down below,
2) add 100 items for that book for some library,
3) find some patron, that patron's card number we will
use as a borrower down below to open holds page,
4) check for the rule or set up a single circulation rule
in admin "/cgi-bin/koha/admin/smart-rules.pl",
that rule should match above book items/library/patron,
check that rule to have a non-zero number of holds (total, daily, count)
allowed,
and, IMPORTANT: set up "On shelf holds allowed" to "If all unavailable",
("item level holds" doesn't matter).
5) open "Home > Catalog > THAT_BOOK > Place a hold on THAT_BOOK" page
("holds" tab), and enter patron code in the search field,
or you can create a direct link by yourself, for example, in my case it was:
/cgi-bin/koha/reserve/request.pl?biblionumber=4=23529000686353
6) it should be pretty long page generation time on old code, densely
increasing for every hundred items added. In the case of this solution, it's
fast, and time increases a little only, linear.
I tested on my computer in VirtualBox for page generation times,
did 3-5 runs for same case to check if results are stable, and got such values:
(old code):
100 items:50 seconds
200 items: 3.2 minutes
300 items: 7.3 minutes
(version with fix):
100 items: 4.4 seconds
200 items: 7.5 seconds
300 items: 10.4 seconds
Signed-off-by: Fridolin Somers
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place volume level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place volume level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23797] Convert OpacLoginInstructions system preference to news block
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23797 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21047] Wrong koha to marc mapping on bibliosubtitle in SQL files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21047 --- Comment #7 from Katrin Fischer --- (In reply to Fridolin SOMERS from comment #6) > Now that there is Bug 11529 do we replace instead of removing ? I think the bug took care of that already - and if you do it for existing installations, it will be incomplete - only new/edited will fill the column. I think it would still be worthwhile to remove the false mapping, if there are any left. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer changed: What|Removed |Added Attachment #100794|0 |1 is obsolete|| --- Comment #119 from Katrin Fischer --- Created attachment 101594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101594=edit Bug 23590: Add lastmodification by and date columns No tests are provided for the changes made to SearchSuggestion. It is going to be remove very soon as it is super ugly... Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer changed: What|Removed |Added Attachment #100793|0 |1 is obsolete|| --- Comment #118 from Katrin Fischer --- Created attachment 101593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101593=edit Bug 23590: Add the ability to notify a new manager Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer changed: What|Removed |Added Attachment #100846|0 |1 is obsolete|| --- Comment #122 from Katrin Fischer --- Created attachment 101597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101597=edit Bug 23590: Fix select manager on list for all tabs Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer changed: What|Removed |Added Attachment #100796|0 |1 is obsolete|| --- Comment #121 from Katrin Fischer --- Created attachment 101596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101596=edit Bug 23590: Remove JS error on the suggestion list The notify option is only available from the edit view Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer changed: What|Removed |Added Attachment #100850|0 |1 is obsolete|| --- Comment #125 from Katrin Fischer --- Created attachment 101600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101600=edit Bug 23590: remove unused variable Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer changed: What|Removed |Added Attachment #100848|0 |1 is obsolete|| --- Comment #123 from Katrin Fischer --- Created attachment 101598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101598=edit Bug 23590: (QA follow-up) Add missing filters and drop script type Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer changed: What|Removed |Added Attachment #100849|0 |1 is obsolete|| --- Comment #124 from Katrin Fischer --- Created attachment 101599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101599=edit Bug 23590: (QA follow-up) Fix some problems created by recent changes and updatedatabase statement - Ensure that the sequence of columns will be the same for new and updated installations (add AFTER ...) - Fix permissions (see bug 22868) - Fix column configuration (see 16784) - Remove '- ' displying before the date Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23590] Allow to modify and notify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #131 from Katrin Fischer --- Created attachment 101606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101606=edit Bug 23590: (QA follow-up) Fix links to patron records (TT variable confusion) Fixes links to the patron accounts from the edit and list view of suggestions. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24968] New: Add Syspref controls for cronjobs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24968 Bug ID: 24968 Summary: Add Syspref controls for cronjobs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com At the simplest it would be nice to have an on/off switch for any cronjob so that libraries can disable cronjobs as needed (during emergency closings etc.) At the most advanced, it could offer the option of controlling all of the parameters for the cronjob, either using a syntax or a new administration area -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185 Fridolin SOMERS changed: What|Removed |Added Attachment #101357|0 |1 is obsolete|| --- Comment #25 from Fridolin SOMERS --- Created attachment 101609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101609=edit Bug 24185: Make holds page faster: preparatory refactoring This is just refactoring. extracting logically independent code to separate sub + tests update. No logic change yet. Searching for "any_available" item among all biblionumber items was done inside of "elsif on_shelf_holds == 2", and it is logically very independent piece of code (this "@items" loop), it needs just biblionumber and patron as parameters so it can be extracted into separate subroutine, and later also called/reused from somewhere else. This ability to call from another place also made for future patch to remove O(n^2) problem with nested loops. Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185 Fridolin SOMERS changed: What|Removed |Added Attachment #101356|0 |1 is obsolete|| --- Comment #24 from Fridolin SOMERS --- Created attachment 101608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101608=edit Bug 24185: Make holds page faster - call to subroutine moved below "if" `$on_shelf_holds` was assigned before "return .. if" but not used in that code piece, so sometimes it was useless. Moved assignment after "return .. if". Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23797] Convert OpacLoginInstructions system preference to news block
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23797 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23797] Convert OpacLoginInstructions system preference to news block
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23797 --- Comment #1 from Owen Leonard --- Created attachment 101610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101610=edit Bug 23797: Convert OpacLoginInstructions system preference to news block This patch builds on Bug 22318 to move the OpacLoginInstructions system preference into the Koha news system, making it possible to have language- and library-specific content. To test you should have some content in the OpacLoginInstructions system preference. Apply the patch and run the database update process. - Go to the OPAC and click the login link. - In the login modal, confirm that the content which was previously in the OpacLoginInstructions system preference displays correctly below the login form. - While not logged in to the OPAC, navigate directly to /cgi-bin/koha/opac-user.pl. The OpacLoginInstructions content should display correctly here as well. - In the staff client, go to Tools -> News and verify that the content from OpacLoginInstructions is now stored in news items. There should be one entry for each of the enabled translations in your system, for instance 'OpacLoginInstructions_en', 'OpacLoginInstructions_fr-FR', 'OpacLoginInstructions_cs-CZ' - Go to Administration -> System preferences and confirm that the OpacLoginInstructions preference has been removed. - To test the correct selection of language-specific content you must run the translation update/install process for the languages you're updating. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
