RE: [PATCH] ARM: EXYNOS5440: DTS: Add virtual GIC DT bindings
Giridhar Maruthy wrote:
Exynos5440 has GIC which has virtualization support
in them. These are used by KVM.
Signed-off-by: Giridhar Maruthy giridha...@samsung.com
---
arch/arm/boot/dts/exynos5440.dtsi |6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/exynos5440.dtsi
b/arch/arm/boot/dts/exynos5440.dtsi
index c374a31..25c6134 100644
--- a/arch/arm/boot/dts/exynos5440.dtsi
+++ b/arch/arm/boot/dts/exynos5440.dtsi
@@ -26,7 +26,11 @@
compatible = arm,cortex-a15-gic;
#interrupt-cells = 3;
interrupt-controller;
- reg = 0x2E1000 0x1000, 0x2E2000 0x1000;
+ reg = 0x2E1000 0x1000,
+ 0x2E2000 0x1000,
+ 0x2E4000 0x2000,
+ 0x2E6000 0x2000;
+ interrupts = 1 9 0xf04;
};
cpus {
--
1.7.9.5
Looks ok to me, applied.
Thanks.
- Kukjin
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 3/3] ARM: EXYNOS5250: Register architected timers
Alexander Graf wrote:
When running on an exynos 5250 SoC, we don't initialize the architected
timers. The chip however supports architected timers.
Yes, exynos5250 can support, mct(multi core timer) is used though.
When we don't initialize them, KVM will try to access them and run into
NULL pointer dereferences attempting to do so.
Yes, right.
This patch is really more of a hack than a real fix, but does get me
working with KVM on Arndale.
Hmm, if you think, this is _really_ a hack, you need to add some comments
about that for clearance, and since the mct.c file has been moved into
drivers/clocksource/, this should be re-worked.
BTW, I discussed about this with Thomas and Giridhar just now, we reached
this 3rd patch could be dropped because the correct way is to add a dts
node for arch timer which patch 2nd is already doing after 3.9-rc1 because
of CLOCKSOURCE_OF_DECLARE macro.
So if you' OK above, let me know so that I can take only 1st and 2nd
patches to support KVM on exynos5250.
Thanks.
- Kukjin
Signed-off-by: Alexander Graf ag...@suse.de
---
arch/arm/mach-exynos/mct.c |4
1 file changed, 4 insertions(+)
diff --git a/arch/arm/mach-exynos/mct.c b/arch/arm/mach-exynos/mct.c
index c9d6650..eefb8af 100644
--- a/arch/arm/mach-exynos/mct.c
+++ b/arch/arm/mach-exynos/mct.c
@@ -482,4 +482,8 @@ void __init exynos4_timer_init(void)
exynos4_timer_resources();
exynos4_clocksource_init();
exynos4_clockevent_init();
+
+ if (soc_is_exynos5250()) {
+ arch_timer_of_register();
+ }
}
--
1.7.10.4
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 3/3] ARM: EXYNOS5250: Register architected timers
Alexander Graf wrote: On 04/02/2013 12:44 PM, Kukjin Kim wrote: Alexander Graf wrote: When running on an exynos 5250 SoC, we don't initialize the architected timers. The chip however supports architected timers. Yes, exynos5250 can support, mct(multi core timer) is used though. When we don't initialize them, KVM will try to access them and run into NULL pointer dereferences attempting to do so. Yes, right. This patch is really more of a hack than a real fix, but does get me working with KVM on Arndale. Hmm, if you think, this is _really_ a hack, you need to add some comments about that for clearance, and since the mct.c file has been moved into drivers/clocksource/, this should be re-worked. BTW, I discussed about this with Thomas and Giridhar just now, we reached this 3rd patch could be dropped because the correct way is to add a dts node for arch timer which patch 2nd is already doing after 3.9-rc1 because of CLOCKSOURCE_OF_DECLARE macro. So if you' OK above, let me know so that I can take only 1st and 2nd patches to support KVM on exynos5250. I'd say go ahead and take them and I'll verify whether things work on your tree :). OK, I will. What's the git repo of your branch? You can test with my for-next branch but this series can be seen tomorrow night(KST) in my public tree. Any problems, please let me know. Thanks. - Kukjin -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
