Re: [Autotest] [PATCH] KVM Test: add -w parameter in nc command in kvm_utils.py

2010-10-27 Thread Lucas Meneghel Rodrigues
On Wed, 2010-10-20 at 14:55 +0800, Feng Yang wrote:
 If a connection and stdin are idle for more than timeout seconds,
 then the connection is silently closed. withou this paramter,
 nc will listen forever for a connection. This may cause our test
 hang. redmine issue:
 http://redmine.englab.nay.redhat.com/issues/show/6947
 Add -w parameter should fix this issue.

Feng, for reasons already explained by Michael, I'll drop this patch
from the queue and not apply it, OK?

Thanks!

 Signed-off-by: Feng Yang fy...@redhat.com
 ---
  client/tests/kvm/kvm_utils.py |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
 
 diff --git a/client/tests/kvm/kvm_utils.py b/client/tests/kvm/kvm_utils.py
 index a51c857..526d38d 100644
 --- a/client/tests/kvm/kvm_utils.py
 +++ b/client/tests/kvm/kvm_utils.py
 @@ -733,7 +733,7 @@ def remote_login(client, host, port, username, password, 
 prompt, linesep=\n,
  elif client == telnet:
  cmd = telnet -l %s %s %s % (username, host, port)
  elif client == nc:
 -cmd = nc %s %s % (host, port)
 +cmd = nc %s %s -w %s % (host, port, timeout)
  else:
  logging.error(Unknown remote shell client: %s % client)
  return


--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [Autotest] [PATCH] KVM Test: add -w parameter in nc command in kvm_utils.py

2010-10-27 Thread Feng Yang

- Lucas Meneghel Rodrigues l...@redhat.com wrote:

 From: Lucas Meneghel Rodrigues l...@redhat.com
 To: Feng Yang fy...@redhat.com
 Cc: autot...@test.kernel.org, kvm@vger.kernel.org
 Sent: Thursday, October 28, 2010 4:26:17 AM GMT +08:00 Beijing / Chongqing / 
 Hong Kong / Urumqi
 Subject: Re: [Autotest] [PATCH] KVM Test: add -w parameter in nc command in 
 kvm_utils.py

 On Wed, 2010-10-20 at 14:55 +0800, Feng Yang wrote:
  If a connection and stdin are idle for more than timeout seconds,
  then the connection is silently closed. withou this paramter,
  nc will listen forever for a connection. This may cause our test
  hang. redmine issue:
  http://redmine.englab.nay.redhat.com/issues/show/6947
  Add -w parameter should fix this issue.
 
 Feng, for reasons already explained by Michael, I'll drop this patch
 from the queue and not apply it, OK?
Yes, please drop it.  Thanks!

 
 Thanks!
 
  Signed-off-by: Feng Yang fy...@redhat.com
  ---
   client/tests/kvm/kvm_utils.py |2 +-
   1 files changed, 1 insertions(+), 1 deletions(-)
  
  diff --git a/client/tests/kvm/kvm_utils.py
 b/client/tests/kvm/kvm_utils.py
  index a51c857..526d38d 100644
  --- a/client/tests/kvm/kvm_utils.py
  +++ b/client/tests/kvm/kvm_utils.py
  @@ -733,7 +733,7 @@ def remote_login(client, host, port, username,
 password, prompt, linesep=\n,
   elif client == telnet:
   cmd = telnet -l %s %s %s % (username, host, port)
   elif client == nc:
  -cmd = nc %s %s % (host, port)
  +cmd = nc %s %s -w %s % (host, port, timeout)
   else:
   logging.error(Unknown remote shell client: %s % client)
   return
 
 
 --
 To unsubscribe from this list: send the line unsubscribe kvm in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html