Re: [KVM-AUTOTEST PATCH] kvm_runtest_2.py: use environment filename specified by the 'env' parameter

2009-05-28 Thread Lucas Meneghel Rodrigues 
On Sun, 2009-05-24 at 18:46 +0300, Michael Goldish wrote:
> Do not use hardcoded environment filename 'env'. Instead use the value
> specified by the 'env' parameter. If unspecified, use 'env' as the filename.

Looks good to me!

> This is important for parallel execution; it may be necessary to use a 
> separate
> environment file for each process.
> 
> Signed-off-by: Michael Goldish 
> ---
>  client/tests/kvm_runtest_2/kvm_runtest_2.py |2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/client/tests/kvm_runtest_2/kvm_runtest_2.py 
> b/client/tests/kvm_runtest_2/kvm_runtest_2.py
> index fda7282..a69951b 100644
> --- a/client/tests/kvm_runtest_2/kvm_runtest_2.py
> +++ b/client/tests/kvm_runtest_2/kvm_runtest_2.py
> @@ -64,7 +64,7 @@ class kvm_runtest_2(test.test):
>  self.write_test_keyval({key: params[key]})
>  
>  # Open the environment file
> -env_filename = os.path.join(self.bindir, "env")
> +env_filename = os.path.join(self.bindir, params.get("env", "env"))
>  env = shelve.open(env_filename, writeback=True)
>  kvm_log.debug("Contents of environment: %s" % str(env))
>  
-- 
Lucas Meneghel Rodrigues
Software Engineer (QE)
Red Hat - Emerging Technologies

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [KVM-AUTOTEST PATCH] kvm_runtest_2.py: use environment filename specified by the 'env' parameter

2009-05-24 Thread sudhir kumar 
good one to be in.  thanks

On Sun, May 24, 2009 at 9:16 PM, Michael Goldish  wrote:
> Do not use hardcoded environment filename 'env'. Instead use the value
> specified by the 'env' parameter. If unspecified, use 'env' as the filename.
>
> This is important for parallel execution; it may be necessary to use a 
> separate
> environment file for each process.
>
> Signed-off-by: Michael Goldish 
> ---
>  client/tests/kvm_runtest_2/kvm_runtest_2.py |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/client/tests/kvm_runtest_2/kvm_runtest_2.py 
> b/client/tests/kvm_runtest_2/kvm_runtest_2.py
> index fda7282..a69951b 100644
> --- a/client/tests/kvm_runtest_2/kvm_runtest_2.py
> +++ b/client/tests/kvm_runtest_2/kvm_runtest_2.py
> @@ -64,7 +64,7 @@ class kvm_runtest_2(test.test):
>             self.write_test_keyval({key: params[key]})
>
>         # Open the environment file
> -        env_filename = os.path.join(self.bindir, "env")
> +        env_filename = os.path.join(self.bindir, params.get("env", "env"))
>         env = shelve.open(env_filename, writeback=True)
>         kvm_log.debug("Contents of environment: %s" % str(env))
>
> --
> 1.5.4.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>



-- 
Sudhir Kumar
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[KVM-AUTOTEST PATCH] kvm_runtest_2.py: use environment filename specified by the 'env' parameter

2009-05-24 Thread Michael Goldish 
Do not use hardcoded environment filename 'env'. Instead use the value
specified by the 'env' parameter. If unspecified, use 'env' as the filename.

This is important for parallel execution; it may be necessary to use a separate
environment file for each process.

Signed-off-by: Michael Goldish 
---
 client/tests/kvm_runtest_2/kvm_runtest_2.py |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/client/tests/kvm_runtest_2/kvm_runtest_2.py 
b/client/tests/kvm_runtest_2/kvm_runtest_2.py
index fda7282..a69951b 100644
--- a/client/tests/kvm_runtest_2/kvm_runtest_2.py
+++ b/client/tests/kvm_runtest_2/kvm_runtest_2.py
@@ -64,7 +64,7 @@ class kvm_runtest_2(test.test):
 self.write_test_keyval({key: params[key]})
 
 # Open the environment file
-env_filename = os.path.join(self.bindir, "env")
+env_filename = os.path.join(self.bindir, params.get("env", "env"))
 env = shelve.open(env_filename, writeback=True)
 kvm_log.debug("Contents of environment: %s" % str(env))
 
-- 
1.5.4.1

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html