Re: [Qemu-devel] [PATCH 0/5] vhost-scsi: Add support for host virtualized target
Hi, Nicholas Have this serial been merged to qemu 1.4? If not, I am rebasing it to upstream, hope no one else is working on that. From: Nicholas Bellinger n...@linux-iscsi.org Hello Anthony Co, This is the fourth installment to add host virtualized target support for the mainline tcm_vhost fabric driver using Linux v3.6-rc into QEMU 1.3.0-rc. The series is available directly from the following git branch: git://git.kernel.org/pub/scm/virt/kvm/nab/qemu-kvm.git vhost-scsi-for-1.3 Note the code is cut against yesterday's QEMU head, and dispite the name of the tree is based upon mainline qemu.org git code + has thus far been running overnight with 100K IOPs small block 4k workloads using v3.6-rc2+ based target code with RAMDISK_DR backstores. Other than some minor fuzz between jumping from QEMU 1.2.0 - 1.2.50, this series is functionally identical to what's been posted for vhost-scsi RFC-v3 to qemu-devel. Please consider applying these patches for an initial vhost-scsi merge into QEMU 1.3.0-rc code, or let us know what else you'd like to see addressed for this series to in order to merge. Thank you! --nab Nicholas Bellinger (2): monitor: Rename+move net_handle_fd_param - monitor_handle_fd_param virtio-scsi: Set max_target=0 during vhost-scsi operation Stefan Hajnoczi (3): vhost: Pass device path to vhost_dev_init() vhost-scsi: add -vhost-scsi host device for use with tcm-vhost virtio-scsi: Add start/stop functionality for vhost-scsi configure| 10 +++ hw/Makefile.objs |1 + hw/qdev-properties.c | 41 +++ hw/vhost-scsi.c | 190 ++ hw/vhost-scsi.h | 62 hw/vhost.c |5 +- hw/vhost.h |3 +- hw/vhost_net.c |2 +- hw/virtio-pci.c |2 + hw/virtio-scsi.c | 55 ++- hw/virtio-scsi.h |1 + monitor.c| 18 + monitor.h|1 + net.c| 18 - net.h|2 - net/socket.c |2 +- net/tap.c|4 +- qemu-common.h|1 + qemu-config.c| 19 + qemu-options.hx |4 + vl.c | 18 + 21 files changed, 431 insertions(+), 28 deletions(-) create mode 100644 hw/vhost-scsi.c create mode 100644 hw/vhost-scsi.h -- Best Regards Wenchao Xia -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Qemu-devel] [PATCH 0/5] vhost-scsi: Add support for host virtualized target
Hello Wenchao,
On Tue, 2013-04-02 at 11:28 +0800, Wenchao Xia wrote:
Hi, Nicholas
Have this serial been merged to qemu 1.4?
Not just yet. Asias, MST, Paolo and myself have been working recently
on the series for qemu 1.4.
If not, I am rebasing it to
upstream, hope no one else is working on that.
The latest PATCH-v2 for vhost-scsi-pci against upstream qemu commit
dcadaa9b (from March 25th) is here:
http://www.spinics.net/lists/target-devel/msg04263.html
Note that you'll need this small work-around patch to avoid a bug that
we're currently tracking down:
http://www.spinics.net/lists/target-devel/msg04122.html
Also, you'll need a recent SeaBios build with the following commits:
commit 5a7730db57ab0715223421e65b54fb50d6fefe5c
Author: Asias He as...@redhat.com
Date: Fri Mar 15 09:45:15 2013 +0800
virtio-scsi: Set _DRIVER_OK flag before scsi target scanning
commit b44a7be17bdd270ea029a8e2ec0c2e80c6cd0444
Author: Asias He as...@redhat.com
Date: Fri Mar 15 09:45:16 2013 +0800
virtio-scsi: Pack struct virtio_scsi_{req_cmd,resp_cmd}
I'll be rebasing to qemu HEAD over the next few days and posting a
PATCH-v3, and would be happy to include you in the CC to follow along.
Thanks!
--nab
From: Nicholas Bellinger n...@linux-iscsi.org
Hello Anthony Co,
This is the fourth installment to add host virtualized target support for
the mainline tcm_vhost fabric driver using Linux v3.6-rc into QEMU 1.3.0-rc.
The series is available directly from the following git branch:
git://git.kernel.org/pub/scm/virt/kvm/nab/qemu-kvm.git
vhost-scsi-for-1.3
Note the code is cut against yesterday's QEMU head, and dispite the name
of the tree is based upon mainline qemu.org git code + has thus far been
running overnight with 100K IOPs small block 4k workloads using v3.6-rc2+
based target code with RAMDISK_DR backstores.
Other than some minor fuzz between jumping from QEMU 1.2.0 - 1.2.50, this
series is functionally identical to what's been posted for vhost-scsi RFC-v3
to qemu-devel.
Please consider applying these patches for an initial vhost-scsi merge into
QEMU 1.3.0-rc code, or let us know what else you'd like to see addressed for
this series to in order to merge.
Thank you!
--nab
Nicholas Bellinger (2):
monitor: Rename+move net_handle_fd_param - monitor_handle_fd_param
virtio-scsi: Set max_target=0 during vhost-scsi operation
Stefan Hajnoczi (3):
vhost: Pass device path to vhost_dev_init()
vhost-scsi: add -vhost-scsi host device for use with tcm-vhost
virtio-scsi: Add start/stop functionality for vhost-scsi
configure| 10 +++
hw/Makefile.objs |1 +
hw/qdev-properties.c | 41 +++
hw/vhost-scsi.c | 190
++
hw/vhost-scsi.h | 62
hw/vhost.c |5 +-
hw/vhost.h |3 +-
hw/vhost_net.c |2 +-
hw/virtio-pci.c |2 +
hw/virtio-scsi.c | 55 ++-
hw/virtio-scsi.h |1 +
monitor.c| 18 +
monitor.h|1 +
net.c| 18 -
net.h|2 -
net/socket.c |2 +-
net/tap.c|4 +-
qemu-common.h|1 +
qemu-config.c| 19 +
qemu-options.hx |4 +
vl.c | 18 +
21 files changed, 431 insertions(+), 28 deletions(-)
create mode 100644 hw/vhost-scsi.c
create mode 100644 hw/vhost-scsi.h
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] vhost-scsi: Add support for host virtualized target
Hi MST, Paolo Co, On Mon, 2013-01-28 at 15:39 +0200, Michael S. Tsirkin wrote: On Mon, Jan 28, 2013 at 02:33:44PM +0100, Paolo Bonzini wrote: Il 28/01/2013 14:36, Michael S. Tsirkin ha scritto: On Mon, Jan 28, 2013 at 02:29:23PM +0100, Paolo Bonzini wrote: Il 28/01/2013 14:11, Michael S. Tsirkin ha scritto: I asked for a standalone device because the configuration mechanism (configfs vs. command-line) and the feature set are completely different. Unlike virtio-net, it's not possible to switch one to the other at run time. Exactly the same applies to any other frontend option. For example if you have two qemu instances with different num_queues values you can not migrate one to the other. So in this sense it is not different from any other frontend option, right? Indeed, in this sense it is not. Actually in this case migrating one to the other could succeed, and make all disks disappear on the destination (because of the different configuration mechanism). That however could be overcome with vhost=on registering a migration blocker. Or better add a subsection if vhost is set: vhost=on to vhost=on can migrate, right? I think it's not yet supported by the kernel. You have no guarantee that I/O is quiescent at the time the VM starts on the destination. You'd need a ioctl to do the equivalent of bdrv_drain_all(). Once you have that, a subsection would do the job, yes. Paolo OK once that's in it would be easy to probe for. I won't really block the patch with the vhost=on/off frontend option if it is properly done (e.g. the QEMU SCSI bus should not be created for vhost=on) and minimally invasive to the non-vhost code. So what's the verdict here..? Shall I respin the vhost-scsi patches against qemu.git HEAD to make it in before Friday's cutoff for v1.4..? Also, I'm not exactly sure what's involved with a vhost=on/off frontend option discussed above, so if you or Paolo could handle this bit it would be very helpful. :) --nab -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] vhost-scsi: Add support for host virtualized target
Also, I'm not exactly sure what's involved with a vhost=on/off frontend option discussed above, so if you or Paolo could handle this bit it would be very helpful. I can do the forward port, if you take care of testing we have enough time to make it into 1.4. Paolo -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] vhost-scsi: Add support for host virtualized target
On Tue, 2013-01-29 at 16:03 -0500, Paolo Bonzini wrote: Also, I'm not exactly sure what's involved with a vhost=on/off frontend option discussed above, so if you or Paolo could handle this bit it would be very helpful. I can do the forward port, if you take care of testing we have enough time to make it into 1.4. Perfect, thanks for the extra help here. ;) I'll look for your forward-port of vhost-scsi, and test as soon as it's available. --nab -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] vhost-scsi: Add support for host virtualized target
Il 21/01/2013 09:50, Michael S. Tsirkin ha scritto: Unfortunately, I've not been able to get back to the conversion requested by Paolo for a standalone vhost-scsi PCI device. It doesn't have to be a standalone device. A vhost=on frontend option is also OK I think. Paolo, any objections? Sorry, I missed this message. I asked for a standalone device because the configuration mechanism (configfs vs. command-line) and the feature set are completely different. Unlike virtio-net, it's not possible to switch one to the other at run time. Paolo -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] vhost-scsi: Add support for host virtualized target
On Mon, Jan 28, 2013 at 02:01:41PM +0100, Paolo Bonzini wrote: Il 21/01/2013 09:50, Michael S. Tsirkin ha scritto: Unfortunately, I've not been able to get back to the conversion requested by Paolo for a standalone vhost-scsi PCI device. It doesn't have to be a standalone device. A vhost=on frontend option is also OK I think. Paolo, any objections? Sorry, I missed this message. I asked for a standalone device because the configuration mechanism (configfs vs. command-line) and the feature set are completely different. Unlike virtio-net, it's not possible to switch one to the other at run time. Paolo Exactly the same applies to any other frontend option. For example if you have two qemu instances with different num_queues values you can not migrate one to the other. So in this sense it is not different from any other frontend option, right? -- MST -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] vhost-scsi: Add support for host virtualized target
Il 28/01/2013 14:11, Michael S. Tsirkin ha scritto: I asked for a standalone device because the configuration mechanism (configfs vs. command-line) and the feature set are completely different. Unlike virtio-net, it's not possible to switch one to the other at run time. Exactly the same applies to any other frontend option. For example if you have two qemu instances with different num_queues values you can not migrate one to the other. So in this sense it is not different from any other frontend option, right? Indeed, in this sense it is not. Actually in this case migrating one to the other could succeed, and make all disks disappear on the destination (because of the different configuration mechanism). That however could be overcome with vhost=on registering a migration blocker. I won't really block the patch with the vhost=on/off frontend option if it is properly done (e.g. the QEMU SCSI bus should not be created for vhost=on) and minimally invasive to the non-vhost code. Paolo -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] vhost-scsi: Add support for host virtualized target
On Mon, Jan 28, 2013 at 02:29:23PM +0100, Paolo Bonzini wrote: Il 28/01/2013 14:11, Michael S. Tsirkin ha scritto: I asked for a standalone device because the configuration mechanism (configfs vs. command-line) and the feature set are completely different. Unlike virtio-net, it's not possible to switch one to the other at run time. Exactly the same applies to any other frontend option. For example if you have two qemu instances with different num_queues values you can not migrate one to the other. So in this sense it is not different from any other frontend option, right? Indeed, in this sense it is not. Actually in this case migrating one to the other could succeed, and make all disks disappear on the destination (because of the different configuration mechanism). That however could be overcome with vhost=on registering a migration blocker. Or better add a subsection if vhost is set: vhost=on to vhost=on can migrate, right? I won't really block the patch with the vhost=on/off frontend option if it is properly done (e.g. the QEMU SCSI bus should not be created for vhost=on) and minimally invasive to the non-vhost code. Paolo -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] vhost-scsi: Add support for host virtualized target
Il 28/01/2013 14:36, Michael S. Tsirkin ha scritto: On Mon, Jan 28, 2013 at 02:29:23PM +0100, Paolo Bonzini wrote: Il 28/01/2013 14:11, Michael S. Tsirkin ha scritto: I asked for a standalone device because the configuration mechanism (configfs vs. command-line) and the feature set are completely different. Unlike virtio-net, it's not possible to switch one to the other at run time. Exactly the same applies to any other frontend option. For example if you have two qemu instances with different num_queues values you can not migrate one to the other. So in this sense it is not different from any other frontend option, right? Indeed, in this sense it is not. Actually in this case migrating one to the other could succeed, and make all disks disappear on the destination (because of the different configuration mechanism). That however could be overcome with vhost=on registering a migration blocker. Or better add a subsection if vhost is set: vhost=on to vhost=on can migrate, right? I think it's not yet supported by the kernel. You have no guarantee that I/O is quiescent at the time the VM starts on the destination. You'd need a ioctl to do the equivalent of bdrv_drain_all(). Once you have that, a subsection would do the job, yes. Paolo I won't really block the patch with the vhost=on/off frontend option if it is properly done (e.g. the QEMU SCSI bus should not be created for vhost=on) and minimally invasive to the non-vhost code. Paolo -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] vhost-scsi: Add support for host virtualized target
On Mon, Jan 28, 2013 at 02:33:44PM +0100, Paolo Bonzini wrote: Il 28/01/2013 14:36, Michael S. Tsirkin ha scritto: On Mon, Jan 28, 2013 at 02:29:23PM +0100, Paolo Bonzini wrote: Il 28/01/2013 14:11, Michael S. Tsirkin ha scritto: I asked for a standalone device because the configuration mechanism (configfs vs. command-line) and the feature set are completely different. Unlike virtio-net, it's not possible to switch one to the other at run time. Exactly the same applies to any other frontend option. For example if you have two qemu instances with different num_queues values you can not migrate one to the other. So in this sense it is not different from any other frontend option, right? Indeed, in this sense it is not. Actually in this case migrating one to the other could succeed, and make all disks disappear on the destination (because of the different configuration mechanism). That however could be overcome with vhost=on registering a migration blocker. Or better add a subsection if vhost is set: vhost=on to vhost=on can migrate, right? I think it's not yet supported by the kernel. You have no guarantee that I/O is quiescent at the time the VM starts on the destination. You'd need a ioctl to do the equivalent of bdrv_drain_all(). Once you have that, a subsection would do the job, yes. Paolo OK once that's in it would be easy to probe for. I won't really block the patch with the vhost=on/off frontend option if it is properly done (e.g. the QEMU SCSI bus should not be created for vhost=on) and minimally invasive to the non-vhost code. Paolo -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] vhost-scsi: Add support for host virtualized target
On Thu, Jan 17, 2013 at 01:07:21PM -0800, Nicholas A. Bellinger wrote: Hi MST Co, On Thu, 2013-01-17 at 18:43 +0200, Michael S. Tsirkin wrote: On Fri, Sep 07, 2012 at 06:48:14AM +, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org Hello Anthony Co, This is the fourth installment to add host virtualized target support for the mainline tcm_vhost fabric driver using Linux v3.6-rc into QEMU 1.3.0-rc. The series is available directly from the following git branch: git://git.kernel.org/pub/scm/virt/kvm/nab/qemu-kvm.git vhost-scsi-for-1.3 Note the code is cut against yesterday's QEMU head, and dispite the name of the tree is based upon mainline qemu.org git code + has thus far been running overnight with 100K IOPs small block 4k workloads using v3.6-rc2+ based target code with RAMDISK_DR backstores. Other than some minor fuzz between jumping from QEMU 1.2.0 - 1.2.50, this series is functionally identical to what's been posted for vhost-scsi RFC-v3 to qemu-devel. Please consider applying these patches for an initial vhost-scsi merge into QEMU 1.3.0-rc code, or let us know what else you'd like to see addressed for this series to in order to merge. Thank you! --nab OK what's the status here? We missed 1.3 but let's try not to miss 1.4? Unfortunately, I've not been able to get back to the conversion requested by Paolo for a standalone vhost-scsi PCI device. It doesn't have to be a standalone device. A vhost=on frontend option is also OK I think. Paolo, any objections? At this point my hands are still full with iSER-target for-3.9 kernel code over the next weeks. What's the v1.4 feature cut-off looking like at this point..? --nab Not sure but soon. -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] vhost-scsi: Add support for host virtualized target
Nicholas A. Bellinger n...@linux-iscsi.org writes: Hi MST Co, On Thu, 2013-01-17 at 18:43 +0200, Michael S. Tsirkin wrote: On Fri, Sep 07, 2012 at 06:48:14AM +, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org Hello Anthony Co, This is the fourth installment to add host virtualized target support for the mainline tcm_vhost fabric driver using Linux v3.6-rc into QEMU 1.3.0-rc. The series is available directly from the following git branch: git://git.kernel.org/pub/scm/virt/kvm/nab/qemu-kvm.git vhost-scsi-for-1.3 Note the code is cut against yesterday's QEMU head, and dispite the name of the tree is based upon mainline qemu.org git code + has thus far been running overnight with 100K IOPs small block 4k workloads using v3.6-rc2+ based target code with RAMDISK_DR backstores. Other than some minor fuzz between jumping from QEMU 1.2.0 - 1.2.50, this series is functionally identical to what's been posted for vhost-scsi RFC-v3 to qemu-devel. Please consider applying these patches for an initial vhost-scsi merge into QEMU 1.3.0-rc code, or let us know what else you'd like to see addressed for this series to in order to merge. Thank you! --nab OK what's the status here? We missed 1.3 but let's try not to miss 1.4? Unfortunately, I've not been able to get back to the conversion requested by Paolo for a standalone vhost-scsi PCI device. Is your git repo above up to date? Perhaps I can find someone to help out.. At this point my hands are still full with iSER-target for-3.9 kernel code over the next weeks. What's the v1.4 feature cut-off looking like at this point..? Hard freeze is on february 1st but 1.5 opens up again on the 15th. So the release windows shouldn't have a major impact on merging... Regards, Anthony Liguori --nab -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] vhost-scsi: Add support for host virtualized target
On Fri, Sep 07, 2012 at 06:48:14AM +, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org Hello Anthony Co, This is the fourth installment to add host virtualized target support for the mainline tcm_vhost fabric driver using Linux v3.6-rc into QEMU 1.3.0-rc. The series is available directly from the following git branch: git://git.kernel.org/pub/scm/virt/kvm/nab/qemu-kvm.git vhost-scsi-for-1.3 Note the code is cut against yesterday's QEMU head, and dispite the name of the tree is based upon mainline qemu.org git code + has thus far been running overnight with 100K IOPs small block 4k workloads using v3.6-rc2+ based target code with RAMDISK_DR backstores. Other than some minor fuzz between jumping from QEMU 1.2.0 - 1.2.50, this series is functionally identical to what's been posted for vhost-scsi RFC-v3 to qemu-devel. Please consider applying these patches for an initial vhost-scsi merge into QEMU 1.3.0-rc code, or let us know what else you'd like to see addressed for this series to in order to merge. Thank you! --nab OK what's the status here? We missed 1.3 but let's try not to miss 1.4? Nicholas Bellinger (2): monitor: Rename+move net_handle_fd_param - monitor_handle_fd_param virtio-scsi: Set max_target=0 during vhost-scsi operation Stefan Hajnoczi (3): vhost: Pass device path to vhost_dev_init() vhost-scsi: add -vhost-scsi host device for use with tcm-vhost virtio-scsi: Add start/stop functionality for vhost-scsi configure| 10 +++ hw/Makefile.objs |1 + hw/qdev-properties.c | 41 +++ hw/vhost-scsi.c | 190 ++ hw/vhost-scsi.h | 62 hw/vhost.c |5 +- hw/vhost.h |3 +- hw/vhost_net.c |2 +- hw/virtio-pci.c |2 + hw/virtio-scsi.c | 55 ++- hw/virtio-scsi.h |1 + monitor.c| 18 + monitor.h|1 + net.c| 18 - net.h|2 - net/socket.c |2 +- net/tap.c|4 +- qemu-common.h|1 + qemu-config.c| 19 + qemu-options.hx |4 + vl.c | 18 + 21 files changed, 431 insertions(+), 28 deletions(-) create mode 100644 hw/vhost-scsi.c create mode 100644 hw/vhost-scsi.h -- 1.7.2.5 ___ Virtualization mailing list virtualizat...@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] vhost-scsi: Add support for host virtualized target
Hi MST Co, On Thu, 2013-01-17 at 18:43 +0200, Michael S. Tsirkin wrote: On Fri, Sep 07, 2012 at 06:48:14AM +, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org Hello Anthony Co, This is the fourth installment to add host virtualized target support for the mainline tcm_vhost fabric driver using Linux v3.6-rc into QEMU 1.3.0-rc. The series is available directly from the following git branch: git://git.kernel.org/pub/scm/virt/kvm/nab/qemu-kvm.git vhost-scsi-for-1.3 Note the code is cut against yesterday's QEMU head, and dispite the name of the tree is based upon mainline qemu.org git code + has thus far been running overnight with 100K IOPs small block 4k workloads using v3.6-rc2+ based target code with RAMDISK_DR backstores. Other than some minor fuzz between jumping from QEMU 1.2.0 - 1.2.50, this series is functionally identical to what's been posted for vhost-scsi RFC-v3 to qemu-devel. Please consider applying these patches for an initial vhost-scsi merge into QEMU 1.3.0-rc code, or let us know what else you'd like to see addressed for this series to in order to merge. Thank you! --nab OK what's the status here? We missed 1.3 but let's try not to miss 1.4? Unfortunately, I've not been able to get back to the conversion requested by Paolo for a standalone vhost-scsi PCI device. At this point my hands are still full with iSER-target for-3.9 kernel code over the next weeks. What's the v1.4 feature cut-off looking like at this point..? --nab -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] vhost-scsi: Add support for host virtualized target
Il 13/09/2012 22:12, Nicholas A. Bellinger ha scritto: Are you still seeing the performance degradation discussed in the thread vhost-scsi port to v1.1.0 + MSI-X performance regression So the performance regression reported here with QEMU v1.2-rc + virtio-scsi ended up being related to virtio interrupts being delivered across multiple CPUs. After explicitly setting the IRQ affinity of the virtio0-request MSI-X vector to a specific CPU, the small block (4k) mixed random I/O performance jumped back up to the expected ~100K IOPs for a single LUN. Have you tried setting rq_affinity to 2? Benchmarking this against multiqueue virtio-scsi is on my todo list. Paolo FYI, I just tried this again with the most recent QEMU v1.2.50 (v1.3-rc) code, and both cases appear to be performing as expected once again regardless of the explicit IRQ affinity setting. -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] vhost-scsi: Add support for host virtualized target
On Tue, 2012-09-11 at 12:36 +0800, Asias He wrote: Hello Nicholas, Hello Asias! On 09/07/2012 02:48 PM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org Hello Anthony Co, This is the fourth installment to add host virtualized target support for the mainline tcm_vhost fabric driver using Linux v3.6-rc into QEMU 1.3.0-rc. The series is available directly from the following git branch: git://git.kernel.org/pub/scm/virt/kvm/nab/qemu-kvm.git vhost-scsi-for-1.3 Note the code is cut against yesterday's QEMU head, and dispite the name of the tree is based upon mainline qemu.org git code + has thus far been running overnight with 100K IOPs small block 4k workloads using v3.6-rc2+ based target code with RAMDISK_DR backstores. Are you still seeing the performance degradation discussed in the thread vhost-scsi port to v1.1.0 + MSI-X performance regression So the performance regression reported here with QEMU v1.2-rc + virtio-scsi ended up being related to virtio interrupts being delivered across multiple CPUs. After explicitly setting the IRQ affinity of the virtio0-request MSI-X vector to a specific CPU, the small block (4k) mixed random I/O performance jumped back up to the expected ~100K IOPs for a single LUN. FYI, I just tried this again with the most recent QEMU v1.2.50 (v1.3-rc) code, and both cases appear to be performing as expected once again regardless of the explicit IRQ affinity setting. --nab -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] vhost-scsi: Add support for host virtualized target
Hello Nicholas, On 09/07/2012 02:48 PM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org Hello Anthony Co, This is the fourth installment to add host virtualized target support for the mainline tcm_vhost fabric driver using Linux v3.6-rc into QEMU 1.3.0-rc. The series is available directly from the following git branch: git://git.kernel.org/pub/scm/virt/kvm/nab/qemu-kvm.git vhost-scsi-for-1.3 Note the code is cut against yesterday's QEMU head, and dispite the name of the tree is based upon mainline qemu.org git code + has thus far been running overnight with 100K IOPs small block 4k workloads using v3.6-rc2+ based target code with RAMDISK_DR backstores. Are you still seeing the performance degradation discussed in the thread vhost-scsi port to v1.1.0 + MSI-X performance regression ? Other than some minor fuzz between jumping from QEMU 1.2.0 - 1.2.50, this series is functionally identical to what's been posted for vhost-scsi RFC-v3 to qemu-devel. Please consider applying these patches for an initial vhost-scsi merge into QEMU 1.3.0-rc code, or let us know what else you'd like to see addressed for this series to in order to merge. Thank you! --nab Nicholas Bellinger (2): monitor: Rename+move net_handle_fd_param - monitor_handle_fd_param virtio-scsi: Set max_target=0 during vhost-scsi operation Stefan Hajnoczi (3): vhost: Pass device path to vhost_dev_init() vhost-scsi: add -vhost-scsi host device for use with tcm-vhost virtio-scsi: Add start/stop functionality for vhost-scsi configure| 10 +++ hw/Makefile.objs |1 + hw/qdev-properties.c | 41 +++ hw/vhost-scsi.c | 190 ++ hw/vhost-scsi.h | 62 hw/vhost.c |5 +- hw/vhost.h |3 +- hw/vhost_net.c |2 +- hw/virtio-pci.c |2 + hw/virtio-scsi.c | 55 ++- hw/virtio-scsi.h |1 + monitor.c| 18 + monitor.h|1 + net.c| 18 - net.h|2 - net/socket.c |2 +- net/tap.c|4 +- qemu-common.h|1 + qemu-config.c| 19 + qemu-options.hx |4 + vl.c | 18 + 21 files changed, 431 insertions(+), 28 deletions(-) create mode 100644 hw/vhost-scsi.c create mode 100644 hw/vhost-scsi.h -- Asias -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/5] vhost-scsi: Add support for host virtualized target
From: Nicholas Bellinger n...@linux-iscsi.org Hello Anthony Co, This is the fourth installment to add host virtualized target support for the mainline tcm_vhost fabric driver using Linux v3.6-rc into QEMU 1.3.0-rc. The series is available directly from the following git branch: git://git.kernel.org/pub/scm/virt/kvm/nab/qemu-kvm.git vhost-scsi-for-1.3 Note the code is cut against yesterday's QEMU head, and dispite the name of the tree is based upon mainline qemu.org git code + has thus far been running overnight with 100K IOPs small block 4k workloads using v3.6-rc2+ based target code with RAMDISK_DR backstores. Other than some minor fuzz between jumping from QEMU 1.2.0 - 1.2.50, this series is functionally identical to what's been posted for vhost-scsi RFC-v3 to qemu-devel. Please consider applying these patches for an initial vhost-scsi merge into QEMU 1.3.0-rc code, or let us know what else you'd like to see addressed for this series to in order to merge. Thank you! --nab Nicholas Bellinger (2): monitor: Rename+move net_handle_fd_param - monitor_handle_fd_param virtio-scsi: Set max_target=0 during vhost-scsi operation Stefan Hajnoczi (3): vhost: Pass device path to vhost_dev_init() vhost-scsi: add -vhost-scsi host device for use with tcm-vhost virtio-scsi: Add start/stop functionality for vhost-scsi configure| 10 +++ hw/Makefile.objs |1 + hw/qdev-properties.c | 41 +++ hw/vhost-scsi.c | 190 ++ hw/vhost-scsi.h | 62 hw/vhost.c |5 +- hw/vhost.h |3 +- hw/vhost_net.c |2 +- hw/virtio-pci.c |2 + hw/virtio-scsi.c | 55 ++- hw/virtio-scsi.h |1 + monitor.c| 18 + monitor.h|1 + net.c| 18 - net.h|2 - net/socket.c |2 +- net/tap.c|4 +- qemu-common.h|1 + qemu-config.c| 19 + qemu-options.hx |4 + vl.c | 18 + 21 files changed, 431 insertions(+), 28 deletions(-) create mode 100644 hw/vhost-scsi.c create mode 100644 hw/vhost-scsi.h -- 1.7.2.5 -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
