[PATCH 0/5] virtio-scsi: create a separate workqueue
patch 1-3,5 are some cleanups. patch 4: create a separate work queue for virtio-scsi to improve the performance, I tested with tmpfs backed disk, the config file is like below, [global] bsrange=4k-64k ioengine=libaio direct=1 iodepth=4 loops=10 size=64M Before: Disk stats (read/write): sda: ios=6547/5275, merge=37/39, ticks=3144/2645, in_queue=5780, util=81.62% sdb: ios=6542/5277, merge=54/59, ticks=3234/3143, in_queue=6364, util=84.50% sdc: ios=6532/5244, merge=65/62, ticks=3440/3076, in_queue=6505, util=86.83% After: Disk stats (read/write): sda: ios=6349/5318, merge=77/89, ticks=4820/3169, in_queue=7991, util=90.62% sdb: ios=6364/5358, merge=39/53, ticks=3810/2816, in_queue=6615, util=84.63% sdc: ios=6458/5352, merge=74/47, ticks=4425/3048, in_queue=7459, util=88.41% Wanlong Gao (5): virtio-scsi: remove the useless assignment virtio-scsi: remove the needless variable gfp_mask virtio-scsi: use pr_err instead of printk virtio-scsi: create a separate work queue for virtio-scsi virtio-scsi: tidy up the goto label in init() Cc: James E.J. Bottomley jbottom...@parallels.com Cc: Paolo Bonzini pbonz...@redhat.com Cc: Rusty Russell ru...@rustcorp.com.au Cc: linux-s...@vger.kernel.org Cc: kvm@vger.kernel.org drivers/scsi/virtio_scsi.c | 43 +++ 1 file changed, 23 insertions(+), 20 deletions(-) -- 1.8.0 -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] virtio-scsi: create a separate workqueue
On Wed, Nov 7, 2012 at 6:18 PM, Wanlong Gao gaowanl...@cn.fujitsu.com wrote: patch 1-3,5 are some cleanups. patch 4: create a separate work queue for virtio-scsi to improve the performance, I tested with tmpfs backed disk, the config file is like below, [global] bsrange=4k-64k ioengine=libaio direct=1 iodepth=4 loops=10 size=64M Before: Disk stats (read/write): sda: ios=6547/5275, merge=37/39, ticks=3144/2645, in_queue=5780, util=81.62% sdb: ios=6542/5277, merge=54/59, ticks=3234/3143, in_queue=6364, util=84.50% sdc: ios=6532/5244, merge=65/62, ticks=3440/3076, in_queue=6505, util=86.83% The result is about the disk stat. Can you please post the iops and the bw instead? After: Disk stats (read/write): sda: ios=6349/5318, merge=77/89, ticks=4820/3169, in_queue=7991, util=90.62% sdb: ios=6364/5358, merge=39/53, ticks=3810/2816, in_queue=6615, util=84.63% sdc: ios=6458/5352, merge=74/47, ticks=4425/3048, in_queue=7459, util=88.41% Wanlong Gao (5): virtio-scsi: remove the useless assignment virtio-scsi: remove the needless variable gfp_mask virtio-scsi: use pr_err instead of printk virtio-scsi: create a separate work queue for virtio-scsi virtio-scsi: tidy up the goto label in init() Cc: James E.J. Bottomley jbottom...@parallels.com Cc: Paolo Bonzini pbonz...@redhat.com Cc: Rusty Russell ru...@rustcorp.com.au Cc: linux-s...@vger.kernel.org Cc: kvm@vger.kernel.org drivers/scsi/virtio_scsi.c | 43 +++ 1 file changed, 23 insertions(+), 20 deletions(-) -- 1.8.0 -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Asias He -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] virtio-scsi: create a separate workqueue
On 11/07/2012 08:23 PM, Asias He wrote: On Wed, Nov 7, 2012 at 6:18 PM, Wanlong Gao gaowanl...@cn.fujitsu.com wrote: patch 1-3,5 are some cleanups. patch 4: create a separate work queue for virtio-scsi to improve the performance, I tested with tmpfs backed disk, the config file is like below, [global] bsrange=4k-64k ioengine=libaio direct=1 iodepth=4 loops=10 size=64M Before: Disk stats (read/write): sda: ios=6547/5275, merge=37/39, ticks=3144/2645, in_queue=5780, util=81.62% sdb: ios=6542/5277, merge=54/59, ticks=3234/3143, in_queue=6364, util=84.50% sdc: ios=6532/5244, merge=65/62, ticks=3440/3076, in_queue=6505, util=86.83% The result is about the disk stat. Can you please post the iops and the bw instead? Sure, before: write: io=589788KB, bw=122211KB/s, iops=3584 , runt= 4826msec bw (KB/s) : min=24208, max=116272, per=57.47%, avg=70236.40, stdev=35496.33 WRITE: io=589788KB, aggrb=122210KB/s, minb=122210KB/s, maxb=122210KB/s, mint=4826msec, maxt=4826msec after: write: io=589788KB, bw=124244KB/s, iops=3530 , runt= 4747msec bw (KB/s) : min=63496, max=117943, per=73.39%, avg=91184.20, stdev=20062.42 WRITE: io=589788KB, aggrb=124244KB/s, minb=124244KB/s, maxb=124244KB/s, mint=4747msec, maxt=4747msec Thanks, Wanlong Gao After: Disk stats (read/write): sda: ios=6349/5318, merge=77/89, ticks=4820/3169, in_queue=7991, util=90.62% sdb: ios=6364/5358, merge=39/53, ticks=3810/2816, in_queue=6615, util=84.63% sdc: ios=6458/5352, merge=74/47, ticks=4425/3048, in_queue=7459, util=88.41% Wanlong Gao (5): virtio-scsi: remove the useless assignment virtio-scsi: remove the needless variable gfp_mask virtio-scsi: use pr_err instead of printk virtio-scsi: create a separate work queue for virtio-scsi virtio-scsi: tidy up the goto label in init() Cc: James E.J. Bottomley jbottom...@parallels.com Cc: Paolo Bonzini pbonz...@redhat.com Cc: Rusty Russell ru...@rustcorp.com.au Cc: linux-s...@vger.kernel.org Cc: kvm@vger.kernel.org drivers/scsi/virtio_scsi.c | 43 +++ 1 file changed, 23 insertions(+), 20 deletions(-) -- 1.8.0 -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] virtio-scsi: create a separate workqueue
patch 1-3,5 are some cleanups. patch 4: create a separate work queue for virtio-scsi to improve the performance, I tested with tmpfs backed disk, the config file is like below, I think something else caused the improvement, because the code you touched (complete_event) shouldn't ever run during a normal benchmark. It's only used for hotplug/hot-unplug. Nevertheless, I'll queue the cleanup patches. Thanks for those. Paolo [global] bsrange=4k-64k ioengine=libaio direct=1 iodepth=4 loops=10 size=64M Before: Disk stats (read/write): sda: ios=6547/5275, merge=37/39, ticks=3144/2645, in_queue=5780, util=81.62% sdb: ios=6542/5277, merge=54/59, ticks=3234/3143, in_queue=6364, util=84.50% sdc: ios=6532/5244, merge=65/62, ticks=3440/3076, in_queue=6505, util=86.83% After: Disk stats (read/write): sda: ios=6349/5318, merge=77/89, ticks=4820/3169, in_queue=7991, util=90.62% sdb: ios=6364/5358, merge=39/53, ticks=3810/2816, in_queue=6615, util=84.63% sdc: ios=6458/5352, merge=74/47, ticks=4425/3048, in_queue=7459, util=88.41% Wanlong Gao (5): virtio-scsi: remove the useless assignment virtio-scsi: remove the needless variable gfp_mask virtio-scsi: use pr_err instead of printk virtio-scsi: create a separate work queue for virtio-scsi virtio-scsi: tidy up the goto label in init() Cc: James E.J. Bottomley jbottom...@parallels.com Cc: Paolo Bonzini pbonz...@redhat.com Cc: Rusty Russell ru...@rustcorp.com.au Cc: linux-s...@vger.kernel.org Cc: kvm@vger.kernel.org drivers/scsi/virtio_scsi.c | 43 +++ 1 file changed, 23 insertions(+), 20 deletions(-) -- 1.8.0 -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] virtio-scsi: create a separate workqueue
On 11/08/2012 06:12 AM, Paolo Bonzini wrote: patch 1-3,5 are some cleanups. patch 4: create a separate work queue for virtio-scsi to improve the performance, I tested with tmpfs backed disk, the config file is like below, I think something else caused the improvement, because the code you touched (complete_event) shouldn't ever run during a normal benchmark. It's only used for hotplug/hot-unplug. Nevertheless, I'll queue the cleanup patches. Thanks for those. Oops, got it, I will investigate more. Thank you for teaching me. Regards, Wanlong Gao -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
