[PATCH 0/7] KVM: irqfd generalization prepare patch set
The concept of an irqfd and interrupt routing are nothing particularly tied into the IOAPIC implementation. In fact, most of the code already is perfectly generic. This patch set decouples most bits of the existing irqchip and irqfd implementation to make it reusable for non-IOAPIC platforms, like the PPC MPIC. I also have a patch that implements working irqfd support on top of these, but that requires the in-kernel MPIC implementation to go upstream first, so I'm holding off on it until we settled everything there, so the concept certainly does work. Alex Alexander Graf (7): KVM: Add KVM_IRQCHIP_NUM_PINS in addition to KVM_IOAPIC_NUM_PINS KVM: Introduce __KVM_HAVE_IRQCHIP KVM: Remove kvm_get_intr_delivery_bitmask KVM: Move irq routing to generic code KVM: Extract generic irqchip logic into irqchip.c KVM: Move irq routing setup to irqchip.c KVM: Move irqfd resample cap handling to generic code arch/x86/include/asm/kvm_host.h |2 + arch/x86/include/uapi/asm/kvm.h |1 + arch/x86/kvm/Makefile |2 +- arch/x86/kvm/x86.c |1 - include/linux/kvm_host.h| 14 +-- include/trace/events/kvm.h | 12 ++- include/uapi/linux/kvm.h|2 +- virt/kvm/assigned-dev.c | 30 - virt/kvm/eventfd.c |6 +- virt/kvm/irq_comm.c | 193 +--- virt/kvm/irqchip.c | 237 +++ virt/kvm/kvm_main.c | 33 ++ 12 files changed, 297 insertions(+), 236 deletions(-) create mode 100644 virt/kvm/irqchip.c -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/7] KVM: irqfd generalization prepare patch set
On Tue, Apr 16, 2013 at 07:26:08PM +0200, Alexander Graf wrote: > The concept of an irqfd and interrupt routing are nothing particularly tied > into the IOAPIC implementation. In fact, most of the code already is perfectly > generic. > > This patch set decouples most bits of the existing irqchip and irqfd > implementation to make it reusable for non-IOAPIC platforms, like the PPC > MPIC. > > I also have a patch that implements working irqfd support on top of these, > but that requires the in-kernel MPIC implementation to go upstream first, so > I'm holding off on it until we settled everything there, so the concept > certainly does work. > > Alex Nothing to object to here really, this is just moving code around. And patches 3 and 4 are definitely cleanups. Assuming this helps PPC gain in-kernel irqchip support: Acked-by: Michael S. Tsirkin > Alexander Graf (7): > KVM: Add KVM_IRQCHIP_NUM_PINS in addition to KVM_IOAPIC_NUM_PINS > KVM: Introduce __KVM_HAVE_IRQCHIP > KVM: Remove kvm_get_intr_delivery_bitmask > KVM: Move irq routing to generic code > KVM: Extract generic irqchip logic into irqchip.c > KVM: Move irq routing setup to irqchip.c > KVM: Move irqfd resample cap handling to generic code > > arch/x86/include/asm/kvm_host.h |2 + > arch/x86/include/uapi/asm/kvm.h |1 + > arch/x86/kvm/Makefile |2 +- > arch/x86/kvm/x86.c |1 - > include/linux/kvm_host.h| 14 +-- > include/trace/events/kvm.h | 12 ++- > include/uapi/linux/kvm.h|2 +- > virt/kvm/assigned-dev.c | 30 - > virt/kvm/eventfd.c |6 +- > virt/kvm/irq_comm.c | 193 +--- > virt/kvm/irqchip.c | 237 > +++ > virt/kvm/kvm_main.c | 33 ++ > 12 files changed, 297 insertions(+), 236 deletions(-) > create mode 100644 virt/kvm/irqchip.c > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/7] KVM: irqfd generalization prepare patch set
On Tue, Apr 16, 2013 at 07:26:08PM +0200, Alexander Graf wrote: > The concept of an irqfd and interrupt routing are nothing particularly tied > into the IOAPIC implementation. In fact, most of the code already is perfectly > generic. > > This patch set decouples most bits of the existing irqchip and irqfd > implementation to make it reusable for non-IOAPIC platforms, like the PPC > MPIC. > > I also have a patch that implements working irqfd support on top of these, > but that requires the in-kernel MPIC implementation to go upstream first, so > I'm holding off on it until we settled everything there, so the concept > certainly does work. > > Alex > Nice cleanup, thanks! Should expect a new series with "ifdef kvm_irqchip" and ia64 compilation fixed. The fixes are minor enough for me to fix them while applying. > Alexander Graf (7): > KVM: Add KVM_IRQCHIP_NUM_PINS in addition to KVM_IOAPIC_NUM_PINS > KVM: Introduce __KVM_HAVE_IRQCHIP > KVM: Remove kvm_get_intr_delivery_bitmask > KVM: Move irq routing to generic code > KVM: Extract generic irqchip logic into irqchip.c > KVM: Move irq routing setup to irqchip.c > KVM: Move irqfd resample cap handling to generic code > > arch/x86/include/asm/kvm_host.h |2 + > arch/x86/include/uapi/asm/kvm.h |1 + > arch/x86/kvm/Makefile |2 +- > arch/x86/kvm/x86.c |1 - > include/linux/kvm_host.h| 14 +-- > include/trace/events/kvm.h | 12 ++- > include/uapi/linux/kvm.h|2 +- > virt/kvm/assigned-dev.c | 30 - > virt/kvm/eventfd.c |6 +- > virt/kvm/irq_comm.c | 193 +--- > virt/kvm/irqchip.c | 237 > +++ > virt/kvm/kvm_main.c | 33 ++ > 12 files changed, 297 insertions(+), 236 deletions(-) > create mode 100644 virt/kvm/irqchip.c -- Gleb. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/7] KVM: irqfd generalization prepare patch set
On Wed, Apr 24, 2013 at 01:20:31PM +0300, Gleb Natapov wrote: > On Tue, Apr 16, 2013 at 07:26:08PM +0200, Alexander Graf wrote: > > The concept of an irqfd and interrupt routing are nothing particularly tied > > into the IOAPIC implementation. In fact, most of the code already is > > perfectly > > generic. > > > > This patch set decouples most bits of the existing irqchip and irqfd > > implementation to make it reusable for non-IOAPIC platforms, like the PPC > > MPIC. > > > > I also have a patch that implements working irqfd support on top of these, > > but that requires the in-kernel MPIC implementation to go upstream first, so > > I'm holding off on it until we settled everything there, so the concept > > certainly does work. > > > > Alex > > > Nice cleanup, thanks! Should expect a new series with "ifdef > kvm_irqchip" and ia64 compilation fixed. The fixes are minor enough for > me to fix them while applying. > Actually the series does not apply any more and has to be rebased on top of the current queue. -- Gleb. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/7] KVM: irqfd generalization prepare patch set
On 25.04.2013, at 09:28, Gleb Natapov wrote: > On Wed, Apr 24, 2013 at 01:20:31PM +0300, Gleb Natapov wrote: >> On Tue, Apr 16, 2013 at 07:26:08PM +0200, Alexander Graf wrote: >>> The concept of an irqfd and interrupt routing are nothing particularly tied >>> into the IOAPIC implementation. In fact, most of the code already is >>> perfectly >>> generic. >>> >>> This patch set decouples most bits of the existing irqchip and irqfd >>> implementation to make it reusable for non-IOAPIC platforms, like the PPC >>> MPIC. >>> >>> I also have a patch that implements working irqfd support on top of these, >>> but that requires the in-kernel MPIC implementation to go upstream first, so >>> I'm holding off on it until we settled everything there, so the concept >>> certainly does work. >>> >>> Alex >>> >> Nice cleanup, thanks! Should expect a new series with "ifdef >> kvm_irqchip" and ia64 compilation fixed. The fixes are minor enough for >> me to fix them while applying. >> > Actually the series does not apply any more and has to be rebased on top of > the > current queue. Heh, we're already at v3: http://www.mail-archive.com/kvm-ppc@vger.kernel.org/msg06214.html Alex -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/7] KVM: irqfd generalization prepare patch set
On 21.04.2013, at 12:51, Michael S. Tsirkin wrote: > On Tue, Apr 16, 2013 at 07:26:08PM +0200, Alexander Graf wrote: >> The concept of an irqfd and interrupt routing are nothing particularly tied >> into the IOAPIC implementation. In fact, most of the code already is >> perfectly >> generic. >> >> This patch set decouples most bits of the existing irqchip and irqfd >> implementation to make it reusable for non-IOAPIC platforms, like the PPC >> MPIC. >> >> I also have a patch that implements working irqfd support on top of these, >> but that requires the in-kernel MPIC implementation to go upstream first, so >> I'm holding off on it until we settled everything there, so the concept >> certainly does work. >> >> Alex > > Nothing to object to here really, this is just > moving code around. > And patches 3 and 4 are definitely cleanups. > Assuming this helps PPC gain in-kernel irqchip support: > > Acked-by: Michael S. Tsirkin Could you please check the newer version of this patch set again and give your ack if it still holds? http://www.mail-archive.com/kvm-ppc@vger.kernel.org/msg06214.html Alex -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
