Re: [PATCH 0/8] KVM: Optimize MMU notifier's THP page invalidation -v4
On Mon, Jul 02, 2012 at 05:52:39PM +0900, Takuya Yoshikawa wrote: v3-v4: Resolved trace_kvm_age_page() issue -- patch 6,7 v2-v3: Fixed intersection calculations. -- patch 3, 8 Takuya Takuya Yoshikawa (8): KVM: MMU: Use __gfn_to_rmap() to clean up kvm_handle_hva() KVM: Introduce hva_to_gfn_memslot() for kvm_handle_hva() KVM: MMU: Make kvm_handle_hva() handle range of addresses KVM: Introduce kvm_unmap_hva_range() for kvm_mmu_notifier_invalidate_range_start() KVM: Separate rmap_pde from kvm_lpage_info-write_count KVM: MMU: Add memslot parameter to hva handlers KVM: MMU: Push trace_kvm_age_page() into kvm_age_rmapp() KVM: MMU: Avoid handling same rmap_pde in kvm_handle_hva_range() arch/powerpc/include/asm/kvm_host.h |2 + arch/powerpc/kvm/book3s_64_mmu_hv.c | 47 --- arch/x86/include/asm/kvm_host.h |3 +- arch/x86/kvm/mmu.c | 107 +++ arch/x86/kvm/x86.c | 11 include/linux/kvm_host.h|8 +++ virt/kvm/kvm_main.c |3 +- 7 files changed, 131 insertions(+), 50 deletions(-) From v2: The new test result was impressively good, see below, and THP page invalidation was more than 5 times faster on my x86 machine. Before: ... 19.852 us | __mmu_notifier_invalidate_range_start(); 28.033 us | __mmu_notifier_invalidate_range_start(); 19.066 us | __mmu_notifier_invalidate_range_start(); 44.715 us | __mmu_notifier_invalidate_range_start(); 31.613 us | __mmu_notifier_invalidate_range_start(); 20.659 us | __mmu_notifier_invalidate_range_start(); 19.979 us | __mmu_notifier_invalidate_range_start(); 20.416 us | __mmu_notifier_invalidate_range_start(); 20.632 us | __mmu_notifier_invalidate_range_start(); 22.316 us | __mmu_notifier_invalidate_range_start(); ... After: ... 4.089 us | __mmu_notifier_invalidate_range_start(); 4.096 us | __mmu_notifier_invalidate_range_start(); 3.560 us | __mmu_notifier_invalidate_range_start(); 3.376 us | __mmu_notifier_invalidate_range_start(); 3.772 us | __mmu_notifier_invalidate_range_start(); 3.353 us | __mmu_notifier_invalidate_range_start(); 3.332 us | __mmu_notifier_invalidate_range_start(); 3.332 us | __mmu_notifier_invalidate_range_start(); 3.332 us | __mmu_notifier_invalidate_range_start(); 3.337 us | __mmu_notifier_invalidate_range_start(); ... Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/8] KVM: Optimize MMU notifier's THP page invalidation -v4
On Mon, Jul 02, 2012 at 05:52:39PM +0900, Takuya Yoshikawa wrote: v3-v4: Resolved trace_kvm_age_page() issue -- patch 6,7 v2-v3: Fixed intersection calculations. -- patch 3, 8 Takuya Takuya Yoshikawa (8): KVM: MMU: Use __gfn_to_rmap() to clean up kvm_handle_hva() KVM: Introduce hva_to_gfn_memslot() for kvm_handle_hva() KVM: MMU: Make kvm_handle_hva() handle range of addresses KVM: Introduce kvm_unmap_hva_range() for kvm_mmu_notifier_invalidate_range_start() KVM: Separate rmap_pde from kvm_lpage_info-write_count KVM: MMU: Add memslot parameter to hva handlers KVM: MMU: Push trace_kvm_age_page() into kvm_age_rmapp() KVM: MMU: Avoid handling same rmap_pde in kvm_handle_hva_range() arch/powerpc/include/asm/kvm_host.h |2 + arch/powerpc/kvm/book3s_64_mmu_hv.c | 47 --- arch/x86/include/asm/kvm_host.h |3 +- arch/x86/kvm/mmu.c | 107 +++ arch/x86/kvm/x86.c | 11 include/linux/kvm_host.h|8 +++ virt/kvm/kvm_main.c |3 +- 7 files changed, 131 insertions(+), 50 deletions(-) From v2: The new test result was impressively good, see below, and THP page invalidation was more than 5 times faster on my x86 machine. Before: ... 19.852 us | __mmu_notifier_invalidate_range_start(); 28.033 us | __mmu_notifier_invalidate_range_start(); 19.066 us | __mmu_notifier_invalidate_range_start(); 44.715 us | __mmu_notifier_invalidate_range_start(); 31.613 us | __mmu_notifier_invalidate_range_start(); 20.659 us | __mmu_notifier_invalidate_range_start(); 19.979 us | __mmu_notifier_invalidate_range_start(); 20.416 us | __mmu_notifier_invalidate_range_start(); 20.632 us | __mmu_notifier_invalidate_range_start(); 22.316 us | __mmu_notifier_invalidate_range_start(); ... After: ... 4.089 us | __mmu_notifier_invalidate_range_start(); 4.096 us | __mmu_notifier_invalidate_range_start(); 3.560 us | __mmu_notifier_invalidate_range_start(); 3.376 us | __mmu_notifier_invalidate_range_start(); 3.772 us | __mmu_notifier_invalidate_range_start(); 3.353 us | __mmu_notifier_invalidate_range_start(); 3.332 us | __mmu_notifier_invalidate_range_start(); 3.332 us | __mmu_notifier_invalidate_range_start(); 3.332 us | __mmu_notifier_invalidate_range_start(); 3.337 us | __mmu_notifier_invalidate_range_start(); ... Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe kvm-ppc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/8] KVM: Optimize MMU notifier's THP page invalidation -v4
On Thu, 5 Jul 2012 10:08:07 -0300 Marcelo Tosatti mtosa...@redhat.com wrote: Neat. Andrea can you please ACK? ping -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/8] KVM: Optimize MMU notifier's THP page invalidation -v4
On Mon, Jul 02, 2012 at 05:52:39PM +0900, Takuya Yoshikawa wrote: v3-v4: Resolved trace_kvm_age_page() issue -- patch 6,7 v2-v3: Fixed intersection calculations. -- patch 3, 8 Takuya Takuya Yoshikawa (8): KVM: MMU: Use __gfn_to_rmap() to clean up kvm_handle_hva() KVM: Introduce hva_to_gfn_memslot() for kvm_handle_hva() KVM: MMU: Make kvm_handle_hva() handle range of addresses KVM: Introduce kvm_unmap_hva_range() for kvm_mmu_notifier_invalidate_range_start() KVM: Separate rmap_pde from kvm_lpage_info-write_count KVM: MMU: Add memslot parameter to hva handlers KVM: MMU: Push trace_kvm_age_page() into kvm_age_rmapp() KVM: MMU: Avoid handling same rmap_pde in kvm_handle_hva_range() arch/powerpc/include/asm/kvm_host.h |2 + arch/powerpc/kvm/book3s_64_mmu_hv.c | 47 --- arch/x86/include/asm/kvm_host.h |3 +- arch/x86/kvm/mmu.c | 107 +++ arch/x86/kvm/x86.c | 11 include/linux/kvm_host.h|8 +++ virt/kvm/kvm_main.c |3 +- 7 files changed, 131 insertions(+), 50 deletions(-) From v2: The new test result was impressively good, see below, and THP page invalidation was more than 5 times faster on my x86 machine. Before: ... 19.852 us | __mmu_notifier_invalidate_range_start(); 28.033 us | __mmu_notifier_invalidate_range_start(); 19.066 us | __mmu_notifier_invalidate_range_start(); 44.715 us | __mmu_notifier_invalidate_range_start(); 31.613 us | __mmu_notifier_invalidate_range_start(); 20.659 us | __mmu_notifier_invalidate_range_start(); 19.979 us | __mmu_notifier_invalidate_range_start(); 20.416 us | __mmu_notifier_invalidate_range_start(); 20.632 us | __mmu_notifier_invalidate_range_start(); 22.316 us | __mmu_notifier_invalidate_range_start(); ... After: ... 4.089 us | __mmu_notifier_invalidate_range_start(); 4.096 us | __mmu_notifier_invalidate_range_start(); 3.560 us | __mmu_notifier_invalidate_range_start(); 3.376 us | __mmu_notifier_invalidate_range_start(); 3.772 us | __mmu_notifier_invalidate_range_start(); 3.353 us | __mmu_notifier_invalidate_range_start(); 3.332 us | __mmu_notifier_invalidate_range_start(); 3.332 us | __mmu_notifier_invalidate_range_start(); 3.332 us | __mmu_notifier_invalidate_range_start(); 3.337 us | __mmu_notifier_invalidate_range_start(); ... Neat. Andrea can you please ACK? -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/8] KVM: Optimize MMU notifier's THP page invalidation -v4
On Mon, Jul 02, 2012 at 05:52:39PM +0900, Takuya Yoshikawa wrote: v3-v4: Resolved trace_kvm_age_page() issue -- patch 6,7 v2-v3: Fixed intersection calculations. -- patch 3, 8 Takuya Takuya Yoshikawa (8): KVM: MMU: Use __gfn_to_rmap() to clean up kvm_handle_hva() KVM: Introduce hva_to_gfn_memslot() for kvm_handle_hva() KVM: MMU: Make kvm_handle_hva() handle range of addresses KVM: Introduce kvm_unmap_hva_range() for kvm_mmu_notifier_invalidate_range_start() KVM: Separate rmap_pde from kvm_lpage_info-write_count KVM: MMU: Add memslot parameter to hva handlers KVM: MMU: Push trace_kvm_age_page() into kvm_age_rmapp() KVM: MMU: Avoid handling same rmap_pde in kvm_handle_hva_range() arch/powerpc/include/asm/kvm_host.h |2 + arch/powerpc/kvm/book3s_64_mmu_hv.c | 47 --- arch/x86/include/asm/kvm_host.h |3 +- arch/x86/kvm/mmu.c | 107 +++ arch/x86/kvm/x86.c | 11 include/linux/kvm_host.h|8 +++ virt/kvm/kvm_main.c |3 +- 7 files changed, 131 insertions(+), 50 deletions(-) From v2: The new test result was impressively good, see below, and THP page invalidation was more than 5 times faster on my x86 machine. Before: ... 19.852 us | __mmu_notifier_invalidate_range_start(); 28.033 us | __mmu_notifier_invalidate_range_start(); 19.066 us | __mmu_notifier_invalidate_range_start(); 44.715 us | __mmu_notifier_invalidate_range_start(); 31.613 us | __mmu_notifier_invalidate_range_start(); 20.659 us | __mmu_notifier_invalidate_range_start(); 19.979 us | __mmu_notifier_invalidate_range_start(); 20.416 us | __mmu_notifier_invalidate_range_start(); 20.632 us | __mmu_notifier_invalidate_range_start(); 22.316 us | __mmu_notifier_invalidate_range_start(); ... After: ... 4.089 us | __mmu_notifier_invalidate_range_start(); 4.096 us | __mmu_notifier_invalidate_range_start(); 3.560 us | __mmu_notifier_invalidate_range_start(); 3.376 us | __mmu_notifier_invalidate_range_start(); 3.772 us | __mmu_notifier_invalidate_range_start(); 3.353 us | __mmu_notifier_invalidate_range_start(); 3.332 us | __mmu_notifier_invalidate_range_start(); 3.332 us | __mmu_notifier_invalidate_range_start(); 3.332 us | __mmu_notifier_invalidate_range_start(); 3.337 us | __mmu_notifier_invalidate_range_start(); ... Neat. Andrea can you please ACK? -- To unsubscribe from this list: send the line unsubscribe kvm-ppc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/8] KVM: Optimize MMU notifier's THP page invalidation -v4
v3-v4: Resolved trace_kvm_age_page() issue -- patch 6,7 v2-v3: Fixed intersection calculations. -- patch 3, 8 Takuya Takuya Yoshikawa (8): KVM: MMU: Use __gfn_to_rmap() to clean up kvm_handle_hva() KVM: Introduce hva_to_gfn_memslot() for kvm_handle_hva() KVM: MMU: Make kvm_handle_hva() handle range of addresses KVM: Introduce kvm_unmap_hva_range() for kvm_mmu_notifier_invalidate_range_start() KVM: Separate rmap_pde from kvm_lpage_info-write_count KVM: MMU: Add memslot parameter to hva handlers KVM: MMU: Push trace_kvm_age_page() into kvm_age_rmapp() KVM: MMU: Avoid handling same rmap_pde in kvm_handle_hva_range() arch/powerpc/include/asm/kvm_host.h |2 + arch/powerpc/kvm/book3s_64_mmu_hv.c | 47 --- arch/x86/include/asm/kvm_host.h |3 +- arch/x86/kvm/mmu.c | 107 +++ arch/x86/kvm/x86.c | 11 include/linux/kvm_host.h|8 +++ virt/kvm/kvm_main.c |3 +- 7 files changed, 131 insertions(+), 50 deletions(-) From v2: The new test result was impressively good, see below, and THP page invalidation was more than 5 times faster on my x86 machine. Before: ... 19.852 us | __mmu_notifier_invalidate_range_start(); 28.033 us | __mmu_notifier_invalidate_range_start(); 19.066 us | __mmu_notifier_invalidate_range_start(); 44.715 us | __mmu_notifier_invalidate_range_start(); 31.613 us | __mmu_notifier_invalidate_range_start(); 20.659 us | __mmu_notifier_invalidate_range_start(); 19.979 us | __mmu_notifier_invalidate_range_start(); 20.416 us | __mmu_notifier_invalidate_range_start(); 20.632 us | __mmu_notifier_invalidate_range_start(); 22.316 us | __mmu_notifier_invalidate_range_start(); ... After: ... 4.089 us | __mmu_notifier_invalidate_range_start(); 4.096 us | __mmu_notifier_invalidate_range_start(); 3.560 us | __mmu_notifier_invalidate_range_start(); 3.376 us | __mmu_notifier_invalidate_range_start(); 3.772 us | __mmu_notifier_invalidate_range_start(); 3.353 us | __mmu_notifier_invalidate_range_start(); 3.332 us | __mmu_notifier_invalidate_range_start(); 3.332 us | __mmu_notifier_invalidate_range_start(); 3.332 us | __mmu_notifier_invalidate_range_start(); 3.337 us | __mmu_notifier_invalidate_range_start(); ... -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/8] KVM: Optimize MMU notifier's THP page invalidation -v4
On 07/02/2012 11:52 AM, Takuya Yoshikawa wrote: v3-v4: Resolved trace_kvm_age_page() issue -- patch 6,7 v2-v3: Fixed intersection calculations. -- patch 3, 8 Takuya Takuya Yoshikawa (8): KVM: MMU: Use __gfn_to_rmap() to clean up kvm_handle_hva() KVM: Introduce hva_to_gfn_memslot() for kvm_handle_hva() KVM: MMU: Make kvm_handle_hva() handle range of addresses KVM: Introduce kvm_unmap_hva_range() for kvm_mmu_notifier_invalidate_range_start() KVM: Separate rmap_pde from kvm_lpage_info-write_count KVM: MMU: Add memslot parameter to hva handlers KVM: MMU: Push trace_kvm_age_page() into kvm_age_rmapp() KVM: MMU: Avoid handling same rmap_pde in kvm_handle_hva_range() Reviewed-by: Avi Kivity a...@redhat.com -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/8] KVM: Optimize MMU notifier's THP page invalidation -v4
v3-v4: Resolved trace_kvm_age_page() issue -- patch 6,7 v2-v3: Fixed intersection calculations. -- patch 3, 8 Takuya Takuya Yoshikawa (8): KVM: MMU: Use __gfn_to_rmap() to clean up kvm_handle_hva() KVM: Introduce hva_to_gfn_memslot() for kvm_handle_hva() KVM: MMU: Make kvm_handle_hva() handle range of addresses KVM: Introduce kvm_unmap_hva_range() for kvm_mmu_notifier_invalidate_range_start() KVM: Separate rmap_pde from kvm_lpage_info-write_count KVM: MMU: Add memslot parameter to hva handlers KVM: MMU: Push trace_kvm_age_page() into kvm_age_rmapp() KVM: MMU: Avoid handling same rmap_pde in kvm_handle_hva_range() arch/powerpc/include/asm/kvm_host.h |2 + arch/powerpc/kvm/book3s_64_mmu_hv.c | 47 --- arch/x86/include/asm/kvm_host.h |3 +- arch/x86/kvm/mmu.c | 107 +++ arch/x86/kvm/x86.c | 11 include/linux/kvm_host.h|8 +++ virt/kvm/kvm_main.c |3 +- 7 files changed, 131 insertions(+), 50 deletions(-) From v2: The new test result was impressively good, see below, and THP page invalidation was more than 5 times faster on my x86 machine. Before: ... 19.852 us | __mmu_notifier_invalidate_range_start(); 28.033 us | __mmu_notifier_invalidate_range_start(); 19.066 us | __mmu_notifier_invalidate_range_start(); 44.715 us | __mmu_notifier_invalidate_range_start(); 31.613 us | __mmu_notifier_invalidate_range_start(); 20.659 us | __mmu_notifier_invalidate_range_start(); 19.979 us | __mmu_notifier_invalidate_range_start(); 20.416 us | __mmu_notifier_invalidate_range_start(); 20.632 us | __mmu_notifier_invalidate_range_start(); 22.316 us | __mmu_notifier_invalidate_range_start(); ... After: ... 4.089 us | __mmu_notifier_invalidate_range_start(); 4.096 us | __mmu_notifier_invalidate_range_start(); 3.560 us | __mmu_notifier_invalidate_range_start(); 3.376 us | __mmu_notifier_invalidate_range_start(); 3.772 us | __mmu_notifier_invalidate_range_start(); 3.353 us | __mmu_notifier_invalidate_range_start(); 3.332 us | __mmu_notifier_invalidate_range_start(); 3.332 us | __mmu_notifier_invalidate_range_start(); 3.332 us | __mmu_notifier_invalidate_range_start(); 3.337 us | __mmu_notifier_invalidate_range_start(); ... -- To unsubscribe from this list: send the line unsubscribe kvm-ppc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html