Re: [PATCH 0/9] pvclock misc fixes - v4.
On Tue, May 11, 2010 at 12:17:38PM -0400, Glauber Costa wrote: > This is the fourth version ov kvmclock fixes. > > Just two minor changes in patch 5, per avi request, and > the addition of cpuid.txt file, documenting all cpuid flags > we use. > > As a side effect, this patch removes the time-travel feature > in kvm guests. > > Glauber Costa (9): > Enable pvclock flags in vcpu_time_info structure > Add a global synchronization point for pvclock > change msr numbers for kvmclock > add new KVMCLOCK cpuid feature > export paravirtual cpuid flags in KVM_GET_SUPPORTED_CPUID > Try using new kvm clock msrs > don't compute pvclock adjustments if we trust the tsc > Tell the guest we'll warn it about tsc stability > Add cpuid.txt file > > Documentation/kvm/cpuid.txt| 44 > arch/x86/include/asm/kvm_para.h| 13 > arch/x86/include/asm/pvclock-abi.h |4 ++- > arch/x86/include/asm/pvclock.h |1 + > arch/x86/kernel/kvmclock.c | 56 ++- > arch/x86/kernel/pvclock.c | 37 +++ > arch/x86/kvm/x86.c | 44 +++- > 7 files changed, 176 insertions(+), 23 deletions(-) > create mode 100644 Documentation/kvm/cpuid.txt Applied all, thanks. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/9] pvclock misc fixes - v4.
On Wed, May 12, 2010 at 07:47:39AM +0200, Alexander Graf wrote: > > On 12.05.2010, at 05:33, Zachary Amsden wrote: > > > On 05/11/2010 06:17 AM, Glauber Costa wrote: > >> This is the fourth version ov kvmclock fixes. > >> > >> Just two minor changes in patch 5, per avi request, and > >> the addition of cpuid.txt file, documenting all cpuid flags > >> we use. > >> > >> As a side effect, this patch removes the time-travel feature > >> in kvm guests. > >> > >> Glauber Costa (9): > >> Enable pvclock flags in vcpu_time_info structure > >> Add a global synchronization point for pvclock > >> change msr numbers for kvmclock > >> add new KVMCLOCK cpuid feature > >> export paravirtual cpuid flags in KVM_GET_SUPPORTED_CPUID > >> Try using new kvm clock msrs > >> don't compute pvclock adjustments if we trust the tsc > >> Tell the guest we'll warn it about tsc stability > >> Add cpuid.txt file > >> > >> Documentation/kvm/cpuid.txt| 44 > >> arch/x86/include/asm/kvm_para.h| 13 > >> arch/x86/include/asm/pvclock-abi.h |4 ++- > >> arch/x86/include/asm/pvclock.h |1 + > >> arch/x86/kernel/kvmclock.c | 56 > >> ++- > >> arch/x86/kernel/pvclock.c | 37 +++ > >> arch/x86/kvm/x86.c | 44 +++- > >> 7 files changed, 176 insertions(+), 23 deletions(-) > >> create mode 100644 Documentation/kvm/cpuid.txt > >> > >> > > Acked-by: Zachary Amsden > > > How about stable queuing of this one? I don't think the MSR part classifies for stable. The sync part, that might. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/9] pvclock misc fixes - v4.
On 12.05.2010, at 08:33, Avi Kivity wrote: > On 05/12/2010 08:47 AM, Alexander Graf wrote: >> How about stable queuing of this one? >> > > Only after this gets some serious field testing. I'm not happy to trade a > known issue for an unknown regression. While I don't expect any problems > with the patchset, testing has often proven me wrong. Agreed. I merely wanted to raise awareness of me wanting to see this in -stable when it is stable :). Alex -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/9] pvclock misc fixes - v4.
On 05/12/2010 08:47 AM, Alexander Graf wrote: How about stable queuing of this one? Only after this gets some serious field testing. I'm not happy to trade a known issue for an unknown regression. While I don't expect any problems with the patchset, testing has often proven me wrong. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/9] pvclock misc fixes - v4.
On 12.05.2010, at 05:33, Zachary Amsden wrote: > On 05/11/2010 06:17 AM, Glauber Costa wrote: >> This is the fourth version ov kvmclock fixes. >> >> Just two minor changes in patch 5, per avi request, and >> the addition of cpuid.txt file, documenting all cpuid flags >> we use. >> >> As a side effect, this patch removes the time-travel feature >> in kvm guests. >> >> Glauber Costa (9): >> Enable pvclock flags in vcpu_time_info structure >> Add a global synchronization point for pvclock >> change msr numbers for kvmclock >> add new KVMCLOCK cpuid feature >> export paravirtual cpuid flags in KVM_GET_SUPPORTED_CPUID >> Try using new kvm clock msrs >> don't compute pvclock adjustments if we trust the tsc >> Tell the guest we'll warn it about tsc stability >> Add cpuid.txt file >> >> Documentation/kvm/cpuid.txt| 44 >> arch/x86/include/asm/kvm_para.h| 13 >> arch/x86/include/asm/pvclock-abi.h |4 ++- >> arch/x86/include/asm/pvclock.h |1 + >> arch/x86/kernel/kvmclock.c | 56 >> ++- >> arch/x86/kernel/pvclock.c | 37 +++ >> arch/x86/kvm/x86.c | 44 +++- >> 7 files changed, 176 insertions(+), 23 deletions(-) >> create mode 100644 Documentation/kvm/cpuid.txt >> >> > Acked-by: Zachary Amsden How about stable queuing of this one? Alex -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/9] pvclock misc fixes - v4.
On 05/11/2010 06:17 AM, Glauber Costa wrote: This is the fourth version ov kvmclock fixes. Just two minor changes in patch 5, per avi request, and the addition of cpuid.txt file, documenting all cpuid flags we use. As a side effect, this patch removes the time-travel feature in kvm guests. Glauber Costa (9): Enable pvclock flags in vcpu_time_info structure Add a global synchronization point for pvclock change msr numbers for kvmclock add new KVMCLOCK cpuid feature export paravirtual cpuid flags in KVM_GET_SUPPORTED_CPUID Try using new kvm clock msrs don't compute pvclock adjustments if we trust the tsc Tell the guest we'll warn it about tsc stability Add cpuid.txt file Documentation/kvm/cpuid.txt| 44 arch/x86/include/asm/kvm_para.h| 13 arch/x86/include/asm/pvclock-abi.h |4 ++- arch/x86/include/asm/pvclock.h |1 + arch/x86/kernel/kvmclock.c | 56 ++- arch/x86/kernel/pvclock.c | 37 +++ arch/x86/kvm/x86.c | 44 +++- 7 files changed, 176 insertions(+), 23 deletions(-) create mode 100644 Documentation/kvm/cpuid.txt Acked-by: Zachary Amsden -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/9] pvclock misc fixes - v4.
On 05/11/2010 07:17 PM, Glauber Costa wrote: This is the fourth version ov kvmclock fixes. Just two minor changes in patch 5, per avi request, and the addition of cpuid.txt file, documenting all cpuid flags we use. Looks good. As a side effect, this patch removes the time-travel feature in kvm guests. Too many reports of users accidentally killing their grandparents anyway. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/9] pvclock misc fixes - v4.
This is the fourth version ov kvmclock fixes. Just two minor changes in patch 5, per avi request, and the addition of cpuid.txt file, documenting all cpuid flags we use. As a side effect, this patch removes the time-travel feature in kvm guests. Glauber Costa (9): Enable pvclock flags in vcpu_time_info structure Add a global synchronization point for pvclock change msr numbers for kvmclock add new KVMCLOCK cpuid feature export paravirtual cpuid flags in KVM_GET_SUPPORTED_CPUID Try using new kvm clock msrs don't compute pvclock adjustments if we trust the tsc Tell the guest we'll warn it about tsc stability Add cpuid.txt file Documentation/kvm/cpuid.txt| 44 arch/x86/include/asm/kvm_para.h| 13 arch/x86/include/asm/pvclock-abi.h |4 ++- arch/x86/include/asm/pvclock.h |1 + arch/x86/kernel/kvmclock.c | 56 ++- arch/x86/kernel/pvclock.c | 37 +++ arch/x86/kvm/x86.c | 44 +++- 7 files changed, 176 insertions(+), 23 deletions(-) create mode 100644 Documentation/kvm/cpuid.txt -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
