Re: [PATCH 1/3][Seabios] Add bitmap for cpu _EJ0 callback

2012-01-19 Thread Vasilis Liaskovitis 
On Fri, Jan 13, 2012 at 07:27:01PM -0500, Kevin O'Connor wrote:
 
 [...]
   Method (CPEJ, 2, NotSerialized) {
   // _EJ0 method - eject callback
  +Store(ShiftLeft(1, Arg0), PRE)
   Sleep(200)
   }

I have another question here: the PCI _EJO callback seems to return 0x0, but
the CPU _EJ0 doesn't return anything. THe ACPIspec4.0a draft section 6.3.3
mentions that _EJx methods have no return value. Is the above difference
intentional?

thanks,

- Vasilis
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3][Seabios] Add bitmap for cpu _EJ0 callback

2012-01-19 Thread Kevin O'Connor 
On Thu, Jan 19, 2012 at 03:02:30PM +0100, Vasilis Liaskovitis wrote:
 On Fri, Jan 13, 2012 at 07:27:01PM -0500, Kevin O'Connor wrote:
  
  [...]
Method (CPEJ, 2, NotSerialized) {
// _EJ0 method - eject callback
   +Store(ShiftLeft(1, Arg0), PRE)
Sleep(200)
}
 
 I have another question here: the PCI _EJO callback seems to return 0x0, but
 the CPU _EJ0 doesn't return anything. THe ACPIspec4.0a draft section 6.3.3
 mentions that _EJx methods have no return value. Is the above difference
 intentional?

If the spec says it doesn't return anything, but the acpi code is,
it's probably just an error.

-Kevin
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3][Seabios] Add bitmap for cpu _EJ0 callback

2012-01-16 Thread Vasilis Liaskovitis 
On Fri, Jan 13, 2012 at 07:27:01PM -0500, Kevin O'Connor wrote:
 On Fri, Jan 13, 2012 at 12:11:30PM +0100, Vasilis Liaskovitis wrote:
  
  Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com
 
 The SeaBIOS change is okay with me, but the qemu/kvm change needs to
 be accepted first.
 
 [...]
   Method (CPEJ, 2, NotSerialized) {
   // _EJ0 method - eject callback
  +Store(ShiftLeft(1, Arg0), PRE)
   Sleep(200)
   }
 
 Is the Sleep() still needed?

I believe it's unneccesary. I 'll test without it and resend.
thanks,

- Vasilis

--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/3][Seabios] Add bitmap for cpu _EJ0 callback

2012-01-13 Thread Vasilis Liaskovitis 

Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com
---
 src/acpi-dsdt.dsl |7 +++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/src/acpi-dsdt.dsl b/src/acpi-dsdt.dsl
index 7082b65..71d8ac4 100644
--- a/src/acpi-dsdt.dsl
+++ b/src/acpi-dsdt.dsl
@@ -650,8 +650,15 @@ DefinitionBlock (
 Store(DerefOf(Index(CPON, Arg0)), Local0)
 If (Local0) { Return(0xF) } Else { Return(0x0) }
 }
+/* CPU eject notify method */
+OperationRegion(PREJ, SystemIO, 0xaf20, 32)
+Field (PREJ, ByteAcc, NoLock, Preserve)
+{
+PRE, 256
+}
 Method (CPEJ, 2, NotSerialized) {
 // _EJ0 method - eject callback
+Store(ShiftLeft(1, Arg0), PRE)
 Sleep(200)
 }
 
-- 
1.7.7.3

--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3][Seabios] Add bitmap for cpu _EJ0 callback

2012-01-13 Thread Kevin O'Connor 
On Fri, Jan 13, 2012 at 12:11:30PM +0100, Vasilis Liaskovitis wrote:
 
 Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com

The SeaBIOS change is okay with me, but the qemu/kvm change needs to
be accepted first.

[...]
  Method (CPEJ, 2, NotSerialized) {
  // _EJ0 method - eject callback
 +Store(ShiftLeft(1, Arg0), PRE)
  Sleep(200)
  }

Is the Sleep() still needed?

-Kevin
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html