Re: [Autotest] [PATCH 2/2] KVM-test: kvm_vm.py: Add quotation marks for appended arguments
On Tue, May 24, 2011 at 11:24 PM, Amos Kong ak...@redhat.com wrote: Appended kernel cmdline should be involved by quotation marks. -append 'root=/dev/vda ro ..' Applied, thanks! Reported-by: Cong Wang amw...@redhat.com Signed-off-by: Amos Kong ak...@redhat.com --- client/virt/kvm_vm.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/client/virt/kvm_vm.py b/client/virt/kvm_vm.py index c9bb273..343488f 100644 --- a/client/virt/kvm_vm.py +++ b/client/virt/kvm_vm.py @@ -332,7 +332,7 @@ class VM(virt_vm.BaseVM): return -initrd '%s' % filename def add_kernel_cmdline(help, cmdline): - return -append %s % cmdline + return -append '%s' % cmdline def add_testdev(help, filename): return ( -chardev file,id=testlog,path=%s ___ Autotest mailing list autot...@test.kernel.org http://test.kernel.org/cgi-bin/mailman/listinfo/autotest -- Lucas -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 2/2] KVM-test: kvm_vm.py: Add quotation marks for appended arguments
Appended kernel cmdline should be involved by quotation marks. -append 'root=/dev/vda ro ..' Reported-by: Cong Wang amw...@redhat.com Signed-off-by: Amos Kong ak...@redhat.com --- client/virt/kvm_vm.py |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/client/virt/kvm_vm.py b/client/virt/kvm_vm.py index c9bb273..343488f 100644 --- a/client/virt/kvm_vm.py +++ b/client/virt/kvm_vm.py @@ -332,7 +332,7 @@ class VM(virt_vm.BaseVM): return -initrd '%s' % filename def add_kernel_cmdline(help, cmdline): -return -append %s % cmdline +return -append '%s' % cmdline def add_testdev(help, filename): return ( -chardev file,id=testlog,path=%s -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/2] KVM-test: kvm_vm.py: Add quotation marks for appended arguments
Amos, thanks for fixing it! -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
