Re: [PATCH 3.2] KVM: Make KVM_INTEL depend on CPU_SUP_INTEL
On Wed, Dec 14, 2011 at 12:27:47PM +0200, Avi Kivity wrote: > PMU virtualization needs to talk to Intel-specific bits of perf; these are > only available when CPU_SUP_INTEL=y. > > Fixes > > arch/x86/built-in.o: In function `atomic_switch_perf_msrs': > vmx.c:(.text+0x6b1d4): undefined reference to `perf_guest_get_msrs' > > Reported-by: Ingo Molnar > Reported-by: Randy Dunlap > Signed-off-by: Avi Kivity Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3.2] KVM: Make KVM_INTEL depend on CPU_SUP_INTEL
On 12/14/2011 02:27 AM, Avi Kivity wrote: > PMU virtualization needs to talk to Intel-specific bits of perf; these are > only available when CPU_SUP_INTEL=y. > > Fixes > > arch/x86/built-in.o: In function `atomic_switch_perf_msrs': > vmx.c:(.text+0x6b1d4): undefined reference to `perf_guest_get_msrs' > > Reported-by: Ingo Molnar > Reported-by: Randy Dunlap > Signed-off-by: Avi Kivity Acked-by: Randy Dunlap Thanks. > --- > arch/x86/kvm/Kconfig |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig > index ff5790d..ca4d49e 100644 > --- a/arch/x86/kvm/Kconfig > +++ b/arch/x86/kvm/Kconfig > @@ -52,6 +52,8 @@ config KVM > config KVM_INTEL > tristate "KVM for Intel processors support" > depends on KVM > + # for perf_guest_get_msrs(): > + depends on CPU_SUP_INTEL > ---help--- > Provides support for KVM on Intel processors equipped with the VT > extensions. -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3.2] KVM: Make KVM_INTEL depend on CPU_SUP_INTEL
On 12/14/2011 12:27 PM, Avi Kivity wrote: > PMU virtualization needs to talk to Intel-specific bits of perf; these are > only available when CPU_SUP_INTEL=y. > > Fixes > > arch/x86/built-in.o: In function `atomic_switch_perf_msrs': > vmx.c:(.text+0x6b1d4): undefined reference to `perf_guest_get_msrs' > > Actually, it's for 3.3. Don't know what I was thinking. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 3.2] KVM: Make KVM_INTEL depend on CPU_SUP_INTEL
PMU virtualization needs to talk to Intel-specific bits of perf; these are only available when CPU_SUP_INTEL=y. Fixes arch/x86/built-in.o: In function `atomic_switch_perf_msrs': vmx.c:(.text+0x6b1d4): undefined reference to `perf_guest_get_msrs' Reported-by: Ingo Molnar Reported-by: Randy Dunlap Signed-off-by: Avi Kivity --- arch/x86/kvm/Kconfig |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig index ff5790d..ca4d49e 100644 --- a/arch/x86/kvm/Kconfig +++ b/arch/x86/kvm/Kconfig @@ -52,6 +52,8 @@ config KVM config KVM_INTEL tristate "KVM for Intel processors support" depends on KVM + # for perf_guest_get_msrs(): + depends on CPU_SUP_INTEL ---help--- Provides support for KVM on Intel processors equipped with the VT extensions. -- 1.7.7.1 -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
