Re: [PATCH v3 0/3]: Fixes to IRQ routing

2010-06-18 Thread Marcelo Tosatti
On Wed, Jun 16, 2010 at 05:11:10PM -0400, Chris Lalancette wrote:
> As we've discussed previously, here is a series of patches to
> fix some of the IRQ routing issues we have in KVM.  With this series
> in place I was able to successfully kdump a RHEL-5 64-bit, and RHEL-6
> 32- and 64-bit guest on CPU's other than the BSP.  RHEL-5 32-bit kdump still
> does not work; it gets stuck on "Checking 'hlt' instruction".  However,
> it does that both before and after this series, so there is something
> else going on there that I still have to debug.
> 
> I also need to change the "kvm_migrate_pit_timer" function to migrate the
> timer over to the last CPU that handled the timer interrupt, on the
> theory that that particlar CPU is likely to handle the timer interrupt again
> in the near future.  However, this is an optimization and shouldn't delay the
> inclusion of the rest of the series for correctness.

Applied, thanks.

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH v3 0/3]: Fixes to IRQ routing

2010-06-16 Thread Chris Lalancette
As we've discussed previously, here is a series of patches to
fix some of the IRQ routing issues we have in KVM.  With this series
in place I was able to successfully kdump a RHEL-5 64-bit, and RHEL-6
32- and 64-bit guest on CPU's other than the BSP.  RHEL-5 32-bit kdump still
does not work; it gets stuck on "Checking 'hlt' instruction".  However,
it does that both before and after this series, so there is something
else going on there that I still have to debug.

I also need to change the "kvm_migrate_pit_timer" function to migrate the
timer over to the last CPU that handled the timer interrupt, on the
theory that that particlar CPU is likely to handle the timer interrupt again
in the near future.  However, this is an optimization and shouldn't delay the
inclusion of the rest of the series for correctness.

Changes since RFC:
 - Changed ps->inject_lock from raw_spinlock_t to spinlock_t
 - Fixed up some formatting issues
 - Changed to have one PIT workqueue per-guest
 - Remember to cancel_work_sync when destroying the PIT

Changes since v1:
 - Call cancel_work_sync everywhere we call hrtimer_cancel
 - Bring back the reinjection logic
 - Fix up formatting issues from checkpatch

Changes since v2:
 - Fix up the reinjection logic thanks to review from Gleb and Marcelo
   Tested with -no-kvm-pit-reinjection on a RHEL-3 guest

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html